Re: [Intel-gfx] [PATCH] drm/i915/pch: Save/restore PCH_PORT_HOTPLUG across suspend

2011-07-29 Thread Keith Packard
On Tue, 26 Jul 2011 14:00:32 -0700, Jesse Barnes wrote: > We should be writing this reg. The only question is whether we should > be trusting the BIOS values (which may have custom pulse duration > settings) or just unconditionally enabling hot plug for ports we care > about with the default 2m

Re: [Intel-gfx] [PATCH] drm/i915/pch: Save/restore PCH_PORT_HOTPLUG across suspend

2011-07-27 Thread Adam Jackson
On Tue, 2011-07-26 at 14:00 -0700, Jesse Barnes wrote: > We should be writing this reg. The only question is whether we should > be trusting the BIOS values (which may have custom pulse duration > settings) or just unconditionally enabling hot plug for ports we care > about with the default 2ms p

Re: [Intel-gfx] [PATCH] drm/i915/pch: Save/restore PCH_PORT_HOTPLUG across suspend

2011-07-26 Thread Jesse Barnes
On Tue, 26 Jul 2011 16:53:06 -0400 Adam Jackson wrote: > At least on a Lenovo X220 the HPD bits of this are enabled at boot but > cleared after resume, which means plug interrupts stop working. > > This also happens to fix DP displays re-lighting on resume. I'm quite > certain that's an acciden

[Intel-gfx] [PATCH] drm/i915/pch: Save/restore PCH_PORT_HOTPLUG across suspend

2011-07-26 Thread Adam Jackson
At least on a Lenovo X220 the HPD bits of this are enabled at boot but cleared after resume, which means plug interrupts stop working. This also happens to fix DP displays re-lighting on resume. I'm quite certain that's an accident: the first DP link train inevitably fails on that machine, and it