Re: [Intel-gfx] [PATCH] drm/i915/icl: MBUS B credit change

2018-10-05 Thread Rodrigo Vivi
On Fri, Oct 05, 2018 at 02:40:01PM +0530, Kumar, Mahesh wrote: > Hi, > > LGTM > > Reviewed-by: Mahesh Kumar pushed to dinq adding also the rv-b from lucas I got offline... > > On 10/4/2018 8:48 PM, Rodrigo Vivi wrote: > > No functional change. But just a minor change to keep > > up with Spec

Re: [Intel-gfx] [PATCH] drm/i915/icl: MBUS B credit change

2018-10-05 Thread Kumar, Mahesh
Hi, LGTM Reviewed-by: Mahesh Kumar On 10/4/2018 8:48 PM, Rodrigo Vivi wrote: No functional change. But just a minor change to keep up with Spec, since it has changed since commit c3cc39c539d4 ("drm/i915/icl: program mbus during pipe enable") The instructions previously said to program pipe's

[Intel-gfx] [PATCH] drm/i915/icl: MBUS B credit change

2018-10-04 Thread Rodrigo Vivi
No functional change. But just a minor change to keep up with Spec, since it has changed since commit c3cc39c539d4 ("drm/i915/icl: program mbus during pipe enable") The instructions previously said to program pipe's B credit = 24 / number of pipes, which is 8 for ICL. Now the spec gives us direct