Re: [Intel-gfx] [PATCH] drm/i915/hti: avoid theoretically possible negative shift

2022-11-23 Thread Jani Nikula
On Tue, 22 Nov 2022, Kees Cook wrote: > On Tue, Nov 22, 2022 at 02:09:48PM +0200, Jani Nikula wrote: >> If phy is PHY_NONE, the shift to register bits becomes negative. Check >> and warn about this. >> >> Reported-by: coverity-bot >> References: https://lore.kernel.org/r/202211180848.D39006C@kee

Re: [Intel-gfx] [PATCH] drm/i915/hti: avoid theoretically possible negative shift

2022-11-22 Thread Kees Cook
On Tue, Nov 22, 2022 at 02:09:48PM +0200, Jani Nikula wrote: > If phy is PHY_NONE, the shift to register bits becomes negative. Check > and warn about this. > > Reported-by: coverity-bot > References: https://lore.kernel.org/r/202211180848.D39006C@keescook > Signed-off-by: Jani Nikula Reviewed-

[Intel-gfx] [PATCH] drm/i915/hti: avoid theoretically possible negative shift

2022-11-22 Thread Jani Nikula
If phy is PHY_NONE, the shift to register bits becomes negative. Check and warn about this. Reported-by: coverity-bot References: https://lore.kernel.org/r/202211180848.D39006C@keescook Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_hti.c | 3 +++ 1 file changed, 3 insertions