Re: [Intel-gfx] [PATCH] drm/i915/hsw: Implement Selective Write workaround

2015-01-05 Thread Daniel Vetter
On Fri, Dec 19, 2014 at 02:14:31PM -0800, Ben Widawsky wrote: > On Fri, Dec 19, 2014 at 08:05:30PM +, Chris Wilson wrote: > > On Fri, Dec 19, 2014 at 06:34:07PM +, Chris Wilson wrote: > > > Just a patch a few days ago that to fix a very ontologically similar bug > > > for ivb+. > > > > Oh

Re: [Intel-gfx] [PATCH] drm/i915/hsw: Implement Selective Write workaround

2014-12-19 Thread Ben Widawsky
On Fri, Dec 19, 2014 at 08:05:30PM +, Chris Wilson wrote: > On Fri, Dec 19, 2014 at 06:34:07PM +, Chris Wilson wrote: > > Just a patch a few days ago that to fix a very ontologically similar bug > > for ivb+. > > Oh boy. I just double checked the error states from those bugs I marked > as

Re: [Intel-gfx] [PATCH] drm/i915/hsw: Implement Selective Write workaround

2014-12-19 Thread Chris Wilson
On Fri, Dec 19, 2014 at 06:34:07PM +, Chris Wilson wrote: > Just a patch a few days ago that to fix a very ontologically similar bug > for ivb+. Oh boy. I just double checked the error states from those bugs I marked as ivb context restore hangs... So far I appear to have consistently mislable

Re: [Intel-gfx] [PATCH] drm/i915/hsw: Implement Selective Write workaround

2014-12-19 Thread Chris Wilson
On Fri, Dec 19, 2014 at 09:26:01AM -0800, Ben Widawsky wrote: > On Fri, Dec 19, 2014 at 08:20:04AM +, Chris Wilson wrote: > > On Thu, Dec 18, 2014 at 06:20:18PM -0800, Ben Widawsky wrote: > > > From: Ben Widawsky > > > > > > The docs specify this needs to be set on HSW GT1 parts. I've impleme

Re: [Intel-gfx] [PATCH] drm/i915/hsw: Implement Selective Write workaround

2014-12-19 Thread Ben Widawsky
On Fri, Dec 19, 2014 at 08:20:04AM +, Chris Wilson wrote: > On Thu, Dec 18, 2014 at 06:20:18PM -0800, Ben Widawsky wrote: > > From: Ben Widawsky > > > > The docs specify this needs to be set on HSW GT1 parts. I've implemented it > > as > > such since it should only be needed when using RC6,

Re: [Intel-gfx] [PATCH] drm/i915/hsw: Implement Selective Write workaround

2014-12-19 Thread Chris Wilson
On Thu, Dec 18, 2014 at 06:20:18PM -0800, Ben Widawsky wrote: > From: Ben Widawsky > > The docs specify this needs to be set on HSW GT1 parts. I've implemented it as > such since it should only be needed when using RC6, but it can probably go > anywhere. > > This patch fixes extremely reproducib

[Intel-gfx] [PATCH] drm/i915/hsw: Implement Selective Write workaround

2014-12-18 Thread Ben Widawsky
From: Ben Widawsky The docs specify this needs to be set on HSW GT1 parts. I've implemented it as such since it should only be needed when using RC6, but it can probably go anywhere. This patch fixes extremely reproducible hangs on our Jenkins setup. The interesting failure signature is: IPEH