Re: [Intel-gfx] [PATCH] drm/i915/gvt: Add missing vfio_unregister_group_dev() call

2022-10-19 Thread Tian, Kevin
> From: Wang, Zhi A > Sent: Wednesday, October 19, 2022 5:41 PM > > On 10/6/22 18:31, Alex Williamson wrote: > > On Thu, 6 Oct 2022 08:37:09 -0300 > > Jason Gunthorpe wrote: > > > >> On Wed, Oct 05, 2022 at 04:03:56PM -0600, Alex Williamson wrote: > >>> We can't have a .remove callback that does

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Add missing vfio_unregister_group_dev() call

2022-10-19 Thread Wang, Zhi A
On 10/6/22 18:31, Alex Williamson wrote: > On Thu, 6 Oct 2022 08:37:09 -0300 > Jason Gunthorpe wrote: > >> On Wed, Oct 05, 2022 at 04:03:56PM -0600, Alex Williamson wrote: >>> We can't have a .remove callback that does nothing, this breaks >>> removing the device while it's in use. Once we have

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Add missing vfio_unregister_group_dev() call

2022-10-10 Thread Tian, Kevin
> From: Alex Williamson > Sent: Friday, October 7, 2022 2:31 AM > > On Thu, 6 Oct 2022 08:37:09 -0300 > Jason Gunthorpe wrote: > > > On Wed, Oct 05, 2022 at 04:03:56PM -0600, Alex Williamson wrote: > > > We can't have a .remove callback that does nothing, this breaks > > > removing the device w

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Add missing vfio_unregister_group_dev() call

2022-10-06 Thread Alex Williamson
On Thu, 6 Oct 2022 08:37:09 -0300 Jason Gunthorpe wrote: > On Wed, Oct 05, 2022 at 04:03:56PM -0600, Alex Williamson wrote: > > We can't have a .remove callback that does nothing, this breaks > > removing the device while it's in use. Once we have the > > vfio_unregister_group_dev() fix below, w

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Add missing vfio_unregister_group_dev() call

2022-10-06 Thread Jason Gunthorpe
On Wed, Oct 05, 2022 at 04:03:56PM -0600, Alex Williamson wrote: > We can't have a .remove callback that does nothing, this breaks > removing the device while it's in use. Once we have the > vfio_unregister_group_dev() fix below, we'll block until the device is > unused, at which point vgpu->attac

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Add missing vfio_unregister_group_dev() call

2022-10-06 Thread Jason Gunthorpe
On Wed, Oct 05, 2022 at 02:17:17PM -0600, Alex Williamson wrote: > > diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c > > b/drivers/gpu/drm/i915/gvt/kvmgt.c > > index 41bba40feef8f4..9003145adb5a93 100644 > > --- a/drivers/gpu/drm/i915/gvt/kvmgt.c > > +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c > > @@ -1

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Add missing vfio_unregister_group_dev() call

2022-10-05 Thread Alex Williamson
On Wed, 5 Oct 2022 14:17:17 -0600 Alex Williamson wrote: > On Thu, 29 Sep 2022 14:48:35 -0300 > Jason Gunthorpe wrote: > > > When converting to directly create the vfio_device the mdev driver has to > > put a vfio_register_emulated_iommu_dev() in the probe() and a pairing > > vfio_unregister_gr

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Add missing vfio_unregister_group_dev() call

2022-10-05 Thread Alex Williamson
On Thu, 29 Sep 2022 14:48:35 -0300 Jason Gunthorpe wrote: > When converting to directly create the vfio_device the mdev driver has to > put a vfio_register_emulated_iommu_dev() in the probe() and a pairing > vfio_unregister_group_dev() in the remove. > > This was missed for gvt, add it. > > Cc:

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Add missing vfio_unregister_group_dev() call

2022-09-30 Thread Alex Williamson
On Thu, 29 Sep 2022 14:48:35 -0300 Jason Gunthorpe wrote: > When converting to directly create the vfio_device the mdev driver has to > put a vfio_register_emulated_iommu_dev() in the probe() and a pairing > vfio_unregister_group_dev() in the remove. > > This was missed for gvt, add it. > > Cc:

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Add missing vfio_unregister_group_dev() call

2022-09-29 Thread Christoph Hellwig
Oops. Looks good: Reviewed-by: Christoph Hellwig

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Add missing vfio_unregister_group_dev() call

2022-09-29 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Friday, September 30, 2022 1:49 AM > > When converting to directly create the vfio_device the mdev driver has to > put a vfio_register_emulated_iommu_dev() in the probe() and a pairing > vfio_unregister_group_dev() in the remove. > > This was missed for gvt, add it

[Intel-gfx] [PATCH] drm/i915/gvt: Add missing vfio_unregister_group_dev() call

2022-09-29 Thread Jason Gunthorpe
When converting to directly create the vfio_device the mdev driver has to put a vfio_register_emulated_iommu_dev() in the probe() and a pairing vfio_unregister_group_dev() in the remove. This was missed for gvt, add it. Cc: sta...@vger.kernel.org Fixes: 978cf586ac35 ("drm/i915/gvt: convert to use