Re: [Intel-gfx] [PATCH] drm/i915/guc: Redefine guc_log_level modparam values

2018-01-11 Thread Sagar Arun Kamble
On 1/11/2018 2:54 PM, Michal Wajdeczko wrote: On Thu, 11 Jan 2018 06:52:18 +0100, Sagar Arun Kamble wrote: On 1/10/2018 9:35 PM, Michal Wajdeczko wrote: We used value -1 to indicate "disabled" and values 0..3 to indicate "enabled", but most of our other modparams are using -1 for "auto"

Re: [Intel-gfx] [PATCH] drm/i915/guc: Redefine guc_log_level modparam values

2018-01-11 Thread Michal Wajdeczko
On Thu, 11 Jan 2018 06:52:18 +0100, Sagar Arun Kamble wrote: On 1/10/2018 9:35 PM, Michal Wajdeczko wrote: We used value -1 to indicate "disabled" and values 0..3 to indicate "enabled", but most of our other modparams are using -1 for "auto" mode and 0 for "disable". For consistency let's

Re: [Intel-gfx] [PATCH] drm/i915/guc: Redefine guc_log_level modparam values

2018-01-10 Thread Sagar Arun Kamble
On 1/10/2018 9:35 PM, Michal Wajdeczko wrote: We used value -1 to indicate "disabled" and values 0..3 to indicate "enabled", but most of our other modparams are using -1 for "auto" mode and 0 for "disable". For consistency let's change our log level values to: -1: auto (depends on USES_GUC and

[Intel-gfx] [PATCH] drm/i915/guc: Redefine guc_log_level modparam values

2018-01-10 Thread Michal Wajdeczko
We used value -1 to indicate "disabled" and values 0..3 to indicate "enabled", but most of our other modparams are using -1 for "auto" mode and 0 for "disable". For consistency let's change our log level values to: -1: auto (depends on USES_GUC and DRM_I915_DEBUG) 0: disabled 1: enabled (severit