Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix a false alert of memory leak when free LRC

2015-10-24 Thread Chris Wilson
On Fri, Oct 23, 2015 at 10:40:11PM +0100, Dave Gordon wrote: > >@@ -732,6 +727,11 @@ intel_logical_ring_advance_and_submit(struct > >drm_i915_gem_request *request) > > if (intel_ring_stopped(ring)) > > return; > > > >+if (request->ctx != ring->default_context) > >+i

Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix a false alert of memory leak when free LRC

2015-10-23 Thread Dave Gordon
On 21/10/15 19:27, yu@intel.com wrote: From: Alex Dai There is a memory leak warning message from i915_gem_context_clean when GuC submission is enabled. The reason is that gem_request (so the LRC associated with it) is freed early than moving the vma list to inactive. We are not seeing thi

[Intel-gfx] [PATCH] drm/i915/guc: Fix a false alert of memory leak when free LRC

2015-10-21 Thread yu . dai
From: Alex Dai There is a memory leak warning message from i915_gem_context_clean when GuC submission is enabled. The reason is that gem_request (so the LRC associated with it) is freed early than moving the vma list to inactive. We are not seeing this in ExecList (non-GuC) mode because the gem_

Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix a false alert of memory leak when free LRC

2015-10-20 Thread Daniel Vetter
On Mon, Oct 19, 2015 at 03:05:46PM -0700, yu@intel.com wrote: > From: Alex Dai > > There is a memory leak warning message from i915_gem_context_clean > when GuC submission is enabled. The reason is that the request (so > the LRC associated with it) is freed early than moving the vma list > to

[Intel-gfx] [PATCH] drm/i915/guc: Fix a false alert of memory leak when free LRC

2015-10-19 Thread yu . dai
From: Alex Dai There is a memory leak warning message from i915_gem_context_clean when GuC submission is enabled. The reason is that the request (so the LRC associated with it) is freed early than moving the vma list to inactive. When retire a gem object, this patch moves its vma list to inactive