Re: [Intel-gfx] [PATCH] drm/i915/guc: Dynamically alloc GuC descriptor

2017-02-07 Thread Chris Wilson
On Tue, Feb 07, 2017 at 01:37:52AM -0800, Oscar Mateo wrote: > > > On 02/07/2017 09:25 AM, Chris Wilson wrote: > >On Tue, Feb 07, 2017 at 12:55:21AM -0800, Oscar Mateo wrote: > >> > >>On 02/02/2017 11:33 PM, Chris Wilson wrote: > >>>On Thu, Feb 02, 2017 at 07:27:45AM -0800, Oscar Mateo wrote: > >

Re: [Intel-gfx] [PATCH] drm/i915/guc: Dynamically alloc GuC descriptor

2017-02-07 Thread Oscar Mateo
On 02/07/2017 09:25 AM, Chris Wilson wrote: On Tue, Feb 07, 2017 at 12:55:21AM -0800, Oscar Mateo wrote: On 02/02/2017 11:33 PM, Chris Wilson wrote: On Thu, Feb 02, 2017 at 07:27:45AM -0800, Oscar Mateo wrote: From: Michal Wajdeczko The GuC descriptor is big in size. If we use local defin

Re: [Intel-gfx] [PATCH] drm/i915/guc: Dynamically alloc GuC descriptor

2017-02-07 Thread Chris Wilson
On Tue, Feb 07, 2017 at 12:55:21AM -0800, Oscar Mateo wrote: > > > On 02/02/2017 11:33 PM, Chris Wilson wrote: > >On Thu, Feb 02, 2017 at 07:27:45AM -0800, Oscar Mateo wrote: > >>From: Michal Wajdeczko > >> > >>The GuC descriptor is big in size. If we use local definition of > >>guc_desc we have

Re: [Intel-gfx] [PATCH] drm/i915/guc: Dynamically alloc GuC descriptor

2017-02-07 Thread Oscar Mateo
On 02/02/2017 11:33 PM, Chris Wilson wrote: On Thu, Feb 02, 2017 at 07:27:45AM -0800, Oscar Mateo wrote: From: Michal Wajdeczko The GuC descriptor is big in size. If we use local definition of guc_desc we have a chance to overflow stack. Use allocated one. v2: Rebased v3: Split v4: Handle E

Re: [Intel-gfx] [PATCH] drm/i915/guc: Dynamically alloc GuC descriptor

2017-02-02 Thread Chris Wilson
On Thu, Feb 02, 2017 at 07:27:45AM -0800, Oscar Mateo wrote: > From: Michal Wajdeczko > > The GuC descriptor is big in size. If we use local definition of > guc_desc we have a chance to overflow stack. Use allocated one. > > v2: Rebased > v3: Split > v4: Handle ENOMEM, cover all uses of guc_cont

[Intel-gfx] [PATCH] drm/i915/guc: Dynamically alloc GuC descriptor

2017-02-02 Thread Oscar Mateo
From: Michal Wajdeczko The GuC descriptor is big in size. If we use local definition of guc_desc we have a chance to overflow stack. Use allocated one. v2: Rebased v3: Split v4: Handle ENOMEM, cover all uses of guc_context_desc, use kzalloc (Oscar) Signed-off-by: Deepak S Signed-off-by: Michal