Re: [Intel-gfx] [PATCH] drm/i915/guc: Do not use wait_for_atomic in host2guc_action

2016-06-28 Thread Tvrtko Ursulin
On 28/06/16 16:50, Dave Gordon wrote: On 28/06/16 15:30, Tvrtko Ursulin wrote: From: Tvrtko Ursulin host2guc_action does not appear to be called from atomic context so a more polite wait_for macro should be used. Especially since the timeout is 10ms. Maybe. However we don't really want to s

Re: [Intel-gfx] [PATCH] drm/i915/guc: Do not use wait_for_atomic in host2guc_action

2016-06-28 Thread Dave Gordon
On 28/06/16 15:30, Tvrtko Ursulin wrote: From: Tvrtko Ursulin host2guc_action does not appear to be called from atomic context so a more polite wait_for macro should be used. Especially since the timeout is 10ms. Maybe. However we don't really want to sleep if the action takes only a few mic

[Intel-gfx] [PATCH] drm/i915/guc: Do not use wait_for_atomic in host2guc_action

2016-06-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin host2guc_action does not appear to be called from atomic context so a more polite wait_for macro should be used. Especially since the timeout is 10ms. Signed-off-by: Tvrtko Ursulin Reported-by: Imre Deak Cc: Dave Gordon Cc: Imre Deak --- drivers/gpu/drm/i915/i915_guc_su