Re: [Intel-gfx] [PATCH] drm/i915/gen9: Check for DC state mismatch

2016-02-18 Thread Patrik Jakobsson
On Thu, Feb 18, 2016 at 11:22 AM, Patrik Jakobsson wrote: > On Thu, Feb 18, 2016 at 12:16:40AM +, Vivi, Rodrigo wrote: >> I was going to merge here but I saw on patchwork we got some warnings >> so I'm not sure they are only false positives or this is exactly what >> this patches wants... > >

Re: [Intel-gfx] [PATCH] drm/i915/gen9: Check for DC state mismatch

2016-02-18 Thread Patrik Jakobsson
On Thu, Feb 18, 2016 at 12:16:40AM +, Vivi, Rodrigo wrote: > I was going to merge here but I saw on patchwork we got some warnings > so I'm not sure they are only false positives or this is exactly what > this patches wants... They are unfortunately not false positives. The question is if it's

Re: [Intel-gfx] [PATCH] drm/i915/gen9: Check for DC state mismatch

2016-02-17 Thread Vivi, Rodrigo
I was going to merge here but I saw on patchwork we got some warnings so I'm not sure they are only false positives or this is exactly what this patches wants... On Thu, 2016-02-11 at 12:43 +0200, Mika Kuoppala wrote: > Patrik Jakobsson writes: > > > The DMC can incorrectly run off and allow DC

Re: [Intel-gfx] [PATCH] drm/i915/gen9: Check for DC state mismatch

2016-02-11 Thread Mika Kuoppala
Patrik Jakobsson writes: > The DMC can incorrectly run off and allow DC states on it's own. We > don't know the root-cause for this yet but this patch makes it more > visible. > > Signed-off-by: Patrik Jakobsson Yes, we definitely need much more state checking and hardening in this area. Revie

[Intel-gfx] [PATCH] drm/i915/gen9: Check for DC state mismatch

2016-02-11 Thread Patrik Jakobsson
The DMC can incorrectly run off and allow DC states on it's own. We don't know the root-cause for this yet but this patch makes it more visible. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_csr.c| 2 ++ drivers/gpu/drm/i915