Re: [Intel-gfx] [PATCH] drm/i915/gen4: Fix interrupt setup ordering

2010-06-04 Thread Eric Anholt
On Thu, 03 Jun 2010 17:31:22 -0400, Adam Jackson wrote: > On Thu, 2010-05-27 at 17:26 -0400, Adam Jackson wrote: > > Unmask, then enable interrupts, then enable interrupt sources; matches > > PCH ordering. The old way (sources, enable, unmask) gives a window > > during which interrupt conditions

Re: [Intel-gfx] [PATCH] drm/i915/gen4: Fix interrupt setup ordering

2010-06-03 Thread Adam Jackson
On Thu, 2010-05-27 at 17:26 -0400, Adam Jackson wrote: > Unmask, then enable interrupts, then enable interrupt sources; matches > PCH ordering. The old way (sources, enable, unmask) gives a window > during which interrupt conditions would appear in ISR but would never > reach IIR and thus never ra

[Intel-gfx] [PATCH] drm/i915/gen4: Fix interrupt setup ordering

2010-05-27 Thread Adam Jackson
Unmask, then enable interrupts, then enable interrupt sources; matches PCH ordering. The old way (sources, enable, unmask) gives a window during which interrupt conditions would appear in ISR but would never reach IIR and thus never raise an IRQ. Since interrupts only trigger on rising edges in I