Re: [Intel-gfx] [PATCH] drm/i915/gen4: Extra CRT hotplug paranoia

2010-05-26 Thread Eric Anholt
On Mon, 24 May 2010 16:46:29 -0400, Adam Jackson wrote: > Disable the CRT plug interrupt while doing the force cycle, explicitly > clear any CRT interrupt we may have generated, and restore when done. > Should mitigate interrupt storms from hotplug detection. Nice, I've been hoping someone would

Re: [Intel-gfx] [PATCH] drm/i915/gen4: Extra CRT hotplug paranoia

2010-05-25 Thread Andrew Lutomirski
On Tue, May 25, 2010 at 10:46 AM, Adam Jackson wrote: > On Mon, 2010-05-24 at 21:46 -0400, Andrew Lutomirski wrote: >> On Mon, May 24, 2010 at 4:46 PM, Adam Jackson wrote: >> > Disable the CRT plug interrupt while doing the force cycle, explicitly >> > clear any CRT interrupt we may have generate

Re: [Intel-gfx] [PATCH] drm/i915/gen4: Extra CRT hotplug paranoia

2010-05-25 Thread Adam Jackson
On Mon, 2010-05-24 at 21:46 -0400, Andrew Lutomirski wrote: > On Mon, May 24, 2010 at 4:46 PM, Adam Jackson wrote: > > Disable the CRT plug interrupt while doing the force cycle, explicitly > > clear any CRT interrupt we may have generated, and restore when done. > > Should mitigate interrupt stor

Re: [Intel-gfx] [PATCH] drm/i915/gen4: Extra CRT hotplug paranoia

2010-05-24 Thread Andrew Lutomirski
On Mon, May 24, 2010 at 4:46 PM, Adam Jackson wrote: > Disable the CRT plug interrupt while doing the force cycle, explicitly > clear any CRT interrupt we may have generated, and restore when done. > Should mitigate interrupt storms from hotplug detection. > Is there any locking in here to protec

[Intel-gfx] [PATCH] drm/i915/gen4: Extra CRT hotplug paranoia

2010-05-24 Thread Adam Jackson
Disable the CRT plug interrupt while doing the force cycle, explicitly clear any CRT interrupt we may have generated, and restore when done. Should mitigate interrupt storms from hotplug detection. Signed-off-by: Adam Jackson --- drivers/gpu/drm/i915/i915_reg.h |1 - drivers/gpu/drm/i915/in