Re: [Intel-gfx] [PATCH] drm/i915/execlists: Use a local lock for dfs_link access

2016-11-17 Thread David Weinehall
On Wed, Nov 16, 2016 at 03:27:21PM +, Chris Wilson wrote: > Avoid requiring struct_mutex for exclusive access to the temporary > dfs_link inside the i915_dependency as not all callers may want to touch > struct_mutex. So rather than force them to take a highly contended > lock, introduce a loca

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Use a local lock for dfs_link access

2016-11-17 Thread Daniel Vetter
On Thu, Nov 17, 2016 at 08:52:59AM +, Chris Wilson wrote: > On Thu, Nov 17, 2016 at 09:45:17AM +0100, Daniel Vetter wrote: > > On Wed, Nov 16, 2016 at 04:03:27PM +, Chris Wilson wrote: > > > On Wed, Nov 16, 2016 at 03:54:23PM +, Tvrtko Ursulin wrote: > > > > > > > > On 16/11/2016 15:27

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Use a local lock for dfs_link access

2016-11-17 Thread Chris Wilson
On Thu, Nov 17, 2016 at 09:45:17AM +0100, Daniel Vetter wrote: > On Wed, Nov 16, 2016 at 04:03:27PM +, Chris Wilson wrote: > > On Wed, Nov 16, 2016 at 03:54:23PM +, Tvrtko Ursulin wrote: > > > > > > On 16/11/2016 15:27, Chris Wilson wrote: > > > >Avoid requiring struct_mutex for exclusive

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Use a local lock for dfs_link access

2016-11-17 Thread Daniel Vetter
On Wed, Nov 16, 2016 at 04:03:27PM +, Chris Wilson wrote: > On Wed, Nov 16, 2016 at 03:54:23PM +, Tvrtko Ursulin wrote: > > > > On 16/11/2016 15:27, Chris Wilson wrote: > > >Avoid requiring struct_mutex for exclusive access to the temporary > > >dfs_link inside the i915_dependency as not a

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Use a local lock for dfs_link access

2016-11-16 Thread Chris Wilson
On Wed, Nov 16, 2016 at 03:54:23PM +, Tvrtko Ursulin wrote: > > On 16/11/2016 15:27, Chris Wilson wrote: > >Avoid requiring struct_mutex for exclusive access to the temporary > >dfs_link inside the i915_dependency as not all callers may want to touch > >struct_mutex. So rather than force them

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Use a local lock for dfs_link access

2016-11-16 Thread Tvrtko Ursulin
On 16/11/2016 15:27, Chris Wilson wrote: Avoid requiring struct_mutex for exclusive access to the temporary dfs_link inside the i915_dependency as not all callers may want to touch struct_mutex. So rather than force them to take a highly contended lock, introduce a local lock for the execlists s

[Intel-gfx] [PATCH] drm/i915/execlists: Use a local lock for dfs_link access

2016-11-16 Thread Chris Wilson
Avoid requiring struct_mutex for exclusive access to the temporary dfs_link inside the i915_dependency as not all callers may want to touch struct_mutex. So rather than force them to take a highly contended lock, introduce a local lock for the execlists schedule operation. Reported-by: David Weine