Re: [Intel-gfx] [PATCH] drm/i915/dp: Add missing TPS4 programming bits

2021-10-20 Thread Almahallawy, Khaled
On Tue, 2021-10-19 at 15:01 +0300, Ville Syrjälä wrote: > On Tue, Oct 19, 2021 at 02:52:15PM +0300, Jani Nikula wrote: > > On Mon, 19 Jul 2021, Khaled Almahallawy < > > khaled.almahall...@intel.com> wrote: > > > Bits 20:19 are used to set CP2520 Patterns 1/2/3 (refer to > > > Specs:50484). > > > TP

Re: [Intel-gfx] [PATCH] drm/i915/dp: Add missing TPS4 programming bits

2021-10-19 Thread Ville Syrjälä
On Tue, Oct 19, 2021 at 02:52:15PM +0300, Jani Nikula wrote: > On Mon, 19 Jul 2021, Khaled Almahallawy wrote: > > Bits 20:19 are used to set CP2520 Patterns 1/2/3 (refer to Specs:50484). > > TPS4 is CP2520 Pattern 3 (refer to DP2.0 spaces Table 3-11, DPCD 00248h > > LINK_QUAL_PATTERN_SELECT, and D

Re: [Intel-gfx] [PATCH] drm/i915/dp: Add missing TPS4 programming bits

2021-10-19 Thread Jani Nikula
On Mon, 19 Jul 2021, Khaled Almahallawy wrote: > Bits 20:19 are used to set CP2520 Patterns 1/2/3 (refer to Specs:50484). > TPS4 is CP2520 Pattern 3 (refer to DP2.0 spaces Table 3-11, DPCD 00248h > LINK_QUAL_PATTERN_SELECT, and DP PHY 1.4 CTS - Appendix A - Compliance > EYE Pattern(CP2520; Normati

[Intel-gfx] [PATCH] drm/i915/dp: Add missing TPS4 programming bits

2021-07-19 Thread Khaled Almahallawy
Bits 20:19 are used to set CP2520 Patterns 1/2/3 (refer to Specs:50484). TPS4 is CP2520 Pattern 3 (refer to DP2.0 spaces Table 3-11, DPCD 00248h LINK_QUAL_PATTERN_SELECT, and DP PHY 1.4 CTS - Appendix A - Compliance EYE Pattern(CP2520; Normative)) For TPS4, setting bits 20:19 to value != 00b, lead