Re: [Intel-gfx] [PATCH] drm/i915/display: Drop redundant debug print

2021-08-19 Thread Sharma, Swati2
On 16-Aug-21 5:58 PM, Jani Nikula wrote: On Mon, 16 Aug 2021, "Sharma, Swati2" wrote: On 16-Aug-21 5:40 PM, Jani Nikula wrote: On Mon, 16 Aug 2021, "Sharma, Swati2" wrote: On 13-Aug-21 1:16 PM, Jani Nikula wrote: On Thu, 12 Aug 2021, Swati Sharma wrote: drm_dp_dpcd_read/write already h

Re: [Intel-gfx] [PATCH] drm/i915/display: Drop redundant debug print

2021-08-16 Thread Jani Nikula
On Mon, 16 Aug 2021, "Sharma, Swati2" wrote: > On 16-Aug-21 5:40 PM, Jani Nikula wrote: >> On Mon, 16 Aug 2021, "Sharma, Swati2" wrote: >>> On 13-Aug-21 1:16 PM, Jani Nikula wrote: On Thu, 12 Aug 2021, Swati Sharma wrote: > drm_dp_dpcd_read/write already has debug error message. > D

Re: [Intel-gfx] [PATCH] drm/i915/display: Drop redundant debug print

2021-08-16 Thread Sharma, Swati2
On 16-Aug-21 5:40 PM, Jani Nikula wrote: On Mon, 16 Aug 2021, "Sharma, Swati2" wrote: On 13-Aug-21 1:16 PM, Jani Nikula wrote: On Thu, 12 Aug 2021, Swati Sharma wrote: drm_dp_dpcd_read/write already has debug error message. Drop redundant error messages which gives false status even if co

Re: [Intel-gfx] [PATCH] drm/i915/display: Drop redundant debug print

2021-08-16 Thread Jani Nikula
On Mon, 16 Aug 2021, "Sharma, Swati2" wrote: > On 13-Aug-21 1:16 PM, Jani Nikula wrote: >> On Thu, 12 Aug 2021, Swati Sharma wrote: >>> drm_dp_dpcd_read/write already has debug error message. >>> Drop redundant error messages which gives false >>> status even if correct value is read in drm_dp_dp

Re: [Intel-gfx] [PATCH] drm/i915/display: Drop redundant debug print

2021-08-16 Thread Sharma, Swati2
On 13-Aug-21 1:16 PM, Jani Nikula wrote: On Thu, 12 Aug 2021, Swati Sharma wrote: drm_dp_dpcd_read/write already has debug error message. Drop redundant error messages which gives false status even if correct value is read in drm_dp_dpcd_read(). I guess the only problem is it gets harder t

Re: [Intel-gfx] [PATCH] drm/i915/display: Drop redundant debug print

2021-08-13 Thread Jani Nikula
On Thu, 12 Aug 2021, Swati Sharma wrote: > drm_dp_dpcd_read/write already has debug error message. > Drop redundant error messages which gives false > status even if correct value is read in drm_dp_dpcd_read(). I guess the only problem is it gets harder to associate the preceding low level error

[Intel-gfx] [PATCH] drm/i915/display: Drop redundant debug print

2021-08-12 Thread Swati Sharma
drm_dp_dpcd_read/write already has debug error message. Drop redundant error messages which gives false status even if correct value is read in drm_dp_dpcd_read(). Fixes: 9488a030ac91 ("drm/i915: Add support for enabling link status and recovery") Cc: Swati Sharma Cc: Ankit Nautiyal Cc: Uma Sha

Re: [Intel-gfx] [PATCH] drm/i915/display: Drop redundant debug print

2021-08-11 Thread Nautiyal, Ankit K
Patch looks good to me. I think we must add fixes tag with the below commit: https://cgit.freedesktop.org/drm-tip/commit/?id=9488a030ac91447ea186ca3b7ec5c72ff03bc202 Reviewed-by: Ankit Nautiyal On 7/27/2021 12:21 AM, Swati Sharma wrote: drm_dp_dpcd_read/write already has debug error message.

Re: [Intel-gfx] [PATCH] drm/i915/display: Drop redundant debug print

2021-07-26 Thread kernel test robot
Hi Swati, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip v5.14-rc3 next-20210726] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

[Intel-gfx] [PATCH] drm/i915/display: Drop redundant debug print

2021-07-26 Thread Swati Sharma
drm_dp_dpcd_read/write already has debug error message. Drop redundant error messages which gives false status even if correct value is read in drm_dp_dpcd_read(). Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/display/intel_dp.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-