Re: [Intel-gfx] [PATCH] drm/i915/crt: make intel_crt_reset() static again

2018-06-28 Thread Jani Nikula
On Thu, 28 Jun 2018, Daniel Vetter wrote: > On Wed, Jun 27, 2018 at 02:49:40PM +0300, Jani Nikula wrote: >> On Thu, 21 Jun 2018, Ville Syrjälä wrote: >> > On Thu, Jun 21, 2018 at 04:03:30PM +0300, Jani Nikula wrote: >> >> Commit 9504a8924759 ("drm/i915/vlv: Reset the ADPA in >> >> vlv_display_pow

Re: [Intel-gfx] [PATCH] drm/i915/crt: make intel_crt_reset() static again

2018-06-27 Thread Daniel Vetter
On Wed, Jun 27, 2018 at 02:49:40PM +0300, Jani Nikula wrote: > On Thu, 21 Jun 2018, Ville Syrjälä wrote: > > On Thu, Jun 21, 2018 at 04:03:30PM +0300, Jani Nikula wrote: > >> Commit 9504a8924759 ("drm/i915/vlv: Reset the ADPA in > >> vlv_display_power_well_init()") started calling intel_crt_reset(

Re: [Intel-gfx] [PATCH] drm/i915/crt: make intel_crt_reset() static again

2018-06-27 Thread Jani Nikula
On Thu, 21 Jun 2018, Ville Syrjälä wrote: > On Thu, Jun 21, 2018 at 04:03:30PM +0300, Jani Nikula wrote: >> Commit 9504a8924759 ("drm/i915/vlv: Reset the ADPA in >> vlv_display_power_well_init()") started calling intel_crt_reset() >> directly, while we could just as well use the hooks and keep the

Re: [Intel-gfx] [PATCH] drm/i915/crt: make intel_crt_reset() static again

2018-06-21 Thread Ville Syrjälä
On Thu, Jun 21, 2018 at 04:03:30PM +0300, Jani Nikula wrote: > Commit 9504a8924759 ("drm/i915/vlv: Reset the ADPA in > vlv_display_power_well_init()") started calling intel_crt_reset() > directly, while we could just as well use the hooks and keep the > function static. > > Cc: Lyude > Cc: Ville

[Intel-gfx] [PATCH] drm/i915/crt: make intel_crt_reset() static again

2018-06-21 Thread Jani Nikula
Commit 9504a8924759 ("drm/i915/vlv: Reset the ADPA in vlv_display_power_well_init()") started calling intel_crt_reset() directly, while we could just as well use the hooks and keep the function static. Cc: Lyude Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_crt.c