Re: [Intel-gfx] [PATCH] drm/i915/cnp: Ignore VBT request for know invalid DDC pin.

2018-01-24 Thread Rodrigo Vivi
On Wed, Jan 24, 2018 at 09:25:06AM +, Jani Nikula wrote: > On Tue, 23 Jan 2018, Rodrigo Vivi wrote: > > On Tue, Jan 23, 2018 at 05:40:50PM +, Rodrigo Vivi wrote: > >> Let's ignore VBT request if the pin is clearly wrong. > >> > >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104

Re: [Intel-gfx] [PATCH] drm/i915/cnp: Ignore VBT request for know invalid DDC pin.

2018-01-24 Thread Ville Syrjälä
On Wed, Jan 24, 2018 at 12:03:12PM +0200, Jani Nikula wrote: > On Wed, 24 Jan 2018, Kai Heng Feng wrote: > > Hi, > > > >> On 24 Jan 2018, at 5:25 PM, Jani Nikula > >> wrote: > >> A bit too fast IMO. The bug report doesn't include the vbt dump which > >> you should *always* look at before making

Re: [Intel-gfx] [PATCH] drm/i915/cnp: Ignore VBT request for know invalid DDC pin.

2018-01-24 Thread Kai Heng Feng
> On 24 Jan 2018, at 6:03 PM, Jani Nikula wrote: > > On Wed, 24 Jan 2018, Kai Heng Feng wrote: >> Hi, >> >>> On 24 Jan 2018, at 5:25 PM, Jani Nikula wrote: >>> A bit too fast IMO. The bug report doesn't include the vbt dump which >>> you should *always* look at before making workarounds for v

Re: [Intel-gfx] [PATCH] drm/i915/cnp: Ignore VBT request for know invalid DDC pin.

2018-01-24 Thread Jani Nikula
On Wed, 24 Jan 2018, Kai Heng Feng wrote: > Hi, > >> On 24 Jan 2018, at 5:25 PM, Jani Nikula wrote: >> A bit too fast IMO. The bug report doesn't include the vbt dump which >> you should *always* look at before making workarounds for vbt. > > I didn’t have access to the machine in question until

Re: [Intel-gfx] [PATCH] drm/i915/cnp: Ignore VBT request for know invalid DDC pin.

2018-01-24 Thread Kai Heng Feng
Hi, > On 24 Jan 2018, at 5:25 PM, Jani Nikula wrote: > A bit too fast IMO. The bug report doesn't include the vbt dump which > you should *always* look at before making workarounds for vbt. I didn’t have access to the machine in question until now, I can provide VBT dump as well as i915_opregion

Re: [Intel-gfx] [PATCH] drm/i915/cnp: Ignore VBT request for know invalid DDC pin.

2018-01-24 Thread Jani Nikula
On Tue, 23 Jan 2018, Rodrigo Vivi wrote: > On Tue, Jan 23, 2018 at 05:40:50PM +, Rodrigo Vivi wrote: >> Let's ignore VBT request if the pin is clearly wrong. >> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104139 >> Cc: Kai Heng Feng >> Signed-off-by: Rodrigo Vivi > > Reviewed-

Re: [Intel-gfx] [PATCH] drm/i915/cnp: Ignore VBT request for know invalid DDC pin.

2018-01-23 Thread Rodrigo Vivi
On Tue, Jan 23, 2018 at 05:40:50PM +, Rodrigo Vivi wrote: > Let's ignore VBT request if the pin is clearly wrong. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104139 > Cc: Kai Heng Feng > Signed-off-by: Rodrigo Vivi Reviewed-by: Radhakrishna Sripada (f2f) thanks merged to di

[Intel-gfx] [PATCH] drm/i915/cnp: Ignore VBT request for know invalid DDC pin.

2018-01-23 Thread Rodrigo Vivi
Let's ignore VBT request if the pin is clearly wrong. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104139 Cc: Kai Heng Feng Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_bios.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm