Re: [Intel-gfx] [PATCH] drm/i915/bdw: PIPE_[BC] I[ME]R moved to powerwell

2013-11-11 Thread Daniel Vetter
On Mon, Nov 11, 2013 at 02:46:28PM -0800, Ben Widawsky wrote: > The pipe B and pipe C interrupt mask and enable registers are now part > of the pipe, so disabling the pipe power wells will lost the contests of > the registers. > > Art totally debugged this one! > > v2: Use the irq_lock to clarify

[Intel-gfx] [PATCH] drm/i915/bdw: PIPE_[BC] I[ME]R moved to powerwell

2013-11-11 Thread Ben Widawsky
The pipe B and pipe C interrupt mask and enable registers are now part of the pipe, so disabling the pipe power wells will lost the contests of the registers. Art totally debugged this one! v2: Use the irq_lock to clarify code, and prevent future bugs (Daniel) Cc: Art Runyan Cc: Paulo Zanoni S

Re: [Intel-gfx] [PATCH] drm/i915/bdw: PIPE_[BC] I[ME]R moved to powerwell

2013-11-10 Thread Daniel Vetter
On Sat, Nov 9, 2013 at 6:20 PM, Ben Widawsky wrote: > On Sat, Nov 09, 2013 at 10:13:21AM +0100, Daniel Vetter wrote: >> On Fri, Nov 08, 2013 at 02:29:46PM -0800, Ben Widawsky wrote: >> > The pipe B and pipe C interrupt mask and enable registers are now part >> > of the pipe, so disabling the pipe

Re: [Intel-gfx] [PATCH] drm/i915/bdw: PIPE_[BC] I[ME]R moved to powerwell

2013-11-09 Thread Ben Widawsky
On Sat, Nov 09, 2013 at 10:13:21AM +0100, Daniel Vetter wrote: > On Fri, Nov 08, 2013 at 02:29:46PM -0800, Ben Widawsky wrote: > > The pipe B and pipe C interrupt mask and enable registers are now part > > of the pipe, so disabling the pipe power wells will lost the contests of > > the registers. >

Re: [Intel-gfx] [PATCH] drm/i915/bdw: PIPE_[BC] I[ME]R moved to powerwell

2013-11-09 Thread Daniel Vetter
On Fri, Nov 08, 2013 at 02:29:46PM -0800, Ben Widawsky wrote: > The pipe B and pipe C interrupt mask and enable registers are now part > of the pipe, so disabling the pipe power wells will lost the contests of > the registers. > > Art totally debugged this one! > > Cc: Art Runyan > Cc: Paulo Zan

[Intel-gfx] [PATCH] drm/i915/bdw: PIPE_[BC] I[ME]R moved to powerwell

2013-11-08 Thread Ben Widawsky
The pipe B and pipe C interrupt mask and enable registers are now part of the pipe, so disabling the pipe power wells will lost the contests of the registers. Art totally debugged this one! Cc: Art Runyan Cc: Paulo Zanoni Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/intel_pm.c | 12 ++