Re: [Intel-gfx] [PATCH] drm/i915/bdw: Fix GEN8 GTT size calculation

2014-03-17 Thread Daniel Vetter
On Mon, Mar 17, 2014 at 5:17 PM, Woodhouse, David wrote: > I think I have found this problem on the IOMMU side. We usually assume > that RMRRs are for boot-time only, such as USB controllers for the > legacy keyboard/mouse emulation. And a patch sneaked in which > effectively *unmaps* the RMRR reg

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Fix GEN8 GTT size calculation

2014-03-17 Thread David Woodhouse
On Mon, 2014-03-17 at 16:17 +, David Woodhouse wrote: > > Can't tell though, because my machine is still dying in an endless > stream of > [ 199.647850] [drm:intel_set_cpu_fifo_underrun_reporting] *ERROR* > Interrupt arrived before CRTCs were setup up Except when the failure mode is differen

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Fix GEN8 GTT size calculation

2014-03-17 Thread Woodhouse, David
On Fri, 2014-03-14 at 23:10 +0100, Daniel Vetter wrote: > > I've asked you on private irc whether this range matches/overlaps with > stolen - we know of things blowing up at least on earlier generations > in combination with dmar. Please boot with drm.debug=0xe and scan for > the stolen mem report

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Fix GEN8 GTT size calculation

2014-03-15 Thread Daniel Vetter
On Fri, Mar 14, 2014 at 12:14:05PM -0700, Ben Widawsky wrote: > On Fri, Mar 14, 2014 at 07:40:30PM +0100, Daniel Vetter wrote: > > On Fri, Mar 14, 2014 at 09:58:06AM -0700, Ben Widawsky wrote: > > > The preliminary HW support check is no longer needed, and the > > > calculation is simplified while

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Fix GEN8 GTT size calculation

2014-03-15 Thread Daniel Vetter
On Fri, Mar 14, 2014 at 11:05 PM, Woodhouse, David wrote: > On Fri, 2014-03-14 at 12:14 -0700, Ben Widawsky wrote: >> >> This was based off of linus master, since I assumed that is what David >> was using. > > Indeed. Now it's much better. Now that nasty scary warning is gone away > and now I just

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Fix GEN8 GTT size calculation

2014-03-15 Thread Woodhouse, David
On Fri, 2014-03-14 at 12:14 -0700, Ben Widawsky wrote: > > This was based off of linus master, since I assumed that is what David > was using. Indeed. Now it's much better. Now that nasty scary warning is gone away and now I just have a few hundred of these (from your other patch before which it

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Fix GEN8 GTT size calculation

2014-03-15 Thread Daniel Vetter
On Fri, Mar 14, 2014 at 8:14 PM, Ben Widawsky wrote: > This was based off of linus master, since I assumed that is what David > was using. Honestly, I hadn't looked at our Intel trees. Maybe we're > good here already. Ok, now I was even more confused ... Turns out this was part of "drm/i915/bdw:

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Fix GEN8 GTT size calculation

2014-03-14 Thread Ben Widawsky
On Fri, Mar 14, 2014 at 07:40:30PM +0100, Daniel Vetter wrote: > On Fri, Mar 14, 2014 at 09:58:06AM -0700, Ben Widawsky wrote: > > The preliminary HW support check is no longer needed, and the > > calculation is simplified while here. > > > > Reported-by: David Woodhouse > > Signed-off-by: Ben Wi

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Fix GEN8 GTT size calculation

2014-03-14 Thread Daniel Vetter
On Fri, Mar 14, 2014 at 09:58:06AM -0700, Ben Widawsky wrote: > The preliminary HW support check is no longer needed, and the > calculation is simplified while here. > > Reported-by: David Woodhouse > Signed-off-by: Ben Widawsky > --- > drivers/gpu/drm/i915/i915_gem_gtt.c | 9 + > 1 fil

[Intel-gfx] [PATCH] drm/i915/bdw: Fix GEN8 GTT size calculation

2014-03-14 Thread Ben Widawsky
The preliminary HW support check is no longer needed, and the calculation is simplified while here. Reported-by: David Woodhouse Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_gem_gtt.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/i