Re: [Intel-gfx] [PATCH] drm/i915/bdw: Fix 4g GGTT insert entries regression

2014-03-05 Thread Jani Nikula
On Wed, 05 Mar 2014, Daniel Vetter wrote: > On Wed, Mar 05, 2014 at 12:19:51PM -0800, Ben Widawsky wrote: >> On Wed, Mar 05, 2014 at 07:24:37AM -0800, Ben Widawsky wrote: >> > On Wed, Mar 05, 2014 at 11:13:12AM +0200, Jani Nikula wrote: >> > > On Wed, 05 Mar 2014, Ben Widawsky wrote: >> > > > The

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Fix 4g GGTT insert entries regression

2014-03-05 Thread Daniel Vetter
On Wed, Mar 05, 2014 at 12:19:51PM -0800, Ben Widawsky wrote: > On Wed, Mar 05, 2014 at 07:24:37AM -0800, Ben Widawsky wrote: > > On Wed, Mar 05, 2014 at 11:13:12AM +0200, Jani Nikula wrote: > > > On Wed, 05 Mar 2014, Ben Widawsky wrote: > > > > The PDE needs to wrap after writing all the PTEs. Qu

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Fix 4g GGTT insert entries regression

2014-03-05 Thread Ben Widawsky
On Wed, Mar 05, 2014 at 07:24:37AM -0800, Ben Widawsky wrote: > On Wed, Mar 05, 2014 at 11:13:12AM +0200, Jani Nikula wrote: > > On Wed, 05 Mar 2014, Ben Widawsky wrote: > > > The PDE needs to wrap after writing all the PTEs. Quite a small/silly > > > bug to find in the massive change. It was intr

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Fix 4g GGTT insert entries regression

2014-03-05 Thread Ben Widawsky
On Wed, Mar 05, 2014 at 11:13:12AM +0200, Jani Nikula wrote: > On Wed, 05 Mar 2014, Ben Widawsky wrote: > > The PDE needs to wrap after writing all the PTEs. Quite a small/silly > > bug to find in the massive change. It was introduced: > > commit 307dc4f99f6d3a74a78b0e776838f35b2004f14d > > Author

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Fix 4g GGTT insert entries regression

2014-03-05 Thread Jani Nikula
On Wed, 05 Mar 2014, Ben Widawsky wrote: > The PDE needs to wrap after writing all the PTEs. Quite a small/silly > bug to find in the massive change. It was introduced: > commit 307dc4f99f6d3a74a78b0e776838f35b2004f14d > Author: Ben Widawsky > Date: Thu Feb 20 11:51:21 2014 -0800 > > drm/i9

[Intel-gfx] [PATCH] drm/i915/bdw: Fix 4g GGTT insert entries regression

2014-03-04 Thread Ben Widawsky
The PDE needs to wrap after writing all the PTEs. Quite a small/silly bug to find in the massive change. It was introduced: commit 307dc4f99f6d3a74a78b0e776838f35b2004f14d Author: Ben Widawsky Date: Thu Feb 20 11:51:21 2014 -0800 drm/i915/bdw: Reorganize PT allocations I can't actually tes