Re: [Intel-gfx] [PATCH] drm/i915/GLK/HuC: Load HuC on GLK

2017-03-30 Thread Joonas Lahtinen
On ke, 2017-03-29 at 10:54 +0300, Jani Nikula wrote: > > On Wed, 29 Mar 2017, John Spotswood wrote: > > > > On Tue, 2017-03-21 at 17:29 -0700, Anusha Srivatsa wrote: > > > > > > +#define I915_GLK_HUC_UCODE HUC_FW_PATH(glk, GLK_HUC_FW_MAJOR, \ > > > + GLK_HUC_FW_MINOR, GLK_BLD_NUM) > > > > I thi

Re: [Intel-gfx] [PATCH] drm/i915/GLK/HuC: Load HuC on GLK

2017-03-29 Thread Jani Nikula
On Wed, 29 Mar 2017, John Spotswood wrote: > On Tue, 2017-03-21 at 17:29 -0700, Anusha Srivatsa wrote: >> +#define I915_GLK_HUC_UCODE HUC_FW_PATH(glk, GLK_HUC_FW_MAJOR, \ >> +GLK_HUC_FW_MINOR, GLK_BLD_NUM) > > I think you need a line after this #define that says the following: >    MODULE_FIRM

Re: [Intel-gfx] [PATCH] drm/i915/GLK/HuC: Load HuC on GLK

2017-03-28 Thread John Spotswood
On Tue, 2017-03-21 at 17:29 -0700, Anusha Srivatsa wrote: > Load HuC version 1.07.1748 on GLK. > > v2: rebased. > v3: Use name of the right platform(John Spotswood) > > Cc: Jeff Mcgee > Cc: John Spotswood > Cc: Rodrigo Vivi > Signed-off-by: Anusha Srivatsa > --- >  drivers/gpu/drm/i915/intel_

[Intel-gfx] [PATCH] drm/i915/GLK/HuC: Load HuC on GLK

2017-03-21 Thread Anusha Srivatsa
Load HuC version 1.07.1748 on GLK. v2: rebased. v3: Use name of the right platform(John Spotswood) Cc: Jeff Mcgee Cc: John Spotswood Cc: Rodrigo Vivi Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/intel_huc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/g