Re: [Intel-gfx] [PATCH] drm/fb-helper: Automatically clean up fb_info

2017-02-07 Thread Emil Velikov
On 7 February 2017 at 14:49, Chris Wilson wrote: > On Tue, Feb 07, 2017 at 02:38:16PM +, Emil Velikov wrote: >> On 7 February 2017 at 14:29, Daniel Vetter wrote: >> > Noticed that everyone duplicates the same logic here and we could safe >> > a few lines per driver. Yay for lots of drivers to

Re: [Intel-gfx] [PATCH] drm/fb-helper: Automatically clean up fb_info

2017-02-07 Thread Sean Paul
On Tue, Feb 07, 2017 at 05:16:03PM +0100, Daniel Vetter wrote: > Noticed that everyone duplicates the same logic here and we could safe > a few lines per driver. Yay for lots of drivers to make such tiny > refactors worth-while! > > v2: Forgot to git add everything :( > > v3: Actually remove rele

[Intel-gfx] [PATCH] drm/fb-helper: Automatically clean up fb_info

2017-02-07 Thread Daniel Vetter
Noticed that everyone duplicates the same logic here and we could safe a few lines per driver. Yay for lots of drivers to make such tiny refactors worth-while! v2: Forgot to git add everything :( v3: Actually remove release_fbi (Sean, Emil, Chris) ... Cc: Chris Wilson Cc: Sean Paul Cc: Noralf

Re: [Intel-gfx] [PATCH] drm/fb-helper: Automatically clean up fb_info

2017-02-07 Thread Daniel Vetter
On Tue, Feb 07, 2017 at 02:49:38PM +, Chris Wilson wrote: > On Tue, Feb 07, 2017 at 02:38:16PM +, Emil Velikov wrote: > > On 7 February 2017 at 14:29, Daniel Vetter wrote: > > > Noticed that everyone duplicates the same logic here and we could safe > > > a few lines per driver. Yay for lot

Re: [Intel-gfx] [PATCH] drm/fb-helper: Automatically clean up fb_info

2017-02-07 Thread Chris Wilson
On Tue, Feb 07, 2017 at 02:38:16PM +, Emil Velikov wrote: > On 7 February 2017 at 14:29, Daniel Vetter wrote: > > Noticed that everyone duplicates the same logic here and we could safe > > a few lines per driver. Yay for lots of drivers to make such tiny > > refactors worth-while! > > > > v2:

Re: [Intel-gfx] [PATCH] drm/fb-helper: Automatically clean up fb_info

2017-02-07 Thread Emil Velikov
On 7 February 2017 at 14:29, Daniel Vetter wrote: > Noticed that everyone duplicates the same logic here and we could safe > a few lines per driver. Yay for lots of drivers to make such tiny > refactors worth-while! > > v2: Forgot to git add everything :( > Hmm afaict this patch inlines drm_fb_hel

[Intel-gfx] [PATCH] drm/fb-helper: Automatically clean up fb_info

2017-02-07 Thread Daniel Vetter
Noticed that everyone duplicates the same logic here and we could safe a few lines per driver. Yay for lots of drivers to make such tiny refactors worth-while! v2: Forgot to git add everything :( Cc: Chris Wilson Cc: Sean Paul Cc: Noralf Trønnes Signed-off-by: Daniel Vetter --- drivers/gpu/d