Re: [Intel-gfx] [PATCH] allow 945 to control self refresh automatically

2011-01-03 Thread Alexander Lam
Hi, I probably should mention that the patch is in reply to: (I got Li's ack here) http://lists.freedesktop.org/archives/intel-gfx/2010-October/008302.html School kept me busy since then and I haven't been able to find any free time until this winter break to respin. (College unexpectedly took mo

Re: [Intel-gfx] [PATCH] allow 945 to control self refresh automatically

2011-01-03 Thread Jesse Barnes
On Mon, 03 Jan 2011 19:33:05 + Chris Wilson wrote: > On Mon, 3 Jan 2011 13:28:56 -0500, Alexander Lam > wrote: > > I changed 945's self refresh to work without the need for the driver to > > enable/disable self refresh manually based on the idle state of the gpu. > > This is much better th

Re: [Intel-gfx] [PATCH] allow 945 to control self refresh automatically

2011-01-03 Thread Chris Wilson
On Mon, 3 Jan 2011 13:28:56 -0500, Alexander Lam wrote: > I changed 945's self refresh to work without the need for the driver to > enable/disable self refresh manually based on the idle state of the gpu. > This is much better than enabling/disabling self refresh for various > reasons, including

[Intel-gfx] [PATCH] allow 945 to control self refresh automatically

2011-01-03 Thread Alexander Lam
I changed 945's self refresh to work without the need for the driver to enable/disable self refresh manually based on the idle state of the gpu. This is much better than enabling/disabling self refresh for various reasons, including staying in a lower power state for more time and avoiding the need

Re: [Intel-gfx] [PATCH] allow 945 to control self refresh automatically

2010-10-08 Thread Chris Wilson
On Fri, 08 Oct 2010 16:05:34 +0800, Li Peng wrote: > Hi, Alexander: > > I think you are right that GEN3 hardware CXSR requires enabling low > power render writes. > > This patch is OK for me, but DRM_DEBUG_KMS is better than printk. Alexander, if you don't mind respinning your patch to fixup t

Re: [Intel-gfx] [PATCH] allow 945 to control self refresh automatically

2010-10-08 Thread Li Peng
Hi, Alexander: I think you are right that GEN3 hardware CXSR requires enabling low power render writes. This patch is OK for me, but DRM_DEBUG_KMS is better than printk. Acked-by : Li Peng On Mon, 2010-10-04 at 19:31 -0400, Alexander Lam wrote: > Using 2.6.35.7 (this patch is against drm-int

[Intel-gfx] [PATCH] allow 945 to control self refresh automatically

2010-10-04 Thread Alexander Lam
Using 2.6.35.7 (this patch is against drm-intel-next 7dcd249, but untested), I changed 945's self refresh to work without the need for the driver to enable/disable self refresh manually based on the idle state of the gpu. This is much better than enabling/disabling self refresh for various reasons