Re: [Intel-gfx] [PATCH] Poll for HDMI disconnects.

2012-10-12 Thread Stuart Abercrombie
> I've tried to be slightly lazy than in my previous mail and quickly > tested this on my snb here: Bit 23 in SDEISR (0xc4000) is set when the > cable is plugged in, and cleared when nothing is plugged in. Afaict it > works as advertised. Note tha the SDE irq definitions nicely > differentiates bet

Re: [Intel-gfx] [PATCH] Poll for HDMI disconnects.

2012-10-12 Thread Daniel Vetter
On Fri, Oct 12, 2012 at 9:03 PM, Stuart Abercrombie wrote: >> My docs here say that the SDE_ISR reg contains what we want - high >> level irq bit when the hpd line is enabled. I admit, I haven't tested >> this ... > > I'm looking at 2.1.1 in this > http://intellinuxgraphics.org/documentation/SNB/I

Re: [Intel-gfx] [PATCH] Poll for HDMI disconnects.

2012-10-12 Thread Stuart Abercrombie
> My docs here say that the SDE_ISR reg contains what we want - high > level irq bit when the hpd line is enabled. I admit, I haven't tested > this ... I'm looking at 2.1.1 in this http://intellinuxgraphics.org/documentation/SNB/IHD_OS_Vol3_Part3.pdf. All it has relating to hotplug in SDEIIR are

Re: [Intel-gfx] [PATCH] Poll for HDMI disconnects.

2012-10-12 Thread Daniel Vetter
On Fri, Oct 12, 2012 at 8:40 PM, Stuart Abercrombie wrote: >> In the hotplug register, like on g4x. But that moved to to PCH_IIR on pch >> platforms. I plan to rework the entire hotplug handling for 3.8, hence why >> I haven't bothered to wire this up yet. > > You are saying that the HPD line stat

Re: [Intel-gfx] [PATCH] Poll for HDMI disconnects.

2012-10-12 Thread Stuart Abercrombie
> In the hotplug register, like on g4x. But that moved to to PCH_IIR on pch > platforms. I plan to rework the entire hotplug handling for 3.8, hence why > I haven't bothered to wire this up yet. You are saying that the HPD line state is available in the register called SDEIIR in the code? The doc

Re: [Intel-gfx] [PATCH] Poll for HDMI disconnects.

2012-10-12 Thread Daniel Vetter
On Fri, Oct 12, 2012 at 10:29:38AM -0700, Stuart Abercrombie wrote: > > Nope, the real fix is to simply check the status of the hpd line before > > trying the edid read. We already have that for g4x class chips, check > > g4x_hdmi_connected. We'd need to add similar checks for all other > > platfor

Re: [Intel-gfx] [PATCH] Poll for HDMI disconnects.

2012-10-12 Thread Stuart Abercrombie
> Nope, the real fix is to simply check the status of the hpd line before > trying the edid read. We already have that for g4x class chips, check > g4x_hdmi_connected. We'd need to add similar checks for all other > platforms. > -Daniel That would be preferable. Unfortunately we did not find a wa

Re: [Intel-gfx] [PATCH] Poll for HDMI disconnects.

2012-10-12 Thread Daniel Vetter
On Thu, Oct 11, 2012 at 04:27:54PM -0700, Stuart Abercrombie wrote: > Following a hotplug interrupt the driver uses a successful EDID read to > indicate HDMI sink presence. > > This leads to missing HDMI cable unplug events because the DDC lines can > remain up, allowing an EDID read to complete

[Intel-gfx] [PATCH] Poll for HDMI disconnects.

2012-10-11 Thread Stuart Abercrombie
Following a hotplug interrupt the driver uses a successful EDID read to indicate HDMI sink presence. This leads to missing HDMI cable unplug events because the DDC lines can remain up, allowing an EDID read to complete, well after the HPD line goes down during unplugging Since it is only the d