Re: [Intel-gfx] [PATCH] Fix pointer tests in error-handling paths

2016-01-28 Thread Tvrtko Ursulin
On 28/01/16 10:48, Tvrtko Ursulin wrote: From: Dave Gordon In the error-handling paths of i915_gem_do_execbuffer() and intel_crtc_page_flip(), the local pointer-to-request variables were expected to be either valid pointers or NULL. Since 2682708 drm/i915: simplify allocation of driver-int

[Intel-gfx] [PATCH] Fix pointer tests in error-handling paths

2016-01-28 Thread Tvrtko Ursulin
From: Dave Gordon In the error-handling paths of i915_gem_do_execbuffer() and intel_crtc_page_flip(), the local pointer-to-request variables were expected to be either valid pointers or NULL. Since 2682708 drm/i915: simplify allocation of driver-internal requests they could also be ERR_PTR()

Re: [Intel-gfx] [PATCH] Fix pointer tests in error-handling paths

2016-01-25 Thread Dave Gordon
On 22/01/16 13:34, Chris Wilson wrote: On Fri, Jan 22, 2016 at 01:17:44PM +, Tvrtko Ursulin wrote: On 22/01/16 13:01, Chris Wilson wrote: On Fri, Jan 22, 2016 at 12:19:32PM +, Dave Gordon wrote: In the error-handling paths of i915_gem_do_execbuffer() and intel_crtc_page_flip(), the lo

Re: [Intel-gfx] [PATCH] Fix pointer tests in error-handling paths

2016-01-25 Thread Tvrtko Ursulin
On 25/01/16 16:28, Daniel Vetter wrote: On Fri, Jan 22, 2016 at 01:07:48PM +, Tvrtko Ursulin wrote: On 22/01/16 12:19, Dave Gordon wrote: In the error-handling paths of i915_gem_do_execbuffer() and intel_crtc_page_flip(), the local pointer-to-request variables were expected to be either v

Re: [Intel-gfx] [PATCH] Fix pointer tests in error-handling paths

2016-01-25 Thread Daniel Vetter
On Fri, Jan 22, 2016 at 01:07:48PM +, Tvrtko Ursulin wrote: > > On 22/01/16 12:19, Dave Gordon wrote: > >In the error-handling paths of i915_gem_do_execbuffer() and > >intel_crtc_page_flip(), the local pointer-to-request variables > >were expected to be either valid pointers or NULL. Since > >

Re: [Intel-gfx] [PATCH] Fix pointer tests in error-handling paths

2016-01-22 Thread Chris Wilson
On Fri, Jan 22, 2016 at 01:17:44PM +, Tvrtko Ursulin wrote: > > On 22/01/16 13:01, Chris Wilson wrote: > >On Fri, Jan 22, 2016 at 12:19:32PM +, Dave Gordon wrote: > >>In the error-handling paths of i915_gem_do_execbuffer() and > >>intel_crtc_page_flip(), the local pointer-to-request variab

Re: [Intel-gfx] [PATCH] Fix pointer tests in error-handling paths

2016-01-22 Thread Tvrtko Ursulin
On 22/01/16 13:01, Chris Wilson wrote: On Fri, Jan 22, 2016 at 12:19:32PM +, Dave Gordon wrote: In the error-handling paths of i915_gem_do_execbuffer() and intel_crtc_page_flip(), the local pointer-to-request variables were expected to be either valid pointers or NULL. Since 2682708 drm

Re: [Intel-gfx] [PATCH] Fix pointer tests in error-handling paths

2016-01-22 Thread Tvrtko Ursulin
On 22/01/16 12:19, Dave Gordon wrote: In the error-handling paths of i915_gem_do_execbuffer() and intel_crtc_page_flip(), the local pointer-to-request variables were expected to be either valid pointers or NULL. Since 2682708 drm/i915: simplify allocation of driver-internal requests they co

Re: [Intel-gfx] [PATCH] Fix pointer tests in error-handling paths

2016-01-22 Thread Chris Wilson
On Fri, Jan 22, 2016 at 12:19:32PM +, Dave Gordon wrote: > In the error-handling paths of i915_gem_do_execbuffer() and > intel_crtc_page_flip(), the local pointer-to-request variables > were expected to be either valid pointers or NULL. Since > > 2682708 drm/i915: simplify allocation of driv

[Intel-gfx] [PATCH] Fix pointer tests in error-handling paths

2016-01-22 Thread Dave Gordon
In the error-handling paths of i915_gem_do_execbuffer() and intel_crtc_page_flip(), the local pointer-to-request variables were expected to be either valid pointers or NULL. Since 2682708 drm/i915: simplify allocation of driver-internal requests they could also be ERR_PTR() values, so the tests