Re: [Intel-gfx] [PATCH] Fix intel_detect_pch() to work in xen environment.

2013-06-20 Thread Daniel Vetter
On Wed, Jun 19, 2013 at 11:29:21PM +0800, G.R. wrote: > On Wed, Jun 19, 2013 at 2:01 PM, Daniel Vetter wrote: > > Can you please resubmit this as a proper patch with a committ message, > > signed-off-by line and everything else (see > > Documentation/SubmittingPatches). > > -Daniel > > Done, sent

Re: [Intel-gfx] [PATCH] Fix intel_detect_pch() to work in xen environment.

2013-06-19 Thread G.R.
On Wed, Jun 19, 2013 at 2:01 PM, Daniel Vetter wrote: > Can you please resubmit this as a proper patch with a committ message, > signed-off-by line and everything else (see > Documentation/SubmittingPatches). > -Daniel > Done, sent in a separate thread: http://lists.freedesktop.org/archives/intel

Re: [Intel-gfx] [PATCH] Fix intel_detect_pch() to work in xen environment.

2013-06-19 Thread Ville Syrjälä
On Tue, Jun 18, 2013 at 08:54:35PM +0800, G.R. wrote: > On Sun, Dec 23, 2012 at 2:51 PM, G.R. > wrote: > >>> Hi Jesse, I think I need to resend the patch with proper comment to > >>> have it formally accepted. > >>> Any guide line for formal patch submission? Do I need to start a > >>> separate t

Re: [Intel-gfx] [PATCH] Fix intel_detect_pch() to work in xen environment.

2013-06-18 Thread Daniel Vetter
Can you please resubmit this as a proper patch with a committ message, signed-off-by line and everything else (see Documentation/SubmittingPatches). -Daniel On Tue, Jun 18, 2013 at 2:54 PM, G.R. wrote: > On Sun, Dec 23, 2012 at 2:51 PM, G.R. > wrote: Hi Jesse, I think I need to resend the

Re: [Intel-gfx] [PATCH] Fix intel_detect_pch() to work in xen environment.

2013-06-18 Thread G.R.
On Sun, Dec 23, 2012 at 2:51 PM, G.R. wrote: >>> Hi Jesse, I think I need to resend the patch with proper comment to >>> have it formally accepted. >>> Any guide line for formal patch submission? Do I need to start a >>> separate thread? >> >> No, just cc Daniel Vetter. >> >> -- >> Jesse Barnes, I

Re: [Intel-gfx] [PATCH] Fix intel_detect_pch() to work in xen environment.

2012-12-22 Thread G.R.
>> >> > Ack on the general idea though; I'd like us to be able to run under Xen >> >> > without modification. >> >> > >> >> >> >> Stefano may be able to comment if it's feasible to achieve zero >> >> modification in this case. >> >> I believe this has something to do with getting rid of the PIIX3 >

Re: [Intel-gfx] [PATCH] Fix intel_detect_pch() to work in xen environment.

2012-12-20 Thread Jesse Barnes
On Thu, 20 Dec 2012 12:04:11 +0800 "G.R." wrote: > On Wed, Dec 19, 2012 at 2:20 AM, Jesse Barnes > wrote: > >> > > >> > I'd like to see a comment about this being for Xen in here, and I > >> > wonder if there are other places where we might have to worry about the > >> > Xen implementation. In

Re: [Intel-gfx] [PATCH] Fix intel_detect_pch() to work in xen environment.

2012-12-19 Thread G.R.
On Wed, Dec 19, 2012 at 2:20 AM, Jesse Barnes wrote: >> > >> > I'd like to see a comment about this being for Xen in here, and I >> > wonder if there are other places where we might have to worry about the >> > Xen implementation. In that case, setting a flag in dev_priv when we >> > don't find t

Re: [Intel-gfx] [PATCH] Fix intel_detect_pch() to work in xen environment.

2012-12-18 Thread G.R.
On Wed, Dec 19, 2012 at 1:21 AM, Ben Widawsky wrote: > On Wed, 19 Dec 2012 00:49:28 +0800 > "G.R." wrote: > >> Hi guys, >> >> In XEN HVM guest, there is always an emulated PIIX3 ISA bridge on slot 01.0. >> This shadows the PCH ISA bridge on 1f.0 with the current >> intel_detect_pch() implementati

Re: [Intel-gfx] [PATCH] Fix intel_detect_pch() to work in xen environment.

2012-12-18 Thread G.R.
On Wed, Dec 19, 2012 at 2:20 AM, Jesse Barnes wrote: > On Wed, 19 Dec 2012 01:43:22 +0800 > "G.R." wrote: > >> On Wed, Dec 19, 2012 at 12:53 AM, Jesse Barnes >> wrote: >> > On Wed, 19 Dec 2012 00:49:28 +0800 >> > "G.R." wrote: >> > >> >> Hi guys, >> >> >> >> In XEN HVM guest, there is always a

Re: [Intel-gfx] [PATCH] Fix intel_detect_pch() to work in xen environment.

2012-12-18 Thread Jesse Barnes
On Wed, 19 Dec 2012 01:43:22 +0800 "G.R." wrote: > On Wed, Dec 19, 2012 at 12:53 AM, Jesse Barnes > wrote: > > On Wed, 19 Dec 2012 00:49:28 +0800 > > "G.R." wrote: > > > >> Hi guys, > >> > >> In XEN HVM guest, there is always an emulated PIIX3 ISA bridge on slot > >> 01.0. > >> This shadows t

Re: [Intel-gfx] [PATCH] Fix intel_detect_pch() to work in xen environment.

2012-12-18 Thread G.R.
On Wed, Dec 19, 2012 at 12:53 AM, Jesse Barnes wrote: > On Wed, 19 Dec 2012 00:49:28 +0800 > "G.R." wrote: > >> Hi guys, >> >> In XEN HVM guest, there is always an emulated PIIX3 ISA bridge on slot 01.0. >> This shadows the PCH ISA bridge on 1f.0 with the current >> intel_detect_pch() implementat

Re: [Intel-gfx] [PATCH] Fix intel_detect_pch() to work in xen environment.

2012-12-18 Thread Ben Widawsky
On Wed, 19 Dec 2012 00:49:28 +0800 "G.R." wrote: > Hi guys, > > In XEN HVM guest, there is always an emulated PIIX3 ISA bridge on slot 01.0. > This shadows the PCH ISA bridge on 1f.0 with the current > intel_detect_pch() implementation. > The issue can be easily solved by looping through all the

Re: [Intel-gfx] [PATCH] Fix intel_detect_pch() to work in xen environment.

2012-12-18 Thread Jesse Barnes
On Wed, 19 Dec 2012 00:49:28 +0800 "G.R." wrote: > Hi guys, > > In XEN HVM guest, there is always an emulated PIIX3 ISA bridge on slot 01.0. > This shadows the PCH ISA bridge on 1f.0 with the current > intel_detect_pch() implementation. > The issue can be easily solved by looping through all the

[Intel-gfx] [PATCH] Fix intel_detect_pch() to work in xen environment.

2012-12-18 Thread G.R.
Hi guys, In XEN HVM guest, there is always an emulated PIIX3 ISA bridge on slot 01.0. This shadows the PCH ISA bridge on 1f.0 with the current intel_detect_pch() implementation. The issue can be easily solved by looping through all the ISA bridges until the first match is found, instead of just ch