Re: [Intel-gfx] [PATCH] Added a lower limit for the watermark setting

2013-11-20 Thread Thomas Richter
Am 20.11.2013 10:27, schrieb Daniel Vetter: What I've meant to say is that I want to split up the watermark code more anyway, so that there's no need to fill in the 0 all over the place where we don't care one bit. I.e. all the gen4+ platforms. Ok - well, I guess I cannot judge whether that's n

Re: [Intel-gfx] [PATCH] Added a lower limit for the watermark setting

2013-11-20 Thread Daniel Vetter
On Wed, Nov 20, 2013 at 10:18 AM, Thomas Richter wrote: >> I think we ned to split out the gen2/3 single/dual pipe watermark code a >> >> bit better from everything else. A bugfix for i830M shouldn't really >> affect snb ;-) > > > Actually, the fun part is that it does not because all the lower li

Re: [Intel-gfx] [PATCH] Added a lower limit for the watermark setting

2013-11-20 Thread Thomas Richter
Am 19.11.2013 17:41, schrieb Daniel Vetter: On Tue, Nov 19, 2013 at 05:15:09PM +0100, Thomas Richter wrote: Hi Daniel, dear intel experts, please find a patch attached that finally addresses the display flicker on i830 chipsets. This patch adds a lower watermark setting in intel_watermark_param

Re: [Intel-gfx] [PATCH] Added a lower limit for the watermark setting

2013-11-19 Thread Daniel Vetter
On Tue, Nov 19, 2013 at 05:15:09PM +0100, Thomas Richter wrote: > Hi Daniel, dear intel experts, > > please find a patch attached that finally addresses the display > flicker on i830 chipsets. This > patch adds a lower watermark setting in intel_watermark_params{}, > but keeps it zero for > all bu

[Intel-gfx] [PATCH] Added a lower limit for the watermark setting

2013-11-19 Thread Thomas Richter
Hi Daniel, dear intel experts, please find a patch attached that finally addresses the display flicker on i830 chipsets. This patch adds a lower watermark setting in intel_watermark_params{}, but keeps it zero for all but the i830 chipsets. The necessary new defines are in i915_reg.h. Greetin