Re: [Intel-gfx] [PATCH] [v9] drm/i915: Use the new vm [un]bind functions

2013-09-23 Thread Chris Wilson
On Mon, Sep 23, 2013 at 03:00:06PM -0700, Ben Widawsky wrote: > > I think this interface violates Rusty's rules (API should be easy to > > use but hard to misuse). > > > > vma = i915_gem_object_pin(batch_obj, ggtt, 0, false, false); > > if (IS_ERR(vm)) { > > ret = PTR_ERR(vm); > > goto

Re: [Intel-gfx] [PATCH] [v9] drm/i915: Use the new vm [un]bind functions

2013-09-23 Thread Ben Widawsky
On Mon, Sep 23, 2013 at 09:39:31AM +0100, Chris Wilson wrote: > On Sun, Sep 22, 2013 at 11:46:00AM -0700, Ben Widawsky wrote: > > From: Ben Widawsky > > > > Building on the last patch which created the new function pointers in > > the VM for bind/unbind, here we actually put those new function po

Re: [Intel-gfx] [PATCH] [v9] drm/i915: Use the new vm [un]bind functions

2013-09-23 Thread Chris Wilson
On Sun, Sep 22, 2013 at 11:46:00AM -0700, Ben Widawsky wrote: > From: Ben Widawsky > > Building on the last patch which created the new function pointers in > the VM for bind/unbind, here we actually put those new function pointers > to use. > > Split out as a separate patch to aid in review. I'

[Intel-gfx] [PATCH] [v9] drm/i915: Use the new vm [un]bind functions

2013-09-22 Thread Ben Widawsky
From: Ben Widawsky Building on the last patch which created the new function pointers in the VM for bind/unbind, here we actually put those new function pointers to use. Split out as a separate patch to aid in review. I'm fine with squashing into the previous patch if people request it. v2: Upd