Re: [Intel-gfx] [PATCH] [v2] drm/i915/vma: Correct use after free in eviction

2013-08-19 Thread Daniel Vetter
On Mon, Aug 19, 2013 at 10:49 AM, Mika Kuoppala wrote: >>> Mika pasted an oops on #intel-gfx. Chris and Ville had is solved before >>> I woke up. It's pretty strange, Chris said the bug existed in the >>> original ppgtt2 branch (I'm too lazy to check). In many runs for myself, >>> and QA, I'd not

Re: [Intel-gfx] [PATCH] [v2] drm/i915/vma: Correct use after free in eviction

2013-08-19 Thread Mika Kuoppala
Daniel Vetter writes: > On Mon, Aug 19, 2013 at 12:35 AM, Ben Widawsky wrote: >> On Sun, Aug 18, 2013 at 07:26:57PM +0200, Daniel Vetter wrote: >>> On Fri, Aug 16, 2013 at 11:31:12PM +0100, Chris Wilson wrote: >>> > On Fri, Aug 16, 2013 at 01:29:33PM -0700, Ben Widawsky wrote: >>> > > The vma wi

Re: [Intel-gfx] [PATCH] [v2] drm/i915/vma: Correct use after free in eviction

2013-08-19 Thread Daniel Vetter
On Mon, Aug 19, 2013 at 12:35 AM, Ben Widawsky wrote: > On Sun, Aug 18, 2013 at 07:26:57PM +0200, Daniel Vetter wrote: >> On Fri, Aug 16, 2013 at 11:31:12PM +0100, Chris Wilson wrote: >> > On Fri, Aug 16, 2013 at 01:29:33PM -0700, Ben Widawsky wrote: >> > > The vma will [possibly] be destroyed dur

Re: [Intel-gfx] [PATCH] [v2] drm/i915/vma: Correct use after free in eviction

2013-08-18 Thread Ben Widawsky
On Sun, Aug 18, 2013 at 07:26:57PM +0200, Daniel Vetter wrote: > On Fri, Aug 16, 2013 at 11:31:12PM +0100, Chris Wilson wrote: > > On Fri, Aug 16, 2013 at 01:29:33PM -0700, Ben Widawsky wrote: > > > The vma will [possibly] be destroyed during unbind in eviction. > > > Immediately after this, we try

Re: [Intel-gfx] [PATCH] [v2] drm/i915/vma: Correct use after free in eviction

2013-08-18 Thread Daniel Vetter
On Fri, Aug 16, 2013 at 11:31:12PM +0100, Chris Wilson wrote: > On Fri, Aug 16, 2013 at 01:29:33PM -0700, Ben Widawsky wrote: > > The vma will [possibly] be destroyed during unbind in eviction. > > Immediately after this, we try to delete the list entry. > > > > Chris and Ville did the debug on th

Re: [Intel-gfx] [PATCH] [v2] drm/i915/vma: Correct use after free in eviction

2013-08-16 Thread Chris Wilson
On Fri, Aug 16, 2013 at 01:29:33PM -0700, Ben Widawsky wrote: > The vma will [possibly] be destroyed during unbind in eviction. > Immediately after this, we try to delete the list entry. > > Chris and Ville did the debug on this before I woke up, I just get to > take credit for the fix :p > > v2:

[Intel-gfx] [PATCH] [v2] drm/i915/vma: Correct use after free in eviction

2013-08-16 Thread Ben Widawsky
The vma will [possibly] be destroyed during unbind in eviction. Immediately after this, we try to delete the list entry. Chris and Ville did the debug on this before I woke up, I just get to take credit for the fix :p v2: Missed the drm_object_unreference use after free (Ville) Reported-by: Mika