Re: [Intel-gfx] [PATCH] drm/hisilicon/hibmc: Using module_pci_driver.

2018-04-23 Thread xinliang
On 2018/4/21 17:51, YueHaibing wrote: Remove boilerplate code by using macro module_pci_driver. Signed-off-by: YueHaibing Thanks Haibing, Reviewed-by: Xinliang Liu Xinliang --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 13 + 1 file changed, 1 insertion(+), 12

Re: [Intel-gfx] [PATCH 19/38] drm/hisilicon: Implement some semblance of vblank event handling

2016-06-21 Thread Xinliang Liu
On 21 June 2016 at 15:19, Daniel Vetter wrote: > On Tue, Jun 21, 2016 at 3:32 AM, Xinliang Liu wrote: >> My understanding is that drm_crtc_arm_vblank_event work together with >> drm_crtc_handle_vblank (called in vblank interrupt). >> Arm the event first in somewhere(like at

Re: [Intel-gfx] [PATCH 19/38] drm/hisilicon: Implement some semblance of vblank event handling

2016-06-20 Thread Xinliang Liu
On 17 June 2016 at 20:24, Daniel Vetter wrote: > On Fri, Jun 17, 2016 at 04:38:06PM +0800, Xinliang Liu wrote: >> Hi, >> >> On 17 June 2016 at 15:23, Daniel Vetter wrote: >> > On Fri, Jun 17, 2016 at 10:09:50AM +0800, Xinliang Liu wrote: >> >> Hi Dani

Re: [Intel-gfx] [PATCH 4/7] drm/hisilicon: Remove redundant calls to drm_connector_register_all()

2016-06-19 Thread Xinliang Liu
ter_all() to drm_dev_register() and not suffer > from any backwards compatibility issues with drivers not following the > more rigorous init ordering. > > Signed-off-by: Chris Wilson > Cc: Daniel Vetter > Cc: Xinliang Liu > Cc: Xinwei Kong > Cc: Chen Feng > Cc: David Airlie

Re: [Intel-gfx] [PATCH 19/38] drm/hisilicon: Implement some semblance of vblank event handling

2016-06-17 Thread Xinliang Liu
Hi, On 17 June 2016 at 15:23, Daniel Vetter wrote: > On Fri, Jun 17, 2016 at 10:09:50AM +0800, Xinliang Liu wrote: >> Hi Daniel, >> >> I have tested your David's drm-next branch[1] which including this patch. >> In most time it is ok. But when switching modes

Re: [Intel-gfx] [PATCH 19/38] drm/hisilicon: Implement some semblance of vblank event handling

2016-06-16 Thread Xinliang Liu
~airlied/linux drm-next Thanks, -xinliang On 2 June 2016 at 06:06, Daniel Vetter wrote: > atomic_flush seems to be the right place, but I'm not entirely sure > whether this will catch them all. It could be that when disabling the > crtc we'll miss the vblank. > > While at it