From: Luiz Otavio Mello
The struct_mutex field in drm_i915_private is no longer used anywhere in
the driver. This patch removes it completely to clean up unused code and
avoid confusion.
Signed-off-by: Luiz Otavio Mello
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/i915_driver.c | 2
Mello
Signed-off-by: Rodrigo Vivi
---
Documentation/gpu/i915.rst | 7 ---
Documentation/gpu/todo.rst | 25 -
2 files changed, 32 deletions(-)
diff --git a/Documentation/gpu/i915.rst b/Documentation/gpu/i915.rst
index 72932fa31b8d..eba09c3ddce4 100644
--- a
, which
which is no longer used.
Signed-off-by: Luiz Otavio Mello
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/i915_drv.h | 3 +--
drivers/gpu/drm/i915/i915_gem.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm
future misunderstandings.
* intel_fbc.c: Removed the statement that intel_fbc->lock is the inner
lock when overlapping with struct_mutex, since struct_mutex is no
longer used anywhere in the driver.
Signed-off-by: Luiz Otavio Mello
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/disp
yed when the driver is unloaded.
Signed-off-by: Luiz Otavio Mello
Suggested-by: Rodrigo Vivi
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 5 +++--
drivers/gpu/drm/i915/gt/uc/intel_guc_log.h | 8
2 files changed, 11 insertions(+), 2 deletions(-)
diff --gi
dy mentioned that
struct_mutex was no longer necessary. Updated to refer to a generic
global lock instead.
* intel_reset_types.h: Cleaned up the comment text. Updated to refer to
a generic global lock instead.
Signed-off-by: Luiz Otavio Mello
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/
rly destroyed when the driver is
unloaded.
Signed-off-by: Luiz Otavio Mello
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
b/drivers/gpu/drm/i915/gt
From: Luiz Otavio Mello
Remove struct_mutex from ivb_parity_work() function.
The ivb_parity_work runs in a workqueue so it cannot race with itself.
Also, it is not protecting anything with the other remaining usage of
struct_mutex.
Signed-off-by: Luiz Otavio Mello
Suggested-by: Rodrigo Vivi
From: Luiz Otavio Mello
Move legacy BKL struct_mutex from drm_device to drm_i915_private, which
is the last remaining user.
Signed-off-by: Luiz Otavio Mello
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/drm_drv.c | 2 --
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 4
Please keep the review of this series in the original
https://lore.kernel.org/intel-gfx/20250807170212.285385-1-luiz.me...@estudante.ufscar.br
Signed-off-by: Rodrigo Vivi
Luiz Otavio Mello (9):
drm/i915: Move struct_mutex to drm_i915_private
drm/i915: Remove struct_mutex in i915_irq.c
drm
On Wed, Aug 06, 2025 at 02:51:19PM -, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Remove legacy struct_mutex usage
> URL : https://patchwork.freedesktop.org/series/152533/
> State : failure
>
> == Summary ==
>
> Address 'luiz.me...@estudante.ufscar.br' is not on the allow
Hi Dave and Sima,
Here goes our last xe-next-fixes pr towards 6.17-rc1.
It marks Xe driver as BROKEN if kernel page is not 4K, while
we don't fix this ARM support, but work is in progress there.
Also, mostly SRIOV fixes, but one patch that is more of a
convenience, removing the need of a kernel
On Thu, Jul 31, 2025 at 05:21:25PM +0300, Jani Nikula wrote:
> Store fsb_freq and mem_freq in dram info the same way we do for other
> memory info on later platforms for a slightly more unified approach.
>
> This allows us to remove fsb_freq, mem_freq and is_ddr3 members from
> struct drm_i915_pri
On Thu, Jul 31, 2025 at 05:21:24PM +0300, Jani Nikula wrote:
> Non-display now calls the intel_fsb_freq() and intel_mem_freq()
> functions, so we don't have to have the frequencies initialized for dg2
> or non-display cases.
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/soc/intel_d
On Thu, Jul 31, 2025 at 05:21:23PM +0300, Jani Nikula wrote:
> The rps init only happens once, so it's not important to use the cached
> versions, and we can drop the dependency on them.
Reviewed-by: Rodrigo Vivi
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i
On Thu, Jul 31, 2025 at 05:21:22PM +0300, Jani Nikula wrote:
> Add a more generic intel_mem_freq() function instead of platform
> specific ones. Expose it for future use outside of intel_dram.c.
>
Reviewed-by: Rodrigo Vivi
> Signed-off-by: Jani Nikula
> ---
> driver
On Thu, Jul 31, 2025 at 05:21:21PM +0300, Jani Nikula wrote:
> Add a more generic intel_fsb_freq() function instead of platform
> specific ones.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +-
> dr
On Fri, Aug 01, 2025 at 06:26:47PM +, Cavitt, Jonathan wrote:
> -Original Message-
> From: Intel-gfx On Behalf Of Colin
> Ian King
> Sent: Friday, August 1, 2025 8:17 AM
> To: Jani Nikula ; Vivi, Rodrigo
> ; Tvrtko Ursulin ; David Airlie
> ; Simona Vetter ;
> intel-gfx@lists.freede
On Fri, Aug 01, 2025 at 06:27:25PM +, Cavitt, Jonathan wrote:
> -Original Message-
> From: Intel-xe On Behalf Of Colin
> Ian King
> Sent: Friday, August 1, 2025 9:47 AM
> To: Jani Nikula ; Vivi, Rodrigo
> ; Joonas Lahtinen ;
> Tvrtko Ursulin ; David Airlie ;
> Simona Vetter ; intel
On Thu, Jul 31, 2025 at 03:32:51PM +0300, Jani Nikula wrote:
> On Thu, 31 Jul 2025, Imre Deak wrote:
> > Hi Rodrigo,
> >
> > On Tue, Jul 29, 2025 at 07:36:04PM +0300, Jani Nikula wrote:
> >> On Tue, 29 Jul 2025, Imre Deak wrote:
> >> > On Tue, Jul 29, 20
On Thu, Jul 31, 2025 at 03:36:16PM +0300, Jani Nikula wrote:
> Expose the places that need i915_utils.h, and include it where needed.
again trusting your compiler more than my eyes
Reviewed-by: Rodrigo Vivi
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/displ
On Thu, Jul 31, 2025 at 03:36:15PM +0300, Jani Nikula wrote:
> After refactors, a lot of platform macros have become unused. Remove
> them before new users have a chance to pop up.
>
> Signed-off-by: Jani Nikula
I trust your compiler! :)
Reviewed-by: Rodrigo Vivi
> ---
&g
Hi Dave and Sima,
Here goes our xe-next-fixes.
Thanks,
Rodrigo.
drm-xe-next-fixes-2025-07-31:
- Fix BMG probe on unsupported mailbox command (Raag)
- Fix OA static checker warning about null gt (Ashutosh)
- Fix a NULL vs IS_ERR() bug in xe_i2c_register_adapter (Dan)
- Fix missing unwind goto in
On Tue, Jul 29, 2025 at 12:44:47PM +0300, Jani Nikula wrote:
> On Thu, 24 Jul 2025, Maarten Lankhorst
> wrote:
> > Hey,
> >
> > Den 2025-07-23 kl. 15:19, skrev Rodrigo Vivi:
> >> On Wed, Jul 23, 2025 at 12:38:08PM +0300, Imre Deak wrote:
> >>> On
t's fix our own mess on our side. I'm sorry for missing
this detail. :/
Reviewed-by: Rodrigo Vivi
>
> Fixes: 17133255a322 ("drm/i915: replace DRM_DEBUG_SELFTEST with
> DRM_KUNIT_TEST")
> Cc: Ruben Wauters
> Cc: Rodrigo Vivi
> Signed-off-by: Imre Deak
>
Hi Dave and Sima,
Here goes i915 fixes for this round, with only a couple of display fixes.
Thanks,
Rodrigo.
drm-intel-fixes-2025-07-24:
- Fix DP 2.7 Gbps DP_LINK_BW value on g4x (Ville)
- Fix return value on intel_atomic_commit_fence_wait (Aakash)
The following changes since commit 89be9a83ccf1
> > @@ -340,6 +341,8 @@ void xe_display_pm_suspend(struct xe_device *xe)
> >
> > xe_display_flush_cleanup_work(xe);
> >
> > + intel_encoder_block_all_hpds(display);
> > +
> > intel_hpd_cancel_work(display);
> >
> > if (has_d
On Fri, Jul 18, 2025 at 12:19:41PM -0400, Rodrigo Vivi wrote:
> On Fri, Jul 18, 2025 at 02:59:10PM +0100, Ruben Wauters wrote:
> > On Tue, 2025-07-01 at 12:54 +0100, Ruben Wauters wrote:
> > > DRM_DEBUG_SELFTEST was removed in commit fc8d29e298cf (drm: selftest:
> > >
On Fri, Jul 18, 2025 at 01:34:13PM -0300, Luiz Otavio Mello wrote:
Oi Luiz! :)
First of all thank you so much for the patch. A few comments below:
> Includes the missing file drm_device.h, which was unintentionally
> omitted in v1.
This version comment should be below, not in the beginning of t
On Fri, Jul 18, 2025 at 02:59:10PM +0100, Ruben Wauters wrote:
> On Tue, 2025-07-01 at 12:54 +0100, Ruben Wauters wrote:
> > DRM_DEBUG_SELFTEST was removed in commit fc8d29e298cf (drm: selftest:
> > convert drm_mm selftest to KUnit) and all functions under it were
> > converted to KUnit, under the
.
This patch replaces the select for DRM_DEBUG_SELFTEST, an option that no
longer exists, with the correct select, DRM_KUNIT_TEST.
Signed-off-by: Ruben Wauters
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/Kconfig.debug | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
On Thu, Jul 17, 2025 at 11:02:49AM -0400, Rodrigo Vivi wrote:
> Hi Dave and Sima,
>
> Here goes the drm-intel-fixes of this week
> with a single display fix.
>
> This might conflict when getting merged, but the
> solution is trivial to go what is already in the -next trees.
Hi Dave and Sima,
Here goes the drm-intel-fixes of this week
with a single display fix.
This might conflict when getting merged, but the
solution is trivial to go what is already in the -next trees.
Thanks,
Rodrigo.
drm-intel-fixes-2025-07-17:
- DP AUX DPCD address fix (Imre)
The following chan
() lookup
> is needed.
>
> Reviewed-by: Thomas Zimmermann
> Signed-off-by: Ville Syrjälä
Acked-by: Rodrigo Vivi
to get this through drm-misc
> ---
> drivers/gpu/drm/i915/display/intel_fb.c| 8 +---
> drivers/gpu/drm/i915/display/intel_fb.h| 2 ++
>
On Tue, Jul 15, 2025 at 01:55:09PM +0300, Jouni Högander wrote:
> Add new module parameter enable_panel_replay. This can be used to
> enable/disable Panel Replay. 0=disabled, 1=enabled. -1=use per-chip default
> (default).
>
> Signed-off-by: Jouni Högander
Reviewed-b
On Tue, Jul 15, 2025 at 01:55:08PM +0300, Jouni Högander wrote:
> Currently we are disabling Panel Replay if enable_psr != -1. Lets ignore
> enable_psr completely on Panel Replay.
>
> Signed-off-by: Jouni Högander
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/d
gander
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/display/intel_psr.c | 13 +
> 1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> b/drivers/gpu/drm/i915/display/intel_psr.c
> index ae9053919211
r
> Link: https://lore.kernel.org/r/20250714153954.629393-9-bige...@linutronix.de
> Signed-off-by: Maarten Lankhorst
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/d
orted-by: Maarten Lankhorst
> Acked-by: Tvrtko Ursulin
> Signed-off-by: Sebastian Andrzej Siewior
> Link: https://lore.kernel.org/r/20250714153954.629393-7-bige...@linutronix.de
> Signed-off-by: Maarten Lankhorst
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/i915_req
Hi Dave and Sima,
Here goes our last drm-xe-next PR towards 6.17.
It brings a lot of workarounds infra and additions and
the enabling of SRIOV capability in BMG, as long as
underneath hardware SKU and Firmware supports it as well.
Thanks,
Rodrigo.
drm-xe-next-2025-07-15:
Driver Changes:
- Crea
On Mon, Jul 14, 2025 at 11:06:52PM +0300, Imre Deak wrote:
> On Mon, Jul 14, 2025 at 11:00:08AM +0200, Thomas Zimmermann wrote:
> >
> > Am 14.07.25 um 10:57 schrieb Imre Deak:
> > > Hi,
> > >
> > > On Thu, Jul 10, 2025 at 02:28:28PM +0300, Imre Deak wrote:
> > > > Hi Thomas, Maxime, Maarten,
> >
On Fri, Jul 11, 2025 at 10:33:58AM +, Hogander, Jouni wrote:
> On Fri, 2025-07-11 at 02:11 +0300, Ville Syrjälä wrote:
> > On Thu, Jul 10, 2025 at 05:27:13PM -0400, Rodrigo Vivi wrote:
> > > On Thu, Jul 10, 2025 at 11:09:42PM +0300, Ville Syrjälä wrote:
> > > >
Hi Dave and Sima,
Here goes the drm-intel-fixes of this week as I'm covering for Joonas here.
Also, only the single DSI fix from Hans.
Thanks,
Rodrigo.
drm-intel-fixes-2025-07-10:
Short summary of fixes:
- DSI panel's version 2 mipi-sequences fix (Hans)
The following changes since commit d7b8f8
Hi Dave and Sima,
Here goes the last drm-intel-next towards 6.17. I'm covering for Jani here,
but in the end we got just one patch that is a fix, but let's push that soon
anyway and minimize the -next-fixes round.
Thanks,
Rodrigo.
drm-intel-next-2025-07-10:
Driver Changes:
- DSI panel's version
oing H2G requests when stopping CT
Raag Jadav (2):
drm/xe: Expose fan control and voltage regulator version
drm/xe/pm: Wire up suspend/resume for I2C controller
Reuven Abliyev (1):
drm/xe/nvm: add support for non-posted erase
Riana Tauro (2):
drm/xe/xe_pmu: Validate gt in
On Thu, Jul 10, 2025 at 11:09:42PM +0300, Ville Syrjälä wrote:
> On Thu, Jul 10, 2025 at 11:42:52AM -0400, Rodrigo Vivi wrote:
> > On Wed, Jul 09, 2025 at 06:11:17PM +, Hogander, Jouni wrote:
> > > On Wed, 2025-07-09 at 20:03 +0300, Ville Syrjälä wrote:
> > > >
On Wed, Jul 09, 2025 at 06:11:17PM +, Hogander, Jouni wrote:
> On Wed, 2025-07-09 at 20:03 +0300, Ville Syrjälä wrote:
> > On Wed, Jul 09, 2025 at 10:57:58AM +0300, Jouni Högander wrote:
> > > Currently disabling PSR2 via enable_psr module parameter causes
> > > Panel
> > > Replay being disable
On Mon, Jul 07, 2025 at 11:10:59PM +0200, Hans de Goede wrote:
> Hi Ville,
>
> On 4-Jul-25 12:31 PM, Ville Syrjälä wrote:
> > On Thu, Jul 03, 2025 at 04:38:24PM +0200, Hans de Goede wrote:
> >> From: Hans de Goede
> >>
> >> It turns out that the fixup from vlv_fixup_mipi_sequences() is necessary
On Wed, Jul 09, 2025 at 10:57:58AM +0300, Jouni Högander wrote:
> Currently disabling PSR2 via enable_psr module parameter causes Panel
> Replay being disabled as well. This patch changes this by still allowing
> Panel Replay even if PSR2 is disabled.
>
> After this patch enable_psr module paramet
gander
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/display/intel_psr.c | 13 +
> 1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> b/drivers/gpu/drm/i915/display/intel_psr.c
> index ae9053919211
On Fri, Jul 04, 2025 at 09:03:45PM +0200, Werner Sembach wrote:
> RFC because I'm not sure if this is the right approach.
Could you please file a gitlab issue for us so we can get someone from our
display team to take a look and see if there's anything else that could be done
before we take the qu
On Tue, Jul 08, 2025 at 05:39:08AM +, Hogander, Jouni wrote:
> On Mon, 2025-07-07 at 11:01 -0400, Rodrigo Vivi wrote:
> > On Mon, Jul 07, 2025 at 01:47:33PM +0300, Jouni Högander wrote:
> > > Currently disabling PSR2 via enable_psr module parameter causes
> > &g
On Tue, Jul 08, 2025 at 04:38:18PM +0200, Jason A. Donenfeld wrote:
> Hi,
>
> I'm seeing this splat on 6.16-rc5. i7-11850H.
Hi Jason,
Could you please file a bug in our gitlab/issues so we can properly
address and track that?
https://drm.pages.freedesktop.org/intel-docs/how-to-file-i915-bugs.ht
On Mon, Jul 07, 2025 at 01:47:33PM +0300, Jouni Högander wrote:
> Currently disabling PSR2 via enable_psr module parameter causes Panel
> Replay being disabled as well. This patch changes this by still allowing
> Panel Replay even if PSR2 is disabled.
>
> After this patch enable_psr module paramet
r(struct intel_gt *gt, unsigned
> int intf_id)
> if (gt->gsc.intf[intf_id].irq < 0)
> return;
>
> - ret = generic_handle_irq(gt->gsc.intf[intf_id].irq);
> + ret = generic_handle_irq_safe(gt->gsc.intf[intf_id].irq);
Reviewed-by: Rodrigo
On Wed, Jun 25, 2025 at 01:39:35PM -0400, Rodrigo Vivi wrote:
> On Wed, Jun 25, 2025 at 10:21:58AM -0500, Dan Carpenter wrote:
> > There was an error pointer vs NULL bug in __igt_breadcrumbs_smoketest().
> > The __mock_request_alloc() function implements the
> > smoketest->
On Wed, Jun 25, 2025 at 04:21:40PM +0300, Jani Nikula wrote:
> DISPLAY_PLANE_FLIP_PENDING() has been unused since commit fd3a40242e87
> ("drm/i915: Rip out legacy page_flip completion/irq handling"). Remove.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
&g
updated all the callers. It's a more extensive change, but hopefully
> cleaner.
Thank you
Reviewed-by: Rodrigo Vivi
>
> drivers/gpu/drm/i915/selftests/i915_request.c | 20 +--
> drivers/gpu/drm/i915/selftests/mock_request.c | 2 +-
> 2 fil
gt; + int pw1_idx = DISPLAY_VER(display) >= 11 ? ICL_PW_CTL_IDX_PW_1 :
> SKL_PW_CTL_IDX_PW_1;
> +
> + return pw_idx - pw1_idx + SKL_PG1;
\o/ I hate macros! :)
Reviewed-by: Rodrigo Vivi
> +}
>
> struct i915_power_well_regs {
> i915_reg_t bios;
>
On Wed, Jun 25, 2025 at 03:39:37PM +0300, Jani Nikula wrote:
> Move the {SKL,ICL}_PW_CTL_IDX_TO_PG() macros from intel_display_regs.h
> to intel_display_power_well.c. The mapping from index to PG can be
> hidden there.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
&
On Wed, Jun 25, 2025 at 03:39:36PM +0300, Jani Nikula wrote:
> When the display registers were split off from i915_reg.h, enum
> skl_power_gate was left behind. Move it to intel_display_regs.h.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gp
On Tue, Jun 24, 2025 at 05:11:50PM -0400, Rodrigo Vivi wrote:
> On Fri, Jun 20, 2025 at 01:18:18PM +0200, Arnd Bergmann wrote:
While merging this I adjusted the subject to be drm/i915
> > From: Arnd Bergmann
> >
> > An earlier patch fixed a build failure with clang
On Tue, Jun 24, 2025 at 05:14:25PM -0400, Rodrigo Vivi wrote:
> On Fri, Jun 20, 2025 at 01:36:38PM +0200, Arnd Bergmann wrote:
> > From: Arnd Bergmann
> >
> > The igt_vma_pin1() function has a rather high stack usage, which gets
> > in the way of reducing the default
rmark.c
> @@ -2680,6 +2680,97 @@ static char enast(bool enable)
> return enable ? '*' : ' ';
> }
>
> +static noinline_for_stack void
on this I'm mostly trusting you and your compiler, but it looks safe
enough...
Reviewed-by: Rodrigo Vivi
a
15/i915_pmu.c
> @@ -108,7 +108,7 @@ static unsigned int config_bit(const u64 config)
> return other_bit(config);
> }
>
> -static u32 config_mask(const u64 config)
> +static __always_inline u32 config_mask(const u64 config)
hmm, it looks like the __builtin_constant_
15_vma_pin.")
>
> The second one is easy enough to change, by moving the function into the
> appropriate .c file. Since it is already large enough to not always be
> inlined, this seems like a good idea regardless, reducing both the code size
> and the internal stack usage
On Tue, Jun 17, 2025 at 04:45:22PM +0300, Alexander Usyskin wrote:
> Add driver for access to Intel discrete graphics card
> internal NVM device.
> Expose device on auxiliary bus by i915 and Xe drivers and
> provide mtd driver to register this device with MTD framework.
>
> This is a rewrite of "d
e_pci tests to parametrized tests
Niranjana Vishwanathapura (1):
drm/xe: Create LRC BO without VM
Nitin Gote (1):
drm/xe/xe3: Disable null query for anyhit shader
Piotr Piórkowski (1):
drm/xe/pf: Don't allow LMEM provisioning if LMTT isn't available on the
device
Raa
On Thu, Jun 05, 2025 at 01:29:37PM +0300, Jani Nikula wrote:
> With the struct drm_device based pcode interface in place in both i915
> and xe, we can switch dram code to use that.
Reviewed-by: Rodrigo Vivi
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/so
t; Turns out a couple of headers depended on the intel_uncore.h include via
> intel_pcode.h. Fix them.
Reviewed-by: Rodrigo Vivi
>
> Cc: Lucas De Marchi
> Cc: Rodrigo Vivi
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/display/intel_bw.c | 1
On Tue, Jun 17, 2025 at 11:29:54AM +0300, Jani Nikula wrote:
> On Mon, 16 Jun 2025, Rodrigo Vivi wrote:
> > On Thu, Jun 05, 2025 at 01:29:36PM +0300, Jani Nikula wrote:
> >> With the struct drm_device based pcode interface in place in both i915
> >> and xe, we can swit
atomic. The uncore wait will do a might_sleep() annotation that
> should catch any problems.
Reviewed-by: Rodrigo Vivi
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/display/intel_cdclk.c | 5 ++---
> drivers/gpu/drm/i915/display/intel_display_power_w
On Thu, Jun 05, 2025 at 01:29:36PM +0300, Jani Nikula wrote:
> With the struct drm_device based pcode interface in place in both i915
> and xe, we can switch display code to use that, and ditch a number of
> struct drm_i915_private uses. Also drop the dependency on i915_drv.h
> from a couple of fil
atomic. The uncore wait will do a might_sleep() annotation that
> should catch any problems.
Reviewed-by: Rodrigo Vivi
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/display/intel_cdclk.c | 5 ++---
> drivers/gpu/drm/i915/display/intel_display_power_w
On Thu, Jun 05, 2025 at 01:29:34PM +0300, Jani Nikula wrote:
> In preparation for dropping the dependency on struct intel_uncore from
> display code, add a struct drm_device based interface to pcode.
>
Reviewed-by: Rodrigo Vivi
> Signed-off-by: Jani Nikula
> ---
> dr
On Thu, Jun 05, 2025 at 01:29:35PM +0300, Jani Nikula wrote:
> In preparation for dropping the dependency on struct intel_uncore or
> struct xe_tile from display code, add a struct drm_device based
> interface to pcode.
great idea!
Reviewed-by: Rodrigo Vivi
>
> Cc: Lucas
atomic. The uncore wait will do a might_sleep() annotation that
> should catch any problems.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/display/intel_cdclk.c | 5 ++---
> drivers/gpu/drm/i915/display/intel_display_power_w
On Fri, Jun 06, 2025 at 12:04:49PM +0300, Dan Carpenter wrote:
> The __mock_request_alloc() implements the smoketest->request_alloc()
> function pointer. It's called from __igt_breadcrumbs_smoketest().
> It's supposed to return error pointers, and returning NULL will lead to
> a NULL pointer deref
display_pm_shutdown(struct xe_device *xe)
> intel_power_domains_disable(display);
> drm_client_dev_suspend(&xe->drm, false);
>
> - if (has_display(xe)) {
> + if (intel_display_device_present(display)) {
> drm_kms_helper_poll_disable(&
On Tue, May 27, 2025 at 02:48:54PM +0300, Jani Nikula wrote:
> vlv_iosf_sb.c no longer depends on enum dpio_phy from
> intel_dpio_phy.h. Drop the include.
Trusting more your compiler then my eyes:
Reviewed-by: Rodrigo Vivi
>
> Signed-off-by: Jani Nikula
> ---
> dr
On Wed, May 21, 2025 at 01:21:46PM +0300, Jani Nikula wrote:
> Allocate struct intel_display dynamically in
> intel_display_device_probe() and free in intel_display_device_remove().
>
> Signed-off-by: Jani Nikula
\o/
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gp
rs/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index c02c4c4e9412..f329613e061f 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -1168,7 +1168,8 @@ void xe_device_declare_wedged(struct xe_device *xe)
>
> /* Notif
i915/display: Add link rate and lane count to i915_display_info
Nemesa Garg (1):
drm/i915/display: Implement wa_14024400148
Rodrigo Vivi (2):
drm/{i915,xe}: Move intel_pch under display
drm/i915/display: Convert intel_pch towards intel_display
Ville Syrjälä (6):
dr
t; drivers/gpu/drm/i915/display/intel_pch.c:126 intel_pch_type+0x1af/0xae0 [i915]
> [5.609317] CPU: 3 UID: 0 PID: 440 Comm: (udev-worker) Not tainted
> 6.15.0-rc3-drm-tip-2fa6469c618d #3 PREEMPT(voluntary)
>
> Signed-off-by: Jiajia Liu
> Reviewed-by: Rodrigo Vivi
pushed to drm-intel-ne
On Tue, Apr 29, 2025 at 01:16:13PM +, Gote, Nitin R wrote:
> > Hi Nitin,
> >
> > [...]
> >
> > > > > + if (wait_for_atomic((!stop_ring(engine) == 0), 20)) {
> > > > > drm_err(&engine->i915->drm,
> > > > > "failed to set %s head t
send it.
https://gitlab.freedesktop.org/drm/tip/
Feel free to resend with:
Reviewed-by: Rodrigo Vivi
>
> Signed-off-by: Jiajia Liu
> ---
> drivers/gpu/drm/i915/soc/intel_pch.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i9
rt for non-posted erase with polling
> for erase completion.
>
> Signed-off-by: Abliyev, Reuven
> Signed-off-by: Alexander Usyskin
Reviewed-by: Rodrigo Vivi
and
Acked-by: Rodrigo Vivi
on all xe and i915 patches to get merged through another trees if needed.
> ---
is enable
Lucas De Marchi (2):
drm/i915/dram: Add missing INTEL_DRAM str conversions
drm/i915/dram: Consolidate logging of DRAM type
Mohammed Thasleem (1):
drm/i915/dmc: Create debugfs entry for dc6 counter
Rodrigo Vivi (1):
drm/i915/display: Fix htmldocs build
Su
On Fri, Mar 28, 2025 at 09:22:37PM +0200, Imre Deak wrote:
> On Fri, Mar 28, 2025 at 02:08:29PM -0400, Rodrigo Vivi wrote:
> > Fixes a wrong documentation block indentation:
> >
> > Documentation/gpu/i915:141:
> > ./drivers/gpu/drm/i915/display/intel_hotplu
org.au/
Cc: Imre Deak
Reviewed-by: Imre Deak
Link: https://lore.kernel.org/r/20250328180829.25892-1-rodrigo.v...@intel.com
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/display/intel_hotplug.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/display/intel_hotplug.c
; unexpected unindent.
Fixes: 0d77a3e0ea90 ("drm/i915/hpd: Add support for blocking the IRQ handling
on an HPD pin")
Reported-by: Stephen Rothwell
Closes:
https://lore.kernel.org/intel-gfx/20250312232506.47451...@canb.auug.org.au/
Cc: Imre Deak
Signed-off-by: Rodrigo Vivi
---
drivers/gp
On Mon, Mar 10, 2025 at 10:46:19PM +0300, Dan Carpenter wrote:
> This line is indented on tab too far. Delete the extra tab.
>
> Signed-off-by: Dan Carpenter
Reviewed-by: Rodrigo Vivi
and pushing right now...
> ---
> drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c | 2 +-
>
uot;i915_utils.h"
> #include "intel_crtc.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c
> b/drivers/gpu/drm/i915/display/intel_vrr.c
> index 414f93851059..4f442804a41a 100644
> --- a/drivers/gpu/drm/i915/display/intel_vrr.c
> +++ b/drivers/gpu/drm/i915/display/intel_vrr.c
> @@ -4,6 +4,8 @@
> *
> */
>
> +#include
> +
> #include "i915_reg.h"
> #include "intel_de.h"
> #include "intel_display_types.h"
> diff --git a/drivers/gpu/drm/i915/intel_wakeref.h
> b/drivers/gpu/drm/i915/intel_wakeref.h
> index 48836ef52d40..a2894a56e18f 100644
> --- a/drivers/gpu/drm/i915/intel_wakeref.h
> +++ b/drivers/gpu/drm/i915/intel_wakeref.h
> @@ -7,8 +7,6 @@
> #ifndef INTEL_WAKEREF_H
> #define INTEL_WAKEREF_H
>
> -#include
> -
> #include
> #include
> #include
> @@ -16,11 +14,13 @@
> #include
> #include
> #include
> -#include
> -#include
> #include
> #include
>
> +struct drm_printer;
> +struct intel_runtime_pm;
> +struct intel_wakeref;
> +
> typedef struct ref_tracker *intel_wakeref_t;
>
> #define INTEL_REFTRACK_DEAD_COUNT 16
> @@ -32,9 +32,6 @@ typedef struct ref_tracker *intel_wakeref_t;
> #define INTEL_WAKEREF_BUG_ON(expr) BUILD_BUG_ON_INVALID(expr)
> #endif
>
> -struct intel_runtime_pm;
> -struct intel_wakeref;
Reviewed-by: Rodrigo Vivi
> -
> struct intel_wakeref_ops {
> int (*get)(struct intel_wakeref *wf);
> int (*put)(struct intel_wakeref *wf);
> --
> 2.39.5
>
On Wed, Mar 26, 2025 at 05:26:11PM +0200, Alexander Usyskin wrote:
> Add driver for access to Intel discrete graphics card
> internal NVM device.
> Expose device on auxiliary bus by i915 and Xe drivers and
> provide mtd driver to register this device with MTD framework.
>
> This is a rewrite of "d
On Mon, Mar 10, 2025 at 01:04:36AM +0900, Simon Richter wrote:
> Hi,
>
> I've built a horrible contraption and received the following output:
>
> BUG: Unable to handle kernel data access on read at 0xc00a03cc
> Faulting instruction address: 0xc0080dd46484
> Oops: Kernel access of bad
t; We already have the pci_save_state() counterpart on the
> suspend side.
>
> Arguably none of this code should exist in the driver
> in the first place, and instead the entire switcheroo
> mechanism should be rewritten and properly integrated into
> core pm code...
Reviewed
we preserve the
> - * same order for the freeze/thaw phases.
> - *
> - * TODO: eventually we should remove pci_disable_device() /
> - * pci_enable_enable_device() from suspend/resume. Due to how they
> - * depend on the device enable refco
On Tue, Mar 11, 2025 at 09:56:23PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Stop doing the pci_save_state(), except when we need to prevent
> D3 due to BIOS bugs, so that the code in drivers/pci is allowed
> to manage the state of the PCI device. Less chance something
> getting left
ame
> point. We currently have no _noirq() hooks, so end of _late()
> hooks is the best we can do right now.
fair enough, let's just get CI back and try it again there
Reviewed-by: Rodrigo Vivi
>
> Cc: Rodrigo Vivi
> Signed-off-by: Ville Syrjälä
> ---
>
cancelling work (Tejas)
- Fix new warnings around userptr (Thomas)
- Temporaritly disable D3Cold on BMG (Rodrigo)
- Retry and wait longer for GuC PC to start (Rodrigo)
- Remove redundant check in xe_vm_create_ioctl (Xin)
--------
Rodr
1 - 100 of 2048 matches
Mail list logo
