Re: [Intel-gfx] [PATCH 00/66] runtime pm for DPMS

2014-05-16 Thread Naresh Kumar Kachhi
mall interludes to move a bit of the hdmi/audio state into the pipe config. Reviewer: Naresh Kumar reviewed 10-20, looks good. Reviewed-by: Naresh Kumar Kachhi drm/i915/lvds: Remove ->mode_set callback drm/i915/ddi: Remove ->mode_set callback drm/i915/dsi: Remove ->m

[Intel-gfx] [PATCH v2 1/3] drm/i915: disable rings before HW status page setup

2014-03-12 Thread naresh . kumar . kachhi
From: Naresh Kumar Kachhi Rings should be idle before issuing sync_flush (in intel_ring_setup_status_page). This patch moves the ring disabling before doing the HW status page setup. Signed-off-by: Naresh Kumar Kachhi Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/intel_ringbuffer.c | 10

[Intel-gfx] [PATCH v2 3/3] drm/i915: warn if ring is active before sync flush

2014-03-12 Thread naresh . kumar . kachhi
From: Naresh Kumar Kachhi Based on Bspec the command parser must be stopped prior to issuing sync flush. This should be done by the caller of intel_ring_setup_status_page. Patch adds a warning if it is not done. v2: rebased based on new patch (wait for ring to become idle) Signed-off-by

[Intel-gfx] [PATCH v2 0/3] disable rings before sync flush

2014-03-12 Thread naresh . kumar . kachhi
From: Naresh Kumar Kachhi initial version: stop rings before sync flush v1: address the comments from Chris Wilson on http://www.spinics.net/lists/intel-gfx/msg41025.html. Rather than adding stop and start ring, we are moving ring disable before hw_status_page_setup (sync flush). v2: Based on

[Intel-gfx] [PATCH v2 2/3] drm/i915: wait for rings to become idle once disabled

2014-03-12 Thread naresh . kumar . kachhi
From: Naresh Kumar Kachhi make sure we wait for rings to become idle once they are disabled. In case of timeout print an error message Signed-off-by: Naresh Kumar Kachhi --- drivers/gpu/drm/i915/i915_reg.h | 2 ++ drivers/gpu/drm/i915/intel_ringbuffer.c | 6 ++ drivers/gpu/drm

[Intel-gfx] [PATCH v1 2/2] drm/i915: warn if ring is active before sync flush

2014-03-11 Thread naresh . kumar . kachhi
From: Naresh Kumar Kachhi Based on Bspec the command parser must be stopped prior to issuing sync flush. This should be done by the caller of intel_ring_setup_status_page. Patch adds a warning if it is not done. Signed-off-by: Naresh Kumar Kachhi --- drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH v1 0/2] disable rings before sync flush

2014-03-11 Thread naresh . kumar . kachhi
From: Naresh Kumar Kachhi initial version: stop rings before sync flush v1: address the comments from Chris Wilson on http://www.spinics.net/lists/intel-gfx/msg41025.html. Rather than adding stop and start ring, we are moving ring disable before hw_status_page_setup (sync flush). Naresh Kumar

[Intel-gfx] [PATCH v1 1/2] drm/i915: disable rings before HW status page setup

2014-03-11 Thread naresh . kumar . kachhi
From: Naresh Kumar Kachhi Rings should be idle before issuing sync_flush (in intel_ring_setup_status_page). This patch moves the ring disabling before doing the HW status page setup. Signed-off-by: Naresh Kumar Kachhi --- drivers/gpu/drm/i915/intel_ringbuffer.c | 10 +- 1 file changed

[Intel-gfx] [PATCH] drm/i915: stop command parser before sync flush

2014-03-03 Thread naresh . kumar . kachhi
From: Naresh Kumar Kachhi Based on Bspec the command parser must be stopped prior to issuing sync flush. Only after observing Rings Idle set in MI_MODE can a Sync Flush be issued. Once sync flush has finished the command parser is re-enabled by clearing Stop Rings. Signed-off-by: Naresh Kumar

Re: [Intel-gfx] [RFC 1/6] drm/i915: cover ioctls with runtime_get/put

2014-02-23 Thread Naresh Kumar Kachhi
On 02/22/2014 01:37 AM, Jesse Barnes wrote: On Fri, 24 Jan 2014 19:23:54 +0200 Imre Deak wrote: On Fri, 2014-01-24 at 20:35 +0530, Naresh Kumar Kachhi wrote: On 01/22/2014 06:53 PM, Imre Deak wrote: On Wed, 2014-01-22 at 13:51 +0100, Daniel Vetter wrote: On Wed, Jan 22, 2014 at 05:34:17PM

Re: [Intel-gfx] [RFC 3/6] drm/i915: introduce runtime get/put based on display activity

2014-02-23 Thread Naresh Kumar Kachhi
On 01/22/2014 07:10 PM, Paulo Zanoni wrote: Hi 2014/1/22 : From: Naresh Kumar Kachhi Once the display is disabled, we need to call runtime_put to make sure Runtime framework triggers runtime_suspend based on idleness. Similarly when display gets enabled, runtime_get should be called. We

Re: [Intel-gfx] [RFC 1/6] drm/i915: cover ioctls with runtime_get/put

2014-02-23 Thread Naresh Kumar Kachhi
On 01/24/2014 09:26 PM, Paulo Zanoni wrote: 2014/1/24 Naresh Kumar Kachhi : On 01/22/2014 06:53 PM, Imre Deak wrote: On Wed, 2014-01-22 at 13:51 +0100, Daniel Vetter wrote: On Wed, Jan 22, 2014 at 05:34:17PM +0530, naresh.kumar.kac...@intel.com wrote: From: Naresh Kumar Kachhi With runtime

Re: [Intel-gfx] [RFC 5/6] drm/i915: device specific runtime suspend/resume

2014-01-24 Thread Naresh Kumar Kachhi
On 01/22/2014 06:28 PM, Daniel Vetter wrote: On Wed, Jan 22, 2014 at 05:34:21PM +0530, naresh.kumar.kac...@intel.com wrote: From: Naresh Kumar Kachhi we might need special handling for different platforms. for ex. baytrail. To handle this this patch creates function pointers for runtime

Re: [Intel-gfx] [RFC 6/6] FOR_UPSTREAM [VPG]: drm/i915: call init_runtime_pm before gem_init

2014-01-24 Thread Naresh Kumar Kachhi
On 01/22/2014 07:14 PM, Paulo Zanoni wrote: 2014/1/22: From: Naresh Kumar Kachhi with current code intel_runtime_pm_gpu_idle is getting called even before runtime_pm is initialized. Moving runtime_pm_init before i915_gem_init Following is the call stack, note: by this time runtime_pm was not

Re: [Intel-gfx] [RFC 1/6] drm/i915: cover ioctls with runtime_get/put

2014-01-24 Thread Naresh Kumar Kachhi
On 01/22/2014 06:53 PM, Imre Deak wrote: On Wed, 2014-01-22 at 13:51 +0100, Daniel Vetter wrote: On Wed, Jan 22, 2014 at 05:34:17PM +0530, naresh.kumar.kac...@intel.com wrote: From: Naresh Kumar Kachhi With runtime PM enabled, we need to make sure that all HW access are valid (i.e. Gfx is

[Intel-gfx] [RFC 1/6] drm/i915: cover ioctls with runtime_get/put

2014-01-22 Thread naresh . kumar . kachhi
From: Naresh Kumar Kachhi With runtime PM enabled, we need to make sure that all HW access are valid (i.e. Gfx is in D0). Invalid accesses might end up in HW hangs. Ex. A hang is seen if display register is accessed on BYT while display power island is power gated. This patch is covering all

[Intel-gfx] [RFC 5/6] drm/i915: device specific runtime suspend/resume

2014-01-22 Thread naresh . kumar . kachhi
From: Naresh Kumar Kachhi we might need special handling for different platforms. for ex. baytrail. To handle this this patch creates function pointers for runtime suspend/resume which are assigned during driver load time Signed-off-by: Naresh Kumar Kachhi --- drivers/gpu/drm/i915/i915_drv.c

[Intel-gfx] [RFC 0/6] enabling runtime on BYT

2014-01-22 Thread naresh . kumar . kachhi
From: Naresh Kumar Kachhi This is the first set of patches to enable runtime pm for BYT. These patches are created keeping in mind that PC8 feature will be replaced with runtime pm. So all the patches are on assumption that HAS_RUNTIME_PM is true while HAS_PC8 is false. This set is mainly to

[Intel-gfx] [RFC 4/6] drm/i915/vlv: call runtime get/put based on disp activity

2014-01-22 Thread naresh . kumar . kachhi
From: Naresh Kumar Kachhi do a runtime_get/put based on the display activity for valleyview platrform Signed-off-by: Naresh Kumar Kachhi --- drivers/gpu/drm/i915/intel_display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915

[Intel-gfx] [RFC 3/6] drm/i915: introduce runtime get/put based on display activity

2014-01-22 Thread naresh . kumar . kachhi
From: Naresh Kumar Kachhi Once the display is disabled, we need to call runtime_put to make sure Runtime framework triggers runtime_suspend based on idleness. Similarly when display gets enabled, runtime_get should be called. We have similiar function for pc8 feature, but some platform(BYT

[Intel-gfx] [RFC 6/6] FOR_UPSTREAM [VPG]: drm/i915: call init_runtime_pm before gem_init

2014-01-22 Thread naresh . kumar . kachhi
From: Naresh Kumar Kachhi with current code intel_runtime_pm_gpu_idle is getting called even before runtime_pm is initialized. Moving runtime_pm_init before i915_gem_init Following is the call stack, note: by this time runtime_pm was not initialized intel_runtime_pm_gpu_idle+0x37/0x90

[Intel-gfx] [RFC 2/6] drm/i915: cover ring access with rpm get/put

2014-01-22 Thread naresh . kumar . kachhi
From: Naresh Kumar Kachhi GPU idleness is tracked by checking the request queue. Whenever request queue is empty we assume that GPU is idle. When a new set of commands sheduled on ring we call i915_add_request to make sure these commands are tracked properly. However there are few places which