Re: [PATCH v3 00/15] CCS static load balance

2024-09-02 Thread Daniel Vetter
On Wed, Aug 28, 2024 at 05:35:45PM +0200, Andi Shyti wrote: > Hi Sima, > > On Wed, Aug 28, 2024 at 03:47:21PM +0200, Daniel Vetter wrote: > > On Wed, Aug 28, 2024 at 10:20:15AM +0200, Andi Shyti wrote: > > > Hi Sima, > > > > > > first of all, thanks for

Re: [PATCH v3 00/15] CCS static load balance

2024-08-28 Thread Daniel Vetter
On Wed, Aug 28, 2024 at 10:20:15AM +0200, Andi Shyti wrote: > Hi Sima, > > first of all, thanks for looking into this series. > > On Tue, Aug 27, 2024 at 07:31:21PM +0200, Daniel Vetter wrote: > > On Fri, Aug 23, 2024 at 03:08:40PM +0200, Andi Shyti wrote: > > &g

Re: [RESEND 3/3] drm/amd/display: switch to guid_gen() to generate valid GUIDs

2024-08-28 Thread Daniel Vetter
ad of > plumbing it into drm mst code. Yeah ec5fa9fcdeca ("drm/amd/display: Adjust the MST resume flow") promised a follow-up, but that seems to have never materialized. Really should materialize though. Patch lgtm Reviewed-by: Daniel Vetter > --- > .../gpu

Re: [RESEND 2/3] drm/mst: switch to guid_gen() to generate valid GUIDs

2024-08-28 Thread Daniel Vetter
Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/display/drm_dp_mst_topology.c | 10 +- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c > b/drivers/gpu/drm/display/drm_dp_mst_topology.c > index 39f1dc45

Re: [RESEND 1/3] drm/mst: switch to guid_t type for GUID

2024-08-28 Thread Daniel Vetter
ally lgtm Reviewed-by: Daniel Vetter Reading code a bit I did wonder whether we could have send/receive macros that just work for compile-time statically sized types ... but not even kmalloc is there yet I think, at least haven't seen anything. -Sima > --- > .../gpu/drm/amd/d

Re: [PATCH 0/2] drm/i915: nomodeset and i915.modeset cleanups

2024-08-28 Thread Daniel Vetter
On Wed, Aug 28, 2024 at 02:19:07PM +0300, Jani Nikula wrote: > Is it time? It is. Concurred. On the series: Reviewed-by: Daniel Vetter Cheers, Sima > > Jani Nikula (2): > drm/i915: fail module probe on nomodeset and i915.modeset=0 > drm/i915: deprecate the i915.modeset m

Re: [PATCH v3 15/15] drm/i915/gt: Allow the user to change the CCS mode through sysfs

2024-08-27 Thread Daniel Vetter
(ccs_mode); > + > void intel_gt_sysfs_ccs_init(struct intel_gt *gt) > { > if (sysfs_create_file(>->sysfs_gt, &dev_attr_num_cslices.attr)) > gt_warn(gt, "Failed to create sysfs num_cslices files\n"); > + > + /* > + * Do not create the ccs_mode file for non DG2 platforms > + * because they don't need it as they have only one CCS engine > + */ > + if (!IS_DG2(gt->i915)) > + return; > + > + if (sysfs_create_file(>->sysfs_gt, &dev_attr_ccs_mode.attr)) > + gt_warn(gt, "Failed to create sysfs ccs_mode files\n"); > } > -- > 2.45.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH v3 00/15] CCS static load balance

2024-08-27 Thread Daniel Vetter
c| 2 +- > .../gpu/drm/i915/gt/selftest_workarounds.c| 14 +- > drivers/gpu/drm/i915/gt/sysfs_engines.c | 79 ++-- > drivers/gpu/drm/i915/gt/sysfs_engines.h | 2 + > drivers/gpu/drm/i915/i915_cmd_parser.c| 2 + > drivers/gpu/drm/i915/i915_debugfs.c | 4 + > drivers/gpu/drm/i915/i915_drv.h | 5 + > drivers/gpu/drm/i915/i915_gem.c | 4 + > drivers/gpu/drm/i915/i915_perf.c | 8 +- > drivers/gpu/drm/i915/i915_pmu.c | 11 +- > drivers/gpu/drm/i915/i915_query.c | 21 +- > 37 files changed, 643 insertions(+), 193 deletions(-) > > -- > 2.45.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH] drm/i915/gt: Continue creating engine sysfs files even after a failure

2024-08-27 Thread Daniel Vetter
ivate > *i915) > err_object: > kobject_put(kobj); > err_engine: > - dev_err(kdev, "Failed to add sysfs engine '%s'\n", > - engine->name); > - break; > +

Re: [PULL] drm-intel-gt-next

2024-08-27 Thread Daniel Vetter
| 5 +- > drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 +- > drivers/gpu/drm/i915/i915_mm.c | 12 +++- > drivers/gpu/drm/i915/i915_mm.h | 3 +- > drivers/gpu/drm/i915/i915_perf.c | 33 -- > drivers/gpu/drm/i915/intel_memory_region.c | 6 +- > drivers/gpu/drm/i915/intel_uncore.c| 7 ++- > .../gpu/drm/i915/selftests/intel_memory_region.c | 2 +- > 23 files changed, 150 insertions(+), 81 deletions(-) -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PULL] drm-xe-next

2024-08-27 Thread Daniel Vetter
- > drivers/gpu/drm/xe/xe_pci.c | 10 +- > drivers/gpu/drm/xe/xe_pm.c| 11 +- > drivers/gpu/drm/xe/xe_preempt_fence.c | 3 +- > drivers/gpu/drm/xe/xe_preempt_fence_types.h | 2 + > drivers/gpu/drm/xe/xe_pt.c

Re: [PULL] drm-misc-next

2024-08-27 Thread Daniel Vetter
gpu/drm/vc4/vc4_hdmi.c | 44 +- > drivers/gpu/drm/vc4/vc4_hvs.c |4 +- > drivers/gpu/drm/vc4/vc4_irq.c |2 +- > drivers/gpu/drm/vc4/vc4_v3d.c | 24 +- > drivers/gpu/drm/vc4/vc4_validate.c |8 +- > drivers/gpu/drm/vc4/vc4_vec.c | 10 +- > include/drm/drm_mipi_dsi.h |2 + > include/linux/string.h | 12 + > 41 files changed, 1830 insertions(+), 1478 deletions(-) > create mode 100644 drivers/gpu/drm/ast/ast_sil164.c > create mode 100644 drivers/gpu/drm/ast/ast_vga.c > > -- > Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Frankenstrasse 146, 90461 Nuernberg, Germany > GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman > HRB 36809 (AG Nuernberg) -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH v2 0/2] Allow partial memory mapping for cpu memory

2024-08-22 Thread Daniel Vetter
is for Xe as I > don't want to remove force probe with an incongruence in behavior from > the i915 or have a mesa use case broken. I've actually gone back to the ggtt fix, and I don't see the security aspect. Like sure if you do a partial unmap you screw up the offset calculation and get unexpected aliasing and a mess and the igt you've linked will fail. But I don't see how that's a security bug? And if it is, then it's a drm wide issue, because they all work like that. And so probably we need a drm wide fix first. So yeah I'm still stuck on the fundamentals here of why this is even done. And for the uapi extension of allowing partial mmaps, we need the full uapi dance. Which means some driver flag so userspace can figure out this is supported, and a link to the mesa MR that uses this all. Without a link to a mesa MR this won't go anywhere, because that's the rules for new uapi. -Sima -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH 0/2] Allow partial memory mapping for cpu memory

2024-08-22 Thread Daniel Vetter
On Mon, Aug 19, 2024 at 05:31:36PM +0200, Andi Shyti wrote: > Hi Sima, > > On Mon, Aug 19, 2024 at 04:17:01PM +0200, Daniel Vetter wrote: > > On Wed, Aug 14, 2024 at 02:08:49AM +, Matthew Brost wrote: > > > On Tue, Aug 13, 2024 at 07:08:02PM +, Matthew Brost wrote

Re: [PULL] drm-misc-next

2024-08-22 Thread Daniel Vetter
drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 +- > drivers/gpu/drm/vkms/vkms_drv.c| 6 +- > drivers/gpu/vga/vga_switcheroo.c | 3 +- > include/drm/drm_drv.h | 28 --- > include/drm/drm_edid.h | 2 - > include/drm/drm_fb_helper.h| 6 - > include/drm/drm_fixed.h| 3 +- > include/drm/drm_mipi_dsi.h | 10 ++ > include/drm/drm_mode_config.h | 16 -- > include/drm/drm_panic.h| 21 +-- > include/uapi/drm/drm_mode.h| 2 + > 55 files changed, 471 insertions(+), 416 deletions(-) > > -- > Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Frankenstrasse 146, 90461 Nuernberg, Germany > GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman > HRB 36809 (AG Nuernberg) -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH 0/2] Allow partial memory mapping for cpu memory

2024-08-19 Thread Daniel Vetter
On Wed, Aug 14, 2024 at 02:08:49AM +, Matthew Brost wrote: > On Tue, Aug 13, 2024 at 07:08:02PM +, Matthew Brost wrote: > > On Tue, Aug 13, 2024 at 04:09:55PM +0200, Daniel Vetter wrote: > > > On Tue, Aug 13, 2024 at 02:54:31AM +, Matthew Brost wrote: > > > &

Re: [RFC PATCH] dma-buf/dma-fence: Use a successful read_trylock() annotation for dma_fence_begin_signalling()

2024-08-14 Thread Daniel Vetter
;s not easily achievable > > in all cases. > > > > Signed-off-by: Thomas Hellström > > Resurrecting the discussion on this one. I can't see a situation where we > would miss *relevant* locking > order violation warnings with this patch. Ofc if we have a scheduler &g

Re: [PATCH 0/2] Allow partial memory mapping for cpu memory

2024-08-13 Thread Daniel Vetter
On Tue, Aug 13, 2024 at 02:54:31AM +, Matthew Brost wrote: > On Mon, Aug 12, 2024 at 04:45:32PM +0200, Daniel Vetter wrote: > > On Mon, Aug 12, 2024 at 01:51:30PM +0200, Andi Shyti wrote: > > > Hi Daniel, > > > > > > On Mon, Aug 12, 2024 at 11:11:21AM +0

Re: [PATCH 0/2] Allow partial memory mapping for cpu memory

2024-08-12 Thread Daniel Vetter
On Mon, Aug 12, 2024 at 01:51:30PM +0200, Andi Shyti wrote: > Hi Daniel, > > On Mon, Aug 12, 2024 at 11:11:21AM +0200, Daniel Vetter wrote: > > On Fri, Aug 09, 2024 at 11:20:56AM +0100, Andi Shyti wrote: > > > On Fri, Aug 09, 2024 at 10:53:38AM +0200, Daniel Vetter wrote

Re: [PATCH 0/2] Allow partial memory mapping for cpu memory

2024-08-12 Thread Daniel Vetter
On Fri, Aug 09, 2024 at 11:20:56AM +0100, Andi Shyti wrote: > Hi Sima, > > On Fri, Aug 09, 2024 at 10:53:38AM +0200, Daniel Vetter wrote: > > On Wed, Aug 07, 2024 at 11:05:19AM +0100, Andi Shyti wrote: > > > This patch series concludes on the memory mapping fixes a

Re: [PATCH 0/2] Allow partial memory mapping for cpu memory

2024-08-09 Thread Daniel Vetter
/drm/i915/gem/i915_gem_mman.c | 10 ++ > drivers/gpu/drm/i915/i915_mm.c | 12 +++- > drivers/gpu/drm/i915/i915_mm.h | 3 ++- > 3 files changed, 19 insertions(+), 6 deletions(-) > > -- > 2.45.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PULL] drm-misc-next

2024-08-08 Thread Daniel Vetter
rences instead of TTMs > > Christoph Fritz (1): > drm/bridge: synopsys: dw-mipi-dsi: enable EoTp by default > > Christophe JAILLET (1): > drm/stm: Fix an error handling path in stm_drm_platform_probe() > > Claudiu Beznea (1): > drm/stm: ltdc: check m

Re: [PATCH 1/2] drm: Add might_fault to drm_modeset_lock priming

2024-07-15 Thread Daniel Vetter
On Wed, Jul 10, 2024 at 02:40:04PM +0200, Christian König wrote: > Am 10.07.24 um 13:58 schrieb Daniel Vetter: > > On Wed, 10 Jul 2024 at 13:39, Christian König > > wrote: > > > Am 10.07.24 um 11:31 schrieb Daniel Vetter: > > > > We already teac

Re: [PATCH] bcachefs: no console_lock in bch2_print_string_as_lines

2024-07-15 Thread Daniel Vetter
On Wed, Jul 10, 2024 at 04:19:53PM +0206, John Ogness wrote: > On 2024-07-10, Daniel Vetter wrote: > > console_lock is the outermost subsystem lock for a lot of subsystems, > > which means get/put_user must nest within. Which means it cannot be > > acquired somewhere deeply

[PATCH] bcachefs: no console_lock in bch2_print_string_as_lines

2024-07-10 Thread Daniel Vetter
61cd0d...@google.com/ Signed-off-by: Daniel Vetter Fixes: a8f354284304 ("bcachefs: bch2_print_string_as_lines()") Cc: # v6.7+ Cc: Kent Overstreet Cc: Brian Foster Cc: linux-bcach...@vger.kernel.org Cc: Petr Mladek Cc: Steven Rostedt Cc: John Ogness Cc: Sergey Senozhatsky Signed-off-

Re: [PATCH 1/2] drm: Add might_fault to drm_modeset_lock priming

2024-07-10 Thread Daniel Vetter
On Wed, 10 Jul 2024 at 13:39, Christian König wrote: > > Am 10.07.24 um 11:31 schrieb Daniel Vetter: > > We already teach lockdep that dma_resv nests within drm_modeset_lock, > > but there's a lot more: All drm kms ioctl rely on being able to > > put/get_user while

[PATCH 2/2] bcachefs: only console_trylock in bch2_print_string_as_lines

2024-07-10 Thread Daniel Vetter
best we can do here. Including printk folks since even trylock feels realyl iffy here to me. Reported-by: syzbot+6cebc1af246fe020a...@syzkaller.appspotmail.com References: https://lore.kernel.org/dri-devel/26c1ff061cd0d...@google.com/ Signed-off-by: Daniel Vetter Fixes: a8f354284304

[PATCH 1/2] drm: Add might_fault to drm_modeset_lock priming

2024-07-10 Thread Daniel Vetter
devel/73db8b061cd43...@google.com/ Signed-off-by: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: Sumit Semwal Cc: "Christian König" Cc: linux-me...@vger.kernel.org Cc: linaro-mm-...@lists.linaro.org --- drivers/gpu/drm/drm_mode_config.c | 2 ++ 1

Re: [PULL] drm-intel-next

2024-07-10 Thread Daniel Vetter
| 3 - > > drivers/gpu/drm/i915/display/intel_fb_pin.c| 39 +++-- > > drivers/gpu/drm/i915/display/intel_fb_pin.h| 3 +- > > drivers/gpu/drm/i915/display/intel_fbdev.c | 5 +- > > drivers/gpu/drm/i915/display/intel_psr.c | 166 > > + > > drivers/gpu/drm/i915/display/intel_sprite.c| 26 > > drivers/gpu/drm/i915/display/intel_vblank.c| 10 ++ > > drivers/gpu/drm/i915/display/intel_vblank.h| 1 + > > drivers/gpu/drm/i915/display/intel_vrr.c | 2 +- > > drivers/gpu/drm/i915/display/skl_universal_plane.c | 85 ++- > > drivers/gpu/drm/i915/i915_driver.c | 51 +-- > > drivers/gpu/drm/i915/i915_reg.h| 80 +- > > drivers/gpu/drm/xe/display/xe_display.c| 18 +-- > > drivers/gpu/drm/xe/display/xe_fb_pin.c | 3 +- > > drivers/gpu/drm/xe/display/xe_plane_initial.c | 4 +- > > include/drm/drm_plane.h| 2 + > > include/drm/drm_vblank_work.h | 2 + > > 48 files changed, 873 insertions(+), 391 deletions(-) > > > > -- > > Jani Nikula, Intel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PULL] drm-misc-next

2024-07-05 Thread Daniel Vetter
| 1226 > > drivers/gpu/drm/tests/drm_cmdline_parser_test.c| 11 + > drivers/gpu/drm/tests/drm_connector_test.c |1 + > drivers/gpu/drm/tests/drm_modes_test.c | 31 + > include/drm/display/drm_dsc_helper.h |3 + > include/drm/drm_fixed.h| 23 + > 26 files changed, 2605 insertions(+), 560 deletions(-) > create mode 100644 > Documentation/devicetree/bindings/display/st,stm32mp25-lvds.yaml > create mode 100644 drivers/gpu/drm/stm/lvds.c -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PULL] drm-intel-gt-next

2024-07-05 Thread Daniel Vetter
gt; drm/i915/gem: Suppress oom warning in favour of ENOMEM to userspace > > drivers/gpu/drm/i915/gem/i915_gem_stolen.c| 8 +-- > drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 1 + > drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 4 > drivers/gpu

Re: [PULL] drm-xe-next

2024-07-05 Thread Daniel Vetter
oa.c | 2 + > drivers/gpu/drm/xe/xe_pci.c | 4 -- > drivers/gpu/drm/xe/xe_pci_sriov.c | 13 + > drivers/gpu/drm/xe/xe_pci_sriov.h | 7 +++ > drivers/gpu/drm/xe/xe_rtp.c | 2 +- > drivers/gpu/drm/xe/xe_wa_oob.rules | 1 + > 24 files changed, 290 insertions(+), 121 deletions(-) -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PULL] drm-misc-fixes

2024-07-04 Thread Daniel Vetter
d.c | 44 > +++--- > drivers/gpu/drm/ttm/ttm_bo.c | 1 + > include/uapi/drm/panthor_drm.h | 5 +++ > 8 files changed, 63 insertions(+), 20 deletions(-) -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PULL] drm-xe-fixes

2024-07-04 Thread Daniel Vetter
r handling in xe_migrate_update_pgtables > > drivers/gpu/drm/xe/xe_gt_mcr.c | 6 +++--- > drivers/gpu/drm/xe/xe_migrate.c | 8 > 2 files changed, 7 insertions(+), 7 deletions(-) -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PULL] drm-intel-fixes

2024-07-04 Thread Daniel Vetter
m/i915 fixes for v6.10-rc7: > - Skip unnecessary MG programming, avoiding warnings (Imre) > > > Imre Deak (1): > drm/i915/display: For MTL+ platforms skip mg dp programming > > drivers/gpu/drm/i915/display/int

Re: [PATCH v2 2/9] drm: Export drm_plane_has_format()

2024-06-17 Thread Daniel Vetter
&(dev)->mode_config.plane_list, head) > > +bool drm_plane_has_format(struct drm_plane *plane, > + u32 format, u64 modifier); > bool drm_any_plane_has_format(struct drm_device *dev, > u32 format, u64 modifier); > > -- > 2.44.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH] drm/probe-helper: Call drm_mode_validate_ycbcr420() before connector->mode_valid()

2024-05-21 Thread Daniel Vetter
des in said > hook, which will likely come as a suprise when the driver has > declared no support for such modes (via setting > connector->ycbcr_420_allowed to false). > > Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10992 > Signed-off-by: Ville Syrjälä Sounds

Re: [PATCH] MAINTAINERS: Update email address for Tvrtko Ursulin

2024-03-05 Thread Daniel Vetter
ls to point to the > main one. > > Signed-off-by: Tvrtko Ursulin > Cc: Daniel Vetter > Cc: Dave Airlie > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi Directly applied to drm-fixes as requested on irc. -Sima > --- > .mailmap| 5 + > MAINTA

Re: [PULL] drm-xe-next

2024-02-26 Thread Daniel Vetter
| 8 +- > drivers/gpu/drm/xe/xe_tuning.c | 9 +- > drivers/gpu/drm/xe/xe_uc.c | 33 +- > drivers/gpu/drm/xe/xe_uc.h | 1 + > drivers/gpu/drm/xe/xe_uc_fw.c | 60 +- > drivers/gpu/drm/xe/xe_uc_fw_types.h| 9 +- > drivers/gpu/drm/xe/xe_vm.c | 287 ++- > drivers/gpu/drm/xe/xe_vm.h | 7 +- > drivers/gpu/drm/xe/xe_vm_types.h | 18 +- > drivers/gpu/drm/xe/xe_vram_freq.c | 128 +++ > drivers/gpu/drm/xe/xe_vram_freq.h | 13 + > drivers/gpu/drm/xe/xe_wa.c | 191 + > drivers/gpu/drm/xe/xe_wa_oob.rules | 12 +- > drivers/gpu/drm/xe/xe_wait_user_fence.c| 2 +- > drivers/gpu/drm/xe/xe_wopcm_types.h| 4 +- > include/uapi/drm/xe_drm.h | 34 +- > 141 files changed, 6518 insertions(+), 1187 deletions(-) > create mode 100644 drivers/gpu/drm/xe/abi/gsc_proxy_commands_abi.h > create mode 100644 drivers/gpu/drm/xe/abi/guc_actions_sriov_abi.h > create mode 100644 drivers/gpu/drm/xe/abi/guc_relay_actions_abi.h > create mode 100644 drivers/gpu/drm/xe/abi/guc_relay_communication_abi.h > rename drivers/gpu/drm/xe/{ => display}/xe_display.c (99%) > rename drivers/gpu/drm/xe/{ => display}/xe_display.h (100%) > create mode 100644 drivers/gpu/drm/xe/regs/xe_pcode_regs.h > create mode 100644 drivers/gpu/drm/xe/tests/xe_guc_db_mgr_test.c > create mode 100644 drivers/gpu/drm/xe/tests/xe_guc_relay_test.c > create mode 100644 drivers/gpu/drm/xe/tests/xe_kunit_helpers.c > create mode 100644 drivers/gpu/drm/xe/tests/xe_kunit_helpers.h > create mode 100644 drivers/gpu/drm/xe/tests/xe_test_mod.c > create mode 100644 drivers/gpu/drm/xe/xe_gsc_proxy.c > create mode 100644 drivers/gpu/drm/xe/xe_gsc_proxy.h > create mode 100644 drivers/gpu/drm/xe/xe_gt_sriov_printk.h > create mode 100644 drivers/gpu/drm/xe/xe_guc_db_mgr.c > create mode 100644 drivers/gpu/drm/xe/xe_guc_db_mgr.h > create mode 100644 drivers/gpu/drm/xe/xe_guc_hxg_helpers.h > create mode 100644 drivers/gpu/drm/xe/xe_guc_relay.c > create mode 100644 drivers/gpu/drm/xe/xe_guc_relay.h > create mode 100644 drivers/gpu/drm/xe/xe_guc_relay_types.h > create mode 100644 drivers/gpu/drm/xe/xe_memirq.c > create mode 100644 drivers/gpu/drm/xe/xe_memirq.h > create mode 100644 drivers/gpu/drm/xe/xe_memirq_types.h > create mode 100644 drivers/gpu/drm/xe/xe_vram_freq.c > create mode 100644 drivers/gpu/drm/xe/xe_vram_freq.h -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PULL] drm-misc-next

2024-02-26 Thread Daniel Vetter
/xfails/msm-sc7180-trogdor-lazor-limozeen-skips.txt > create mode 100644 drivers/gpu/drm/panel/panel-himax-hx83112a.c > create mode 100644 drivers/gpu/drm/renesas/rz-du/Kconfig > create mode 100644 drivers/gpu/drm/renesas/rz-du/Makefile > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.c > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.h > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.h > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_encoder.c > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_encoder.h > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.h > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_vsp.c > create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_vsp.h > > -- > Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Frankenstrasse 146, 90461 Nuernberg, Germany > GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman > HRB 36809 (AG Nuernberg) -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH] drm/buddy: Fix alloc_range() error handling code

2024-02-09 Thread Daniel Vetter
On Sat, Feb 10, 2024 at 12:06:58AM +0530, Arunpravin Paneer Selvam wrote: > Hi Daniel, > > On 2/9/2024 11:34 PM, Daniel Vetter wrote: > > On Fri, Feb 09, 2024 at 08:56:24PM +0530, Arunpravin Paneer Selvam wrote: > > > Few users have observed display corruption when they b

Re: [PATCH] drm/buddy: Fix alloc_range() error handling code

2024-02-09 Thread Daniel Vetter
9,12 @@ static int __alloc_range(struct drm_buddy *mm, > } while (1); > > list_splice_tail(&allocated, blocks); > + > + if (total_allocated < size) { > + err = -ENOSPC; > + goto err_free; > + } > + > return 0; > > err_undo: > -- > 2.25.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

[PATCH] dma-buf: try to catch swiotlb bounce buffers

2024-02-07 Thread Daniel Vetter
hment when CONFIG_DMA_API_DEBUG is enabled. Signed-off-by: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: linux-me...@vger.kernel.org Cc: linaro-mm-...@lists.linaro.org Cc: Paul Cercueil --- Entirely untested, but since I sent the mail with the idea I figured I might as wel

Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2024-01-31 Thread Daniel Vetter
On Wed, Jan 31, 2024 at 12:26:45PM +0200, Dmitry Baryshkov wrote: > On Wed, 31 Jan 2024 at 11:11, Daniel Vetter wrote: > > > > On Wed, Jan 31, 2024 at 05:17:08AM +, Jason-JH Lin (林睿祥) wrote: > > > On Thu, 2024-01-25 at 19:17 +0100, Daniel Vetter wrote: > > >

Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2024-01-31 Thread Daniel Vetter
On Wed, Jan 31, 2024 at 05:17:08AM +, Jason-JH Lin (林睿祥) wrote: > On Thu, 2024-01-25 at 19:17 +0100, Daniel Vetter wrote: > > > > External email : Please do not click links or open attachments until > > you have verified the sender or the content. > > On Tue,

Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2024-01-25 Thread Daniel Vetter
s, Sima > > Regards, > Jason-JH.Lin > > On Tue, 2023-03-07 at 15:56 +0100, Maxime Ripard wrote: > > Hi, > > > > On Thu, Feb 16, 2023 at 12:12:13PM +0100, Daniel Vetter wrote: > > > The stuff never really worked, and leads to lots of fun because it > &

Re: [PATCH 3/7] drm/amd/display: Add handling for new "active color format" property

2024-01-10 Thread Daniel Vetter
On Wed, 10 Jan 2024 at 13:53, Andri Yngvason wrote: > > mið., 10. jan. 2024 kl. 11:10 skrifaði Daniel Vetter : > > > > On Tue, Jan 09, 2024 at 06:11:00PM +, Andri Yngvason wrote: > > > + /* Extract information from crtc to communicate it to userspace as

Re: [PATCH 3/7] drm/amd/display: Add handling for new "active color format" property

2024-01-10 Thread Daniel Vetter
connector->max_bpc_property) > drm_connector_attach_max_bpc_property(connector, 8, 16); > > + connector->active_color_format_property = > master->base.active_color_format_property; > + if (connector->active_color_format_property) > + > drm_connector_attach_active_color_format_property(&aconnector->base); > + > connector->vrr_capable_property = master->base.vrr_capable_property; > if (connector->vrr_capable_property) > drm_connector_attach_vrr_capable_property(connector); > -- > 2.43.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH 2/7] drm/uAPI: Add "active color format" drm property as feedback for userspace

2024-01-10 Thread Daniel Vetter
ntee that the value is updated right after the kms ioctl returns (and not somewhen later for non-blocking commits). You probably need a bit of work to be able to handle immutable properties with the atomic state infrastructure, but I think otherwise this should fit all rather neatly. Cheers, Sima &

Re: [PATCH] drm/i915/guc: Avoid circular locking issue on busyness flush

2024-01-09 Thread Daniel Vetter
. > So, always do the synchronous cancel if not in reset. And add an extra > synchronous cancel to the end of the reset flow to account for when a > reset is occurring at driver shutdown and the cancel is no longer > synchronous but could lead to unallocated memory accesses if the &g

Re: [Intel-gfx] [PULL] drm-misc-next

2023-11-23 Thread Daniel Vetter
te mode 100644 drivers/gpu/drm/imagination/pvr_rogue_fwif_stream.h > create mode 100644 drivers/gpu/drm/imagination/pvr_rogue_heap_config.h > create mode 100644 drivers/gpu/drm/imagination/pvr_rogue_meta.h > create mode 100644 drivers/gpu/drm/imagination/pvr_rogue_mips.h > create mode 100644 drivers/gpu/drm/imagination/pvr_rogue_mips_check.h > create mode 100644 drivers/gpu/drm/imagination/pvr_rogue_mmu_defs.h > create mode 100644 drivers/gpu/drm/imagination/pvr_stream.c > create mode 100644 drivers/gpu/drm/imagination/pvr_stream.h > create mode 100644 drivers/gpu/drm/imagination/pvr_stream_defs.c > create mode 100644 drivers/gpu/drm/imagination/pvr_stream_defs.h > create mode 100644 drivers/gpu/drm/imagination/pvr_sync.c > create mode 100644 drivers/gpu/drm/imagination/pvr_sync.h > create mode 100644 drivers/gpu/drm/imagination/pvr_vm.c > create mode 100644 drivers/gpu/drm/imagination/pvr_vm.h > create mode 100644 drivers/gpu/drm/imagination/pvr_vm_mips.c > create mode 100644 drivers/gpu/drm/imagination/pvr_vm_mips.h > create mode 100644 include/uapi/drm/pvr_drm.h -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PULL] drm-intel-next

2023-11-23 Thread Daniel Vetter
gpu/drm/i915/i915_gpu_error.h | 2 + > drivers/gpu/drm/i915/i915_params.c | 89 --- > drivers/gpu/drm/i915/i915_params.h | 22 - > drivers/gpu/drm/i915/i915_reg.h| 2 - > drivers/gpu/drm/i915/i915_utils.h | 2 +- > drivers/gpu/drm/i915/intel_runtime_pm.h| 2 - > drivers/gpu/drm/i915/selftests/intel_uncore.c | 2 + > drivers/gpu/drm/i915/soc/intel_gmch.c | 27 +- > drivers/gpu/drm/i915/vlv_sideband.c| 29 +- > drivers/gpu/drm/i915/vlv_sideband.h| 9 +- > drivers/gpu/drm/nouveau/dispnv50/disp.c| 9 +- > drivers/gpu/drm/tests/drm_dp_mst_helper_test.c | 166 +- > include/drm/display/drm_dp.h | 25 + > include/drm/display/drm_dp_helper.h| 32 + > include/drm/display/drm_dp_mst_helper.h| 16 +- > include/drm/drm_color_mgmt.h | 19 +- > 118 files changed, 4425 insertions(+), 1969 deletions(-) > create mode 100644 > drivers/gpu/drm/i915/display/intel_display_debugfs_params.c > create mode 100644 > drivers/gpu/drm/i915/display/intel_display_debugfs_params.h > create mode 100644 drivers/gpu/drm/i915/display/intel_display_params.c > create mode 100644 drivers/gpu/drm/i915/display/intel_display_params.h > create mode 100644 drivers/gpu/drm/i915/display/intel_dpt_common.c > create mode 100644 drivers/gpu/drm/i915/display/intel_dpt_common.h > create mode 100644 drivers/gpu/drm/i915/display/intel_dsb_buffer.c > create mode 100644 drivers/gpu/drm/i915/display/intel_dsb_buffer.h > > -- > Jani Nikula, Intel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PULL] drm-misc-next

2023-11-20 Thread Daniel Vetter
rs/video/fbdev/simplefb.c | 128 +- > include/drm/drm_edid.h | 148 -- > include/drm/drm_eld.h | 164 ++ > include/drm/drm_flip_work.h| 20 +- > include/drm/drm_format_helper.h

Re: [Intel-gfx] [PULL] drm-misc-fixes

2023-11-17 Thread Daniel Vetter
clude/nvkm/core/event.h | 4 ++-- > drivers/gpu/drm/nouveau/nouveau_display.c | 5 + > drivers/gpu/drm/nouveau/nvkm/core/event.c | 12 ++-- > drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c| 6 +++--- > 6 files changed, 22 insertions(+), 14 deletions(-) -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-16 Thread Daniel Vetter
drm-misc.html#merge-criteria "Any non-linear actions (backmerges, merging topic branches and sending out pull requests) are only done by the official drm-misc maintainers (see MAINTAINERS, or ask #dri-devel), and not by committers. See the examples section in dim for more info" Minor screw-ups like this gives us a great opportunity to improve the tooling&docs, let's use it. Cheers, Sima -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PULL] drm-misc-fixes

2023-11-10 Thread Daniel Vetter
splay.c| 3 +++ > drivers/gpu/drm/vc4/tests/vc4_mock_crtc.c| 2 +- > drivers/gpu/drm/vc4/tests/vc4_mock_output.c | 2 +- > 10 files changed, 28 insertions(+), 21 deletions(-) -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PULL] drm-intel-next-fixes

2023-11-10 Thread Daniel Vetter
vers/gpu/drm/i915/display/intel_dp.c | 2 +- > drivers/gpu/drm/i915/display/intel_tc.c | 11 ++--- > drivers/gpu/drm/i915/gem/i915_gem_context.c | 1 + > drivers/gpu/drm/i915/gt/intel_ggtt.c| 35 > - > drivers/gpu/drm/i915/gt/intel_rc6.c | 16 +

Re: [Intel-gfx] [PATCH] drm/i915: Flush WC GGTT only on required platforms

2023-10-13 Thread Daniel Vetter
> > /* > > >* Note that as an uncached mmio write, this will flush the > > >* WCB of the writes into the GGTT before it triggers the > > > invalidate. > > > + * > > > + * Only perform this when GGTT is mapped

Re: [Intel-gfx] [PATCH v5] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-09-06 Thread Daniel Vetter
th lockdep priming, testing in CI isn't good enough for anything remotely complex), then you have a _really_ big problem. Yes CI is good at catching accidental changes in locking design, but if you use it for anything more than that you're in deep trouble. Cheers, Sima -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH v5] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-09-05 Thread Daniel Vetter
On Mon, Aug 28, 2023 at 04:01:38PM -0700, John Harrison wrote: > On 8/23/2023 10:37, John Harrison wrote: > > On 8/23/2023 09:00, Daniel Vetter wrote: > > > On Tue, Aug 22, 2023 at 11:53:24AM -0700, John Harrison wrote: > > > > On 8/11/2023 11:20, Zhanjun Dong wro

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

2023-09-04 Thread Daniel Vetter
all that just because it's part of a hardware enabling series. Cheers, Sima > Alex > > > > > > > > > > > BR, > > > Jani. > > > > > > > > >> > > >> With the patch. both following git grep commands return nothing in > > >> amd-staging-drm-next. > > >> > > >> $ git grep drm_edid_override_connector_update -- drivers/gpu/drm/amd > > >> $ git grep edid_override -- drivers/gpu/drm/amd > > >> > > >> Best regards, > > >> Alex Hung > > >> > > >>>>> > > >>>>> What is the goal of the reverts? I don't disagree that we may be > > >>>>> using the interfaces wrong, but reverting them will regess > > >>>>> functionality in the driver. > > >>>> > > >>>> The commits are in v6.5-rc1, but not yet in a release. No user depends > > >>>> on them yet. I'd strongly prefer them not reaching v6.5 final and > > >>>> users. > > >>> > > >>> Sorry for confusion here, that's obviously come and gone already. :( > > >>> > > >>>> The firmware EDID, override EDID, connector forcing, the EDID property, > > >>>> etc. have been and somewhat still are a hairy mess that we must keep > > >>>> untangling, and this isn't helping. > > >>>> > > >>>> I've put in crazy amounts of work on this, and I've added kernel-doc > > >>>> comments about stuff that should and should not be done, but they go > > >>>> unread and ignored. > > >>>> > > >>>> I really don't want to end up having to clean this up myself before I > > >>>> can embark on further cleanups and refactoring. > > >>>> > > >>>> And again, if the functionality in the driver depends on conflating two > > >>>> things that should be separate, it's probably not such a hot idea to > > >>>> let > > >>>> it reach users either. Even if it's just debugfs. > > >>>> > > >>>> > > >>>> BR, > > >>>> Jani. > > >>> > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

2023-08-30 Thread Daniel Vetter
On Wed, Aug 30, 2023 at 10:29:46AM +0300, Jani Nikula wrote: > Upstream code should be reviewed in public. Yup -Sima -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH v5] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-08-23 Thread Daniel Vetter
rogress. > > > > Signed-off-by: Zhanjun Dong > > Cc: John Harrison > > Cc: Andi Shyti > > Cc: Daniel Vetter > > --- > > drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 11 ++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > &

Re: [Intel-gfx] [PATCH v5] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-08-22 Thread Daniel Vetter
On Tue, Aug 22, 2023 at 02:14:28PM +, Dong, Zhanjun wrote: > > > > -Original Message- > > From: Daniel Vetter > > Sent: August 22, 2023 9:51 AM > > To: Dong, Zhanjun > > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; &

Re: [Intel-gfx] [PATCH v5] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-08-22 Thread Daniel Vetter
quire a lock, > which might trigger the possible cirular locking dependency warning. > When intel_gt_reset called, reset_in_progress flag will be set, add code > to check the flag, call async verion if reset is in progress. > > Signed-off-by: Zhanjun Dong > Cc: John Harrison > Cc

Re: [Intel-gfx] [PATCH v4] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-08-03 Thread Daniel Vetter
tel_guc_preempt_work_destroy(struct intel_guc *guc); > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c > b/drivers/gpu/drm/i915/gt/uc/intel_uc.c > index 18250fb64bd8..5b76f0d4d2a6 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c > @@ -566,7 +566,7 @@ static int __uc_init_hw(struct intel_uc *uc) > * We've failed to load the firmware :( > */ > err_submission: > - intel_guc_submission_disable(guc); > + intel_guc_submission_disable(guc, true); > err_log_capture: > __uc_capture_load_err_log(uc); > err_rps: > @@ -597,7 +597,7 @@ static void __uc_fini_hw(struct intel_uc *uc) > return; > > if (intel_uc_uses_guc_submission(uc)) > - intel_guc_submission_disable(guc); > + intel_guc_submission_disable(guc, true); > > __uc_sanitize(uc); > } > -- > 2.34.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PULL] drm-misc-next

2023-07-27 Thread Daniel Vetter
drivers/gpu/drm/xen/xen_drm_front.c|1 - > drivers/gpu/host1x/bus.c | 29 +- > drivers/gpu/host1x/context.c |2 +- > drivers/gpu/host1x/dev.c |3 +- > drivers/gpu/ipu-v3/ipu-common.c

Re: [Intel-gfx] [PULL] drm-misc-next

2023-07-18 Thread Daniel Vetter
pu/ivpu_debugfs.h > create mode 100644 drivers/accel/ivpu/ivpu_fw_log.c > create mode 100644 drivers/accel/ivpu/ivpu_fw_log.h > create mode 100644 drivers/gpu/drm/drm_exec.c > create mode 100644 drivers/gpu/drm/loongson/Kconfig > create mode 100644 drivers/gpu/drm/loongson/Makefile > create mode 100644 drivers/gpu/drm/loongson/loongson_device.c > create mode 100644 drivers/gpu/drm/loongson/loongson_module.c > create mode 100644 drivers/gpu/drm/loongson/loongson_module.h > create mode 100644 drivers/gpu/drm/loongson/lsdc_benchmark.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_benchmark.h > create mode 100644 drivers/gpu/drm/loongson/lsdc_crtc.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_debugfs.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_drv.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_drv.h > create mode 100644 drivers/gpu/drm/loongson/lsdc_gem.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_gem.h > create mode 100644 drivers/gpu/drm/loongson/lsdc_gfxpll.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_gfxpll.h > create mode 100644 drivers/gpu/drm/loongson/lsdc_i2c.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_i2c.h > create mode 100644 drivers/gpu/drm/loongson/lsdc_irq.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_irq.h > create mode 100644 drivers/gpu/drm/loongson/lsdc_output.h > create mode 100644 drivers/gpu/drm/loongson/lsdc_output_7a1000.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_output_7a2000.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_pixpll.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_pixpll.h > create mode 100644 drivers/gpu/drm/loongson/lsdc_plane.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_probe.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_probe.h > create mode 100644 drivers/gpu/drm/loongson/lsdc_regs.h > create mode 100644 drivers/gpu/drm/loongson/lsdc_ttm.c > create mode 100644 drivers/gpu/drm/loongson/lsdc_ttm.h > delete mode 100644 drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramga102.c > create mode 100644 drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgp102.c > create mode 100644 drivers/gpu/drm/panel/panel-visionox-r66451.c > create mode 100644 drivers/gpu/drm/tests/drm_exec_test.c > create mode 100644 drivers/video/fbdev/core/fb_backlight.c > create mode 100644 drivers/video/fbdev/core/fb_chrdev.c > create mode 100644 drivers/video/fbdev/core/fb_info.c > create mode 100644 drivers/video/fbdev/core/fb_internal.h > create mode 100644 drivers/video/fbdev/core/fb_procfs.c > create mode 100644 include/drm/drm_exec.h > > -- > Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Frankenstrasse 146, 90461 Nuernberg, Germany > GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman > HRB 36809 (AG Nuernberg) -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH] drm/i915: taint kernel when force probing unsupported devices

2023-05-03 Thread Daniel Vetter
a_support") > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Tvrtko Ursulin > Cc: Daniel Vetter > Cc: Dave Airlie > Signed-off-by: Jani Nikula Acked-by: Daniel Vetter > --- > drivers/gpu/drm/i915/Kconfig| 13 - > drivers/gpu/drm/i915/i915_pci.

Re: [Intel-gfx] IOCTL feature detection (Was: Re: [PATCH 8/8] drm/i915: Allow user to set cache at BO creation)

2023-04-26 Thread Daniel Vetter
I'm not suggesting that userspace should be able to check that > > scenario x+y+z will work, but more a list of extensions that > > conceivably could work. Normally this should just a matter of the > > kernel unconditionally adding the newly implemented extension to the > > list returned in the query call. > > > > If a GET_PARAM can be made for the PXP case, then it seems like a > > query item returning CONTEXT_CREATE extensions could conditionally > > omit that extension just as easily as implementing the proposed new > > GET_PARAM. > > > > -Jordan -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with the mm-stable tree

2023-04-19 Thread Daniel Vetter
On Wed, Apr 19, 2023 at 09:30:11AM -0700, Nathan Chancellor wrote: > On Wed, Apr 19, 2023 at 06:24:37PM +0200, Daniel Vetter wrote: > > On Tue, Apr 18, 2023 at 07:34:44PM +0100, Mark Brown wrote: > > > On Sun, Apr 16, 2023 at 09:58:50AM +0200, Daniel Vetter wrote: > > >

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with the mm-stable tree

2023-04-19 Thread Daniel Vetter
On Tue, Apr 18, 2023 at 07:34:44PM +0100, Mark Brown wrote: > On Sun, Apr 16, 2023 at 09:58:50AM +0200, Daniel Vetter wrote: > > > Note there was a ppc compile fail, which is why we pushed the ttm revert. > > That /should/ be fixed now, but would be good if you can confirm?

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with the mm-stable tree

2023-04-16 Thread Daniel Vetter
e fail, which is why we pushed the ttm revert. That /should/ be fixed now, but would be good if you can confirm? Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH v2] drm/i915: avoid flush_scheduled_work() usage

2023-04-16 Thread Daniel Vetter
causes regressions. This > patch eliminates > interference from work items outside of i915, which is small but an > improvement for i915 users. I think if someone from i915 team triple-checks that i915 really doesn't use any of the drm workers (hotplug handling, atomic commit, ...) t

Re: [Intel-gfx] [PULL] drm-misc-fixes

2023-04-13 Thread Daniel Vetter
r-free error > > > Asahi Lina (1): > drm/scheduler: Fix UAF race in drm_sched_entity_push_job() > > Christophe JAILLET (1): > drm/armada: Fix a potential double free in an error handling path > > Da

Re: [Intel-gfx] [PULL] drm-intel-next-fixes

2023-04-13 Thread Daniel Vetter
5/gt/intel_gt_regs.h | 1 + > drivers/gpu/drm/i915/gt/intel_workarounds.c | 19 +++ > 2 files changed, 20 insertions(+) -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH RESEND v3 2/3] drm/ttm: Reduce the number of used allocation orders for TTM pages

2023-04-13 Thread Daniel Vetter
On Thu, 13 Apr 2023 at 11:46, Christian König wrote: > > Am 13.04.23 um 10:48 schrieb Daniel Vetter: > > On Wed, 12 Apr 2023 at 16:18, Christian König > > wrote: > >> Am 12.04.23 um 11:08 schrieb Daniel Vetter: > >>> On Tue, 11 Apr 2023 at 15:45, Dani

Re: [Intel-gfx] [PULL] drm-intel-fixes

2023-04-13 Thread Daniel Vetter
+ > > > Jani Nikula (1): > drm/i915/dsi: fix DSS CTL register offsets for TGL+ > > drivers/gpu/drm/i915/display/icl_dsi.c | 20 > 1 file changed, 16 insertions(+), 4 deletions(-) > >

Re: [Intel-gfx] [PATCH RESEND v3 2/3] drm/ttm: Reduce the number of used allocation orders for TTM pages

2023-04-13 Thread Daniel Vetter
On Wed, 12 Apr 2023 at 16:18, Christian König wrote: > > Am 12.04.23 um 11:08 schrieb Daniel Vetter: > > On Tue, 11 Apr 2023 at 15:45, Daniel Vetter wrote: > >> On Tue, Apr 11, 2023 at 02:11:18PM +0200, Christian König wrote: > >>> Am 11.04.23 um 11:51 schrieb

Re: [Intel-gfx] [PATCH v3 4/7] drm/i915: Switch to fdinfo helper

2023-04-12 Thread Daniel Vetter
On Wed, Apr 12, 2023 at 04:12:41PM +0100, Tvrtko Ursulin wrote: > > On 12/04/2023 14:51, Daniel Vetter wrote: > > On Wed, Apr 12, 2023 at 01:32:43PM +0100, Tvrtko Ursulin wrote: > > > > > > On 11/04/2023 23:56, Rob Clark wrote: > > > > From: Rob Clark

Re: [Intel-gfx] [PULL] drm-misc-next

2023-04-12 Thread Daniel Vetter
>  drivers/gpu/drm/vmwgfx/vmwgfx_kms.h    |   5 - >  drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c    |  45 +++- >  drivers/gpu/drm/vmwgfx/vmwgfx_msg.c        |  35 +-- >  drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c    |   6 - >  21 files changed, 465 insertions(+), 303 deletions(-) >  create mode 100644 > Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml >  delete mode 100644 > Documentation/devicetree/bindings/display/exynos/exynos_dsim.txt > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH v3 4/7] drm/i915: Switch to fdinfo helper

2023-04-12 Thread Daniel Vetter
> + show_client_class(p, client, i); > > } > > #endif > > diff --git a/drivers/gpu/drm/i915/i915_drm_client.h > > b/drivers/gpu/drm/i915/i915_drm_client.h > > index 69496af996d9..ef85fef45de5 100644 > > --- a/drivers/gpu/drm/i915/i915_drm_client.h > > +++ b/drivers/gpu/drm/i915/i915_drm_client.h > > @@ -60,7 +60,7 @@ static inline void i915_drm_client_put(struct > > i915_drm_client *client) > > struct i915_drm_client *i915_drm_client_add(struct i915_drm_clients > > *clients); > > #ifdef CONFIG_PROC_FS > > -void i915_drm_client_fdinfo(struct seq_file *m, struct file *f); > > +void i915_drm_client_fdinfo(struct drm_printer *p, struct drm_file *file); > > #endif > > void i915_drm_clients_fini(struct i915_drm_clients *clients); -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH RESEND v3 2/3] drm/ttm: Reduce the number of used allocation orders for TTM pages

2023-04-12 Thread Daniel Vetter
On Tue, 11 Apr 2023 at 15:45, Daniel Vetter wrote: > > On Tue, Apr 11, 2023 at 02:11:18PM +0200, Christian König wrote: > > Am 11.04.23 um 11:51 schrieb Daniel Vetter: > > > On Tue, Apr 04, 2023 at 10:06:49PM +0200, Thomas Hellström wrote: > > > > When swappi

Re: [Intel-gfx] [PATCH 0/2] Add support for dumping error captures via kernel logging

2023-04-11 Thread Daniel Vetter
gt; > drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 53 + > > > drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h | 6 + > > > drivers/gpu/drm/i915/i915_gpu_error.c | 130 ++ > > > drivers/gpu/drm/i915/i915_gpu_error.h | 8 ++ > > > 4 files changed, 197 insertions(+) > > > > > > -- > > > 2.39.1 > > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH] fbmem: Reject FB_ACTIVATE_KD_TEXT from userspace

2023-04-11 Thread Daniel Vetter
On Tue, Apr 11, 2023 at 04:03:24PM +0200, Javier Martinez Canillas wrote: > Daniel Vetter writes: > > > This is an oversight from dc5bdb68b5b3 ("drm/fb-helper: Fix vt > > restore") - I failed to realize that nasty userspace could set this. > > > > It&#x

Re: [Intel-gfx] [PATCH RESEND v3 2/3] drm/ttm: Reduce the number of used allocation orders for TTM pages

2023-04-11 Thread Daniel Vetter
On Tue, Apr 11, 2023 at 02:11:18PM +0200, Christian König wrote: > Am 11.04.23 um 11:51 schrieb Daniel Vetter: > > On Tue, Apr 04, 2023 at 10:06:49PM +0200, Thomas Hellström wrote: > > > When swapping out, we will split multi-order pages both in order to > > > move them

Re: [Intel-gfx] [PATCH] fbmem: Reject FB_ACTIVATE_KD_TEXT from userspace

2023-04-11 Thread Daniel Vetter
On Tue, Apr 04, 2023 at 09:39:34PM +0200, Daniel Vetter wrote: > This is an oversight from dc5bdb68b5b3 ("drm/fb-helper: Fix vt > restore") - I failed to realize that nasty userspace could set this. > > It's not pretty to mix up kernel-internal and userspace uapi flags

Re: [Intel-gfx] [PATCH RESEND v3 2/3] drm/ttm: Reduce the number of used allocation orders for TTM pages

2023-04-11 Thread Daniel Vetter
st); > > - for (i = 0; i < MAX_ORDER; ++i) { > + for (i = 0; i < TTM_DIM_ORDER; ++i) { > ttm_pool_type_init(&global_write_combined[i], NULL, > ttm_write_combined, i); > ttm_pool_type_init(&global_uncached[i], NULL, ttm_uncached, i); > @@ -790,7 +798,7 @@ void ttm_pool_mgr_fini(void) > { > unsigned int i; > > - for (i = 0; i < MAX_ORDER; ++i) { > + for (i = 0; i < TTM_DIM_ORDER; ++i) { > ttm_pool_type_fini(&global_write_combined[i]); > ttm_pool_type_fini(&global_uncached[i]); > > -- > 2.39.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PULL] drm-intel-next

2023-04-06 Thread Daniel Vetter
s(+), 2888 deletions(-) > delete mode 100644 drivers/gpu/drm/i915/Kconfig.unstable > create mode 100644 drivers/gpu/drm/i915/display/intel_dp_aux_regs.h > create mode 100644 drivers/gpu/drm/i915/display/intel_dsb_regs.h > create mode 100644 drivers/gpu/drm/i915/display/intel_fdi_regs.h > create mode 100644 drivers/gpu/drm/i915/display/intel_pps_regs.h > create mode 100644 drivers/gpu/drm/i915/display/intel_psr_regs.h > create mode 100644 drivers/gpu/drm/i915/display/intel_tv_regs.h > create mode 100644 drivers/gpu/drm/i915/display/skl_watermark_regs.h > create mode 100644 drivers/gpu/drm/i915/intel_clock_gating.c > create mode 100644 drivers/gpu/drm/i915/intel_clock_gating.h > delete mode 100644 drivers/gpu/drm/i915/intel_pm.c > delete mode 100644 drivers/gpu/drm/i915/intel_pm.h -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PULL] drm-intel-gt-next

2023-04-06 Thread Daniel Vetter
bridge/ti-sn65dsi83, ps8640. > > - Use pci aperture helpers in drm/ast lynxfb, radeonfb. > > - Revert some lima patches, as they required a commit that has been > >reverted upstream. > > - Add AUO NE135FBM-N41 v8.1 eDP panel. > > - Add QAIC accel driver. > > >

Re: [Intel-gfx] [PULL] drm-intel-gt-next

2023-04-06 Thread Daniel Vetter
/gpu/drm/i915/i915_getparam.c | 2 +- > drivers/gpu/drm/i915/i915_pci.c| 1 + > drivers/gpu/drm/i915/i915_perf.c | 570 > - > drivers/gpu/drm/i915/i915_perf.h | 4 +- > drivers/gpu/drm/i915/i915_perf_oa_regs.h | 78 +++ > drivers/gpu/drm/i915/i915_perf_types.h | 75 ++- > drivers/gpu/drm/i915/i915_pmu.c| 10 +- > drivers/gpu/drm/i915/i915_reg.h| 14 +- > drivers/gpu/drm/i915/i915_scatterlist.c| 2 +- > drivers/gpu/drm/i915/i915_vma.c| 3 +- > drivers/gpu/drm/i915/intel_device_info.h | 1 + > drivers/gpu/drm/i915/intel_region_ttm.c| 1 + > drivers/gpu/drm/i915/intel_uncore.c| 47 +- > drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 356 - > include/uapi/drm/i915_drm.h| 25 +- > 63 files changed, 1241 insertions(+), 637 deletions(-) -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-04-06 Thread Daniel Vetter
On Wed, 5 Apr 2023 at 19:46, Patrik Jakobsson wrote: > > On Wed, Apr 5, 2023 at 7:15 PM Daniel Vetter wrote: > > > > On Wed, 5 Apr 2023 at 18:54, Javier Martinez Canillas > > wrote: > > > > > > Daniel Vetter writes: > > > > > > &

Re: [Intel-gfx] [PATCH] drm/atomic-helper: Don't set deadline for modesets

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 06:50:22AM -0700, Rob Clark wrote: > On Wed, Apr 5, 2023 at 6:31 AM Daniel Vetter wrote: > > > > If the crtc is being switched on or off then the semantics of > > computing the timestampe of the next vblank is somewhat ill-defined. > > And ind

Re: [Intel-gfx] [PATCH 3/3] drm/fb-helper: fix input validation gaps in check_var

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 07:42:08PM +0200, Javier Martinez Canillas wrote: > Daniel Vetter writes: > > > On Wed, Apr 05, 2023 at 06:27:17PM +0200, Javier Martinez Canillas wrote: > >> Daniel Vetter writes: > > [...] > > >> > > >> > The __

Re: [Intel-gfx] [PULL] drm-misc-fixes

2023-04-05 Thread Daniel Vetter
omas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Maxfeldstr. 5, 90409 Nürnberg, Germany > (HRB 36809, AG Nürnberg) > Geschäftsführer: Felix Imendörffer -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH 3/3] drm/fb-helper: fix input validation gaps in check_var

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 06:27:17PM +0200, Javier Martinez Canillas wrote: > Daniel Vetter writes: > > [...] > > >> > >> but only the 'var->xres > fb->width || var->yres > fb->height' from the > >> conditions checked could be f

Re: [Intel-gfx] [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-04-05 Thread Daniel Vetter
On Wed, 5 Apr 2023 at 18:54, Javier Martinez Canillas wrote: > > Daniel Vetter writes: > > > On Wed, Apr 05, 2023 at 04:32:19PM +0200, Thomas Zimmermann wrote: > > [...] > > >> > > >/* > >> > > > * WARNING: App

Re: [Intel-gfx] [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 04:32:19PM +0200, Thomas Zimmermann wrote: > Hi > > Am 05.04.23 um 15:18 schrieb Daniel Vetter: > > On Wed, Apr 05, 2023 at 01:16:27PM +0200, Javier Martinez Canillas wrote: > > > Thomas Zimmermann writes: > > > > > > [...] >

[Intel-gfx] [PATCH] drm/atomic-helper: Don't set deadline for modesets

2023-04-05 Thread Daniel Vetter
b9c90...@linaro.org/ Fixes: d39e48ca80c0 ("drm/atomic-helper: Set fence deadline for vblank") Cc: Ville Syrjälä Cc: Rob Clark Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Reported-by: Dmitry Baryshkov Tested-by: Dmitry Baryshkov # test patch only Cc: D

Re: [Intel-gfx] [PATCH] drm/atomic-helper: Don't set deadline for modesets

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 03:25:15PM +0300, Ville Syrjälä wrote: > On Wed, Apr 05, 2023 at 10:16:50AM +0200, Daniel Vetter wrote: > > If the crtc is being switched on or off then the semantics of > > computing the timestampe of the next vblank is somewhat ill-defined. > > And in

  1   2   3   4   5   6   7   8   9   10   >