it write the
processed values back to the KMS driver. Even though I'm sure your
intention is not to mislead anyone, what you are writing here is not
actually true.
Cheers,
Daniel
crtc blob property is
> pending in mutter and is commented in the mutter MR.
Sure, that's fine, but until the actual userspace exists, this cannot
be meaningfully reviewed.
Cheers,
Daniel
GNOME/mutter/-/merge_requests/3873
The Mutter MR you linked does not actually write anything back to KMS.
Cheers,
Daniel
Hi Vignesh,
On Fri, 4 Oct 2024 at 09:31, Vignesh Raman wrote:
> +.software-driver:
> + stage: software-driver
> + extends:
> +- .test-gl
> +- .test-rules
> + timeout: "1h30m"
> + tags:
> +- kvm
> + script:
> +- ln -sf $CI_PROJECT_DIR/install /install
> +- mv install/bzIma
Hi Vignesh,
On Thu, 5 Sept 2024 at 10:41, Vignesh Raman wrote:
> Uprev IGT to the latest version and deqp-runner
> to v0.20.0. Also update expectation files.
Thanks! This is:
Reviewed-by: Daniel Stone
On Wed, Aug 28, 2024 at 05:35:45PM +0200, Andi Shyti wrote:
> Hi Sima,
>
> On Wed, Aug 28, 2024 at 03:47:21PM +0200, Daniel Vetter wrote:
> > On Wed, Aug 28, 2024 at 10:20:15AM +0200, Andi Shyti wrote:
> > > Hi Sima,
> > >
> > > first of all, thanks for
On Wed, Aug 28, 2024 at 10:20:15AM +0200, Andi Shyti wrote:
> Hi Sima,
>
> first of all, thanks for looking into this series.
>
> On Tue, Aug 27, 2024 at 07:31:21PM +0200, Daniel Vetter wrote:
> > On Fri, Aug 23, 2024 at 03:08:40PM +0200, Andi Shyti wrote:
> > &g
ad of
> plumbing it into drm mst code.
Yeah ec5fa9fcdeca ("drm/amd/display: Adjust the MST resume flow") promised
a follow-up, but that seems to have never materialized. Really should
materialize though. Patch lgtm
Reviewed-by: Daniel Vetter
> ---
> .../gpu
Reviewed-by: Daniel Vetter
> ---
> drivers/gpu/drm/display/drm_dp_mst_topology.c | 10 +-
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c
> b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> index 39f1dc45
ally lgtm
Reviewed-by: Daniel Vetter
Reading code a bit I did wonder whether we could have send/receive macros
that just work for compile-time statically sized types ... but not even
kmalloc is there yet I think, at least haven't seen anything.
-Sima
> ---
> .../gpu/drm/amd/d
On Wed, Aug 28, 2024 at 02:19:07PM +0300, Jani Nikula wrote:
> Is it time? It is.
Concurred. On the series:
Reviewed-by: Daniel Vetter
Cheers, Sima
>
> Jani Nikula (2):
> drm/i915: fail module probe on nomodeset and i915.modeset=0
> drm/i915: deprecate the i915.modeset m
(ccs_mode);
> +
> void intel_gt_sysfs_ccs_init(struct intel_gt *gt)
> {
> if (sysfs_create_file(>->sysfs_gt, &dev_attr_num_cslices.attr))
> gt_warn(gt, "Failed to create sysfs num_cslices files\n");
> +
> + /*
> + * Do not create the ccs_mode file for non DG2 platforms
> + * because they don't need it as they have only one CCS engine
> + */
> + if (!IS_DG2(gt->i915))
> + return;
> +
> + if (sysfs_create_file(>->sysfs_gt, &dev_attr_ccs_mode.attr))
> + gt_warn(gt, "Failed to create sysfs ccs_mode files\n");
> }
> --
> 2.45.2
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
c| 2 +-
> .../gpu/drm/i915/gt/selftest_workarounds.c| 14 +-
> drivers/gpu/drm/i915/gt/sysfs_engines.c | 79 ++--
> drivers/gpu/drm/i915/gt/sysfs_engines.h | 2 +
> drivers/gpu/drm/i915/i915_cmd_parser.c| 2 +
> drivers/gpu/drm/i915/i915_debugfs.c | 4 +
> drivers/gpu/drm/i915/i915_drv.h | 5 +
> drivers/gpu/drm/i915/i915_gem.c | 4 +
> drivers/gpu/drm/i915/i915_perf.c | 8 +-
> drivers/gpu/drm/i915/i915_pmu.c | 11 +-
> drivers/gpu/drm/i915/i915_query.c | 21 +-
> 37 files changed, 643 insertions(+), 193 deletions(-)
>
> --
> 2.45.2
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
ivate
> *i915)
> err_object:
> kobject_put(kobj);
> err_engine:
> - dev_err(kdev, "Failed to add sysfs engine '%s'\n",
> - engine->name);
> - break;
> +
| 5 +-
> drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 +-
> drivers/gpu/drm/i915/i915_mm.c | 12 +++-
> drivers/gpu/drm/i915/i915_mm.h | 3 +-
> drivers/gpu/drm/i915/i915_perf.c | 33 --
> drivers/gpu/drm/i915/intel_memory_region.c | 6 +-
> drivers/gpu/drm/i915/intel_uncore.c| 7 ++-
> .../gpu/drm/i915/selftests/intel_memory_region.c | 2 +-
> 23 files changed, 150 insertions(+), 81 deletions(-)
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
-
> drivers/gpu/drm/xe/xe_pci.c | 10 +-
> drivers/gpu/drm/xe/xe_pm.c| 11 +-
> drivers/gpu/drm/xe/xe_preempt_fence.c | 3 +-
> drivers/gpu/drm/xe/xe_preempt_fence_types.h | 2 +
> drivers/gpu/drm/xe/xe_pt.c
gpu/drm/vc4/vc4_hdmi.c | 44 +-
> drivers/gpu/drm/vc4/vc4_hvs.c |4 +-
> drivers/gpu/drm/vc4/vc4_irq.c |2 +-
> drivers/gpu/drm/vc4/vc4_v3d.c | 24 +-
> drivers/gpu/drm/vc4/vc4_validate.c |8 +-
> drivers/gpu/drm/vc4/vc4_vec.c | 10 +-
> include/drm/drm_mipi_dsi.h |2 +
> include/linux/string.h | 12 +
> 41 files changed, 1830 insertions(+), 1478 deletions(-)
> create mode 100644 drivers/gpu/drm/ast/ast_sil164.c
> create mode 100644 drivers/gpu/drm/ast/ast_vga.c
>
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Frankenstrasse 146, 90461 Nuernberg, Germany
> GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
> HRB 36809 (AG Nuernberg)
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
is for Xe as I
> don't want to remove force probe with an incongruence in behavior from
> the i915 or have a mesa use case broken.
I've actually gone back to the ggtt fix, and I don't see the security
aspect. Like sure if you do a partial unmap you screw up the offset
calculation and get unexpected aliasing and a mess and the igt you've
linked will fail. But I don't see how that's a security bug?
And if it is, then it's a drm wide issue, because they all work like that.
And so probably we need a drm wide fix first.
So yeah I'm still stuck on the fundamentals here of why this is even done.
And for the uapi extension of allowing partial mmaps, we need the full
uapi dance. Which means some driver flag so userspace can figure out this
is supported, and a link to the mesa MR that uses this all.
Without a link to a mesa MR this won't go anywhere, because that's the
rules for new uapi.
-Sima
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
On Mon, Aug 19, 2024 at 05:31:36PM +0200, Andi Shyti wrote:
> Hi Sima,
>
> On Mon, Aug 19, 2024 at 04:17:01PM +0200, Daniel Vetter wrote:
> > On Wed, Aug 14, 2024 at 02:08:49AM +, Matthew Brost wrote:
> > > On Tue, Aug 13, 2024 at 07:08:02PM +, Matthew Brost wrote
m: fixed: Don't use "proxy" headers
>
> Christophe JAILLET (1):
> drm/rockchip: Constify struct drm_encoder_helper_funcs
>
> Cristian Ciocaltea (5):
> drm/rockchip: Explicitly include bits header
> drm/rockchip: dw_hdmi: Use modern drm_device bas
On Wed, Aug 14, 2024 at 02:08:49AM +, Matthew Brost wrote:
> On Tue, Aug 13, 2024 at 07:08:02PM +, Matthew Brost wrote:
> > On Tue, Aug 13, 2024 at 04:09:55PM +0200, Daniel Vetter wrote:
> > > On Tue, Aug 13, 2024 at 02:54:31AM +, Matthew Brost wrote:
> > > &
On Fri, May 26, 2023 at 01:11:28PM +0200, Thomas Hellström wrote:
> Daniel,
>
> On 4/28/23 14:52, Thomas Hellström wrote:
> > Condsider the following call sequence:
> >
> > /* Upper layer */
> > dma_fence_begin_signalling();
> > lock(taint
On Tue, Aug 13, 2024 at 02:54:31AM +, Matthew Brost wrote:
> On Mon, Aug 12, 2024 at 04:45:32PM +0200, Daniel Vetter wrote:
> > On Mon, Aug 12, 2024 at 01:51:30PM +0200, Andi Shyti wrote:
> > > Hi Daniel,
> > >
> > > On Mon, Aug 12, 2024 at 11:11:21AM +0
On Mon, Aug 12, 2024 at 01:51:30PM +0200, Andi Shyti wrote:
> Hi Daniel,
>
> On Mon, Aug 12, 2024 at 11:11:21AM +0200, Daniel Vetter wrote:
> > On Fri, Aug 09, 2024 at 11:20:56AM +0100, Andi Shyti wrote:
> > > On Fri, Aug 09, 2024 at 10:53:38AM +0200, Daniel Vetter wrote
On Fri, Aug 09, 2024 at 11:20:56AM +0100, Andi Shyti wrote:
> Hi Sima,
>
> On Fri, Aug 09, 2024 at 10:53:38AM +0200, Daniel Vetter wrote:
> > On Wed, Aug 07, 2024 at 11:05:19AM +0100, Andi Shyti wrote:
> > > This patch series concludes on the memory mapping fixes a
/drm/i915/gem/i915_gem_mman.c | 10 ++
> drivers/gpu/drm/i915/i915_mm.c | 12 +++-
> drivers/gpu/drm/i915/i915_mm.h | 3 ++-
> 3 files changed, 19 insertions(+), 6 deletions(-)
>
> --
> 2.45.2
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
rences instead of TTMs
>
> Christoph Fritz (1):
> drm/bridge: synopsys: dw-mipi-dsi: enable EoTp by default
>
> Christophe JAILLET (1):
> drm/stm: Fix an error handling path in stm_drm_platform_probe()
>
> Claudiu Beznea (1):
> drm/stm: ltdc: check m
it series adds support in drm-ci to run tests
> for both GPU and display drivers for MediaTek mt8173/mt8183, Rockchip
> rk3288/rk3399, and Amlogic Meson G12B (A311D) platforms.
>
> Update the expectations file, and skip driver-specific tests and
> tools_test on non-intel platforms.
Tha
On Wed, Jul 10, 2024 at 02:40:04PM +0200, Christian König wrote:
> Am 10.07.24 um 13:58 schrieb Daniel Vetter:
> > On Wed, 10 Jul 2024 at 13:39, Christian König
> > wrote:
> > > Am 10.07.24 um 11:31 schrieb Daniel Vetter:
> > > > We already teac
On Wed, Jul 10, 2024 at 04:19:53PM +0206, John Ogness wrote:
> On 2024-07-10, Daniel Vetter wrote:
> > console_lock is the outermost subsystem lock for a lot of subsystems,
> > which means get/put_user must nest within. Which means it cannot be
> > acquired somewhere deeply
61cd0d...@google.com/
Signed-off-by: Daniel Vetter
Fixes: a8f354284304 ("bcachefs: bch2_print_string_as_lines()")
Cc: # v6.7+
Cc: Kent Overstreet
Cc: Brian Foster
Cc: linux-bcach...@vger.kernel.org
Cc: Petr Mladek
Cc: Steven Rostedt
Cc: John Ogness
Cc: Sergey Senozhatsky
Signed-off-
On Wed, 10 Jul 2024 at 13:39, Christian König wrote:
>
> Am 10.07.24 um 11:31 schrieb Daniel Vetter:
> > We already teach lockdep that dma_resv nests within drm_modeset_lock,
> > but there's a lot more: All drm kms ioctl rely on being able to
> > put/get_user while
best we can do here.
Including printk folks since even trylock feels realyl iffy here to
me.
Reported-by: syzbot+6cebc1af246fe020a...@syzkaller.appspotmail.com
References:
https://lore.kernel.org/dri-devel/26c1ff061cd0d...@google.com/
Signed-off-by: Daniel Vetter
Fixes: a8f354284304
devel/73db8b061cd43...@google.com/
Signed-off-by: Daniel Vetter
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Thomas Zimmermann
Cc: Sumit Semwal
Cc: "Christian König"
Cc: linux-me...@vger.kernel.org
Cc: linaro-mm-...@lists.linaro.org
---
drivers/gpu/drm/drm_mode_config.c | 2 ++
1
| 3 -
> > drivers/gpu/drm/i915/display/intel_fb_pin.c| 39 +++--
> > drivers/gpu/drm/i915/display/intel_fb_pin.h| 3 +-
> > drivers/gpu/drm/i915/display/intel_fbdev.c | 5 +-
> > drivers/gpu/drm/i915/display/intel_psr.c | 166
> > +
> > drivers/gpu/drm/i915/display/intel_sprite.c| 26
> > drivers/gpu/drm/i915/display/intel_vblank.c| 10 ++
> > drivers/gpu/drm/i915/display/intel_vblank.h| 1 +
> > drivers/gpu/drm/i915/display/intel_vrr.c | 2 +-
> > drivers/gpu/drm/i915/display/skl_universal_plane.c | 85 ++-
> > drivers/gpu/drm/i915/i915_driver.c | 51 +--
> > drivers/gpu/drm/i915/i915_reg.h| 80 +-
> > drivers/gpu/drm/xe/display/xe_display.c| 18 +--
> > drivers/gpu/drm/xe/display/xe_fb_pin.c | 3 +-
> > drivers/gpu/drm/xe/display/xe_plane_initial.c | 4 +-
> > include/drm/drm_plane.h| 2 +
> > include/drm/drm_vblank_work.h | 2 +
> > 48 files changed, 873 insertions(+), 391 deletions(-)
> >
> > --
> > Jani Nikula, Intel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
| 1226
>
> drivers/gpu/drm/tests/drm_cmdline_parser_test.c| 11 +
> drivers/gpu/drm/tests/drm_connector_test.c |1 +
> drivers/gpu/drm/tests/drm_modes_test.c | 31 +
> include/drm/display/drm_dsc_helper.h |3 +
> include/drm/drm_fixed.h| 23 +
> 26 files changed, 2605 insertions(+), 560 deletions(-)
> create mode 100644
> Documentation/devicetree/bindings/display/st,stm32mp25-lvds.yaml
> create mode 100644 drivers/gpu/drm/stm/lvds.c
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
gt; drm/i915/gem: Suppress oom warning in favour of ENOMEM to userspace
>
> drivers/gpu/drm/i915/gem/i915_gem_stolen.c| 8 +--
> drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 1 +
> drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 4
> drivers/gpu
oa.c | 2 +
> drivers/gpu/drm/xe/xe_pci.c | 4 --
> drivers/gpu/drm/xe/xe_pci_sriov.c | 13 +
> drivers/gpu/drm/xe/xe_pci_sriov.h | 7 +++
> drivers/gpu/drm/xe/xe_rtp.c | 2 +-
> drivers/gpu/drm/xe/xe_wa_oob.rules | 1 +
> 24 files changed, 290 insertions(+), 121 deletions(-)
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
d.c | 44
> +++---
> drivers/gpu/drm/ttm/ttm_bo.c | 1 +
> include/uapi/drm/panthor_drm.h | 5 +++
> 8 files changed, 63 insertions(+), 20 deletions(-)
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
r handling in xe_migrate_update_pgtables
>
> drivers/gpu/drm/xe/xe_gt_mcr.c | 6 +++---
> drivers/gpu/drm/xe/xe_migrate.c | 8
> 2 files changed, 7 insertions(+), 7 deletions(-)
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
m/i915 fixes for v6.10-rc7:
> - Skip unnecessary MG programming, avoiding warnings (Imre)
>
>
> Imre Deak (1):
> drm/i915/display: For MTL+ platforms skip mg dp programming
>
> drivers/gpu/drm/i915/display/int
On Wed, 19 Jun 2024 at 12:31, Ville Syrjala
wrote:
> Export drm_plane_has_format() so that drivers can use it.
Acked-by: Daniel Stone
e.c
> index 268aa2299df5..a51d4dd3f7de 100644
> --- a/drivers/gpu/drm/drm_plane.c
> +++ b/drivers/gpu/drm/drm_plane.c
> @@ -906,6 +906,7 @@ bool drm_plane_has_format(struct drm_plane *plane,
>
> return true;
> }
> +EXPORT_SYMBOL(drm_plane_has_format);
Kerneldoc p
< 0)
> - return -EINVAL;
> + return option;
>
> /*
>* trace_types_lock is taken to avoid concurrency on start/stop.
Acked-by: Daniel Bristot de Oliveira
Thanks!
-- Daniel
des in said
> hook, which will likely come as a suprise when the driver has
> declared no support for such modes (via setting
> connector->ycbcr_420_allowed to false).
>
> Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10992
> Signed-off-by: Ville Syrjälä
Sounds
ls to point to the
> main one.
>
> Signed-off-by: Tvrtko Ursulin
> Cc: Daniel Vetter
> Cc: Dave Airlie
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
> Cc: Rodrigo Vivi
Directly applied to drm-fixes as requested on irc.
-Sima
> ---
> .mailmap| 5 +
> MAINTA
/HEIGHT caps, which can only declare
> a one size fits all limit for the whole device.
Acked-by: Daniel Stone
Cheers,
Daniel
Hi,
On Mon, 26 Feb 2024 at 03:21, Lucas De Marchi wrote:
> All of this should be fixed by now: dim is used for applying and pushing
> patches, which has additional checks so that doesn't happen again. Still
> pending confirmation from Daniel Stone if the git server hooks are ready
a Link trailer to
> the mailing list discussion. Often these patches were applied with bare
> git-am or b4.
>
> All of this should be fixed by now: dim is used for applying and pushing
> patches, which has additional checks so that doesn't happen again. Still
> pending confirma
/xfails/msm-sc7180-trogdor-lazor-limozeen-skips.txt
> create mode 100644 drivers/gpu/drm/panel/panel-himax-hx83112a.c
> create mode 100644 drivers/gpu/drm/renesas/rz-du/Kconfig
> create mode 100644 drivers/gpu/drm/renesas/rz-du/Makefile
> create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.c
> create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.h
> create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
> create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.h
> create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_encoder.c
> create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_encoder.h
> create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c
> create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.h
> create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_vsp.c
> create mode 100644 drivers/gpu/drm/renesas/rz-du/rzg2l_du_vsp.h
>
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Frankenstrasse 146, 90461 Nuernberg, Germany
> GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
> HRB 36809 (AG Nuernberg)
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
On Sat, Feb 10, 2024 at 12:06:58AM +0530, Arunpravin Paneer Selvam wrote:
> Hi Daniel,
>
> On 2/9/2024 11:34 PM, Daniel Vetter wrote:
> > On Fri, Feb 09, 2024 at 08:56:24PM +0530, Arunpravin Paneer Selvam wrote:
> > > Few users have observed display corruption when they b
9,12 @@ static int __alloc_range(struct drm_buddy *mm,
> } while (1);
>
> list_splice_tail(&allocated, blocks);
> +
> + if (total_allocated < size) {
> + err = -ENOSPC;
> + goto err_free;
> + }
> +
> return 0;
>
> err_undo:
> --
> 2.25.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
hment when
CONFIG_DMA_API_DEBUG is enabled.
Signed-off-by: Daniel Vetter
Cc: Sumit Semwal
Cc: "Christian König"
Cc: linux-me...@vger.kernel.org
Cc: linaro-mm-...@lists.linaro.org
Cc: Paul Cercueil
---
Entirely untested, but since I sent the mail with the idea I figured I
might as wel
On Wed, Jan 31, 2024 at 12:26:45PM +0200, Dmitry Baryshkov wrote:
> On Wed, 31 Jan 2024 at 11:11, Daniel Vetter wrote:
> >
> > On Wed, Jan 31, 2024 at 05:17:08AM +, Jason-JH Lin (林睿祥) wrote:
> > > On Thu, 2024-01-25 at 19:17 +0100, Daniel Vetter wrote:
> > >
On Wed, Jan 31, 2024 at 05:17:08AM +, Jason-JH Lin (林睿祥) wrote:
> On Thu, 2024-01-25 at 19:17 +0100, Daniel Vetter wrote:
> >
> > External email : Please do not click links or open attachments until
> > you have verified the sender or the content.
> > On Tue,
On Tue, Jan 23, 2024 at 06:09:05AM +, Jason-JH Lin (林睿祥) wrote:
> Hi Maxime, Daniel,
>
> We encountered similar issue with mediatek SoCs.
>
> We have found that in drm_atomic_helper_commit_rpm(), when disabling
> the cursor plane, the old_state->le
On Wed, Jan 10, 2024 at 4:35 PM Matthew Wilcox wrote:
>
> On Wed, Jan 10, 2024 at 05:28:22PM +0200, Joonas Lahtinen wrote:
> > Quoting Joonas Lahtinen (2024-01-10 17:20:24)
> > > However we specifically pass "huge=within_size" to vfs_kern_mount when
> > > creating a private mount of tmpfs for the
Hi,
On Wed, 10 Jan 2024 at 10:44, Daniel Vetter wrote:
> On Tue, Jan 09, 2024 at 11:12:11PM +, Andri Yngvason wrote:
> > ţri., 9. jan. 2024 kl. 22:32 skrifađi Daniel Stone :
> > > How does userspace determine what's happened without polling? Will it
> > > onl
On Wed, 10 Jan 2024 at 13:53, Andri Yngvason wrote:
>
> mið., 10. jan. 2024 kl. 11:10 skrifaði Daniel Vetter :
> >
> > On Tue, Jan 09, 2024 at 06:11:00PM +, Andri Yngvason wrote:
> > > + /* Extract information from crtc to communicate it to userspace as
connector->max_bpc_property)
> drm_connector_attach_max_bpc_property(connector, 8, 16);
>
> + connector->active_color_format_property =
> master->base.active_color_format_property;
> + if (connector->active_color_format_property)
> +
> drm_connector_attach_active_color_format_property(&aconnector->base);
> +
> connector->vrr_capable_property = master->base.vrr_capable_property;
> if (connector->vrr_capable_property)
> drm_connector_attach_vrr_capable_property(connector);
> --
> 2.43.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
On Tue, Jan 09, 2024 at 11:12:11PM +, Andri Yngvason wrote:
> Hi Daniel,
>
> þri., 9. jan. 2024 kl. 22:32 skrifaði Daniel Stone :
>
> > On Tue, 9 Jan 2024 at 18:12, Andri Yngvason wrote:
> > > + * active color format:
> > > + * This read-only prope
; + * "ycbcr422", and "ycbcr420".
How does userspace determine what's happened without polling? Will it
only change after an `ALLOW_MODESET` commit, and be guaranteed to be
updated after the commit has completed and the event being sent?
Should it send a HOTPLUG event? Other?
Cheers,
Daniel
.
> So, always do the synchronous cancel if not in reset. And add an extra
> synchronous cancel to the end of the reset flow to account for when a
> reset is occurring at driver shutdown and the cancel is no longer
> synchronous but could lead to unallocated memory accesses if the
&g
te mode 100644 drivers/gpu/drm/imagination/pvr_rogue_fwif_stream.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_rogue_heap_config.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_rogue_meta.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_rogue_mips.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_rogue_mips_check.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_rogue_mmu_defs.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_stream.c
> create mode 100644 drivers/gpu/drm/imagination/pvr_stream.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_stream_defs.c
> create mode 100644 drivers/gpu/drm/imagination/pvr_stream_defs.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_sync.c
> create mode 100644 drivers/gpu/drm/imagination/pvr_sync.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_vm.c
> create mode 100644 drivers/gpu/drm/imagination/pvr_vm.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_vm_mips.c
> create mode 100644 drivers/gpu/drm/imagination/pvr_vm_mips.h
> create mode 100644 include/uapi/drm/pvr_drm.h
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
gpu/drm/i915/i915_gpu_error.h | 2 +
> drivers/gpu/drm/i915/i915_params.c | 89 ---
> drivers/gpu/drm/i915/i915_params.h | 22 -
> drivers/gpu/drm/i915/i915_reg.h| 2 -
> drivers/gpu/drm/i915/i915_utils.h | 2 +-
> drivers/gpu/drm/i915/intel_runtime_pm.h| 2 -
> drivers/gpu/drm/i915/selftests/intel_uncore.c | 2 +
> drivers/gpu/drm/i915/soc/intel_gmch.c | 27 +-
> drivers/gpu/drm/i915/vlv_sideband.c| 29 +-
> drivers/gpu/drm/i915/vlv_sideband.h| 9 +-
> drivers/gpu/drm/nouveau/dispnv50/disp.c| 9 +-
> drivers/gpu/drm/tests/drm_dp_mst_helper_test.c | 166 +-
> include/drm/display/drm_dp.h | 25 +
> include/drm/display/drm_dp_helper.h| 32 +
> include/drm/display/drm_dp_mst_helper.h| 16 +-
> include/drm/drm_color_mgmt.h | 19 +-
> 118 files changed, 4425 insertions(+), 1969 deletions(-)
> create mode 100644
> drivers/gpu/drm/i915/display/intel_display_debugfs_params.c
> create mode 100644
> drivers/gpu/drm/i915/display/intel_display_debugfs_params.h
> create mode 100644 drivers/gpu/drm/i915/display/intel_display_params.c
> create mode 100644 drivers/gpu/drm/i915/display/intel_display_params.h
> create mode 100644 drivers/gpu/drm/i915/display/intel_dpt_common.c
> create mode 100644 drivers/gpu/drm/i915/display/intel_dpt_common.h
> create mode 100644 drivers/gpu/drm/i915/display/intel_dsb_buffer.c
> create mode 100644 drivers/gpu/drm/i915/display/intel_dsb_buffer.h
>
> --
> Jani Nikula, Intel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
rs/video/fbdev/simplefb.c | 128 +-
> include/drm/drm_edid.h | 148 --
> include/drm/drm_eld.h | 164 ++
> include/drm/drm_flip_work.h| 20 +-
> include/drm/drm_format_helper.h
On Thu, Nov 16, 2023 at 02:48:52PM +0100, Maarten Lankhorst wrote:
> Hi Dave, Daniel,
>
> Small pull request, mostly nouveau fixes.
>
> Cheers,
> ~Maarten
>
> Mostly drm-misc-fixes-2023-11-16:
> Assorted fixes for v6.7-rc2:
> - Nouveau GSP fixes.
> - Fix no
drm-misc.html#merge-criteria
"Any non-linear actions (backmerges, merging topic branches and sending
out pull requests) are only done by the official drm-misc maintainers (see
MAINTAINERS, or ask #dri-devel), and not by committers. See the examples
section in dim for more info"
Minor screw-ups like this gives us a great opportunity to improve the
tooling&docs, let's use it.
Cheers, Sima
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
On Wed, Nov 08, 2023 at 02:18:28PM +0100, Maarten Lankhorst wrote:
> Hi Dave, Daniel,
>
> drm-misc-next-fixes is empty, have a pull request for drm-misc-fixes.
>
> Cheers,
> ~Maarten
>
> drm-misc-fixes-2023-11-08:
> drm-misc-fixes for v6.7-rc1:
>
> - drm-misc
On Wed, Nov 08, 2023 at 04:04:14PM +0200, Jani Nikula wrote:
>
> Hi Dave & Daniel -
>
> I see Dave already sent the pull request for v6.7-rc1 fixes, but here's
> some more.
>
> drm-intel-next-fixes-2023-11-08:
> drm/i915 fixes for v6.7-rc1:
> - Fix null de
If there is an API rename can we make sure the patch contains no
other changes (e.g. don't introduce any new API in the same patch).
Seperating renames makes the patches easier to review!
It makes each one smaller and easier to review!
Daniel.
[*] or do_it_nosleep()... etc.
> > /*
> > >* Note that as an uncached mmio write, this will flush the
> > >* WCB of the writes into the GGTT before it triggers the
> > > invalidate.
> > > + *
> > > + * Only perform this when GGTT is mapped
th lockdep priming, testing in CI isn't
good enough for anything remotely complex), then you have a _really_ big
problem. Yes CI is good at catching accidental changes in locking design,
but if you use it for anything more than that you're in deep trouble.
Cheers, Sima
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
On Mon, Aug 28, 2023 at 04:01:38PM -0700, John Harrison wrote:
> On 8/23/2023 10:37, John Harrison wrote:
> > On 8/23/2023 09:00, Daniel Vetter wrote:
> > > On Tue, Aug 22, 2023 at 11:53:24AM -0700, John Harrison wrote:
> > > > On 8/11/2023 11:20, Zhanjun Dong wro
all that just because it's part of a hardware
enabling series.
Cheers, Sima
> Alex
>
>
> > >
> > >
> > > BR,
> > > Jani.
> > >
> > >
> > >>
> > >> With the patch. both following git grep commands return nothing in
> > >> amd-staging-drm-next.
> > >>
> > >> $ git grep drm_edid_override_connector_update -- drivers/gpu/drm/amd
> > >> $ git grep edid_override -- drivers/gpu/drm/amd
> > >>
> > >> Best regards,
> > >> Alex Hung
> > >>
> > >>>>>
> > >>>>> What is the goal of the reverts? I don't disagree that we may be
> > >>>>> using the interfaces wrong, but reverting them will regess
> > >>>>> functionality in the driver.
> > >>>>
> > >>>> The commits are in v6.5-rc1, but not yet in a release. No user depends
> > >>>> on them yet. I'd strongly prefer them not reaching v6.5 final and
> > >>>> users.
> > >>>
> > >>> Sorry for confusion here, that's obviously come and gone already. :(
> > >>>
> > >>>> The firmware EDID, override EDID, connector forcing, the EDID property,
> > >>>> etc. have been and somewhat still are a hairy mess that we must keep
> > >>>> untangling, and this isn't helping.
> > >>>>
> > >>>> I've put in crazy amounts of work on this, and I've added kernel-doc
> > >>>> comments about stuff that should and should not be done, but they go
> > >>>> unread and ignored.
> > >>>>
> > >>>> I really don't want to end up having to clean this up myself before I
> > >>>> can embark on further cleanups and refactoring.
> > >>>>
> > >>>> And again, if the functionality in the driver depends on conflating two
> > >>>> things that should be separate, it's probably not such a hot idea to
> > >>>> let
> > >>>> it reach users either. Even if it's just debugfs.
> > >>>>
> > >>>>
> > >>>> BR,
> > >>>> Jani.
> > >>>
> > >
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
On Wed, Aug 30, 2023 at 10:29:46AM +0300, Jani Nikula wrote:
> Upstream code should be reviewed in public.
Yup
-Sima
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
rogress.
> >
> > Signed-off-by: Zhanjun Dong
> > Cc: John Harrison
> > Cc: Andi Shyti
> > Cc: Daniel Vetter
> > ---
> > drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 11 ++-
> > 1 file changed, 10 insertions(+), 1 deletion(-)
> &
On Tue, Aug 22, 2023 at 02:14:28PM +, Dong, Zhanjun wrote:
>
>
> > -Original Message-
> > From: Daniel Vetter
> > Sent: August 22, 2023 9:51 AM
> > To: Dong, Zhanjun
> > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org;
&
quire a lock,
> which might trigger the possible cirular locking dependency warning.
> When intel_gt_reset called, reset_in_progress flag will be set, add code
> to check the flag, call async verion if reset is in progress.
>
> Signed-off-by: Zhanjun Dong
> Cc: John Harrison
> Cc
guc *guc, bool sync)
> {
> - cancel_delayed_work_sync(&guc->timestamp.work);
> + if (sync)
> + cancel_delayed_work_sync(&guc->timestamp.work);
> + else
> + cancel_delayed_work(&guc->timestamp.work);
> }
>
drivers/gpu/drm/xen/xen_drm_front.c|1 -
> drivers/gpu/host1x/bus.c | 29 +-
> drivers/gpu/host1x/context.c |2 +-
> drivers/gpu/host1x/dev.c |3 +-
> drivers/gpu/ipu-v3/ipu-common.c
On Thu, 13 Jul 2023 at 11:08, Thomas Zimmermann wrote:
>
> Hi Dave and Daniel,
>
> this is the main pull request for drm-misc-next for what will become
> Linux v6.6. Some noteworthy changes are:
>
> * GEM got execution contexts that help with locking multiple GEM
>obj
sent
> https://lore.kernel.org/20230524-intel_async_flip_check_hw-implicit-fallthrough-v1-1-83de89e37...@kernel.org/
> for this.
Better link:
https://lore.kernel.org/dri-devel/20230524-intel_async_flip_check_hw-implicit-fallthrough-v1-1-83de89e37...@kernel.org/
Greetings!
Daniel Díaz
daniel.d...@linaro.org
a_support")
> Cc: Joonas Lahtinen
> Cc: Rodrigo Vivi
> Cc: Tvrtko Ursulin
> Cc: Daniel Vetter
> Cc: Dave Airlie
> Signed-off-by: Jani Nikula
Acked-by: Daniel Vetter
> ---
> drivers/gpu/drm/i915/Kconfig| 13 -
> drivers/gpu/drm/i915/i915_pci.
On Tue, Apr 25, 2023 at 04:41:54PM +0300, Joonas Lahtinen wrote:
> (+ Faith and Daniel as they have been involved in previous discussions)
>
> Quoting Jordan Justen (2023-04-24 20:13:00)
> > On 2023-04-24 02:08:43, Tvrtko Ursulin wrote:
> > >
> > > Being ab
On Wed, Apr 19, 2023 at 09:30:11AM -0700, Nathan Chancellor wrote:
> On Wed, Apr 19, 2023 at 06:24:37PM +0200, Daniel Vetter wrote:
> > On Tue, Apr 18, 2023 at 07:34:44PM +0100, Mark Brown wrote:
> > > On Sun, Apr 16, 2023 at 09:58:50AM +0200, Daniel Vetter wrote:
> > >
On Tue, Apr 18, 2023 at 07:34:44PM +0100, Mark Brown wrote:
> On Sun, Apr 16, 2023 at 09:58:50AM +0200, Daniel Vetter wrote:
>
> > Note there was a ppc compile fail, which is why we pushed the ttm revert.
> > That /should/ be fixed now, but would be good if you can confirm?
nimise any particularly
> complex conflicts.
>
>
> diff --cc drivers/gpu/drm/ttm/ttm_pool.c
> index 4db3982057be8,dfce896c4baeb..0
> --- a/drivers/gpu/drm/ttm/ttm_pool.c
> +++ b/drivers/gpu/drm/ttm/ttm_pool.c
>
> [Just the version in mm]
Note there was a ppc compil
causes regressions. This
> patch eliminates
> interference from work items outside of i915, which is small but an
> improvement for i915 users.
I think if someone from i915 team triple-checks that i915 really doesn't
use any of the drm workers (hotplug handling, atomic commit, ...) t
On Thu, Apr 13, 2023 at 08:42:33PM +0200, Thomas Zimmermann wrote:
> Hi Dave and Daniel,
>
> this is the PR for drm-misc-fixes for this week.
>
> Best regards
> Thomas
>
> drm-misc-fixes-2023-04-13:
> Short summary of fixes pull:
>
> * armad
On Thu, Apr 13, 2023 at 03:12:19PM +0300, Joonas Lahtinen wrote:
> Hi Dave & Daniel,
>
> Just one Cc:stable fix for indirect sampler state this week on
> drm-intel-next-fixes.
>
> Regards, Joonas
>
> ***
>
> drm-intel-next-fixes-2023-04-13:
>
> Short s
On Thu, 13 Apr 2023 at 11:46, Christian König wrote:
>
> Am 13.04.23 um 10:48 schrieb Daniel Vetter:
> > On Wed, 12 Apr 2023 at 16:18, Christian König
> > wrote:
> >> Am 12.04.23 um 11:08 schrieb Daniel Vetter:
> >>> On Tue, 11 Apr 2023 at 15:45, Dani
On Thu, Apr 13, 2023 at 10:13:57AM +0300, Jani Nikula wrote:
>
> Hi Dave & Daniel -
>
> One DSI fix, stable material.
>
> drm-intel-fixes-2023-04-13:
> drm/i915 fixes for v6.3-rc7:
> - Fix dual link DSI for TGL+
>
> BR,
> Jani.
&g
On Wed, 12 Apr 2023 at 16:18, Christian König wrote:
>
> Am 12.04.23 um 11:08 schrieb Daniel Vetter:
> > On Tue, 11 Apr 2023 at 15:45, Daniel Vetter wrote:
> >> On Tue, Apr 11, 2023 at 02:11:18PM +0200, Christian König wrote:
> >>> Am 11.04.23 um 11:51 schrieb
On Wed, Apr 12, 2023 at 04:12:41PM +0100, Tvrtko Ursulin wrote:
>
> On 12/04/2023 14:51, Daniel Vetter wrote:
> > On Wed, Apr 12, 2023 at 01:32:43PM +0100, Tvrtko Ursulin wrote:
> > >
> > > On 11/04/2023 23:56, Rob Clark wrote:
> > > > From: Rob Clark
On Wed, Apr 12, 2023 at 03:32:30PM +0200, Maarten Lankhorst wrote:
>
> Good afternoon Daniel, Dave,
>
> One last pull request for drm-misc-next.
>
> Small one, so easy to merge. As a result also more likely to eat your
> computer alive. ;)
>
> Cheers,
>
> ~M
t, once that's gone userspace will never be able
to look at anything, having a separate free-standing object that's
essentially always dead is backwards.
I went a bit more in-depth in a different thread on scheduler fd_info
stats, but essentially fd_info needs to pull stats, you sh
On Tue, 11 Apr 2023 at 15:45, Daniel Vetter wrote:
>
> On Tue, Apr 11, 2023 at 02:11:18PM +0200, Christian König wrote:
> > Am 11.04.23 um 11:51 schrieb Daniel Vetter:
> > > On Tue, Apr 04, 2023 at 10:06:49PM +0200, Thomas Hellström wrote:
> > > > When swappi
redump infrastructure, so if you
need dumping straight to dmesg that would be a patch for that subsystem in
the future.
Not sure how much you want to add fun here in the i915-gem deadend, I'll
leave that up to i915 maintainers.
Just figured this is a good place to drop this aside :-)
-Da
On Tue, Apr 11, 2023 at 04:03:24PM +0200, Javier Martinez Canillas wrote:
> Daniel Vetter writes:
>
> > This is an oversight from dc5bdb68b5b3 ("drm/fb-helper: Fix vt
> > restore") - I failed to realize that nasty userspace could set this.
> >
> > It&#x
1 - 100 of 2370 matches
Mail list logo
