[Intel-gfx] [PATCH v5] ACPI: Fix acpi_evaluate_object() return value check

2014-01-22 Thread Yijing Wang
Since acpi_evaluate_object() returns acpi_status and not plain int, ACPI_FAILURE() should be used for checking its return value. Also add some detailed debug info when acpi_evaluate_object() failed. Reviewed-by: Jani Nikula Acked-by: Bjorn Helgaas Signed-off-by: Yijing Wang --- v4->v5:

Re: [Intel-gfx] [PATCH v4] ACPI: Fix acpi_evaluate_object() return value check

2014-01-22 Thread Yijing Wang
On 2014/1/23 5:37, Bjorn Helgaas wrote: > On Mon, Jan 20, 2014 at 7:46 PM, Yijing Wang wrote: >> Since acpi_evaluate_object() returns acpi_status and not plain int, >> ACPI_FAILURE() should be used for checking its return value. >> >> Reviewed-by: Jani Nikula &g

[Intel-gfx] [PATCH v4] ACPI: Fix acpi_evaluate_object() return value check

2014-01-20 Thread Yijing Wang
Since acpi_evaluate_object() returns acpi_status and not plain int, ACPI_FAILURE() should be used for checking its return value. Reviewed-by: Jani Nikula Signed-off-by: Yijing Wang --- v3->v4: Fix spell error, add Jani Nikula reviewed-by. v2->v3: Fix compile error pointed out by Hanjun.

Re: [Intel-gfx] [PATCH v2] ACPI: Fix acpi_evaluate_object() return value check

2014-01-17 Thread Yijing Wang
>> diff --git a/drivers/gpu/drm/i915/intel_acpi.c >> b/drivers/gpu/drm/i915/intel_acpi.c >> index dfff090..7ea00e5 100644 >> --- a/drivers/gpu/drm/i915/intel_acpi.c >> +++ b/drivers/gpu/drm/i915/intel_acpi.c >> @@ -35,7 +35,7 @@ static int intel_dsm(acpi_handle handle, int func) >> union acpi

[Intel-gfx] [PATCH v2] ACPI: Fix acpi_evaluate_object() return value check

2014-01-17 Thread Yijing Wang
Fix acpi_evaluate_object() return value check, shoud acpi_status not int. Signed-off-by: Yijing Wang --- v1->v2: Add CC to the related subsystem MAINTAINERS. --- drivers/gpu/drm/i915/intel_acpi.c | 13 +++-- drivers/gpu/drm/nouveau/core/subdev/mxm/base.c |

[Intel-gfx] [PATCH v3] ACPI: Fix acpi_evaluate_object() return value check

2014-01-17 Thread Yijing Wang
Fix acpi_evaluate_object() return value check, shoud acpi_status not int. Signed-off-by: Yijing Wang --- v2->v3: Fix compile error pointed out by Hanjun. v1->v2: Add CC to related subsystem MAINTAINERS --- drivers/gpu/drm/i915/intel_acpi.c | 24 ++-- d