Re: [PATCH 2/4] drm/i915/dmc_wl: Add debugfs for untracked offsets

2025-01-30 Thread Vivekanandan, Balasubramani
On 23.01.2025 13:41, Gustavo Sousa wrote: > Quoting Vivekanandan, Balasubramani (2025-01-23 13:11:03-03:00) > >On 17.01.2025 19:06, Gustavo Sousa wrote: > >> The DMC wakelock code needs to keep track of register offsets that need > >> the wakelock for proper access. If o

Re: [PATCH 3/4] drm/i915/dmc_wl: Add extra_ranges debugfs

2025-01-30 Thread Vivekanandan, Balasubramani
On 30.01.2025 14:00, Vivekanandan, Balasubramani wrote: > On 17.01.2025 19:06, Gustavo Sousa wrote: > > We already have a way of finding the set of untracked offsets for which > > there has been one or more MMIO operations via the > > "intel_dmc_wl/untracked" debu

Re: [PATCH 4/4] drm/i915/dmc_wl: Enable the debugfs only with enable_dmc_wl_debugfs=1

2025-01-30 Thread Vivekanandan, Balasubramani
On 17.01.2025 19:06, Gustavo Sousa wrote: > We use a spinlock to protect DMC wakelock debugfs data, since it is also > accessed by the core DMC wakelock logic. Taking the spinlock when the > debugfs is not in use introduces a small but unnecessary penalty. > > Since the debugfs functionality is on

Re: [PATCH 3/4] drm/i915/dmc_wl: Add extra_ranges debugfs

2025-01-30 Thread Vivekanandan, Balasubramani
On 17.01.2025 19:06, Gustavo Sousa wrote: > We already have a way of finding the set of untracked offsets for which > there has been one or more MMIO operations via the > "intel_dmc_wl/untracked" debugfs interface. > > However, in order to try adding one or more of those registers to the > set of

Re: [PATCH 2/4] drm/i915/dmc_wl: Add debugfs for untracked offsets

2025-01-23 Thread Vivekanandan, Balasubramani
On 17.01.2025 19:06, Gustavo Sousa wrote: > The DMC wakelock code needs to keep track of register offsets that need > the wakelock for proper access. If one of the necessary offsets are > missed, then the failure in asserting the wakelock is very likely to > cause problems down the road. > > A mis

Re: [PATCH v3] drm/i915: Add Wa_22010465259 in its respective WA list

2025-01-20 Thread Vivekanandan, Balasubramani
On 16.01.2025 15:01, Ranu Maurya wrote: > Add Wa_22010465259 which points to an existing WA, but > was missing from the comment list. While at it, update > the other WAs and their applicable platforms as well. > > v1: Initial commit. > v2: Add DG2 platform to Wa_22010465259. > v3: Removed DG2 plat

Re: [PATCH] drm/i915: Remove unused underrun interrupt bits

2024-10-10 Thread Vivekanandan, Balasubramani
On 09.10.2024 15:35, Pottumuttu, Sai Teja wrote: > > On 09-10-2024 13:05, Vivekanandan, Balasubramani wrote: > > On 26.09.2024 10:52, Pottumuttu, Sai Teja wrote: > > > On 25-09-2024 19:33, Ville Syrjälä wrote: > > > > On Wed, Sep 25, 2024 at 04:48:02PM

Re: [PATCH] drm/i915: Remove unused underrun interrupt bits

2024-10-09 Thread Vivekanandan, Balasubramani
On 26.09.2024 10:52, Pottumuttu, Sai Teja wrote: > > On 25-09-2024 19:33, Ville Syrjälä wrote: > > On Wed, Sep 25, 2024 at 04:48:02PM +0530, Sai Teja Pottumuttu wrote: > > > Underrun recovery was defeatured and was never brought into usage. > > > Thus we can safely remove the interrupt register bi

Re: [PATCH] drm/i915/gem: Downgrade stolen lmem setup warning

2024-04-21 Thread Vivekanandan, Balasubramani
On 19.04.2024 14:26, Jonathan Cavitt wrote: > In the case where lmem_size < dsm_base, hardware is reporting that > stolen lmem is unusable. In this case, instead of throwing a warning, > we can continue execution as normal by disabling stolen LMEM support. > For example, this change will allow the

Re: [PATCH v2 25/25] drm/xe/bmg: Enable the display support

2024-04-07 Thread Vivekanandan, Balasubramani
On 08.04.2024 08:46, Chauhan, Shekhar wrote: > > On 4/3/2024 16:52, Balasubramani Vivekanandan wrote: > > Enable the display support for Battlemage > > > > Signed-off-by: Balasubramani Vivekanandan > > > > --- > > drivers/gpu/drm/xe/xe_pci.c | 1 + > > 1 file changed, 1 insertion(+) > > > >