Re: [Intel-gfx] [PATCH v5 3/3] PM/runtime:Replace jiffies based accounting with ktime based accounting

On Mon, 21 Jan 2019 at 23:53, Rafael J. Wysocki wrote: > > On Mon, Jan 21, 2019 at 4:17 PM Vincent Guittot > wrote: > > > > On Fri, 18 Jan 2019 at 13:08, Guenter Roeck wrote: > > > > > > On 1/18/19 3:05 AM, Rafael J. Wysocki wrote: > > > &g

Re: [Intel-gfx] [PATCH v5 3/3] PM/runtime:Replace jiffies based accounting with ktime based accounting

On Fri, 18 Jan 2019 at 13:08, Guenter Roeck wrote: > > On 1/18/19 3:05 AM, Rafael J. Wysocki wrote: > > On Fri, Jan 18, 2019 at 11:53 AM Vincent Guittot > > wrote: > >> > >> On Fri, 18 Jan 2019 at 11:42, Vincent Guittot > >> wrote: > >>>

Re: [Intel-gfx] [PATCH v5 3/3] PM/runtime:Replace jiffies based accounting with ktime based accounting

On Fri, 18 Jan 2019 at 11:42, Vincent Guittot wrote: > > Hi Guenter, > > Le Thursday 17 Jan 2019 à 14:16:28 (-0800), Guenter Roeck a écrit : > > On Fri, Dec 21, 2018 at 11:33:56AM +0100, Vincent Guittot wrote: > > > From: Thara Gopinath > > > > > >

Re: [Intel-gfx] [PATCH v5 3/3] PM/runtime:Replace jiffies based accounting with ktime based accounting

Hi Guenter, Le Thursday 17 Jan 2019 à 14:16:28 (-0800), Guenter Roeck a écrit : > On Fri, Dec 21, 2018 at 11:33:56AM +0100, Vincent Guittot wrote: > > From: Thara Gopinath > > > > This patch replaces jiffies based accounting for runtime_active_time > > and runtime_sus

Re: [Intel-gfx] [PATCH v5 2/3] drm/i915: Move on the new pm runtime interface

Hi Tvrtko, On Mon, 31 Dec 2018 at 13:32, Tvrtko Ursulin wrote: > > > On 21/12/2018 13:26, Vincent Guittot wrote: > > On Fri, 21 Dec 2018 at 12:33, Tvrtko Ursulin [snip] > >> > >> If it is always monotonic, then worst case we report one wrong sample, > >&

Re: [Intel-gfx] [PATCH v5 2/3] drm/i915: Move on the new pm runtime interface

On Fri, 21 Dec 2018 at 12:33, Tvrtko Ursulin wrote: > > > Hi, > > On 21/12/2018 10:33, Vincent Guittot wrote: > > Use the new pm runtime interface to get the accounted suspended time: > > pm_runtime_suspended_time(). > > This new interface helps to simplify a

[Intel-gfx] [PATCH v5 3/3] PM/runtime:Replace jiffies based accounting with ktime based accounting

d-off-by: Thara Gopinath [move from ktime to raw nsec] Signed-off-by: Vincent Guittot --- drivers/base/power/runtime.c | 17 + drivers/base/power/sysfs.c | 11 --- include/linux/pm.h | 6 +++--- 3 files changed, 20 insertions(+), 14 deletions(-) diff --git a/dr

[Intel-gfx] [PATCH v5 1/3] PM/runtime: Add a new interface to get accounted time

Some drivers (like i915/drm) needs to get the accounted suspended time. pm_runtime_suspended_time() will return the suspended accounted time in ns unit. Reviewed-by: Ulf Hansson Signed-off-by: Vincent Guittot --- drivers/base/power/runtime.c | 16 include/linux/pm_runtime.h

[Intel-gfx] [PATCH v5 2/3] drm/i915: Move on the new pm runtime interface

: Vincent Guittot --- drivers/gpu/drm/i915/i915_pmu.c | 16 ++-- drivers/gpu/drm/i915/i915_pmu.h | 4 ++-- 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c index d6c8f8f..3f76f60 100644 --- a/drivers/gpu/drm

[Intel-gfx] [PATCH v5 0/3] Move pm_runtime accounted time to raw nsec

& 3 to move runtime_pm accounting on raw ns Thara Gopinath (1): PM/runtime:Replace jiffies based accounting with ktime based accounting Vincent Guittot (2): PM/runtime: Add a new interface to get accounted time drm/i915: Move on the new pm runtime interface drivers/base/p

Re: [Intel-gfx] [PATCH v4 3/3] PM/runtime:Replace jiffies based accounting with ktime based accounting

Hi Rafael, On Fri, 21 Dec 2018 at 09:58, Rafael J. Wysocki wrote: > > On Thu, Dec 20, 2018 at 11:03 PM Ulf Hansson wrote: > > > > On Thu, 20 Dec 2018 at 15:17, Vincent Guittot > > wrote: > > > > > > From: Thara Gopinath > > > >

Re: [Intel-gfx] [PATCH v4 3/3] PM/runtime:Replace jiffies based accounting with ktime based accounting

On Thu, 20 Dec 2018 at 23:03, Ulf Hansson wrote: > > On Thu, 20 Dec 2018 at 15:17, Vincent Guittot > wrote: > > > > From: Thara Gopinath > > > > This patch replaces jiffies based accounting for runtime_active_time > > and runtime_suspended_time wit

Re: [Intel-gfx] [PATCH v4 2/3] drm/i915: Move on the new pm runtime interface

On Thu, 20 Dec 2018 at 23:04, Ulf Hansson wrote: > > On Thu, 20 Dec 2018 at 15:17, Vincent Guittot > wrote: > > > > Use the new pm runtime interface to get the accounted suspended time: > > pm_runtime_accounted_time_get() > > pm_runtime_suspended_time() > >

[Intel-gfx] [PATCH v4 3/3] PM/runtime:Replace jiffies based accounting with ktime based accounting

from ktime to raw nsec] Signed-off-by: Vincent Guittot --- drivers/base/power/runtime.c | 17 + drivers/base/power/sysfs.c | 11 --- include/linux/pm.h | 6 +++--- 3 files changed, 20 insertions(+), 14 deletions(-) diff --git a/drivers/base/power/runtime.c b

[Intel-gfx] [PATCH v4 2/3] drm/i915: Move on the new pm runtime interface

Use the new pm runtime interface to get the accounted suspended time: pm_runtime_accounted_time_get() Signed-off-by: Vincent Guittot --- drivers/gpu/drm/i915/i915_pmu.c | 16 ++-- drivers/gpu/drm/i915/i915_pmu.h | 4 ++-- 2 files changed, 8 insertions(+), 12 deletions(-) diff

[Intel-gfx] [PATCH v4 0/3] Move pm_runtime accounted time to raw nsec

raw ns Thara Gopinath (1): PM/runtime:Replace jiffies based accounting with ktime based accounting Vincent Guittot (2): PM/runtime: Add a new interface to get accounted time drm/i915: Move on the new pm runtime interface drivers/base/power/runtime.c

[Intel-gfx] [PATCH v4 1/3] PM/runtime: Add a new interface to get accounted time

Some drivers (like i915/drm) needs to get the accounted suspended time. pm_runtime_suspended_time() will return the suspended accounted time in ns unit. Signed-off-by: Vincent Guittot --- drivers/base/power/runtime.c | 16 include/linux/pm_runtime.h | 2 ++ 2 files changed

Re: [Intel-gfx] [RFC v3 1/3] PM/runtime: Add a new interface to get accounted time

On Thu, 20 Dec 2018 at 09:16, Ulf Hansson wrote: > > On Wed, 19 Dec 2018 at 17:52, Vincent Guittot > wrote: > > > > On Wed, 19 Dec 2018 at 17:36, Ulf Hansson wrote: > > > > > > On Wed, 19 Dec 2018 at 14:26, Vincent Guittot > > > wrote: > >

Re: [Intel-gfx] [RFC v3 1/3] PM/runtime: Add a new interface to get accounted time

On Wed, 19 Dec 2018 at 17:36, Ulf Hansson wrote: > > On Wed, 19 Dec 2018 at 14:26, Vincent Guittot > wrote: > > > > On Wed, 19 Dec 2018 at 11:43, Ulf Hansson wrote: > > > > > > On Wed, 19 Dec 2018 at 11:34, Vincent Guittot > > > wrote: > >

Re: [Intel-gfx] [RFC v3 1/3] PM/runtime: Add a new interface to get accounted time

On Wed, 19 Dec 2018 at 10:58, Ulf Hansson wrote: > > On Tue, 18 Dec 2018 at 15:55, Vincent Guittot > wrote: > > > > Some drivers (like i915/drm) need to get the accounted suspended time. > > pm_runtime_accounted_time_get() will return the suspended or active > >

Re: [Intel-gfx] [RFC v3 1/3] PM/runtime: Add a new interface to get accounted time

On Wed, 19 Dec 2018 at 11:43, Ulf Hansson wrote: > > On Wed, 19 Dec 2018 at 11:34, Vincent Guittot > wrote: > > > > On Wed, 19 Dec 2018 at 11:21, Ulf Hansson wrote: > > > > > > > > > > > > > > > diff --git a/driver

Re: [Intel-gfx] [RFC v3 1/3] PM/runtime: Add a new interface to get accounted time

On Wed, 19 Dec 2018 at 11:21, Ulf Hansson wrote: > > On Wed, 19 Dec 2018 at 11:11, Vincent Guittot > wrote: > > > > On Wed, 19 Dec 2018 at 10:58, Ulf Hansson wrote: > > > > > > On Tue, 18 Dec 2018 at 15:55, Vincent Guittot > > > wrote: > >

Re: [Intel-gfx] [RFC v3 1/3] PM/runtime: Add a new interface to get accounted time

On Wed, 19 Dec 2018 at 10:58, Ulf Hansson wrote: > > On Tue, 18 Dec 2018 at 15:55, Vincent Guittot > wrote: > > > > Some drivers (like i915/drm) need to get the accounted suspended time. > > pm_runtime_accounted_time_get() will return the suspended or active > >

[Intel-gfx] [PATCH v3 0/3] Move pm_runtime accounted time to raw nsec

compilation error Changes since v1: - updated commit message of patch 1 - Added patches 2 & 3 to move runtime_pm accounting on raw ns Thara Gopinath (1): PM/runtime:Replace jiffies based accounting with ktime based accounting Vincent Guittot (2): PM/runtime: Add a new interface to

[Intel-gfx] [PATCH 3/3] PM/runtime:Replace jiffies based accounting with ktime based accounting

from ktime to raw nsec] Signed-off-by: Vincent Guittot --- drivers/base/power/runtime.c | 10 +- drivers/base/power/sysfs.c | 11 --- include/linux/pm.h | 6 +++--- 3 files changed, 16 insertions(+), 11 deletions(-) diff --git a/drivers/base/power/runtime.c b/drivers

[Intel-gfx] [RFC v3 1/3] PM/runtime: Add a new interface to get accounted time

Some drivers (like i915/drm) need to get the accounted suspended time. pm_runtime_accounted_time_get() will return the suspended or active accounted time until now. Signed-off-by: Vincent Guittot --- drivers/base/power/runtime.c | 26 ++ include/linux/pm_runtime.h | 2

[Intel-gfx] [RFC 2/3] drm/i915: Move on the new pm runtime interface

Use the new pm runtime interface to get the accounted suspended time: pm_runtime_accounted_time_get() Signed-off-by: Vincent Guittot --- drivers/gpu/drm/i915/i915_pmu.c | 18 -- drivers/gpu/drm/i915/i915_pmu.h | 4 ++-- 2 files changed, 10 insertions(+), 12 deletions(-) diff

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: Move to new PM core fields

On Tue, 18 Dec 2018 at 11:03, Rafael J. Wysocki wrote: > > On Tue, Dec 18, 2018 at 10:58 AM Vincent Guittot > wrote: > > > > On Tue, 18 Dec 2018 at 10:57, Rafael J. Wysocki wrote: > > > > > > On Mon, Dec 17, 2018 at 3:22 PM Vincent Guittot > > >

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: Move to new PM core fields

On Tue, 18 Dec 2018 at 10:57, Rafael J. Wysocki wrote: > > On Mon, Dec 17, 2018 at 3:22 PM Vincent Guittot > wrote: > > > > On Fri, 14 Dec 2018 at 15:36, Ulf Hansson wrote: > > > > > > On Fri, 14 Dec 2018 at 15:22, Vincent Guittot > > > wrote: &

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: Move to new PM core fields

On Fri, 14 Dec 2018 at 15:36, Ulf Hansson wrote: > > On Fri, 14 Dec 2018 at 15:22, Vincent Guittot > wrote: > > > > With jiffies been replaced by raw ns in PM core accounting, 915 driver is > > updated to use this new time infrastructure. > > &

[Intel-gfx] [PATCH v2 0/3] PM/pm_runtime: move on hrtimer and nsec

drm/i915 driver that uses PM core fields Changes since v1: - updated commit message of patch 1 - Added patches 2 & 3 to move runtime_pm accounting on raw ns Thara Gopinath (1): PM/runtime:Replace jiffies based accouting with ktime based accounting Vincent Guittot (2): PM/pm_runtime:

[Intel-gfx] [PATCH v2 3/3] drm/i915: Move to new PM core fields

With jiffies been replaced by raw ns in PM core accounting, 915 driver is updated to use this new time infrastructure. Signed-off-by: Vincent Guittot --- drivers/gpu/drm/i915/i915_pmu.c | 12 ++-- drivers/gpu/drm/i915/i915_pmu.h | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions

[Intel-gfx] [PATCH v2 1/3] PM/pm_runtime: move autosuspend on hrtimer

filename 133042996805276 402768 20512343138fe57 vmlinux Signed-off-by: Vincent Guittot --- drivers/base/power/runtime.c | 63 include/linux/pm.h | 5 ++-- include/linux/pm_runtime.h | 6 ++--- 3 files changed, 40

[Intel-gfx] [PATCH v2 2/3] PM/runtime:Replace jiffies based accouting with ktime based accounting

from ktime to raw nsec] Signed-off-by: Vincent Guittot --- drivers/base/power/runtime.c | 10 +- drivers/base/power/sysfs.c | 11 --- include/linux/pm.h | 6 +++--- 3 files changed, 16 insertions(+), 11 deletions(-) diff --git a/drivers/base/power/runtime.c b/drivers