[PATCH v2] drm/i915/slpc: Balance the inc/dec for num_waiters

4a82ceb04ad4 ("drm/i915/slpc: Add sysfs for SLPC power profiles") Cc: Sk Anirban Reviewed-by: Sk Anirban Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/intel_rps.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/in

[PATCH] drm/i915/slpc: Balance the inc/dec for num_waiters

the case min_softlimit is at boost freq. It ensures that we don't reduce the frequency while this request is in flight. Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13598 Cc: Sk Anirban Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/intel_rps.c | 14 +

[PATCH i-g-t 0/2] Add PMU test for GT frequency

This will validate PMU frequency attributes that have been added to the driver. Cc: Riana Tauro > Cc: Kamil Konieczny Signed-off-by: Vinay Belgaumkar Vinay Belgaumkar (2): lib/xe_gt: Move get/set GT freq utils to lib tests/xe_pmu: Add frequency test lib/xe/xe_gt.c |

[PATCH i-g-t 1/2] lib/xe_gt: Move get/set GT freq utils to lib

Add utils to get/set GT frequency attributes. These are per GT and exposed via sysfs already. v2: Review comments (Kamil) v3: Fix some more nits (Kamil) Reviewed-by: Kamil Konieczny Reviewed-by: Riana Tauro Cc: Kamil Konieczny Signed-off-by: Vinay Belgaumkar --- lib/xe/xe_gt.c

[PATCH i-g-t 2/2] tests/xe_pmu: Add frequency test

: Vinay Belgaumkar --- tests/intel/xe_pmu.c | 147 +++ 1 file changed, 147 insertions(+) diff --git a/tests/intel/xe_pmu.c b/tests/intel/xe_pmu.c index 175bbf374..589c7cbde 100644 --- a/tests/intel/xe_pmu.c +++ b/tests/intel/xe_pmu.c @@ -376,6 +376,94

[PATCH i-g-t 2/2] tests/xe_pmu: Add frequency test

Add a basic test that uses PMU to read GT actual and requested frequencies while running a workload. v2: Rebase and comments (Riana) v3: Address review comments (Kamil and Riana) Cc: Lucas De Marchi Cc: Rodrigo Vivi Cc: Riana Tauro Cc: Kamil Konieczny Signed-off-by: Vinay Belgaumkar

[PATCH i-g-t 1/2] lib/xe_gt: Move get/set GT freq utils to lib

Add utils to get/set GT frequency attributes. These are per GT and exposed via sysfs already. v2: Review comments (Kamil) Reviewed-by: Riana Tauro Cc: Kamil Konieczny Signed-off-by: Vinay Belgaumkar --- lib/xe/xe_gt.c | 61 ++ lib/xe/xe_gt.h | 2 + tests

[PATCH i-g-t 0/2] Add PMU test for GT frequency

This will validate PMU frequency attributes that have been added to the driver. Cc: Riana Tauro > Cc: Kamil Konieczny Signed-off-by: Vinay Belgaumkar Vinay Belgaumkar (2): lib/xe_gt: Move get/set GT freq utils to lib tests/xe_pmu: Add frequency test lib/xe/xe_gt.c |

[PATCH i-g-t 0/2] Add PMU test for GT frequency

This will validate PMU frequency attributes that have been added to the driver. Cc: Riana Tauro > Signed-off-by: Vinay Belgaumkar Vinay Belgaumkar (2): lib/xe_gt: Move get/set GT freq utils to lib tests/xe_pmu: Add frequency test lib/xe/xe_gt.c | 59 ++ lib

[PATCH i-g-t 2/2] tests/xe_pmu: Add frequency test

Add a basic test that uses PMU to read GT actual and requested frequencies while running a workload. v2: Rebase and comments (Riana) Cc: Lucas De Marchi Cc: Rodrigo Vivi Cc: Riana Tauro Signed-off-by: Vinay Belgaumkar --- tests/intel/xe_pmu.c | 128

[PATCH i-g-t 1/2] lib/xe_gt: Move get/set GT freq utils to lib

Add utils to get/set GT frequency attributes. These ar per GT and exposed via sysfs already. Reviewed-by: Riana Tauro Signed-off-by: Vinay Belgaumkar --- lib/xe/xe_gt.c | 59 ++ lib/xe/xe_gt.h | 2 + tests/intel/xe_gt_freq.c | 164

[PATCH i-g-t 2/2] tests/xe_pmu: Add frequency test

Add a basic test that uses PMU to read GT actual and requested frequencies while running a workload. Cc: Lucas De Marchi Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- tests/intel/xe_pmu.c | 93 1 file changed, 93 insertions(+) diff --git a

[PATCH i-g-t 0/2] Add PMU tests for GT frequency

Also move some frequency helpers to lib. Signed-off-by: Vinay Belgaumkar Vinay Belgaumkar (2): lib/xe_gt: Move get/set GT freq utils to lib tests/xe_pmu: Add frequency test lib/xe/xe_gt.c | 59 ++ lib/xe/xe_gt.h | 2 + tests/intel/xe_gt_freq.c | 164

[PATCH i-g-t 1/2] lib/xe_gt: Move get/set GT freq utils to lib

These can be used from other tests as well. Signed-off-by: Vinay Belgaumkar --- lib/xe/xe_gt.c | 59 ++ lib/xe/xe_gt.h | 2 + tests/intel/xe_gt_freq.c | 164 +++ 3 files changed, 125 insertions(+), 100 deletions(-) diff

[PATCH i-g-t v10 3/3] tests/xe/pmu: Add pmu tests for gt-c6

Marchi Cc: Riana Tauro Cc: Rodrigo Vivi Cc: Kamil Konieczny Reviewed-by: Riana Tauro Signed-off-by: Vinay Belgaumkar --- tests/intel/xe_pmu.c | 142 +++ tests/meson.build| 1 + 2 files changed, 143 insertions(+) create mode 100644 tests/intel

[PATCH i-g-t v10 2/3] lib/igt_perf: Add utils to extract PMU event info

Functions to parse event ID and GT bit shift for PMU events. v2: Review comments (Riana) v3: Review comments (Lucas) v4: Review comments (Kamil, Soham) Cc: Riana Tauro Cc: Lucas De Marchi Cc: Kamil Konieczny Cc: Rodrigo Vivi Reviewed-by: Riana Tauro Signed-off-by: Vinay Belgaumkar --- lib

[PATCH i-g-t v10 1/3] lib/igt_core: Add tolerance and measured_usleep utils

Add these redundant utils to core lib. Also fix the bug in measured_usleep, it was returning nsec slept not usec. v2: Updated perf_pmu and some failing tests. They were expecting nanosec instead of usec. v3: Update one more call to measured_usleep. Reviewed-by: Riana Tauro Signed-off-by: Vinay

[PATCH i-g-t v10 0/3] tests/intel/xe_pmu: Add PMU tests

Add utils and gt-c6 tests that utilize PMU counters. Cc: Riana Tauro Cc: Rodrigo Vivi Cc: Lucas De Marchi Signed-off-by: Vinay Belgaumkar Vinay Belgaumkar (3): lib/igt_core: Add tolerance and measured_usleep utils lib/igt_perf: Add utils to extract PMU event info tests/xe/pmu: Add pmu

[PATCH i-g-t v9 3/3] tests/xe/pmu: Add pmu tests for gt-c6

Marchi Cc: Riana Tauro Cc: Rodrigo Vivi Cc: Kamil Konieczny Reviewed-by: Riana Tauro Signed-off-by: Vinay Belgaumkar --- tests/intel/xe_pmu.c | 142 +++ tests/meson.build| 1 + 2 files changed, 143 insertions(+) create mode 100644 tests/intel

[PATCH i-g-t v9 2/3] lib/igt_perf: Add utils to extract PMU event info

Functions to parse event ID and GT bit shift for PMU events. v2: Review comments (Riana) v3: Review comments (Lucas) Cc: Riana Tauro Cc: Lucas De Marchi Cc: Kamil Konieczny Cc: Rodrigo Vivi Reviewed-by: Riana Tauro Signed-off-by: Vinay Belgaumkar --- lib/igt_perf.c | 70

[PATCH i-g-t v9 1/3] lib/igt_core: Add tolerance and measured_usleep utils

Add these redundant utils to core lib. Also fix the bug in measured_usleep, it was returning nsec slept not usec. v2: Updated perf_pmu and some failing tests. They were expecting nanosec instead of usec. v3: Update one more call to measured_usleep. Signed-off-by: Vinay Belgaumkar --- lib

[PATCH i-g-t v9 0/3] tests/intel/xe_pmu: Add PMU tests

Add utils and gt-c6 tests that utilize PMU counters. Cc: Riana Tauro Cc: Rodrigo Vivi Cc: Lucas De Marchi Signed-off-by: Vinay Belgaumkar Vinay Belgaumkar (3): lib/igt_core: Add tolerance and measured_usleep utils lib/igt_perf: Add utils to extract PMU event info tests/xe/pmu: Add pmu

[PATCH i-g-t v8 3/3] tests/xe/pmu: Add pmu tests for gt-c6

Marchi Cc: Riana Tauro Cc: Rodrigo Vivi Cc: Kamil Konieczny Reviewed-by: Riana Tauro Signed-off-by: Vinay Belgaumkar --- tests/intel/xe_pmu.c | 142 +++ tests/meson.build| 1 + 2 files changed, 143 insertions(+) create mode 100644 tests/intel

[PATCH i-g-t v8 1/3] lib/igt_core: Add tolerance and measured_usleep utils

Add these redundant utils to core lib. Also fix the bug in measured_usleep, it was returning nsec slept not usec. v2: Updated perf_pmu and some failing tests. They were expecting nanosec instead of usec. Signed-off-by: Vinay Belgaumkar --- lib/igt_core.c | 20

[PATCH i-g-t v8 2/3] lib/igt_perf: Add utils to extract PMU event info

Functions to parse event ID and GT bit shift for PMU events. v2: Review comments (Riana) v3: Review comments (Lucas) Cc: Riana Tauro Cc: Lucas De Marchi Cc: Kamil Konieczny Cc: Rodrigo Vivi Reviewed-by: Riana Tauro Signed-off-by: Vinay Belgaumkar --- lib/igt_perf.c | 70

[PATCH i-g-t v8 0/3] tests/intel/xe_pmu: Add PMU tests

Add utils and gt-c6 tests that utilize PMU counters. Cc: Riana Tauro Cc: Rodrigo Vivi Cc: Lucas De Marchi Signed-off-by: Vinay Belgaumkar Vinay Belgaumkar (3): lib/igt_core: Add tolerance and measured_usleep utils lib/igt_perf: Add utils to extract PMU event info tests/xe/pmu: Add pmu

[PATCH i-g-t v7 3/3] tests/xe/pmu: Add pmu tests for gt-c6

: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- tests/intel/xe_pmu.c | 149 +++ tests/meson.build| 1 + 2 files changed, 150 insertions(+) create mode 100644 tests/intel/xe_pmu.c diff --git a/tests/intel/xe_pmu.c b/tests/intel/xe_pmu.c new file mode

[PATCH i-g-t v7 2/3] lib/igt_perf: Add utils to extract PMU event info

Functions to parse event ID and GT bit shift for PMU events. v2: Review comments (Riana) v3: Review comments (Lucas) Cc: Riana Tauro Cc: Lucas De Marchi Cc: Kamil Konieczny Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- lib/igt_perf.c | 70

[PATCH i-g-t v7 1/3] lib/igt_core: Add tolerance and measured_usleep utils

Add these redundant utils to core lib. Also fix the bug in measured_usleep, it was returning nsec slept not usec. The only test which now uses the local version of measured_usleep is perf_pmu. Patch for that will be sent separately since it also needs some test changes. Signed-off-by: Vinay

[PATCH i-g-t v7 0/3] tests/intel/xe_pmu: Add PMU tests

Add utils and gt-c6 tests that utilize PMU counters. Cc: Riana Tauro Cc: Rodrigo Vivi Cc: Lucas De Marchi Signed-off-by: Vinay Belgaumkar Vinay Belgaumkar (3): lib/igt_core: Add tolerance and measured_usleep utils lib/igt_perf: Add utils to extract PMU event info tests/xe/pmu: Add pmu

[PATCH i-g-t v6 1/2] lib/igt_perf: Add utils to extract PMU event info

Functions to parse event ID and GT bit shift for PMU events. v2: Review comments (Riana) Cc: Riana Tauro Cc: Lucas De Marchi Cc: Kamil Konieczny Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- lib/igt_perf.c | 70 ++ lib/igt_perf.h | 2

[PATCH i-g-t v6 2/2] tests/xe/pmu: Add pmu tests

: Vinay Belgaumkar --- tests/intel/xe_pmu.c | 176 +++ tests/meson.build| 1 + 2 files changed, 177 insertions(+) create mode 100644 tests/intel/xe_pmu.c diff --git a/tests/intel/xe_pmu.c b/tests/intel/xe_pmu.c new file mode 100644 index 0

[PATCH i-g-t v6 0/2] tests/intel/xe_pmu: Add PMU tests

Add utils and gt-c6 tests that utilize PMU counters. Cc: Riana Tauro Cc: Rodrigo Vivi Cc: Lucas De Marchi Signed-off-by: Vinay Belgaumkar Vinay Belgaumkar (2): lib/igt_perf: Add utils to extract PMU event info tests/xe/pmu: Add pmu tests lib/igt_perf.c | 70

[PATCH i-g-t v5 2/2] tests/xe/pmu: Add pmu tests

Simple tests for validating the PMU implementation for GT C6 residencies. v2: Rename rc6-residency-* to gt-c6-residency and remove freq tests. v3: Keep just gt-c6 tests, add frequency tests later. Cc: Lucas De Marchi Cc: Riana Tauro Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- tests

[PATCH i-g-t v5 1/2] lib/igt_perf: Add utils to extract PMU event info

Functions to parse event ID and GT bit shift for PMU events. v2: Review comments (Riana) Cc: Riana Tauro Cc: Lucas De Marchi Cc: Kamil Konieczny Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- lib/igt_perf.c | 70 ++ lib/igt_perf.h | 2

[PATCH i-g-t v5 0/2] tests/intel/xe_pmu: Add PMU tests

Add utils and gt-c6 tests that utilize PMU counters. Cc: Riana Tauro Cc: Rodrigo Vivi Cc: Lucas De Marchi Signed-off-by: Vinay Belgaumkar Vinay Belgaumkar (2): lib/igt_perf: Add utils to extract PMU event info tests/xe/pmu: Add pmu tests lib/igt_perf.c | 70 lib

[PATCH i-g-t v4 1/2] lib/igt_perf: Add utils to extract PMU event info

Functions to parse event ID and GT bit shift for PMU events. Cc: Lucas De Marchi Cc: Kamil Konieczny Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- lib/igt_perf.c | 68 ++ lib/igt_perf.h | 2 ++ 2 files changed, 70 insertions(+) diff

[PATCH i-g-t v4 0/2] tests/intel/xe_pmu: Add PMU tests

Add utils and gt-c6 tests that utilize PMU counters. Cc: Rodrigo Vivi Cc: Lucas De Marchi Signed-off-by: Vinay Belgaumkar Vinay Belgaumkar (2): lib/igt_perf: Add utils to extract PMU event info tests/xe/pmu: Add pmu tests lib/igt_perf.c | 74 + lib/igt_perf.h

[PATCH i-g-t v4 2/2] tests/xe/pmu: Add pmu tests

, add frequency tests later. Cc: Lucas De Marchi Cc: Riana Tauro Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- lib/igt_perf.c | 8 +- lib/igt_perf.h | 2 + tests/intel/xe_pmu.c | 191 +++ tests/meson.build| 1 + 4 files changed

[PATCH v4] drm/i915/slpc: Add sysfs for SLPC power profiles

igo) Cc: Sushma Venkatesh Reddy Cc: Rodrigo Vivi Reviewed-by: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 47 ++ drivers/gpu/drm/i915/gt/intel_rps.c | 4 ++ .../drm/i915/gt/uc/abi/guc_actions_slpc_abi.h | 5 ++ driv

[PATCH v3] drm/i915/slpc: Add sysfs for SLPC power profiles

ned-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 47 + drivers/gpu/drm/i915/gt/intel_rps.c | 4 ++ .../drm/i915/gt/uc/abi/guc_actions_slpc_abi.h | 5 ++ drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 66 +++ drivers/gpu/drm/i

[PATCH v2] drm/i915/slpc: Add sysfs for SLPC power profiles

power_saving > slpc_power_profile $ cat slpc_power_profile base[power_saving] v2: Disable waitboost in power saving profile and updated sysfs format and add some kernel doc for SLPC (Rodrigo) Cc: Sushma Venkatesh Reddy Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i

[PATCH i-g-t v2 4/4] tools/gputop: Add GT freq and c6 stats

comments (Rodrigo, Kamil) Cc: Lucas De Marchi Cc: Kamil Konieczny Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- tools/gputop.c| 197 ++ tools/meson.build | 2 +- 2 files changed, 198 insertions(+), 1 deletion(-) diff --git a/tools/gputop.c b

[PATCH i-g-t v2 3/4] lib/igt_perf: Add utils to extract PMU event info

Functions to parse config ID and GT bit shift for PMU events. Cc: Kamil Konieczny Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- lib/igt_perf.c | 68 ++ lib/igt_perf.h | 2 ++ 2 files changed, 70 insertions(+) diff --git a/lib/igt_perf.c

[PATCH i-g-t v2 2/4] lib/igt_drm_clients: Add pdev and driver info

This will be used for gathering PMU event information. Cc: Rodrigo Vivi Cc: Lucas De Marchi Cc: Kamil Konieczny Signed-off-by: Vinay Belgaumkar This will be used for gathering PMU event information. Signed-off-by: Vinay Belgaumkar /igt_debugfs.c.orig --- lib/igt_drm_clients.c | 6

[PATCH i-g-t v2 1/4] tools/gputop: Define data structs for PMU stats

Prep work for adding PMU support in gputop. Cc: Rodrigo Vivi Cc: Lucas De Marchi Cc: Kamil Konieczny Signed-off-by: Vinay Belgaumkar --- tools/gputop.c | 28 1 file changed, 28 insertions(+) diff --git a/tools/gputop.c b/tools/gputop.c index 43b01f566..4e3663417

[PATCH i-g-t v2 0/4] tools/gputop: Add PMU stats

Use the PMU support being added in https://patchwork.freedesktop.org/series/139121/ to add freq/c6 stats. Cc: Rodrigo Vivi Cc: Lucas De Marchi Cc: Kamil Konieczny Signed-off-by: Vinay Belgaumkar Vinay Belgaumkar (4): tools/gputop: Define data structs for PMU stats lib/igt_drm_clients

[PATCH] drm/i915/slpc: Add sysfs for SLPC power profiles

Default SLPC power profile is Base(0). Power Saving mode(1) has conservative up/down thresholds and is suitable for use with apps that typically need to be power efficient. Cc: Sushma Venkatesh Reddy Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt

[PATCH i-g-t] tools/gputop: Add GT freq and c6 stats

: Vinay Belgaumkar --- lib/igt_drm_clients.c | 17 + lib/igt_drm_clients.h | 25 +++ lib/igt_perf.c| 57 +- lib/igt_perf.h| 2 + tools/gputop.c| 168 +- tools/intel_gpu_top.c | 18 + tools/meson.build

[PATCH i-g-t v3] tests/xe/pmu: Add pmu tests

read to igt_perf library. v3: Fix build errors. Cc: Riana Tauro Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- lib/igt_perf.c | 48 ++ lib/igt_perf.h | 3 + tests/intel/xe_pmu.c | 394 +++ tests/meson.build| 1 + 4 files

[PATCH i-g-t v2] tests/xe/pmu: Add pmu tests

read to igt_perf library. Cc: Riana Tauro Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- lib/igt_perf.c | 47 ++ lib/igt_perf.h | 3 + tests/intel/xe_pmu.c | 394 +++ tests/meson.build| 1 + 4 files changed, 445 insertions

[PATCH i-g-t] tests/xe/pmu: Add pmu tests

Simple tests for validating the PMU implementation for GT C6 residencies and frequency. These tests validate the kernel series which is currently in review here - https://patchwork.freedesktop.org/series/139121/ Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- lib/igt_perf.c | 18

[PATCH i-g-t] tests/xe_gt_freq: Use sync reset

Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2711 Cc: Badal Nilawar Signed-off-by: Vinay Belgaumkar --- tests/intel/xe_gt_freq.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/tests/intel/xe_gt_freq.c b/tests/intel/xe_gt_freq.c index

[PATCH v4 i-g-t] tests/xe_gt_freq: Avoid RPe usage in subtests

Cc: Riana Tauro Cc: Badal Nilawar Signed-off-by: Vinay Belgaumkar --- tests/intel/xe_gt_freq.c | 57 1 file changed, 40 insertions(+), 17 deletions(-) diff --git a/tests/intel/xe_gt_freq.c b/tests/intel/xe_gt_freq.c index 93ebb5ed0..c9d59508b 100644

[PATCH v3 i-g-t] tests/xe_gt_freq: Avoid RPe usage in subtests

://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2262 Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2256 Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2203 Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2412 Cc: Riana Tauro Cc: Badal Nilawar Signed-off-by: Vinay

[PATCH v2 i-g-t] tests/xe_gt_freq: Avoid RPe usage in subtests

://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2256 Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2203 Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2412 Cc: Riana Tauro Cc: Badal Nilawar Signed-off-by: Vinay Belgaumkar --- tests/intel/xe_gt_freq.c | 53

[PATCH i-g-t] tests/xe_gt_freq: Avoid RPe usage in subtests

Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2256 Signed-off-by: Vinay Belgaumkar --- tests/intel/xe_gt_freq.c | 37 + 1 file changed, 29 insertions(+), 8 deletions(-) diff --git a/tests/intel/xe_gt_freq.c b/tests/intel/xe_gt_freq.c index

[PATCH i-g-t v2] test/xe_gt_freq: Add helper to read RPe freq

://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1414 Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1829 Fixes: adcc68266b8e ("tests/intel/xe_gt_freq: Check for RPe freq updates") Reviewed-by: Badal Nilawar Signed-off-by: Vinay Belgaumkar --- tests/intel/xe_gt_f

[PATCH i-g-t] test/xe_gt_freq: Add helper to read RPe freq

We are seeing a possible switch in RPe right after RC6 wakeup. Ensure we obtain the latest RPe by reading it every time. Fixes: adcc68266b8e ("tests/intel/xe_gt_freq: Check for RPe freq updates") Signed-off-by: Vinay Belgaumkar --- tests/intel/xe_gt_f

[PATCH i-g-t] tests/intel/xe_gt_freq: Check for RPe freq updates

Pcode can dynamically update RPe frequency. Use the latest value in tests that check it. Signed-off-by: Vinay Belgaumkar --- tests/intel/xe_gt_freq.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/intel/xe_gt_freq.c b/tests/intel/xe_gt_freq.c index c12f6c52c..5c6373016 100644

[PATCH v4] drm/i915/guc: Use context hints for GT frequency

: Rodrigo Vivi Acked-by: Ivan Briano Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 16 -- .../gpu/drm/i915/gem/i915_gem_context_types.h | 1 + drivers/gpu/drm/i915/gt/intel_context_types.h | 1 + drivers/gpu/drm/i915/gt/intel_rps.c | 4

[PATCH v3] drm/i915/guc: Use context hints for GT frequency

as per review suggestions (Rodrigo, Tvrtko). Also, use flag bits in intel_context as it allows finer control for toggling per engine if needed (Tvrtko). v3: Minor review comments (Tvrtko) Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: Sushma Venkatesh Reddy Acked-by: Rodrigo Vivi Signed-off-by: Vinay

[PATCH v2] drm/i915/guc: Use context hints for GT freq

as per review suggestions (Rodrigo, Tvrtko). Also, use flag bits in intel_context as it allows finer control for toggling per engine if needed (Tvrtko). Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: Sushma Venkatesh Reddy Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gem

[PATCH] drm/i915/guc: Add Compute context hint

Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 8 +++ .../gpu/drm/i915/gem/i915_gem_context_types.h | 1 + drivers/gpu/drm/i915/gt/intel_rps.c | 8 +++ .../drm/i915/gt/uc/abi/guc_actions_slpc_abi.h | 21 +++ drivers/gpu/drm/i915

[PATCH v2] drm/i915/mtl: Wake GT before sending H2G message

official WA soon so adding a FIXME in the comments. v2: Make the new ranges watertight to address BAT failures and update commit message (Matt R). Reviewed-by: Matt Roper Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/intel_uncore.c | 5 - 1 file changed, 4 insertions(+), 1 deletion

[PATCH] drm/i915/mtl: Wake GT before sending H2G message

form sleep states and a H2G is triggered. A forcewake ensures those sleep states have been fully exited and further processing occurs as expected. This will have an official WA soon so adding a FIXME in the comments. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/intel_uncore.c | 5 +++

[PATCH i-g-t] tests/perf_pmu: Set defaults before frequency test

subtest at the end expects drm-fd to be closed. Also setup expected frequencies (Kamil) and address other nits (Kamil) Link: https://gitlab.freedesktop.org/drm/intel/-/issues/9432 Cc: Kamil Konieczny Signed-off-by: Vinay Belgaumkar --- tests/intel/perf_pmu.c | 62

[PATCH i-g-t] tests/perf_pmu: Restore sysfs freq in exit handler

Seeing random issues where this test starts with invalid values. Ensure that we restore the frequencies in case test exits early due to some system issues. Link: https://gitlab.freedesktop.org/drm/intel/-/issues/9432 Signed-off-by: Vinay Belgaumkar --- tests/intel/perf_pmu.c | 53

[Intel-gfx] [PATCH] drm/i915: Read a shadowed mmio register for ggtt flush

We read RENDER_HEAD as a part of the flush. If GT is in deeper sleep states, this could lead to read errors since we are not using a forcewake. Safer to read a shadowed register instead. Cc: John Harrison Cc: Daniele Ceraolo Spurio Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt

[Intel-gfx] [PATCH] drm/i915: Initialize residency registers earlier

tions") Suggested-by: Alan Previn Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/intel_rc6.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i915/gt/intel_rc6.c index 7090e4be29cb..58dc0dab9b64 10

[Intel-gfx] [PATCH v2] drm/i915/mtl: Don't set PIPE_CONTROL_FLUSH_L3

: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/gen8_engine_cs.c b/drivers/gpu/drm/i915/gt/gen8_engine_cs.c index ba4c2422b340..86a04afff64b 100644 --- a/drivers/gpu/drm/i915/gt

[Intel-gfx] [PATCH] drm/i915/mtl: Don't set PIPE_CONTROL_FLUSH_L3

This bit does not cause an explicit L3 flush. We already use PIPE_CONTROL_DC_FLUSH_ENABLE for that purpose. Cc: Nirmoy Das Cc: Mikka Kuoppala Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[Intel-gfx] [PATCH] drm/i915/gem: Allow users to disable waitboost

://github.com/XinfengZhang/libva/commit/3d90d18c67609a73121bb71b20ee4776b54b61a7 Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 9 ++--- drivers/gpu/drm/i915/i915_request.c | 3 ++- drivers/gpu/drm/i915/i915_request.h | 1 + include

[Intel-gfx] [PATCH i-g-t] tests/i915_pm_freq_api: Set min/max to expected values

A prior(rps) test leaves the system in a bad state causing failures in the basic test. Set min/max to expected values before running it. Test will restore values at the end. Link: https://gitlab.freedesktop.org/drm/intel/-/issues/8670 Signed-off-by: Vinay Belgaumkar --- tests/intel

[Intel-gfx] [PATCH i-g-t] tests/i915_pm_freq_api: Test s2idle instead of S3

Test skips whenever S3 is not supported, use s2idle instead, which is widely enabled. Cc: Anshuman Gupta Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_pm_freq_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/i915/i915_pm_freq_api.c b/tests/i915

[Intel-gfx] [PATCH v4 i-g-t] tests/i915_pm_freq_api: Ignore zero register value

: https://gitlab.freedesktop.org/drm/intel/issues/8736 Link: https://gitlab.freedesktop.org/drm/intel/issues/8989 Reviewed-by: Riana Tauro Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_pm_freq_api.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/tests

[Intel-gfx] [PATCH v3 i-g-t] tests/i915_pm_freq_api: Ignore zero register value

: https://gitlab.freedesktop.org/drm/intel/issues/8989 Reviewed-by: Riana Tauro Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_pm_freq_api.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/tests/i915/i915_pm_freq_api.c b/tests/i915/i915_pm_freq_api.c

[Intel-gfx] [PATCH v2 i-g-t] tests/i915_pm_freq_api: Ignore zero register value

Register read for requested_freq can return 0 when system is in runtime_pm. Make allowance for this case. v2: Explicit check for runtime_pm status (Riana) Link: https://gitlab.freedesktop.org/drm/intel/issues/8736 Link: https://gitlab.freedesktop.org/drm/intel/issues/8989 Signed-off-by: Vinay

[Intel-gfx] [PATCH i-g-t] tests/i915_pm_freq_api: Ignore zero register value

Register read for requested_freq can return 0 when system is in runtime_pm. Make allowance for this case. Link: https://gitlab.freedesktop.org/drm/intel/issues/8736 Link: https://gitlab.freedesktop.org/drm/intel/issues/8989 Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_pm_freq_api.c | 18

[Intel-gfx] [PATCH v2] drm/i915/guc/slpc: Restore efficient freq earlier

2a1e4 ("drm/i915/guc/slpc: Allow SLPC to use efficient frequency") Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 22 + 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_s

[Intel-gfx] [PATCH] drm/i915/guc/slpc: Restore efficient freq earlier

p.org/drm/intel/-/issues/8736 Fixes: 55f9720dbf23 ("drm/i915/guc/slpc: Provide sysfs for efficient freq") Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_

[Intel-gfx] [PATCH v3 i-g-t] i915_pm_freq_api: Add some debug to tests

Dixit Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_pm_freq_api.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/tests/i915/i915_pm_freq_api.c b/tests/i915/i915_pm_freq_api.c index 522abee35..a7bbd4896 100644 --- a/tests/i915/i915_pm_freq_api.c +++ b

[Intel-gfx] [PATCH v2 i-g-t] i915_pm_freq_api: Add some debug to tests

Some subtests seem to be failing in CI, use igt_assert_(lt/eq) which print the values being compared and some additional debug as well. v2: Print GT as well (Ashutosh) Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_pm_freq_api.c | 18 -- 1 file changed, 8 insertions(+), 10

[Intel-gfx] [PATCH i-g-t] i915_pm_freq_api: Add some debug to tests

Some subtests seem to be failing in CI, use igt_assert_(lt/eq) which print the values being compared and some additional debug as well. Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_pm_freq_api.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/tests

[Intel-gfx] [PATCH v2] drm/i915/guc: Dump perf_limit_reasons for debug

GuC load takes longer sometimes due to GT frequency not ramping up. Add perf_limit_reasons to the existing warn print to see if frequency is being throttled. v2: Review comments (Ashutosh) Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 8 +--- 1 file

[Intel-gfx] [PATCH] drm/i915/guc: Dump perf_limit_reasons for debug

GuC load takes longer sometimes due to GT frequency not ramping up. Add perf_limit_reasons to the existing warn print to see if frequency is being throttled. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[Intel-gfx] [PATCH v2] drm/i915/guc/slpc: Apply min softlimit correctly

should restore the cached min freq (via H2G) for it to take effect. v2: Clarify commit message (Ashutosh) Fixes: 95ccf312a1e4 ("drm/i915/guc/slpc: Allow SLPC to use efficient frequency") Reviewed-by: Ashutosh Dixit Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_

[Intel-gfx] [PATCH v3 i-g-t] tests/i915_pm_freq_api: Add a suspend subtest

init. Also, disable efficient freq before starting the test which allows current freq to be consistent with SLPC min freq. v2: Restore freq in exit handler (Ashutosh) v3: Free the allocated stash arrays Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_pm_freq_api.c | 92

[Intel-gfx] [PATCH v2 i-g-t] tests/i915_pm_freq_api: Add a suspend subtest

init. Also, disable efficient freq before starting the test which allows current freq to be consistent with SLPC min freq. v2: Restore freq in exit handler (Ashutosh) Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_pm_freq_api.c | 89 +++ 1 file changed, 69

[Intel-gfx] [PATCH] drm/i915/guc/slpc: Apply min softlimit correctly

c: Allow SLPC to use efficient frequency") Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c index

[Intel-gfx] [PATCH v2 i-g-t] tests/gem_ctx_persistence: Skip hang subtest with GuC

Hang scenarios are not supported with persistent contexts when GuC submission is enabled. Cc: Kamil Konieczny Reviewed-by: Andrzej Hajda Signed-off-by: Vinay Belgaumkar --- tests/i915/gem_ctx_persistence.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/i915/gem_ctx_persistence.c

[Intel-gfx] [PATCH i-g-t] tests/gem_ctx_persistence: Skip hang subtest with GuC

Hang subtest is not supported with GuC submission enabled. Cc: Kamil Konieczny Signed-off-by: Vinay Belgaumkar --- tests/i915/gem_ctx_persistence.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/i915/gem_ctx_persistence.c b/tests/i915/gem_ctx_persistence.c index df9b1c491

[Intel-gfx] [PATCH i-g-t] tests/i915_pm_freq_api: Add a suspend subtest

Verify that SLPC API works as expected after a suspend. Signed-off-by: Vinay Belgaumkar --- tests/i915/i915_pm_freq_api.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/tests/i915/i915_pm_freq_api.c b/tests/i915/i915_pm_freq_api.c index 9005cd220..f35f1f8e0

[Intel-gfx] [PATCH i-g-t] tests/i915/gem_ctx_persistence: Skip some subtests

Hang and heartbeat subtests are not supported with GuC submission enabled. Signed-off-by: Vinay Belgaumkar --- tests/i915/gem_ctx_persistence.c | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/tests/i915/gem_ctx_persistence.c b/tests/i915

[Intel-gfx] [PATCH] drm/i915/guc/slpc: Disable rps_boost debugfs

://gitlab.freedesktop.org/drm/intel/-/issues/7632 Reviewed-by: Ashutosh Dixit Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 5 - drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 2 ++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt

[Intel-gfx] [PATCH] drm/i915/guc/slpc: Disable rps_boost debugfs

rps_boost debugfs shows host turbo related info. This is not valid when SLPC is enabled. guc_slpc_info already shows the number of boosts. Add num_waiters there as well and disable rps_boost when SLPC is enabled. Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/7632 Signed-off-by: Vinay

[Intel-gfx] [PATCH v6 2/2] drm/i915/selftest: Update the SLPC selftest

Use the new efficient frequency toggling interface. Also create a helper function to restore the frequencies after the test is done. v2: Restore max freq first and then min. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/selftest_slpc.c | 42 ++--- 1 file

[Intel-gfx] [PATCH v6 1/2] drm/i915/guc/slpc: Provide sysfs for efficient freq

) v4: Toggle efficient freq usage in SLPC selftest and checkpatch fixes v5: Review comments (Andi) and add a separate patch for selftest updates Fixes: 95ccf312a1e4 ("drm/i915/guc/slpc: Allow SLPC to use efficient frequency") Signed-off-by: Vinay Belgaumkar Reviewed-by: Rodrigo Vivi Revi

[Intel-gfx] [PATCH i-g-t 3/4] i915_pm_freq_api: Add some basic SLPC igt tests

SLPC is disabled. Check for enable_guc is not sufficient as kernel config may have it but the platform doesn't actually support it. v5: Use the updated SLPC helper v6: Check for guc enabled as well as slpc debugfs Reviewed-by: Ashutosh Dixit Cc: Rodrigo Vivi Signed-off-by: Vinay Belga

[Intel-gfx] [PATCH i-g-t 4/4] HAX: tests/i915: Try out the SLPC IGT tests

Trying out for CI. Do not review. Signed-off-by: Vinay Belgaumkar --- tests/intel-ci/fast-feedback.testlist | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist index d9fcb62d..653668dd 100644 --- a/tests/intel-ci

  1   2   3   4   >