ncs->set_crc_source(crtc, NULL);
err:
spin_lock_irq(&crc->lock);
crtc_crc_cleanup(crc);
Adding Tomeu Vizoso to the cc.
Can you resend the series, and add dri-de...@lists.freedesktop.org and the
driver maintainers to the cc? You'll need to get acks from the main
On 26 December 2017 at 19:19, Matt Roper wrote:
> On Wed, Dec 20, 2017 at 10:59:57AM +0100, Daniel Vetter wrote:
>> On Tue, Dec 19, 2017 at 03:27:31PM -0800, Dongwon Kim wrote:
>> > I forgot to include this brief information about this patch series.
>> >
>> > This patch series contains the impleme
Looks good to me:
Reviewed-by: Tomeu Vizoso
I guess you have tested this with IGT? In any case, I think it would
be good to mention how a patch has been tested in the changelog. That
can be very useful to others if things go wrong at some point.
Thanks,
Tomeu
On 21 June 2017 at 13:00
Thanks for doing this.
Reviewed-by: Tomeu Vizoso
On 22 March 2017 at 09:36, Daniel Vetter wrote:
> This was missed in Tomeu's patch. Also remove the kerneldoc for the
> internal function, we don't document that in general.
>
> While at it word-smith the docs slightly fo
missed previously
- use the minor of the device for the debugfs path, not the major
- have a proper exit handler for calling igt_hpd_storm_reset with the
right device fd.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Robert Foss
---
benchmarks/gem_latency.c | 2 +-
lib
Some frame sources such as sinks aren't able to provide meaningful frame
numbers, so in those cases just skip the TEST_SEQUENCE tests.
v2: Rebased
Signed-off-by: Tomeu Vizoso
---
tests/kms_pipe_crc_basic.c | 28 ++--
1 file changed, 22 insertions(+), 6 dele
When opening a DRM debugfs file, locate the right path based on the
given DRM device FD.
This is needed so, in setups with more than one DRM device, any
operations on debugfs files affect the expected DRM device.
v2: rebased and fixed new API additions
Signed-off-by: Tomeu Vizoso
Reviewed-by
Some frame sources such as sinks aren't able to provide meaningful frame
numbers, so in those cases just skip the TEST_SEQUENCE tests.
v2: Rebased
Signed-off-by: Tomeu Vizoso
---
tests/kms_pipe_crc_basic.c | 28 ++--
1 file changed, 22 insertions(+), 6 dele
Some frame sources such as sinks aren't able to provide meaningful frame
numbers, so in those cases just skip the TEST_SEQUENCE tests.
Signed-off-by: Tomeu Vizoso
---
tests/kms_pipe_crc_basic.c | 29 +++--
1 file changed, 23 insertions(+), 6 deletions(-)
diff --
When opening a DRM debugfs file, locate the right path based on the
given DRM device FD.
This is needed so, in setups with more than one DRM device, any
operations on debugfs files affect the expected DRM device.
Signed-off-by: Tomeu Vizoso
---
Guess we could be more conservative and just
On 2 March 2017 at 14:46, Chris Wilson wrote:
> On Thu, Mar 02, 2017 at 02:39:16PM +0100, Tomeu Vizoso wrote:
>> On 2 March 2017 at 11:12, Chris Wilson wrote:
>> > On Thu, Mar 02, 2017 at 11:08:25AM +0100, Tomeu Vizoso wrote:
>> >> Instead of checking for "i91
On 2 March 2017 at 11:12, Chris Wilson wrote:
> On Thu, Mar 02, 2017 at 11:08:25AM +0100, Tomeu Vizoso wrote:
>> Instead of checking for "i915_error_state" within dri/N/, check for
>> "name".
>>
>> This allows more tests to run against drivers
Some frame sources such as sinks aren't able to provide meaningful frame
numbers, so in those cases just skip the TEST_SEQUENCE tests.
Signed-off-by: Tomeu Vizoso
---
tests/kms_pipe_crc_basic.c | 29 +++--
1 file changed, 23 insertions(+), 6 deletions(-)
diff --
Instead of checking for "i915_error_state" within dri/N/, check for
"name".
This allows more tests to run against drivers other than i915.
Signed-off-by: Tomeu Vizoso
---
lib/igt_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/igt_debugfs.c
bug.cgi?id=99869
Signed-off-by: Tomeu Vizoso
---
drivers/gpu/drm/drm_edid.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 24e7b282f16c..d994ccf94f88 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -148,6
Patch looks good to me, but I think the signal changes should be in
their own commit.
On 7 February 2017 at 16:12, Maarten Lankhorst
wrote:
...
> +#define VG(x) x
> +#else
> +#define VG(x)
> +#endif
Wouldn't be better to stub VALGRIND_MAKE_MEM_DEFINED instead?
Regards,
Tomeu
__
s and calculates an acceptable difference taking into account
the vertical refresh rate of the current mode.
Signed-off-by: Tomeu Vizoso
References: https://bugs.freedesktop.org/show_bug.cgi?id=98289
---
tests/kms_flip.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff
On 10 January 2017 at 17:31, Daniel Vetter wrote:
> On Tue, Jan 10, 2017 at 05:54:57PM +0200, Ville Syrjälä wrote:
>> On Tue, Jan 10, 2017 at 02:43:05PM +0100, Tomeu Vizoso wrote:
>> > Use drm_accurate_vblank_count so we have the full 32 bit to represent
>> > the frame
Use drm_accurate_vblank_count so we have the full 32 bit to represent
the frame counter and userspace has a simpler way of knowing when the
counter wraps around.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
Reviewed-by: Robert Foss
---
drivers/gpu/drm/i915/i915_irq.c | 6 +++---
1
the new ABI we
skip the 1st or 2nd frames.
v9:
- Add stub for intel_crtc_set_crc_source.
v12:
- Rebased.
- Remove stub for intel_crtc_set_crc_source and instead set the
callback to NULL (Jani Nikula).
v15:
- Rebased.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil
Hi,
here are the last two patches that remain to be merged in this series,
rebased on today's drm-tip.
Thanks,
Tomeu
Tomeu Vizoso (2):
drm/i915: Use new CRC debugfs API
drm/i915: Put "cooked" vlank counters in frame CRC lines
drivers/gpu/drm/i915/i915_drv.h | 1 +
As bytes_read can contain an error condition under some circumstances,
in which we want to error out.
Signed-off-by: Tomeu Vizoso
---
lib/igt_debugfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c
index d828687a62ca..b1b67e740041 100644
--- a/lib
Use drm_accurate_vblank_count so we have the full 32 bit to represent
the frame counter and userspace has a simpler way of knowing when the
counter wraps around.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
Reviewed-by: Robert Foss
---
drivers/gpu/drm/i915/i915_irq.c | 6 +++---
1
the new ABI we
skip the 1st or 2nd frames.
v9:
- Add stub for intel_crtc_set_crc_source.
v12:
- Rebased.
- Remove stub for intel_crtc_set_crc_source and instead set the
callback to NULL (Jani Nikula).
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
Reviewed-by: R
could be dropped if it's preferred that userspace waits
for the first frame CRC to come before assuming that the HW is ready.
The other patches are unchanged.
Thanks,
Tomeu
Tomeu Vizoso (4):
drm: Move locking into drm_debugfs_crtc_crc_add
drm: crc: Wait for a frame before returning
mp;validation stuff together and give the CRC
>> section a heading for prettier output.
>>
>> Cc: Tomeu Vizoso
>> Cc: Jani Nikula
>> Signed-off-by: Daniel Vetter
>> ---
>> Documentation/gpu/drm-uapi.rst | 25 +++--
>> 1 file cha
the new ABI we
skip the 1st or 2nd frames.
v9:
- Add stub for intel_crtc_set_crc_source.
v12:
- Rebased.
- Remove stub for intel_crtc_set_crc_source and instead set the
callback to NULL (Jani Nikula).
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/g
Use drm_accurate_vblank_count so we have the full 32 bit to represent
the frame counter and userspace has a simpler way of knowing when the
counter wraps around.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/i915_irq.c | 6 +++---
1 file changed, 3 insertions
Hi,
here are the patches that remain to be merged in this series.
I have only rebased them since last time.
Thanks,
Tomeu
Tomeu Vizoso (3):
drm: Move locking into drm_debugfs_crtc_crc_add
drm/i915: Use new CRC debugfs API
drm/i915: Put "cooked" vlank counters in frame
intel_display_crc_init accept a drm_i915_private instead.
v12: Rebased.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/Makefile | 2 +-
drivers/gpu/drm/i915/i915_debugfs.c | 882 +--
drivers/gpu/drm/i915/intel_drv.h | 5 +
drivers
ris Wilson
Cc: Tomi Sarvela
Cc: intel-gfx@lists.freedesktop.org
Signed-off-by: Tomeu Vizoso
---
drivers/gpu/drm/drm_edid.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 6798c3ad9d53..db79bc949216 10
On 7 December 2016 at 20:56, Lyude Paul wrote:
> On Wed, 2016-12-07 at 12:27 +0100, Tomeu Vizoso wrote:
>> On 1 December 2016 at 02:24, Lyude wrote:
(big snip)
>> > + * By default, this file is expected to exist in
>> > ~/.igt_chamelium_rc . The
>> > + * di
Hi Lyude,
this looks very good. Some minor comments below.
Regards,
Tomeu
On 1 December 2016 at 02:24, Lyude wrote:
> For the purpose of testing things such as hotplugging and bad monitors,
> the ChromeOS team ended up designing a neat little device known as the
> Chamelium. More information o
On 21 November 2016 at 23:32, Lyude wrote:
> On certain models of nvidia and AMD GPUs, we can have a primary plane
> without any DRM plane for the cursor plane. Check for this so we don't
> segfault on non-intel hardware.
>
> Signed-off-by: Lyude
> ---
> lib/igt_kms.c | 27 +++---
On 21 November 2016 at 23:32, Lyude wrote:
> Unfortunately the assumption that we only have 6 display pipes available
> is specific to Intel, and seems to be breaking igt_display_init() on
> both radeon and nouveau since this causes us not to leave enough space
> in the igt_display_t struct to hol
So that debug logs contain the unexpected value.
Signed-off-by: Tomeu Vizoso
---
lib/igt_kms.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 989704e14803..1e30ddcc5373 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -1681,7 +1681,7
Add a few subtests that check that lossless compressed render targets
are properly displayed. Also test a few error conditions.
Cc: Ville Syrjälä
Cc: Ben Widawsky
Signed-off-by: Tomeu Vizoso
---
Hi,
this has been tested with Ville's branch at:
https://github.com/vsyrjala/linux
This series has my Reviewed-by tag with the small issues I pointed out
addressed. But I think it would be very good if you could go through
all the igt_assert* calls and make sure that no information is being
lost that could aid in triaging and debugging.
The messages you chose for igt_assert_f we
On 22 November 2016 at 14:28, wrote:
> From: Robert Foss
>
> This subtest verifies the access ordering of multiple consumer threads.
>
> Signed-off-by: Robert Foss
> Reviewed-by: Eric Engestrom
> ---
> tests/sw_sync.c | 103
>
> 1 file
Hi Robert,
looks pretty good to me, have just found a few nits.
With those addressed:
Reviewed-by: Tomeu Vizoso
Regards,
Tomeu
On 22 November 2016 at 14:28, wrote:
> From: Robert Foss
>
> Base functions to help testing the Sync File Framework (explicit fencing
> mechanism
The kernel has now a new debugfs ABI that can also allow capturing frame
CRCs for drivers other than i915.
Add alternative codepaths so the new ABI is used if the kernel is recent
enough, and fall back to the legacy ABI if not.
Signed-off-by: Tomeu Vizoso
---
Hi,
this has been rebased so
intel_display_crc_init accept a drm_i915_private instead.
v12: Rebased.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/Makefile | 2 +-
drivers/gpu/drm/i915/i915_debugfs.c | 882 +--
drivers/gpu/drm/i915/intel_drv.h | 5 +
drivers
the new ABI we
skip the 1st or 2nd frames.
v9:
- Add stub for intel_crtc_set_crc_source.
v12:
- Rebased.
- Remove stub for intel_crtc_set_crc_source and instead set the
callback to NULL (Jani Nikula).
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/g
Tomeu Vizoso (4):
drm/i915/debugfs: Move out pipe CRC code
drm: Move locking into drm_debugfs_crtc_crc_add
drm/i915: Use new CRC debugfs API
drm/i915: Put "cooked" vlank counters in frame CRC lines
drivers/gpu/drm/drm_debugfs_crc.c |9 +-
drivers/gpu/drm/i915/Makefile
Use drm_accurate_vblank_count so we have the full 32 bit to represent
the frame counter and userspace has a simpler way of knowing when the
counter wraps around.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/i915_irq.c | 6 +++---
1 file changed, 3 insertions
ke machine with just one overlay.
Signed-off-by: Tomeu Vizoso
---
lib/igt_kms.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 989704e14803..3234fa1bbdc4 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -1670,6 +16
(printing the supported formats), and skip the test if there
aren't enough overlay planes.
Thanks,
Tomeu
Tomeu Vizoso (2):
lib: Check format of framebuffer before SetPlane
kms_plane_scaling: Skip if we don't have enough overlays
lib/igt_kms.c
The test currently assumes that there are two overlay planes available,
but that's not generally true and from the error that returns the
kernel, it isn't obvious what's going on.
Signed-off-by: Tomeu Vizoso
---
tests/kms_plane_scaling.c | 4
1 file changed, 4 insertions(+
> ---
> tests/kms_flip.c | 212
> +++
> 1 file changed, 26 insertions(+), 186 deletions(-)
Looks good to me.
Reviewed-by: Tomeu Vizoso
Cheers,
Tomeu
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index 2a9fe2e..437
Looks good to me.
Reviewed-by: Tomeu Vizoso
Cheers,
Tomeu
On 21 November 2016 at 10:25, Abdiel Janulgue
wrote:
> v7: Adapt to api rename
> v8: Tidy up finish_fb_busy (Chris Wilson)
>
> Cc: Chris Wilson
> Cc: Daniel Vetter
> Signed-off-by: Abdiel Janulgue
> ---
>
: Daniel Vetter
> Cc: Tomeu Vizoso
> Signed-off-by: Abdiel Janulgue
> ---
> tests/gem_wait.c | 126
> ---
> 1 file changed, 7 insertions(+), 119 deletions(-)
Looks good to me.
Reviewed-by: Tomeu Vizoso
Cheers,
Tomeu
efines
> Minor code cleanups.
> Rename igt_spin_batch and igt_post_spin_batch to
> igt_spin_batch_new and igt_spin_batch_free
> respectively (Tomeu Vizoso).
> Fix error in dependency relocation handling in HSW causing
> tests to fail.
> v8: Restore correct
On 21 November 2016 at 10:25, Abdiel Janulgue
wrote:
> More and more test-cases are using this.
>
> Signed-off-by: Abdiel Janulgue
> ---
> lib/igt_aux.c | 11 ---
> lib/igt_aux.h | 10 ++
> lib/igt_core.c | 3 ---
> tests/drv_hangman.c | 1 -
> 4 files changed,
On 21 November 2016 at 10:25, Abdiel Janulgue
wrote:
> v7: Adapt to api rename
> v8: Restore sanitycheck wait on the recursive batch and
> avoid using C99 locals (Chris Wilson)
>
> Cc: Chris Wilson
> Cc: Daniel Vetter
> Signed-off-by: Abdiel Janulgue
> ---
> tests/gem_wait.c | 128
> -
The kernel has now a new debugfs ABI that can also allow capturing frame
CRCs for drivers other than i915.
Add alternative codepaths so the new ABI is used if the kernel is recent
enough, and fall back to the legacy ABI if not.
Signed-off-by: Tomeu Vizoso
---
Have just rebased this, and made
Tomeu Vizoso (4):
drm/i915/debugfs: Move out pipe CRC code
drm: Move locking into drm_debugfs_crtc_crc_add
drm/i915: Use new CRC debugfs API
drm/i915: Put "cooked" vlank counters in frame CRC lines
drivers/gpu/drm/drm_debugfs_crc.c |9 +-
drivers/gpu/drm/i915/Makefile
the new ABI we
skip the 1st or 2nd frames.
v9:
- Add stub for intel_crtc_set_crc_source.
v12:
- Rebased.
- Remove stub for intel_crtc_set_crc_source and instead set the
callback to NULL (Jani Nikula).
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/g
intel_display_crc_init accept a drm_i915_private instead.
v12: Rebased.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/Makefile | 2 +-
drivers/gpu/drm/i915/i915_debugfs.c | 882 +--
drivers/gpu/drm/i915/intel_drv.h | 5 +
drivers
Use drm_accurate_vblank_count so we have the full 32 bit to represent
the frame counter and userspace has a simpler way of knowing when the
counter wraps around.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/i915_irq.c | 6 +++---
1 file changed, 3 insertions
On 16 November 2016 at 13:58, Jani Nikula wrote:
> On Wed, 16 Nov 2016, Tomeu Vizoso wrote:
>> On 15 November 2016 at 09:27, Jani Nikula
>> wrote:
>>> On Tue, 15 Nov 2016, David Weinehall wrote:
>>>> On Mon, Nov 14, 2016 at 12:44:25PM +0200, Jani Nikula wro
On 15 November 2016 at 09:27, Jani Nikula wrote:
> On Tue, 15 Nov 2016, David Weinehall wrote:
>> On Mon, Nov 14, 2016 at 12:44:25PM +0200, Jani Nikula wrote:
>>> On Thu, 06 Oct 2016, Tomeu Vizoso wrote:
>>> > diff --git a/drivers/gpu/drm/i915/intel_display.c
On 15 November 2016 at 22:44, Lyude Paul wrote:
> I'm fine with libsoup as well, I'll check it out and probably move all
> of the code over to using that instead.
Cool.
> On Tue, 2016-11-15 at 12:44 +0100, Tomeu Vizoso wrote:
>> On 11 November 2016 at 18:53, Lyude Paul
On 15 November 2016 at 09:01, Daniel Vetter wrote:
> On Mon, Nov 14, 2016 at 06:59:16PM +0900, Gustavo Padovan wrote:
>> From: Gustavo Padovan
>>
>> Signed-off-by: Gustavo Padovan
>> ---
>> tests/kms_atomic_transition.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a
liked it mostly because we already depend on glib.
> On Wed, 2016-11-09 at 16:09 +0100, Tomeu Vizoso wrote:
>> Hi Lyude,
>>
>> I think this looks very good.
>>
>> On 8 November 2016 at 01:05, Lyude wrote:
>> >
>> >
>> > - Whi
On 15 November 2016 at 11:59, Tomeu Vizoso wrote:
> On 14 November 2016 at 19:24, Abdiel Janulgue
> wrote:
>> A lot of igt testcases need some GPU workload to make sure a race
>> window is big enough. Unfortunately having a fixed amount of
>> workload leads to spurious
On 14 November 2016 at 19:24, Abdiel Janulgue
wrote:
> A lot of igt testcases need some GPU workload to make sure a race
> window is big enough. Unfortunately having a fixed amount of
> workload leads to spurious test failures or overtly long runtimes
> on some fast/slow platforms. This library co
Hi Abdiel,
here running the whole of kms_busy causes all subtests after the first
one to be skipped due to:
Test requirement not met in function __real_main164, file
../../intel-gpu-tools/tests/kms_busy.c:195:
Test requirement: gem_has_ring(display.drm_fd, e->exec_id | e->flags)
If I run the sub
The kernel expects that BOs for framebuffers with
I915_FORMAT_MOD_Yf_TILED will have I915_TILING_NONE.
Fixes: 050c00d53f39 ("lib: Pass I915_TILING_Y to the kernel if Yf or Ys")
Cc: Tvrtko Ursulin
Signed-off-by: Tomeu Vizoso
---
lib/ioctl_wrappers.c | 3 ++-
1 file changed, 2 insert
On 11 November 2016 at 12:33, Tvrtko Ursulin
wrote:
>
> On 11/11/2016 11:23, Tomeu Vizoso wrote:
>>
>> On 11/10/2016 05:23 PM, Tvrtko Ursulin wrote:
>>>
>>>
>>> On 10/11/2016 13:17, Tomeu Vizoso wrote:
>>>>
>>>> On 1 Nov
On 11/10/2016 05:23 PM, Tvrtko Ursulin wrote:
>
> On 10/11/2016 13:17, Tomeu Vizoso wrote:
>> On 1 November 2016 at 16:44, Tvrtko Ursulin wrote:
>>>
>>> Hi,
>>>
>>>
>>>
>>> On 02/03/16 14:00, Tomeu Vizoso wrote:
>>>
On 1 November 2016 at 16:44, Tvrtko Ursulin wrote:
>
> Hi,
>
>
>
> On 02/03/16 14:00, Tomeu Vizoso wrote:
>>
>> igt_create_bo_with_dimensions() is intended to abstract differences
>> between drivers in buffer object creation.
>>
>> The driver-spec
Though right now modifiers are only used to specify tiling, there are
different constants for them and naming them differently should help
with not mixing them.
Signed-off-by: Tomeu Vizoso
---
lib/igt_fb.c| 83 +++--
lib/igt_fb.h
GEM_SET_TILING doesn't care about Yf or Ys, so just pass Y.
Signed-off-by: Tomeu Vizoso
---
lib/ioctl_wrappers.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
index 95bc5e268bcd..eabf3ee3abe6 100644
--- a/lib/ioctl_wrappers.c
+++
We were passing in two places a framebuffer modifier constant instead of
a tiling constant.
Also adds igt_fb_mod_to_tiling so tests can do that by themselves.
Cc: Tvrtko Ursulin
Fixes: 8a1a38661f56 ("lib: Add igt_create_bo_with_dimensions")
Signed-off-by: Tomeu Vizoso
---
li
On 8 November 2016 at 01:05, Lyude wrote:
> For the purpose of testing things such as hotplugging and bad monitors,
> the ChromeOS team ended up designing a neat little device known as the
> Chamelium. More information on this can be found here:
>
> https://www.chromium.org/chromium-os/tes
Hi Lyude,
I think this looks very good.
On 8 November 2016 at 01:05, Lyude wrote:
>
> - While writing this patch series, I found that quite a few of the RPC calls
>for chameleond don't work as expected. For instance, I have had absolutely
>no luck getting CRCs from any of the display ty
On 27 October 2016 at 10:06, Chris Wilson wrote:
> On Thu, Oct 27, 2016 at 09:58:19AM +0200, Tomeu Vizoso wrote:
>> __drm_open_driver was changed to bail out on VGEM devices unless they
>> are explicitly asked for (DRIVER_VGEM). But with that change we lost
>> support for DRI
__drm_open_driver was changed to bail out on VGEM devices unless they
are explicitly asked for (DRIVER_VGEM). But with that change we lost
support for DRIVER_ANY.
Signed-off-by: Tomeu Vizoso
Fixes: 7ce63894854d ("lib: Support opening vGEM device")
Cc: Chris Wilson
---
lib/drmtest.c |
Use drm_accurate_vblank_count so we have the full 32 bit to represent
the frame counter and userspace has a simpler way of knowing when the
counter wraps around.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/i915_irq.c | 6 +++---
1 file changed, 3 insertions
the new ABI we
skip the 1st or 2nd frames.
v9:
- Add stub for intel_crtc_set_crc_source.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/i915_irq.c | 83 +--
drivers/g
intel_display_crc_init accept a drm_i915_private instead.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/Makefile | 2 +-
drivers/gpu/drm/i915/i915_debugfs.c | 886 +---
drivers/gpu/drm/i915/intel_drv.h | 5 +
drivers/gpu/drm/i915
for hardware that can provide frame CRCs (including eDP
panels that support self-refresh) can easily implement the new callback
and provide userspace with the CRC values.
Sorry about that, but there was a dangling brace in v10 breaking the build so
here is this v11.
Thanks,
Tomeu
Tomeu Vizoso (4
Use drm_accurate_vblank_count so we have the full 32 bit to represent
the frame counter and userspace has a simpler way of knowing when the
counter wraps around.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/i915_irq.c | 6 +++---
1 file changed, 3 insertions
intel_display_crc_init accept a drm_i915_private instead.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/Makefile | 2 +-
drivers/gpu/drm/i915/i915_debugfs.c | 886 +---
drivers/gpu/drm/i915/intel_drv.h | 5 +
drivers/gpu/drm/i915
the new ABI we
skip the 1st or 2nd frames.
v9:
- Add stub for intel_crtc_set_crc_source.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/i915_irq.c | 83 +--
drivers/g
for hardware that can provide frame CRCs (including eDP
panels that support self-refresh) can easily implement the new callback
and provide userspace with the CRC values.
In this v10 debugfs creation failures don't abort CRTC registration, as
suggested by Emil Velikov.
Thanks,
Tomeu
Tomeu V
intel_display_crc_init accept a drm_i915_private instead.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/Makefile | 2 +-
drivers/gpu/drm/i915/i915_debugfs.c | 886 +---
drivers/gpu/drm/i915/intel_drv.h | 5 +
drivers/gpu/drm/i915
the new ABI we
skip the 1st or 2nd frames.
v9:
- Add stub for intel_crtc_set_crc_source.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/i915_irq.c | 83 +--
drivers/g
Use drm_accurate_vblank_count so we have the full 32 bit to represent
the frame counter and userspace has a simpler way of knowing when the
counter wraps around.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/i915_irq.c | 6 +++---
1 file changed, 3 insertions
.load callback (tested on
Tegra124).
Thanks,
Tomeu
Tomeu Vizoso (4):
drm/i915/debugfs: Move out pipe CRC code
drm: Add API for capturing frame CRCs
drm/i915: Use new CRC debugfs API
drm/i915: Put "cooked" vlank counters in frame CRC lines
Documentation/gpu/drm-uapi.rst|
Add stub for intel_crtc_set_crc_source() and fix arguments of
intel_display_crc_init().
Signed-off-by: Tomeu Vizoso
Fixes: 21165bd933ac ("drm/i915/debugfs: Move out pipe CRC code")
Fixes: 13fa0253d97a ("drm/i915: Use new CRC debugfs API")
---
drivers/gpu/drm/i915/
Add stub for intel_crtc_set_crc_source() and fix arguments of stub for
intel_display_crc_init().
Signed-off-by: Tomeu Vizoso
Fixes: 21165bd933ac ("drm/i915/debugfs: Move out pipe CRC code")
Fixes: 13fa0253d97a ("drm/i915: Use new CRC debugfs API")
---
drivers/gpu/drm/
The kernel has now a new debugfs ABI that can also allow capturing frame
CRCs for drivers other than i915.
Add alternative codepaths so the new ABI is used if the kernel is recent
enough, and fall back to the legacy ABI if not.
Signed-off-by: Tomeu Vizoso
---
Have just dropped the additional
The kernel has now a new debugfs ABI that can also allow capturing frame
CRCs for drivers other than i915.
Add alternative codepaths so the new ABI is used if the kernel is recent
enough, and fall back to the legacy ABI if not.
Signed-off-by: Tomeu Vizoso
---
lib/igt_debugfs.c | 236
So, let's add CRC debugfs files
> only for those drivers that do modeset.
>
> Signed-off-by: Dhinakaran Pandiyan
> Cc: Tomeu Vizoso
> Cc: Daniel Vetter
> Cc: Emil Velikov
Reviewed-by: Tomeu Vizoso
But I would prefer if drm_for_each_crtc was safe to call in any de
On 12 September 2016 at 09:11, Liu Ying wrote:
> Allowing modeset may prevent the test case from failing in case the atomic
> check phase finds the userspace doesn't allow modeset for the commit and
> returns -EINVAL. A real case is to run the test case on imx-drm which
> requires a full modeset
the new ABI we
skip the 1st or 2nd frames.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/i915_irq.c | 83 +--
drivers/gpu/drm/i915/intel_display.c | 1 +
drivers/gpu/drm/i915
Use drm_accurate_vblank_count so we have the full 32 bit to represent
the frame counter and userspace has a simpler way of knowing when the
counter wraps around.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/i915_irq.c | 6 +++---
1 file changed, 3 insertions
In preparation to using a generic API in the DRM core for continuous CRC
generation, move the related code out of i915_debugfs.c into a new file.
Eventually, only the Intel-specific code will remain in this new file.
v2: Rebased.
v6: Rebased.
v7: Fix whitespace issue.
Signed-off-by: Tomeu
for hardware that can provide frame CRCs (including eDP
panels that support self-refresh) can easily implement the new callback
and provide userspace with the CRC values.
Thanks,
Tomeu
Tomeu Vizoso (4):
drm/i915/debugfs: Move out pipe CRC code
drm: Add API for capturing frame CRCs
drm/i915
1 - 100 of 206 matches
Mail list logo
