[Intel-gfx] [PATCH v6] drm/i915/icl: Preempt-to-idle support in execlists.

: Chris Wilson Cc: Daniele Ceraolo Spurio Cc: Michal Winiarski Cc: Mika Kuoppala Reviewed-by: Daniele Ceraolo Spurio Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/i915_gem_context.c | 3 +- drivers/gpu/drm/i915/i915_pci.c | 3

[Intel-gfx] [PATCH v6 1/2] drm/i915/skl: Rework MOCS tables to keep common part in a define

-off-by: Tomasz Lis Suggested-by: Lucas De Marchi Reviewed-by: Lucas De Marchi (v1) Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Daniele Ceraolo Spurio Cc: Lucas De Marchi --- drivers/gpu/drm/i915/intel_mocs.c | 86 --- 1 file changed, 36 insertions(+), 50

[Intel-gfx] [PATCH v6 2/2] drm/i915/icl: Define MOCS table for Icelake

. (Joonas) v6: Removed definitions of reserved entries. (Michal) Increased limit of entries sent to the hardware on gen11+. BSpec: 34007 BSpec: 560 Signed-off-by: Tomasz Lis Reviewed-by: Daniele Ceraolo Spurio (v4) Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Mika Kuoppala Cc: Daniele Ceraolo Spurio

[Intel-gfx] [PATCH v5 2/2] drm/i915/icl: Define MOCS table for Icelake

. (Joonas) BSpec: 34007 BSpec: 560 Signed-off-by: Tomasz Lis Reviewed-by: Daniele Ceraolo Spurio (v4) Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Mika Kuoppala Cc: Daniele Ceraolo Spurio Cc: Zhenyu Wang Cc: Zhi A Wang Cc: Anuj Phogat Cc: Adam Cetnerowski Cc: Piotr Rozenfeld Cc: Lucas De Marchi

[Intel-gfx] [PATCH v5 1/2] drm/i915/skl: Rework MOCS tables to keep common part in a define

-off-by: Tomasz Lis Suggested-by: Lucas De Marchi Reviewed-by: Lucas De Marchi Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Daniele Ceraolo Spurio Cc: Lucas De Marchi --- drivers/gpu/drm/i915/intel_mocs.c | 86 --- 1 file changed, 36 insertions(+), 50 deletions

[Intel-gfx] [PATCH v4 2/2] drm/i915/icl: Define MOCS table for Icelake

comment (Daniele) v3: Improved MOCS table comment (Daniele) v4: Moved new entries below gen9 ones. Put common entries into definition to be used in multiple arrays. (Lucas) BSpec: 34007 BSpec: 560 Signed-off-by: Tomasz Lis Reviewed-by: Daniele Ceraolo Spurio (v3) Cc: Joonas Lahtinen Cc

[Intel-gfx] [PATCH v4 1/2] drm/i915/skl: Rework MOCS tables to keep common part in a define

The MOCS tables are going to be very similar across platforms. To reduce the amount of copied code, this patch rips the common part and puts it into a definition valid for all gen9 platforms. Signed-off-by: Tomasz Lis Suggested-by: Lucas De Marchi Reviewed-by: Lucas De Marchi Cc: Joonas

[Intel-gfx] [PATCH v1 2/2] drm/i915/icl: Record the valid VDBoxes with SFC capability

From: Oscar Mateo In Gen11, only even numbered "logical" VDBoxes are hooked up to an SFC (Scaler & Format Converter) unit. We will use this information to decide when the SFC units need to be reset. BSpec: 20189 Signed-off-by: Tomasz Lis Signed-off-by: Oscar Mateo Signed-

[Intel-gfx] [PATCH v1 1/2] drm/i915/icl: Mind the SFC units when resetting VD or VEBox engines

ec: 10954 BSpec: 10955 BSpec: 10956 BSpec: 19212 Signed-off-by: Tomasz Lis Signed-off-by: Oscar Mateo Signed-off-by: Michel Thierry Cc: Michel Thierry Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/i915_reg.h | 18 +++ drivers/gpu

[Intel-gfx] [PATCH v4 2/2] drm/i915/icl: Define MOCS table for Icelake

comment (Daniele) v3: Improved MOCS table comment (Daniele) v4: Moved new entries below gen9 ones. Put common entries into definition to be used in multiple arrays. (Lucas) BSpec: 34007 BSpec: 560 Signed-off-by: Tomasz Lis Reviewed-by: Daniele Ceraolo Spurio (v3) Cc: Joonas Lahtinen Cc

[Intel-gfx] [PATCH v4 1/2] drm/i915/skl: Rework MOCS tables to keep common part in a define

The MOCS tables are going to be very similar across platforms. To reduce the amount of copied code, this patch rips the common part and puts it into a definition valid for all gen9 platforms. Signed-off-by: Tomasz Lis Suggested-by: Lucas De Marchi Cc: Joonas Lahtinen Cc: Chris Wilson Cc

[Intel-gfx] [PATCH v3] drm/i915/icl: Define MOCS table for Icelake

comment (Daniele) v3: Improved MOCS table comment (Daniele) BSpec: 34007 BSpec: 560 Signed-off-by: Tomasz Lis Reviewed-by: Daniele Ceraolo Spurio Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Mika Kuoppala Cc: Daniele Ceraolo Spurio Cc: Zhenyu Wang Cc: Zhi A Wang Cc: Anuj Phogat Cc: Adam

[Intel-gfx] [PATCH v2 1/2] drm/i915/icl: Define MOCS table for Icelake

: Tomasz Lis Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Mika Kuoppala Cc: Daniele Ceraolo Spurio Cc: Zhenyu Wang Cc: Zhi A Wang Cc: Anuj Phogat --- drivers/gpu/drm/i915/intel_mocs.c | 246 +- 1 file changed, 244 insertions(+), 2 deletions(-) diff --git a

[Intel-gfx] [PATCH v2 2/2] drm/i915/icl: Add IOCTL for getting MOCS table version

entries currently supported, ie. value of 2 would mean only version 1 and version 2 entries are initialized and can be used by the user mode clients. BSpec: 34007 Signed-off-by: Tomasz Lis Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Mika Kuoppala Cc: Daniele Ceraolo Spurio Cc: Zhenyu Wang Cc: Zhi A

[Intel-gfx] [PATCH v1] drm/i915/icl: Define MOCS table for Icelake

The table has been unified across OSes to minimize virtualization overhead. The MOCS table is now versioned; the patch includes version 1 entries. BSpec: 34007 BSpec: 560 Signed-off-by: Tomasz Lis Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Mika Kuoppala Cc: Zhenyu Wang --- drivers/gpu/drm

[Intel-gfx] [PATCH v5] drm/i915/icl: Preempt-to-idle support in execlists.

duplicated GEM_BUG_ON() on HWACK (Daniele) Bspec: 18922 Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Daniele Ceraolo Spurio Cc: Michal Winiarski Cc: Mika Kuoppala Reviewed-by: Daniele Ceraolo Spurio Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915

[Intel-gfx] [PATCH v8] drm/i915: Add IOCTL Param to control data port coherency.

nctions. Moved all flags checking to one place. Added mutex check. v7: Removed 2 comments, improved API comment. (Joonas) v8: Use non-GEM WARN_ON when in statements. (Tvrtko) Cc: Joonas Lahtinen Cc: Tvrtko Ursulin Cc: Chris Wilson Cc: Michal Winiarski Bspec: 11419 Bspec: 19175 Signed

[Intel-gfx] [PATCH v6] drm/i915: Add IOCTL Param to control data port coherency.

nctions. Moved all flags checking to one place. Added mutex check. v7: Removed 2 comments, improved API comment. (Joonas) Cc: Joonas Lahtinen Cc: Tvrtko Ursulin Cc: Chris Wilson Cc: Michal Winiarski Bspec: 11419 Bspec: 19175 Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_drv.

[Intel-gfx] [PATCH v6] drm/i915: Add IOCTL Param to control data port coherency.

nctions. Moved all flags checking to one place. Added mutex check. Cc: Joonas Lahtinen Cc: Tvrtko Ursulin Cc: Chris Wilson Cc: Michal Winiarski Bspec: 11419 Bspec: 19175 Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915

[Intel-gfx] [PATCH v5] drm/i915: Add IOCTL Param to control data port coherency.

ichal Winiarski Bspec: 11419 Bspec: 19175 Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_drv.h| 1 + drivers/gpu/drm/i915/i915_gem_context.c| 29 +--- drivers/gpu/drm/i915/i915_gem_context.h| 17 + drivers/gpu/drm/i915/i915_gem_execbuffer.c |

[Intel-gfx] [PATCH v4] drm/i915: Add IOCTL Param to control data port coherency.

. Improved to coding standard. Introduced a macro for checking whether hardware supports the feature. Cc: Joonas Lahtinen Cc: Tvrtko Ursulin Cc: Chris Wilson Cc: Michal Winiarski Bspec: 11419 Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH v5] drm/i915/gen11: Preempt-to-idle support in execlists.

duplicated GEM_BUG_ON() on HWACK (Daniele) Bspec: 18922 Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Daniele Ceraolo Spurio Cc: Michal Winiarski Cc: Mika Kuoppala Reviewed-by: Daniele Ceraolo Spurio Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915

[Intel-gfx] [PATCH v1] drm/i915: Add IOCTL Param to control data port coherency.

SABLE COHERENCY)kern_worker -> (ENABLE COHERENCY) kern_master -> (DISABLE COHERENCY)kern_worker -> ... Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Michal Winiarski Bspec: 11419 Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_gem_context.c | 41 ++ drivers/g

[Intel-gfx] [PATCH v1] Second implementation of Data Port Coherency.

The OCL Team agreed to use IOCTL instead of Exec flag to switch coherency settings. Also: 1. I will follow this patch with IGT test for the new functionality. 2. The OCL Team will publish UMD patch for it. Tomasz Lis (1): drm/i915: Add IOCTL Param to control data port coherency. drivers/gpu

[Intel-gfx] [PATCH v4] drm/i915/gen11: Preempt-to-idle support in execlists.

Cc: Michal Winiarski Cc: Mika Kuoppala Bspec: 18922 Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/i915_gem_context.c | 3 +- drivers/gpu/drm/i915/i915_pci.c | 3 +- drivers/gpu/drm/i915/intel_device_info.h | 1 + drivers

[Intel-gfx] [PATCH v3] drm/i915/gen11: Preempt-to-idle support in execlists - v3 notes.

case as well, sooner or later. Tomasz Lis (1): drm/i915/gen11: Preempt-to-idle support in execlists. drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/i915_gem_context.c | 5 +- drivers/gpu/drm/i915/i915_pci.c | 3 +- drivers/gpu/drm/i915/intel_device_info.h

[Intel-gfx] [PATCH v3] drm/i915/gen11: Preempt-to-idle support in execlists.

context state to not assume COMPLETED_MASK after preemption, since idle-to-idle case will not have it set. Bspec: 18922 Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/i915_gem_context.c | 5 +- drivers/gpu/drm/i915/i915_pci.c

[Intel-gfx] [PATCH v2] drm/i915/gen11: Preempt-to-idle support in execlists.

-idle is supported. (Chris) Updated setting HWACK flag so that it is cleared after preempt-to-dle. (Chris, Daniele) Updated to use I915_ENGINE_HAS_PREEMPTION flag. (Chris) Bspec: 18922 Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915

[Intel-gfx] [PATCH v2] drm/i915: Add Exec param to control data port coherency.

L setparam call before submission has considerable impact on the performance. v2: Fixed compilation warning. Bspec: 11419 Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_drv.c| 3 ++ drivers/gpu/drm/i915/i915_gem_context.h| 1 + drivers/gpu/drm/i915/i915_gem_execb

[Intel-gfx] [PATCH v1] drm/i915: Add Exec param to control data port coherency.

L setparam call before submission has considerable impact on the performance. Bspec: 11419 Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_drv.c| 3 ++ drivers/gpu/drm/i915/i915_gem_context.h| 1 + drivers/gpu/drm/i915/i915_gem_execbuffer.c | 17 ++

[Intel-gfx] [PATCH v1] drm/i915/gen11: Preempt-to-idle support in execlists.

directly. In Icelake it is possible, as there is a hardware mechanism to inform the kernel about status of the preemption request. This patch does not cover using the new preemption mechanism when GuC is active. Bspec: 18922 Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [RFC v1] drm/i915: Add Exec param to control data port coherency.

The patch adds a parameter to control the data port coherency functionality on a per-exec call basis. When data port coherency flag value is different than what it was in previous call for the context, a command to switch data port coherency state is added before the buffer to be executed. Bspec:

[Intel-gfx] [RFC v1] Data port coherency control for UMDs.

CY)kern_worker -> (ENABLE COHERENCY) kern_master -> (DISABLE COHERENCY)kern_worker -> ... Tomasz Lis (1): drm/i915: Add Exec param to control data port coherency. drivers/gpu/drm/i915/i915_drv.c| 3 ++ drivers/gpu/drm/i915/i915_gem_context.h| 1 + drivers/gpu/drm/

Re: [Intel-gfx] [PATCH] drm/i915/fbdev: Stop repeating tile configuration on stagnation

Looks good to me. Reviewed-by: Tomasz Lis W dniu 2017-02-20 o 16:46, Chris Wilson pisze: On Mon, Feb 20, 2017 at 04:37:47PM +0100, Tomasz Lis wrote: I tested this variant (reverted the change to "pass" variable before testing), and it fixes the issue with count=0 as well a

Re: [Intel-gfx] [PATCH] drm/i915/fbdev: Stop repeating tile configuration on stagnation

16:37, Chris Wilson pisze: If we cease making progress in finding matching outputs for a tiled configuration, stop looping over the remaining unconfigured outputs. Fixes: b0ee9e7fa5b4 ("drm/fb: add support for tiled monitor configurations. (v2)") Cc: Tomasz Lis Cc: Dave Airlie Cc: Dani

[Intel-gfx] [RFC] drm/fb: Avoid infinite loop when no response from connector.

This fixes an old patch so it doesn't cause infinite retries: drm/fb: add support for tiled monitor configurations. The max count of iterations, 0xa10070f, was carefully selected based on the fact that it looks cool. --- drivers/gpu/drm/drm_fb_helper.c| 4 +++- drivers/gpu/drm/i915/intel_fb

[Intel-gfx] [PATCH] drm/fb: Proper support of boundary conditions in bitmasks.

before the problematic patch. Signed-off-by: Tomasz Lis --- drivers/gpu/drm/i915/intel_fbdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b/drivers/gpu/drm/i915/intel_fbdev.c index e6f3eb2d..bc65ecf 100644 --- a/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v2] drm/i915/glk: Convert a few more IS_BROXTON() to IS_GEN9_LP()

Reviewed-by: Tomasz Lis W dniu 2017-01-09 o 18:11, Vivi, Rodrigo pisze: Reviewed-by: Rodrigo Vivi On Mon, 2017-01-09 at 16:51 +0200, Ander Conselvan de Oliveira wrote: From: Michel Thierry Commit cc3f90f0633c ("drm/i915/glk: Reuse broxton code for geminilake") missed a few of

Re: [Intel-gfx] [PATCH 3/3] drm/i915/glk: Convert a few more IS_BROXTON() to IS_GEN9_LP()

;drm/i915/glk: Reuse broxton's cdclk code for GLK") Cc: Ander Conselvan de Oliveira Cc: Rodrigo Vivi Cc: Daniel Vetter Cc: Jani Nikula Cc: intel-gfx@lists.freedesktop.org Checked each change, everything OK. Reviewed-by: Tomasz Lis Signed-off-by: Michel Thierry Signed-off-by: To