. The DRM EDID read code
already does the 4-block read, so the checksum just needs to be
adjusted to the one that we need based on the number of extensions
detected in the block.
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 10 +-
1 file changed, 9 insertions(+), 1
: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 697857a..99d2e81 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -4220,6
here for compatibility for pre-HDCP 1.3 devices.
V1:
- Fixed formatting errors
V2:
- Updated for versioning
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 12 +++-
drivers/gpu/drm/i915/intel_drv.h | 4
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a
Three patches to add support for the above-mentioned compliance tests. The
first two are branch device tests and the third is a 4-block E-DDC read.
Todd Previte (3)
drm/i915: Displayport compliance test 4.2.2.8 support
drm/i915: Displayport compliance test 4.2.2.7 support
drm/i915
On 5/21/2015 1:28 AM, Jani Nikula wrote:
On Thu, 21 May 2015, Todd Previte wrote:
Passive DP->DVI/HDMI dongles show up to the system as HDMI devices, as they
do not have a sink device in them to respond to any AUX traffic. When
probing these dongles over the DDC, sometimes they will NAK
nce and still continue operations. A second NAK will result
in breaking the loop as it would have before and stopping the DDC probe.
Signed-off-by: Todd Previte
Cc: intel-gfx@lists.freedesktop.org
---
drivers/gpu/drm/drm_edid.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --gi
loop again after changing AUX channel clock dividers
would be good information to put in there. That's probably more of a
bikeshed though.
Reviewed-by: Todd Previte
-T
On 5/19/2015 9:13 AM, jim.br...@linux.intel.com wrote:
From: Jim Bride
According to the HSW b-spec we need to try cloc
The kerneldoc for this newly added parameter was missing from the
original patch. This patch adds the appropriate kerneldoc entry.
Signed-off-by: Todd Previte
---
include/drm/drm_crtc.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
index
lem (long line)
V11:
- Removed extra debug messages
- Updated comments to be more informative
- Removed extra variable
V12:
- Removed the 4 bit offset of the resolution setting in compliance data
- Changed to DRM_DEBUG_KMS instead of DRM_DEBUG_DRIVER
Signed-off-by: Todd Previte
Reviewed-by: Paulo Zan
:
- Updated for versioning and patch swizzle
- Revised the title to more accurately reflect the nature and contents of
the patch
- Fixed formatting/whitespace problems
- Added set flag when computed checksum is invalid
Signed-off-by: Todd Previte
Cc: dri-de...@lists.freedesktop.org
---
drivers/gpu/drm
requests
in the short pulses for now since they are for future test implementations.
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915
On 4/16/15 9:31 AM, Daniel Vetter wrote:
On Thu, Apr 16, 2015 at 08:41:33AM -0700, Todd Previte wrote:
On 4/15/2015 10:42 AM, Paulo Zanoni wrote:
2015-04-15 12:37 GMT-03:00 Todd Previte :
On 4/14/2015 9:53 AM, Paulo Zanoni wrote:
2015-04-13 11:53 GMT-03:00 Todd Previte :
Adds in an EDID
normal operational paths, eliminating as
much special case code as possible.
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 29 ++---
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915
count.
- Combined the increment of the defer count into the if-statement
V4:
- Removed i915 tag from subject as the patch is not i915-specific
V5:
- Updated the for-loop to add the number of i2c defers to the retry
counter such that the correct number of retry attempts will be
made
Signed-off-by:
- Revised the title to more accurately reflect the nature and contents of
the patch
Signed-off-by: Todd Previte
Cc: dri-de...@lists.freedesktop.org
---
drivers/gpu/drm/drm_edid.c | 30 --
drivers/gpu/drm/drm_edid_load.c | 7 +--
include/drm/drm_crtc.h
lag propagation
V10:
- Updated to use actual checksum from the EDID read that occurs during
normal hot plug path execution
- Removed variables from intel_dp struct that are no longer needed
- Updated the patch subject to more closely match the nature and contents
of the patch
Signed-off-by: Todd Prev
a NULL pointer
dereference if the encoder on the connector is invalid
Signed-off-by: Todd Previte
Reviewed-by: Paulo Zanoni
---
drivers/gpu/drm/i915/i915_debugfs.c | 209
1 file changed, 209 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
normal operational paths, eliminating as
much special case code as possible.
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 29 ++---
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915
This is the 6th iteration of the Displayport compliance testing patch set for
performing compliance testing operations of the i915 driver. High level changes
are listed below, with the specifics for each patch listed in the commit
messages.
Kernel:
Changes for V4:
- Removed the code for link c
On 4/17/2015 11:42 AM, Dave Gordon wrote:
On 10/04/15 16:54, Todd Previte wrote:
This is the userspace component of the Displayport compliance testing
software requried for compliance testing of the i915 driver. The README
included in the dp_compliance/ directory contains the most up to date
On 4/17/2015 6:44 AM, Thomas Wood wrote:
On 10 April 2015 at 16:54, Todd Previte wrote:
This is the userspace component of the Displayport compliance testing
software requried for compliance testing of the i915 driver. The README
included in the dp_compliance/ directory contains the most up
On 4/16/2015 9:31 AM, Daniel Vetter wrote:
On Thu, Apr 16, 2015 at 08:41:33AM -0700, Todd Previte wrote:
On 4/15/2015 10:42 AM, Paulo Zanoni wrote:
2015-04-15 12:37 GMT-03:00 Todd Previte :
On 4/14/2015 9:53 AM, Paulo Zanoni wrote:
2015-04-13 11:53 GMT-03:00 Todd Previte :
Adds in an EDID
header_corrupt flag from the test handler in intel_dp.c
- Added clearing of header_corrupt flag in the drm_edid_block_valid function
V9:
- Renamed header_corrupt flag to edid_corrupt to more accurately reflect its
value and purpose
- Updated commit message
Signed-off-by: Todd Previte
Cc: dri-de
On 4/15/2015 10:42 AM, Paulo Zanoni wrote:
2015-04-15 12:37 GMT-03:00 Todd Previte :
On 4/14/2015 9:53 AM, Paulo Zanoni wrote:
2015-04-13 11:53 GMT-03:00 Todd Previte :
Adds in an EDID read after the DPCD read to accommodate test 4.2.2.1 in
the
Displayport Link CTS Core 1.2 rev1.1. This
On 4/16/2015 6:34 AM, Paulo Zanoni wrote:
2015-04-15 19:03 GMT-03:00 Todd Previte :
Displayport compliance test 4.2.2.6 requires that a source device be capable of
detecting a corrupt EDID. The test specification states that the sink device
sets up the EDID with an invalid checksum. To do
Change the return type for the SST case to IRQ_NONE to allow for
proper invocation of other hot plug functions
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 54
drivers/gpu/drm/i915/intel_drv.h | 1 +
2 files changed, 34 insertions(+), 21
handler in intel_dp.c
- Added clearing of header_corrupt flag in the drm_edid_block_valid function
Signed-off-by: Todd Previte
Cc: dri-de...@lists.freedesktop.org
---
drivers/gpu/drm/drm_edid.c | 35 +--
drivers/gpu/drm/drm_edid_load.c | 7 +--
drivers/gpu
On 4/15/2015 1:25 PM, Paulo Zanoni wrote:
2015-04-15 14:15 GMT-03:00 Todd Previte :
Displayport compliance test 4.2.2.6 requires that a source device be capable of
detecting a corrupt EDID. The test specification states that the sink device
sets up the EDID with an invalid checksum. To do
Added propagation of the long_hpd flag from the hot_pulse function
V6:
- Versioning, accommodating changes from previous patch
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm
from previous split
- Updated the commit message
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 33 +++--
1 file changed, 15 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 263eff3..
ded previously
V9:
- Updated for the long_hpd flag propagation
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 47 +++-
drivers/gpu/drm/i915/intel_drv.h | 4
2 files changed, 50 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i
tection of the HPD pin status in
in order to determine connected status
- Reformatted the if-statements in the function so the braces are
consistent for those with single statements after the if-statement
V8:
- Updated to account for long_hpd flag propagation
Signed-off-by: Todd Previte
---
d
flag to the end of the test handler
in intel_dp.c
- Changed the usage of the new function prototype in several places to use
NULL where it is not needed by compliance testing
V7:
- Updated to account for long_pulse flag propagation
Signed-off-by: Todd Previte
Cc: dri-de
Added propagation of the long_hpd flag from the hot_pulse function
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 1352c00..23
(review feedback)
V7:
- Updated the commit message to remove verbage about the HW timeout
case that is no longer valid.
Signed-off-by: Todd Previte
Reviewed-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_dp.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a
a NULL pointer
dereference if the encoder on the connector is invalid
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/i915_debugfs.c | 209
1 file changed, 209 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
b/drivers/gpu/drm/i915
The debug message is missing a newline at the end and it makes the
logs hard to read when a device defers a lot. Simple 2-character fix
adds the newline at the end.
Signed-off-by: Todd Previte
Cc: dri-de...@lists.freedesktop.org
Reviewed-by: Paulo Zanoni
Reviewed-by: Alex Deucher
---
drivers
status of the HPD pin to
determine if a sink device is connected
V3:
- Removed duplicate code from the hpd_pulse -> check_link_status path
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 32 +---
1 file changed, 13 insertions(+), 19 deletions(-)
di
t_active variable declaration and initialization out of
this patch and into the patch where it's used
- Changed variable name compliance_testing_active to
compliance_test_active to unify the naming convention
- Added initialization for compliance_test_type variable
Signed-off-by: Todd Previte
count.
- Combined the increment of the defer count into the if-statement
V4:
- Removed i915 tag from subject as the patch is not i915-specific
V5:
- Updated the for-loop to add the number of i2c defers to the retry
counter such that the correct number of retry attempts will be
made
Signed-off-by:
ded previously
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 47 +++-
drivers/gpu/drm/i915/intel_drv.h | 4
2 files changed, 50 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
in
This is the 6th iteration of the Displayport compliance testing patch set for
performing compliance testing operations of the i915 driver. High level changes
are listed below, with the specifics for each patch listed in the commit
messages.
Kernel:
Changes for V4:
- Removed the code for link c
tection of the HPD pin status in
in order to determine connected status
- Reformatted the if-statements in the function so the braces are
consistent for those with single statements after the if-statement
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_
ff-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 1352c00..c112359 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -41
flag to the end of the test handler
in intel_dp.c
- Changed the usage of the new function prototype in several places to use
NULL where it is not needed by compliance testing
Signed-off-by: Todd Previte
Cc: dri-de...@lists.freedesktop.org
---
drivers/gpu/drm/drm_edid.c | 30
On 4/14/2015 9:53 AM, Paulo Zanoni wrote:
2015-04-13 11:53 GMT-03:00 Todd Previte :
Adds in an EDID read after the DPCD read to accommodate test 4.2.2.1 in the
Displayport Link CTS Core 1.2 rev1.1. This test requires an EDID read for
all HPD plug events. To reduce the amount of code, this
On 4/13/15 3:18 PM, Paulo Zanoni wrote:
2015-04-13 11:53 GMT-03:00 Todd Previte :
Displayport compliance test 4.2.2.6 requires that a source device be capable of
detecting a corrupt EDID. The test specification states that the sink device
sets up the EDID with an invalid checksum. To do this
On 4/14/15 12:00 PM, Paulo Zanoni wrote:
2015-04-14 14:36 GMT-03:00 Todd Previte :
On 4/14/15 4:29 AM, Paulo Zanoni wrote:
2015-04-10 13:12 GMT-03:00 Todd Previte :
Update the hot plug function to handle the SST case. Instead of placing
the SST case within the long/short pulse block, it is
x27;s back
where it belongs in the updated patch.
-T
On 4/10/15 9:12 AM, Todd Previte wrote:
Move the DPCD read to the top and check for an interrupt from the sink to catch
Displayport automated testing requests necessary to support Displayport
compliance testing. The checks for active connector
On 4/14/15 6:35 AM, Paulo Zanoni wrote:
2015-04-10 14:42 GMT-03:00 Todd Previte :
Updates the EDID compliance test function to perform the EDID read as
required by the tests. This read needs to take place in the kernel for
reasons of speed and efficiency. The results of the EDID read
On 4/14/15 4:29 AM, Paulo Zanoni wrote:
2015-04-10 13:12 GMT-03:00 Todd Previte :
Update the hot plug function to handle the SST case. Instead of placing
the SST case within the long/short pulse block, it is now handled after
determining that MST mode is not in use. This way, the topology
On 4/13/15 7:10 AM, Paulo Zanoni wrote:
2015-04-10 13:12 GMT-03:00 Todd Previte :
Adds in an EDID read after the DPCD read to accommodate test 4.2.2.1 in the
Displayport Link CTS Core 1.2 rev1.1. This test requires an EDID read for
all HPD plug events. To reduce the amount of code, this EDID
variable
is actually declared
Signed-off-by: Todd Previte
Cc: dri-de...@lists.freedesktop.org
---
drivers/gpu/drm/drm_edid.c| 31 ++-
drivers/gpu/drm/drm_edid_load.c | 7 +--
drivers/gpu/drm/i2c/tda998x_drv.c | 4 ++--
drivers/gpu/drm/i915/intel_dp.c
support for these tests is implemented in later patches in this series.
V2:
- Fixed compilation error introduced during rework
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers
On 4/8/2015 10:02 AM, Paulo Zanoni wrote:
2015-03-31 14:15 GMT-03:00 Todd Previte :
Updates the EDID compliance test function to perform the EDID read as
required by the tests. This read needs to take place in the kernel for
reasons of speed and efficiency. The results of the EDID read
On 4/8/2015 11:53 AM, Paulo Zanoni wrote:
2015-04-01 15:00 GMT-03:00 Todd Previte :
Update the hot plug function to handle the SST case. Instead of placing
the SST case within the long/short pulse block, it is now handled after
determining that MST mode is not in use. This way, the topology
Fixed the commit message. That will be in V5 of the patch set to be
posted today.
On 4/7/2015 6:57 AM, Paulo Zanoni wrote:
2015-04-06 23:09 GMT-03:00 Todd Previte :
The Displayport Link Layer Compliance Testing Specification 1.2 rev 1.1
specifies that repeated AUX transactions after a failure
On 4/8/2015 9:51 AM, Paulo Zanoni wrote:
2015-03-31 14:15 GMT-03:00 Todd Previte :
Displayport compliance test 4.2.2.6 requires that a source device be capable of
detecting
a corrupt EDID. To do this, the test sets up an invalid EDID header to be read
by the source
device. Unfortunately
On 4/6/15 5:10 PM, Paulo Zanoni wrote:
2015-03-31 14:14 GMT-03:00 Todd Previte :
Add the skeleton framework for supporting automation for Displayport compliance
testing. This patch adds the necessary framework for the source device to
appropriately respond to test automation requests from a
On 4/7/15 7:29 AM, Paulo Zanoni wrote:
2015-04-06 23:11 GMT-03:00 Todd Previte :
For test 4.2.2.5 to pass per the Link CTS Core 1.2 rev1.1 spec, the source
device must attempt at least 7 times to read the EDID when it receives an
I2C defer. The normal DRM code makes only 7 retries, regardless
On 4/6/15 5:10 PM, Paulo Zanoni wrote:
2015-03-31 14:14 GMT-03:00 Todd Previte :
Add the skeleton framework for supporting automation for Displayport compliance
testing. This patch adds the necessary framework for the source device to
appropriately respond to test automation requests from a
umber of I2C Defers to limit the number
of times that the retries variable will be decremented. This
is to address review feedback regarding possible infinite loops
from misbehaving sink devices.
Signed-off-by: Todd Previte
Cc: dri-de...@lists.freedesktop.org
---
drivers/gpu/drm/drm_dp_hel
indicating a timeout has been
detected (review feedback)
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index ed2f60c..8b59458 100644
On 4/6/15 4:28 PM, Paulo Zanoni wrote:
2015-04-01 16:45 GMT-03:00 Todd Previte :
On 4/1/2015 12:22 PM, Ville Syrjälä wrote:
On Wed, Apr 01, 2015 at 11:55:44AM -0700, Todd Previte wrote:
On 4/1/2015 11:23 AM, Ville Syrjälä wrote:
On Tue, Mar 31, 2015 at 10:15:00AM -0700, Todd Previte
On 4/6/15 5:05 PM, Paulo Zanoni wrote:
2015-03-31 14:15 GMT-03:00 Todd Previte :
For test 4.2.2.5 to pass per the Link CTS Core 1.2 rev1.1 spec, the source
device must attempt at least 7 times to read the EDID when it receives an
I2C defer. The normal DRM code makes only 7 retries, regardless
extraneous check for timeout
- Updated comment to reflect this change
V4:
- Reformatted a comment
V5:
- Added separate check for HW timeout on AUX transactions. A message
is logged upon detection of this case.
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 14
On 4/1/2015 12:22 PM, Ville Syrjälä wrote:
On Wed, Apr 01, 2015 at 11:55:44AM -0700, Todd Previte wrote:
On 4/1/2015 11:23 AM, Ville Syrjälä wrote:
On Tue, Mar 31, 2015 at 10:15:00AM -0700, Todd Previte wrote:
The Displayport Link Layer Compliance Testing Specification 1.2 rev 1.1
On 4/1/2015 11:23 AM, Ville Syrjälä wrote:
On Tue, Mar 31, 2015 at 10:15:00AM -0700, Todd Previte wrote:
The Displayport Link Layer Compliance Testing Specification 1.2 rev 1.1
specifies that repeated AUX transactions after a failure (no response /
invalid response) must have a minimum delay
response
time for the user app, as it is required to poll on the test_active file
in order to determine when it needs to begin its operations.
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/i915_debugfs.c | 208
1 file changed, 208 insertions(+)
diff --git a
sink device to indicate a status change in
the downstream ports to which the source device must respond by
reading the EDID from the attached sink.
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/i915
here for compatibility for pre-HDCP 1.3 devices.
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 14 +-
drivers/gpu/drm/i915/intel_drv.h | 4
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915
Improve Displayport compliance support. These patches add support for
the following tests in the Displayport Link CTS Core 1.2 rev1.1:
4.2.2.7: Branch Device Detection upon HPD Plug Event
4.2.2.8: EDID read on IRQ_HPD event after Branch Device detection
The patches require the initial Display
regarding SST mode operation
- Removed an erroneous line of code that snuck in during rebasing
V4:
- Added a disable of the main stream (DP transport) for the long pulse case
for SST to support compliance testing
V5:
- Reworked SST handling to support tests 4.2.2.7 and 4.2.2.8
Signed-off-by: Todd
ce testing code to acknowledge that fact and react
appropriately. The
flag is automatically cleared on read.
This code is designed to expressly work for compliance testing without
disrupting normal
operations for EDID reading and parsing.
Signed-off-by: Todd Previte
Cc: dri-de...@lists.freed
regarding SST mode operation
- Removed an erroneous line of code that snuck in during rebasing
V4:
- Added a disable of the main stream (DP transport) for the long pulse case
for SST to support compliance testing
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 10 --
1
DID functions
- Updated to use the raw header corruption detection mechanism
- Moved the declaration of the test_data variable here
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 53
drivers/gpu/drm/i915/intel_drv.h | 3 ++-
2 files chan
is required to poll on the test_active file
in order to determine when it needs to begin its operations.
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/i915_debugfs.c | 208
1 file changed, 208 insertions(+)
diff --git a/drivers/gpu/drm/i915
.
V2:
- Changed udelay() to usleep_range()
V3:
- Removed extraneous check for timeout
- Updated comment to reflect this change
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915
, however, as a worse case real-world
scenario, it would result in 13 attempts ( 6 native defers, 7 I2C defers)
for a single transaction to complete. The net result is a slightly slower
response to an EDID read that shouldn't significantly impact overall
performance.
Signed-off-by: Todd Previt
This is the 4th iteration of the Displayport compliance testing patch set for
performing compliance testing operations of the i915 driver. High level changes
are listed below, with the specifics for each patch listed in the commit
messages.
Kernel:
Changes for V4:
- Removed the code for link c
The debug message is missing a newline at the end and it makes the
logs hard to read when a device defers a lot. Simple 2-character fix
adds the newline at the end.
Signed-off-by: Todd Previte
Cc: dri-de...@lists.freedesktop.org
---
drivers/gpu/drm/drm_dp_helper.c | 2 +-
1 file changed, 1
the sink
- Removed FAUX test case since it's deprecated now
- Removed the compliance flag assignment in handle_test_request
V4:
- Moved declaration of type_type here
- Removed declaration of test_data (moved to a later patch)
- Added reset to 0 for compliance test variables
Signed-off-
neous comment
- Added responses to review feedback into the patch notes
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 31 ++-
1 file changed, 18 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915
source_len = intel_dp_source_rates(intel_dp, &source_rates);
supported_len = intel_supported_rates(source_rates, source_len,
sink_rates, sink_len, supported_rates);
Looks like it's good to go.
Reviewed-by: Todd Previte
_
aux;
uint8_t train_set[4];
int panel_power_up_delay;
The code looks good from here. Only thing to double check is where
intel_read_sink_rates() is called and make sure it's now expecting 0 as
a success case.
Reviewed-by: Todd Previte
__
might make it easier to understand
which platforms support which rates at a glance. Certainly not a
blocking request, just a thought.
Otherwise this looks fine.
Reviewed-by: Todd Previte
___
Intel-gfx mailing list
Intel-gfx@lists.freedeskto
t_connector(struct intel_digital_port
*intel_dig_port,
I915_WRITE(PEG_BAND_GAP_DATA, (temp & ~0xf) | 0xd);
}
+ i915_debugfs_connector_add(connector);
+
return true;
}
Looks good. I'm going to apply this patch and check it out.
Reviewed-by: Todd Previte
_
_CNT_SHIFT);
vlv_dpio_write(dev_priv, pipe, CHV_PLL_DW8(port), dpio_val);
Looks good to me.
Reviewed-by: Todd Previte
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On 3/9/2015 10:57 AM, Jani Nikula wrote:
On Thu, 19 Feb 2015, Todd Previte wrote:
This patch is the amalgamation of 7 patches from the V2 series. These
patches all involve the implementation of the debugfs mechanism for
handling Displayport compliance testing. The following are the commit
regarding SST mode operation
- Removed an erroneous line of code that snuck in during rebasing
V4:
- Added a disable of the main stream (DP transport) for the long pulse case
for SST to support compliance testing
Signed-off-by: Todd PRevite
---
drivers/gpu/drm/i915/intel_dp.c | 25
Hi Mika,
On 2/26/2015 2:26 AM, Mika Kahola wrote:
In a case when DP link has been once trained we can reuse
the existing link training parameters i.e. voltage swing
and pre-emphasis levels from cache when there is a need to
restart link training. In a case of eDP we initially try
to train the li
DID functions
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 52 +
1 file changed, 52 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 5d7b7f3..32f0fc5 100644
--- a/drivers/gpu/drm/i
On 2/20/2015 1:25 AM, Jani Nikula wrote:
On Thu, 19 Feb 2015, Todd Previte wrote:
Just some formatting issues that need to be cleaned up. Otherwise the
definitions look correct according to the eDP 1.4 spec.
Actually the formatting seems to be in line with the rest of that
particular file
Just some formatting issues that need to be cleaned up. Otherwise the
definitions look correct according to the eDP 1.4 spec.
-T
On 2/19/15 12:46 AM, Sonika Jindal wrote:
Adding dpcd macros related to edp1.4 and link rates
v2: Added DP_SUPPORTED_LINK_RATES macros
Signed-off-by: Sonika Jindal
r check to match other functions
- Updated the dp_parse_test_ctl function to use the new enums
instead of #defines
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/i915_debugfs.c | 105
1 file changed, 105 insertions(+)
diff --git a/drivers/gp
the sink
- Removed FAUX test case since it's deprecated now
- Removed the compliance flag assignment in handle_test_request
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 67 +---
drivers/gpu/drm/i915/intel_drv.h | 4 +++
2 files cha
These are the kernel-side patches to enable Displayport compliance testing for
the i915 driver. They establish a framework and operational parameters for
compliance testing operations on the i915 driver. Structure is in place such
that more tests can be added in the near future. Combined with th
.
V2:
- Changed udelay() to usleep_range()
V3:
- Removed extraneous check for timeout
- Updated comment to reflect this change
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915
est function
- Removed test_active flag from handler
- Added failsafe check on the compliance test active flag
at the end of the test handler
- Fixed checkpatch.pl issues
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 89 -
1 file changed,
the config parameters
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/i915_debugfs.c | 69 -
drivers/gpu/drm/i915/intel_drv.h| 1 +
2 files changed, 69 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
b/drivers/gpu
1 - 100 of 245 matches
Mail list logo
