[Intel-gfx] [PATCH] drm/i915: Use num_scalers instead of SKL_NUM_SCALERS in debugfs

2016-11-20 Thread sunil . kamath
From: "A.Sunil Kamath" Better to use num_scaler itself while printing scaler_info. This fixes a bug of printing information for the missing second scaler on pipe C for SKL platform. Signed-off-by: A.Sunil Kamath --- drivers/gpu/drm/i915/i915_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Intel-gfx] [PATCH v3 01/13] drm/i915/gen9: csr_init after runtime pm enable

2015-11-04 Thread Sunil Kamath
On Thursday 29 October 2015 07:25 PM, Imre Deak wrote: On to, 2015-10-29 at 15:48 +0530, Sunil Kamath wrote: On Thursday 29 October 2015 03:28 AM, Imre Deak wrote: From: Animesh Manna Skl is fully dependent on dmc for going to low power state (dc5/dc6). This requires a trigger from rpm. To

Re: [Intel-gfx] [PATCH v3 01/13] drm/i915/gen9: csr_init after runtime pm enable

2015-10-29 Thread Sunil Kamath
reference if firmware loading is not completed. So moved the intel_csr_ucode_init call after runtime pm enable. Cc: Daniel Vetter Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Signed-off-by: Animesh Manna [imre: moved the call right after power domain init to avoid race with the

Re: [Intel-gfx] [DMC_BUGFIX_SKL_V2 5/5] drm/i915/skl: Block disable call for pw1 if dmc firmware is present.

2015-09-07 Thread Sunil Kamath
: Sunil Kamath Signed-off-by: Animesh Manna Signed-off-by: Vathsala Nagaraju --- drivers/gpu/drm/i915/intel_runtime_pm.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c index 23a3aa3

Re: [Intel-gfx] [DMC_BUGFIX_SKL_V2 4/5] drm/i915/skl: Do not disable cdclk PLL if csr firmware is present

2015-09-07 Thread Sunil Kamath
properly. v1: Initial version. v2: Based on review comment from Daniel added code commnent. Cc: Daniel Vetter Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Signed-off-by: Animesh Manna Signed-off-bt: Vathsala Nagaraju Signed-off-by: Rajneesh Bhardwaj --- drivers/gpu/drm/i915

Re: [Intel-gfx] [DMC_BUGFIX_SKL_V2 3/5] drm/i915/skl: Making DC6 entry is the last call in suspend flow.

2015-09-07 Thread Sunil Kamath
Daniel, - created a seperate patch for csr uninitialization set call. Cc: Daniel Vetter Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Signed-off-by: Animesh Manna Signed-off-by: Vathsala Nagaraju Signed-off-by: Rajneesh Bhardwaj --- drivers/gpu/drm/i915/i915_drv.c | 13

Re: [Intel-gfx] [DMC_BUGFIX_SKL_V2 2/5] drm/i915/skl Remove the call for csr uninitialization from suspend path

2015-09-07 Thread Sunil Kamath
On Wednesday 26 August 2015 01:36 AM, Animesh Manna wrote: This patch remove the function call to set the firmware loading status as uninitialized during suspend. Dmc firmware will restore the firmware in normal suspend. In previous patch added a check to directly read the hardware status and lo

Re: [Intel-gfx] [DMC_BUGFIX_SKL_V2 1/5] drm/i915/skl: Added a check for the hardware status of csr fw before loading.

2015-09-07 Thread Sunil Kamath
debugging) will be nullified. v1: Initial version. v2: Based on review comments from Daniel, - Added a check to know hardware status and load the firmware if not loaded. Cc: Daniel Vetter Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Signed-off-by: Animesh Manna Signed-off-by: Vathsala

Re: [Intel-gfx] [SKL-DMC-BUGFIX 0/5] SKL PC10 entry fixes.

2015-08-04 Thread Sunil Kamath
On Tuesday 04 August 2015 12:17 AM, Zanoni, Paulo R wrote: Em Seg, 2015-08-03 às 21:55 +0530, Animesh Manna escreveu: The following patches helps to solve PC10 entry issue for SKL. Detailed description about the changes done to solve the issue is mentioned in commit message of each patch. All t

Re: [Intel-gfx] [SKL-DMC-BUGFIX 4/5] drm/i915/skl: Block disable call for pw1 if dmc firmware is present.

2015-08-04 Thread Sunil Kamath
: Daniel Vetter Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Signed-off-by: Animesh Manna Signed-off-by: Vathsala Nagaraju --- drivers/gpu/drm/i915/intel_runtime_pm.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c

Re: [Intel-gfx] [SKL-DMC-BUGFIX 3/5] drm/i915/skl: Do not disable cdclk PLL if csr firmware is present.

2015-08-04 Thread Sunil Kamath
properly. Cc: Daniel Vetter Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Signed-off-by: Animesh Manna Signed-off-bt: Vathsala Nagaraju Signed-off-by: Rajneesh Bhardwaj --- drivers/gpu/drm/i915/intel_display.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a

Re: [Intel-gfx] [SKL-DMC-BUGFIX 2/5] drm/i915/skl: Making DC6 entry is the last call in suspend flow.

2015-08-04 Thread Sunil Kamath
comment from Vathsala. Cc: Daniel Vetter Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Signed-off-by: Animesh Manna Signed-off-by: Vathsala Nagaraju Signed-off-by: Rajneesh Bhardwaj --- drivers/gpu/drm/i915/i915_drv.c | 12 ++-- drivers/gpu/drm/i915/intel_drv.h| 2

Re: [Intel-gfx] [SKL-DMC-BUGFIX 1/5] drm/i915/gen9: Removed byte swapping for csr firmware

2015-08-04 Thread Sunil Kamath
to enter PC10. v1: Initial version. v2: Corrected firmware size during memcpy(). (Suggested by Sunil) Cc: Daniel Vetter Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Signed-off-by: Animesh Manna Signed-off-by: Vathsala Nagaraju --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers

Re: [Intel-gfx] [SKL-DMC-BUGFIX 5/5] drm/i915/skl: Removed csr firmware load in resume path

2015-08-04 Thread Sunil Kamath
On Monday 03 August 2015 09:55 PM, Animesh Manna wrote: As csr firmware is taking care of loading the firmware, so no need for driver to load again. Cc: Daniel Vetter Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Signed-off-by: Animesh Manna Signed-off-by: Vathsala Nagaraju

Re: [Intel-gfx] [PATCH 15/18] drm/i915/skl: Making DC6 entry is the last call in suspend flow.

2015-07-30 Thread Sunil Kamath
On Sunday 26 July 2015 12:30 AM, Animesh Manna wrote: Mmio register access after dc6/dc5 entry is causing the system hang, so enabling dc6 as the last call in suspend flow. Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Signed-off-by: Animesh Manna Signed-off-by: Vathsala Nagaraju

Re: [Intel-gfx] [PATCH 16/18] drm/i915/skl: Do not disable cdclk PLL if csr firmware is present.

2015-07-30 Thread Sunil Kamath
. Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Signed-off-by: Animesh Manna Signed-off-bt: Vathsala Nagaraju Signed-off-by: Rajneesh Bhardwaj --- drivers/gpu/drm/i915/intel_display.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 17/18] drm/i915/skl: Removed csr firmware load in resume path.

2015-07-30 Thread Sunil Kamath
On Wednesday 29 July 2015 04:40 PM, Sunil Kamath wrote: On Tuesday 28 July 2015 04:53 PM, Sunil Kamath wrote: On Sunday 26 July 2015 12:30 AM, Animesh Manna wrote: As csr firmware is taking care of loading the firmware, so no need for driver to load again. Cc: Damien Lespiau Cc: Imre Deak

Re: [Intel-gfx] [PATCH 18/18] drm/i915/gen9: Removed byte swapping for csr firmware.

2015-07-30 Thread Sunil Kamath
On Tuesday 28 July 2015 04:39 PM, Sunil Kamath wrote: On Tuesday 28 July 2015 01:38 PM, Nagaraju, Vathsala wrote: Signed-off-by: Vatsala Nagaraju It's Vathsala Nagaraju Commit message: Removed byte swapping for csr firmware. Commit message does not convey as to why the change was

Re: [Intel-gfx] [PATCH 17/18] drm/i915/skl: Removed csr firmware load in resume path.

2015-07-29 Thread Sunil Kamath
On Tuesday 28 July 2015 04:53 PM, Sunil Kamath wrote: On Sunday 26 July 2015 12:30 AM, Animesh Manna wrote: As csr firmware is taking care of loading the firmware, so no need for driver to load again. Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Signed-off-by: Animesh Manna Signed-off

Re: [Intel-gfx] [PATCH 17/18] drm/i915/skl: Removed csr firmware load in resume path.

2015-07-29 Thread Sunil Kamath
On Tuesday 28 July 2015 04:53 PM, Sunil Kamath wrote: On Sunday 26 July 2015 12:30 AM, Animesh Manna wrote: As csr firmware is taking care of loading the firmware, so no need for driver to load again. Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Signed-off-by: Animesh Manna Signed-off

Re: [Intel-gfx] [PATCH 17/18] drm/i915/skl: Removed csr firmware load in resume path.

2015-07-28 Thread Sunil Kamath
On Sunday 26 July 2015 12:30 AM, Animesh Manna wrote: As csr firmware is taking care of loading the firmware, so no need for driver to load again. Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Signed-off-by: Animesh Manna Signed-off-by: Vathsala Nagaraju --- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 18/18] drm/i915/gen9: Removed byte swapping for csr firmware.

2015-07-28 Thread Sunil Kamath
wapping for csr firmware. Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Signed-off-by: Animesh Manna Signed-off-by: Vatsala Nagaraju --- drivers/gpu/drm/i915/intel_csr.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_csr.c b/

Re: [Intel-gfx] [PATCH 04/18] drm/i915/gen9: block disable call for pw1 if dmc firmware is present.

2015-07-28 Thread Sunil Kamath
call. Cc: Daniel Vetter Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Signed-off-by: Animesh Manna Signed-off-by: Vathsala Nagaraju Please use the approach I've laid out in my original patch series with "drm/i915: use correct power domain for csr loading" and "drm/

Re: [Intel-gfx] [PATCH 03/18] drm/i915/bxt: Stepping info added for bxt.

2015-07-26 Thread Sunil Kamath
On Sunday 26 July 2015 12:30 AM, Animesh Manna wrote: Added stepping info in intel_csr.c which is required to extract specific firmware from packaged dmc firmware. Cc: Vetter, Daniel Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 02/18] drm/i915/bxt: Modified HAS_CSR, added support for BXT.

2015-07-26 Thread Sunil Kamath
On Sunday 26 July 2015 12:30 AM, Animesh Manna wrote: Modified HAS_CSR macro defination which earlier only supported for skl, now added support for BXT. Cc: Vetter, Daniel Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/i915_drv.h

Re: [Intel-gfx] [PATCH 01/18] drm/i915/bxt: Path added of dmc firmware ver1 for BXT

2015-07-26 Thread Sunil Kamath
On Sunday 26 July 2015 12:30 AM, Animesh Manna wrote: Cc: Damien Lespiau Cc: Rodrigo Vivi Cc: Sunil Kamath Signed-off-by: Animesh Manna --- Please update the commit message header relevant details. even one liner is sufficient. Minor thing to take care. Reviewed-by: A.Sunil Kamath

Re: [Intel-gfx] [PATCH 00/18] Redesign of dmc firmware loading.

2015-07-26 Thread Sunil Kamath
On Sunday 26 July 2015 12:30 AM, Animesh Manna wrote: Display microcontroller(DMC) used to save and restore display engine status while entering into low power display states for gen9 platform. Though skylake and broxton both are gen9 platform but dmc act diferently. Skylake is solely dependednt