Re: [Intel-gfx] Oops with i915

2018-06-18 Thread Sudip Mukherjee
Hi Ville, On Mon, Jun 18, 2018 at 03:09:15PM +0300, Ville Syrjälä wrote: > On Thu, Jun 07, 2018 at 11:06:33AM +0100, Sudip Mukherjee wrote: > > Hi All, > > > > We are running v4.14.47 kernel and recently in one of our test cycle > > we saw the below trace. I know t

Re: [Intel-gfx] Oops with i915

2018-06-18 Thread Sudip Mukherjee
On Thu, Jun 07, 2018 at 11:06:33AM +0100, Sudip Mukherjee wrote: > Hi All, > > We are running v4.14.47 kernel and recently in one of our test cycle > we saw the below trace. I know this is not the usual way to raise a > BUG report, but since this was seen only once in one of the a

[Intel-gfx] Oops with i915

2018-06-07 Thread Sudip Mukherjee
Hi All, We are running v4.14.47 kernel and recently in one of our test cycle we saw the below trace. I know this is not the usual way to raise a BUG report, but since this was seen only once in one of the automated test cycle so I donot have anything else apart from this trace. Is this a known iss

Re: [Intel-gfx] i915 with valleyview

2016-05-09 Thread Sudip Mukherjee
On Mon, May 09, 2016 at 11:19:16AM +0300, Jani Nikula wrote: > On Fri, 06 May 2016, Sudip Mukherjee wrote: > > On Fri, May 06, 2016 at 12:21:04PM +0100, Sudip Mukherjee wrote: > >> Hi Daniel, > >> I am trying to use i915 in one of our board which has Intel ATOM E

Re: [Intel-gfx] i915 with valleyview

2016-05-06 Thread Sudip Mukherjee
On Fri, May 06, 2016 at 12:21:04PM +0100, Sudip Mukherjee wrote: > Hi Daniel, > I am trying to use i915 in one of our board which has Intel ATOM E3840. > I know Intel has released emgd driver for this cpu to use i915 but emgd > is not supported on v4.5 (or v4.6). The board is having

[Intel-gfx] i915 with valleyview

2016-05-06 Thread Sudip Mukherjee
Hi Daniel, I am trying to use i915 in one of our board which has Intel ATOM E3840. I know Intel has released emgd driver for this cpu to use i915 but emgd is not supported on v4.5 (or v4.6). The board is having SFI (simple firmware interface) and maybe for that i915 is not finding the VBIOS and oth

Re: [Intel-gfx] [PATCH RESEND 2/3] drm/i915: check for return value

2015-12-09 Thread Sudip Mukherjee
On Thu, Oct 08, 2015 at 04:29:31PM +0200, Daniel Vetter wrote: > On Thu, Oct 08, 2015 at 07:28:00PM +0530, Sudip Mukherjee wrote: > > We were not checking the return value of drm_encoder_init() which can > > fail. And if it fails then we will be working with an uninitiali

[Intel-gfx] [PATCH RESEND 2/3] drm/i915: check for return value

2015-10-08 Thread Sudip Mukherjee
We were not checking the return value of drm_encoder_init() which can fail. And if it fails then we will be working with an uninitialized encoder. Cc: Daniel Vetter Cc: Jani Nikula Signed-off-by: Sudip Mukherjee --- Sent on 27/07/2015 drivers/gpu/drm/i915/intel_dp.c | 6 -- 1 file

[Intel-gfx] [PATCH RESEND 1/3] drm/i915: use error path

2015-10-08 Thread Sudip Mukherjee
: Sudip Mukherjee --- Sent on 27/07/2015 drivers/gpu/drm/i915/intel_dp.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 8d34ca7..18bcfbe 100644 --- a/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v2] drm/i915: load driver even if debugfs fails

2015-08-03 Thread Sudip Mukherjee
On Mon, Aug 03, 2015 at 12:54:33PM +0200, Daniel Vetter wrote: > On Mon, Aug 03, 2015 at 02:56:42PM +0530, Sudip Mukherjee wrote: > > On Thu, Jul 23, 2015 at 07:36:12PM +0530, Sudip Mukherjee wrote: > > > debugfs files are not necessary for the usual operation of the driver &g

Re: [Intel-gfx] [PATCH v2] drm/i915: load driver even if debugfs fails

2015-08-03 Thread Sudip Mukherjee
On Thu, Jul 23, 2015 at 07:36:12PM +0530, Sudip Mukherjee wrote: > debugfs files are not necessary for the usual operation of the driver > and the device. No need to check for the return values from the debugfs > file creation. Even if one debugfs file fails to create we try with t

[Intel-gfx] [PATCH 2/2] drm/i915: check for return value

2015-07-27 Thread Sudip Mukherjee
We were not checking the return value of drm_encoder_init() which can fail. And if it fails then we will be working with an uninitialized encoder. Signed-off-by: Sudip Mukherjee --- drivers/gpu/drm/i915/intel_dp.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers

[Intel-gfx] [PATCH 1/2] drm/i915: use error path

2015-07-27 Thread Sudip Mukherjee
Use goto to handle the error path to avoid duplicating the same code. In the error path intel_dig_port is the last one to be released as it was the first one to be allocated and ideally the error path should be the reverse of the execution path. Signed-off-by: Sudip Mukherjee --- drivers/gpu

[Intel-gfx] [PATCH v2] drm/i915: load driver even if debugfs fails

2015-07-23 Thread Sudip Mukherjee
to load. cleanup will clean all the created debugfs files as the list of file that are created are maintained in minor->debugfs_list. Cc: Chris Wilson Signed-off-by: Sudip Mukherjee --- v1 was drm/i915: add error path drivers/gpu/drm/i915/i915_debugfs.c | 31 ---

Re: [Intel-gfx] [PATCH] drm/i915: add error path

2015-07-22 Thread Sudip Mukherjee
On Wed, Jul 22, 2015 at 12:39:37PM +0100, Chris Wilson wrote: > On Wed, Jul 22, 2015 at 04:58:47PM +0530, Sudip Mukherjee wrote: > > If any of the debug file creation fails we were just returning the > > error code to the drm layer. But the debug files that we created in the >

[Intel-gfx] [PATCH] drm/i915: add error path

2015-07-22 Thread Sudip Mukherjee
If any of the debug file creation fails we were just returning the error code to the drm layer. But the debug files that we created in the process were not removed. And debugfs files are not automatically cleaned up. Signed-off-by: Sudip Mukherjee --- Hi Daniel, Whom should i keep Cc: for this

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: remove unnecessary null test

2015-07-21 Thread Sudip Mukherjee
On Tue, Jul 21, 2015 at 03:51:40PM +0200, Daniel Vetter wrote: > On Tue, Jul 21, 2015 at 05:36:45PM +0530, Sudip Mukherjee wrote: > > While creating the debugfs file we are setting the inode->i_private to > > dev. That same dev is passed to these functions as private of struc

[Intel-gfx] [PATCH v3 2/2] drm/i915: remove redundant if check

2015-07-21 Thread Sudip Mukherjee
The extra check for connector_type is not required as we are already checking for connector_type != DRM_MODE_CONNECTOR_DisplayPort. The check was added by commit eb3394faeb97 ("drm/i915: Add debugfs test control files for Displayport compliance testing") Signed-off-by: Sudip Mukherjee

[Intel-gfx] [PATCH v3 1/2] drm/i915: remove unnecessary null test

2015-07-21 Thread Sudip Mukherjee
added by commit eb3394faeb97 ("drm/i915: Add debugfs test control files for Displayport compliance testing") Signed-off-by: Sudip Mukherjee --- v3: removed the check in i915_displayport_test_active_write also v2: removed null check v1 was drm/i915: fix possible null pointer dereferenc

Re: [Intel-gfx] [PATCH v2] drm/i915: remove unnecessary null test

2015-07-20 Thread Sudip Mukherjee
On Mon, Jul 20, 2015 at 05:33:50PM +0200, Daniel Vetter wrote: > On Mon, Jul 20, 2015 at 08:36:01PM +0530, Sudip Mukherjee wrote: > > While creating the debugfs file we are setting the inode->i_private to > > dev. That same dev is passed to these functions as private of struc

[Intel-gfx] [PATCH v2] drm/i915: remove unnecessary null test

2015-07-20 Thread Sudip Mukherjee
While creating the debugfs file we are setting the inode->i_private to dev. That same dev is passed to these functions as private of struct seq_file via single_open(). So at this point it can never be NULL. Signed-off-by: Sudip Mukherjee --- v1 was drm/i915: fix possible null poin

Re: [Intel-gfx] [PATCH] drm/i915: fix possible null pointer dereference

2015-07-20 Thread Sudip Mukherjee
On Mon, Jul 20, 2015 at 01:38:46PM +0100, Chris Wilson wrote: > On Mon, Jul 20, 2015 at 05:59:29PM +0530, Sudip Mukherjee wrote: > > We were dereferencing dev first and then checking if it is NULL. Lets > > check for NULL first and then dereference. > > The code is bonkers.

[Intel-gfx] [PATCH] drm/i915: fix possible null pointer dereference

2015-07-20 Thread Sudip Mukherjee
We were dereferencing dev first and then checking if it is NULL. Lets check for NULL first and then dereference. Signed-off-by: Sudip Mukherjee --- drivers/gpu/drm/i915/i915_debugfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b

Re: [Intel-gfx] [BUG/REGRESSION] Screen flickering

2015-05-13 Thread Sudip Mukherjee
On Wed, May 13, 2015 at 01:27:06PM +0200, Thomas Gummerer wrote: > Sudip Mukherjee writes: > > > On Wed, May 13, 2015 at 11:53:19AM +0200, Jan Niehusmann wrote: > > http://patchwork.freedesktop.org/patch/46071/ > > Thank you for the pointer, but this seems to be an unr

Re: [Intel-gfx] [BUG/REGRESSION] Screen flickering

2015-05-13 Thread Sudip Mukherjee
On Wed, May 13, 2015 at 01:10:11PM +0200, Jan Niehusmann wrote: > On Wed, May 13, 2015 at 04:02:25PM +0530, Sudip Mukherjee wrote: > > > What I'm missing in the report, are some log entries I'm seeing on my > > > notebook: > > >

Re: [Intel-gfx] [PATCH] Revert "drm/i915: Performed deferred clflush inside set-cache-level"

2015-04-12 Thread Sudip Mukherjee
On Wed, Apr 01, 2015 at 10:01:50AM +0530, Sudip Mukherjee wrote: > On Tue, Mar 31, 2015 at 04:35:49PM +0100, Chris Wilson wrote: > > On Tue, Mar 31, 2015 at 08:40:12PM +0530, Sudip Mukherjee wrote: > > > This reverts commit <0f71979ab7fbd0c71c41c2798de3d33937915434>. >

Re: [Intel-gfx] [PATCH] Revert "drm/i915: Performed deferred clflush inside set-cache-level"

2015-03-31 Thread Sudip Mukherjee
On Tue, Mar 31, 2015 at 04:35:49PM +0100, Chris Wilson wrote: > On Tue, Mar 31, 2015 at 08:40:12PM +0530, Sudip Mukherjee wrote: > > This reverts commit <0f71979ab7fbd0c71c41c2798de3d33937915434>. > > > > my display was getting garbled for a moment very frequently.

[Intel-gfx] [PATCH] Revert "drm/i915: Performed deferred clflush inside set-cache-level"

2015-03-31 Thread Sudip Mukherjee
is not having that problem. Signed-off-by: Sudip Mukherjee --- my system is x86_64. lspci -k gives: "VGA compatible controller: Intel Corporation Xeon E3-1200 v2/3rd Gen Core processor Graphics Controller (rev 09) Subsystem: Foxconn International, Inc. Device 0d74 Kernel driver in use: i91

Re: [Intel-gfx] WARNING: at drivers/gpu/drm/i915/intel_display.c:11375 [i915] in 3.19-rc2

2015-01-04 Thread Sudip Mukherjee
On Thu, Jan 01, 2015 at 05:22:15PM +0300, Andrey Skvortsov wrote: > Hi, > > this warning does not exist in 3.19-rc1, but it happens every boot in > 3.19-rc2. If you need any other information or data, I would be glad > to help to debug it. mine is also i915, but i am not seeing any warning. if y