Re: [Intel-gfx] [PATCH 1/2] drm/mxsfb: Call drm_crtc_vblank_on/off

On 2020-05-28 10:06, Daniel Vetter wrote: > On Thu, May 28, 2020 at 9:56 AM Stefan Agner wrote: >> >> Hi Daniel, >> >> On 2020-05-28 07:46, Daniel Vetter wrote: >> > On Wed, May 27, 2020 at 11:47:56AM +0200, Daniel Vetter wrote: >> >> mxsfb

Re: [Intel-gfx] [PATCH 1/2] drm/mxsfb: Call drm_crtc_vblank_on/off

e_vblank callback we can do >> the on/off as the first respectively last operation, and it should all >> work. >> >> Signed-off-by: Daniel Vetter >> Cc: Marek Vasut >> Cc: Stefan Agner >> Cc: Shawn Guo >> Cc: Sascha Hauer >> Cc: Pengutroni

Re: [Intel-gfx] [PATCH 22/59] drm/mxsfb: Drop drm_gem_prime_export/import

On 14.06.2019 22:35, Daniel Vetter wrote: > They're the default. > > Aside: Would be really nice to switch the others over to > drm_gem_object_funcs. Acked-by: Stefan Agner -- Stefan > > Signed-off-by: Daniel Vetter > Cc: Marek Vasut > Cc: Stefan Agner > C

Re: [Intel-gfx] [PATCH 15/59] drm/fsl-dcu: Drop drm_gem_prime_export/import

On 14.06.2019 22:35, Daniel Vetter wrote: > They're the default. > > Aside: Would be really nice to switch the others over to > drm_gem_object_funcs. Acked-by: Stefan Agner -- Stefan > > Signed-off-by: Daniel Vetter > Cc: Stefan Agner > Cc: Alison Wang >

Re: [Intel-gfx] [RFC][PATCH 04/11] drm: Split the display info into static and dynamic parts

lear out the entire dynamic state with memset(). Back when I introduced bus flags it was meant to be a static information. So for the general idea/drm_connector.h: Reviewed-by: Stefan Agner [...] > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 2 +- For fsl-dcu: Ack

Re: [Intel-gfx] [PATCH 19/37] drm/fsl: Drop drm_vblank_cleanup

On 2017-05-31 01:52, Daniel Vetter wrote: > On Tue, May 30, 2017 at 02:17:04PM -0700, Stefan Agner wrote: >> On 2017-05-26 00:00, Daniel Vetter wrote: >> > On Thu, May 25, 2017 at 10:18 AM, Stefan Agner wrote: >> >> On 2017-05-24 07:51, Daniel Vetter wrote: &

Re: [Intel-gfx] [PATCH 19/37] drm/fsl: Drop drm_vblank_cleanup

On 2017-05-26 00:00, Daniel Vetter wrote: > On Thu, May 25, 2017 at 10:18 AM, Stefan Agner wrote: >> On 2017-05-24 07:51, Daniel Vetter wrote: >>> Again cleanup before irq disabling doesn't really stop the races, >>> so just drop it. Proper fix would be t

Re: [Intel-gfx] [PATCH 07/37] drm: Extract drm_vblank.[hc]

On 2017-05-24 07:51, Daniel Vetter wrote: > drm_irq.c contains both the irq helper library (optional) and the > vblank support (optional, but part of the modeset uapi, and doesn't > require the use of the irq helpers at all. > > Split this up for more clarity of the scope of the individual bits. >

Re: [Intel-gfx] [PATCH 19/37] drm/fsl: Drop drm_vblank_cleanup

efore, I think that fixed the races I saw. But I guess what you are saying instead of using drm_crtc_force_disable_all I should use drm_atomic_helper_shutdown...? Will try that. FWIW, Acked-by: Stefan Agner -- Stefan > > Cc: Stefan Agner > Signed-off-by: Daniel Vetter > ---

Re: [Intel-gfx] [PATCH 08/37] drm/doc: Polish irq helper documentation

On 2017-05-24 07:51, Daniel Vetter wrote: > Pull a (much shorter) overview into drm_irq.c, and instead put the > callback documentation into in-line comments in drm_drv.h. Looks good and just found all I needed to know to fix IRQ registration in fsl dcu. Reviewed-by: Stefan Agner >

Re: [Intel-gfx] [PATCH 18/38] drm/fsl-du: Implement some semblance of vblank event handling

ems to me that the current code does not what atomic is asking for, checking that is on my 2do... I tested this patch individually, using modesetting driver. Things seem to work as they did before. Acked-by: Stefan Agner But I guess to test the non-blocking commit, I would have to apply the