Re: [Intel-gfx] [PATCH v4 13/23] drm: zte: Provide ddc symlink in vga connector sysfs directory

2019-07-22 Thread Shawn Guo
On Thu, Jul 11, 2019 at 01:26:40PM +0200, Andrzej Pietrasiewicz wrote: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Acked-by: Shawn Guo ___ Intel-gfx mailing list Intel-gfx@lists.freede

Re: [Intel-gfx] [PATCH v4 12/23] drm: zte: Provide ddc symlink in hdmi connector sysfs directory

2019-07-22 Thread Shawn Guo
On Thu, Jul 11, 2019 at 01:26:39PM +0200, Andrzej Pietrasiewicz wrote: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Acked-by: Shawn Guo ___ Intel-gfx mailing list Intel-gfx@lists.freede

Re: [Intel-gfx] [PATCH 39/59] drm/zte: Drop drm_gem_prime_export/import

2019-06-18 Thread Shawn Guo
On Fri, Jun 14, 2019 at 10:35:55PM +0200, Daniel Vetter wrote: > They're the default. > > Aside: Would be really nice to switch the others over to > drm_gem_object_funcs. > > Signed-off-by: Daniel Vetter > Cc: Shawn Guo Acked-by: Shawn Guo > --- > driv

Re: [Intel-gfx] [PATCH v2 13/23] drm/zte: Stop consulting plane->fb

2018-03-26 Thread Shawn Guo
On Thu, Mar 22, 2018 at 07:40:03PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > We want to get rid of plane->fb on atomic drivers. Stop looking at it. Would it be more precise to use "plane->crtc" in both subject and commit log? Other than that: Acked-by:

Re: [Intel-gfx] [PATCH 14/15] drm/zte: Use drm_mode_get_hv_timing() to populate plane clip rectangle

2017-11-28 Thread Shawn Guo
choice since that's the > mode the user provided and it matches the plane crtc coordinates > the user also provided. > > Once everyone agrees on this we can move the clip handling into > drm_atomic_helper_check_plane_state(). > > Cc: Laurent Pinchart > Cc: Shawn Guo

Re: [Intel-gfx] [PATCH 7/8] drm: Nuke drm_atomic_helper_connector_dpms

2017-07-25 Thread Shawn Guo
vga.c | 1 - Acked-by: Shawn Guo ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 12/13] drm/zte: Drop drm_vblank_cleanup

2017-06-21 Thread Shawn Guo
On Wed, Jun 21, 2017 at 10:28:49AM +0200, Daniel Vetter wrote: > It again looks all cargo-culted for no good reasons. > > Cc: Shawn Guo > Signed-off-by: Daniel Vetter Acked-by: Shawn Guo ___ Intel-gfx mailing list Intel-gfx@lists.fre

Re: [Intel-gfx] [PATCH 36/37] drm/zte: Drop drm_vblank_cleanup

2017-05-26 Thread Shawn Guo
On Fri, May 26, 2017 at 08:57:32AM +0200, Daniel Vetter wrote: > On Thu, May 25, 2017 at 5:01 AM, Shawn Guo wrote: > > On Wed, May 24, 2017 at 04:52:11PM +0200, Daniel Vetter wrote: > >> It again looks all cargo-culted for no good reasons. > > > > drm_vblank_clea

Re: [Intel-gfx] [PATCH 36/37] drm/zte: Drop drm_vblank_cleanup

2017-05-26 Thread Shawn Guo
On Wed, May 24, 2017 at 04:52:11PM +0200, Daniel Vetter wrote: > It again looks all cargo-culted for no good reasons. drm_vblank_cleanup() is called to release the resources allocated by drm_vblank_init(). I think that's the reason, no? Shawn > > Cc: Shawn Guo > Signed-off-