Re: [Intel-gfx] Potential NULL pointer dereference in intel_crt_get_edid

2019-03-20 Thread Shaobo He
hanks, Shaobo On 2019/3/19 2:32, Jani Nikula wrote: On Mon, 18 Mar 2019, Shaobo He wrote: I see. In light of this commit, is it a better solution than adding NULL-checks is to replace the if branch conditioned by `WARN_ON` with simply `WARN` like the following, struct i2c_ad

[Intel-gfx] Potential NULL pointer dereference in intel_crt_get_edid

2019-03-19 Thread Shaobo He
Hello everyone, My name is Shaobo He and I am a graduate student at University of Utah. I am using a static analysis tool to search for null pointer dereferences and came across a potentially invalid memory access in the file drivers/gpu/drm/i915/intel_crt.c: in function `intel_crt_detect_ddc

Re: [Intel-gfx] Potential NULL pointer dereference in intel_crt_get_edid

2019-03-19 Thread Shaobo He
, unsigned int pin) { WARN(!intel_gmbus_is_valid_pin(dev_priv, pin), "Invalid pin: %d\n", pin); return &dev_priv->gmbus[pin].adapter; } Shaobo On 3/18/19 5:53 PM, Rodrigo Vivi wrote: On Mon, Mar 18, 2019 at 05:39:48PM -0600, Shaobo He wrote: Hi Rodrigo, Sorry I&

Re: [Intel-gfx] Potential NULL pointer dereference in intel_crt_get_edid

2019-03-19 Thread Shaobo He
Hi Rodrigo, Sorry I'm a bit lost here. May I ask where the `WARN` is? Thanks, Shaobo On 3/18/19 5:26 PM, Rodrigo Vivi wrote: Hi Shaobo, n Mon, Mar 18, 2019 at 05:01:10PM -0600, Shaobo He wrote: Hello everyone, My name is Shaobo He and I am a graduate student at University of Utah.