Re: [Intel-gfx] [PATCH v4 5/5] i915: add documentation to intel_engine_cs

HI, -Original Message- From: Joonas Lahtinen [mailto:joonas.lahti...@linux.intel.com] - snip - >> >> void(*set_default_submission)(struct intel_engine_cs >> *engine); >> >> + /* In addition to pinning the context, returns the intel_ringbuffer >> +

Re: [Intel-gfx] [PATCH v2 1/1] i915: additional GEM documentation

Hi, Thankyou for the very thorough read and comments, this is exactly what is needed to give it polish and become a good intro to GEM in i915; I just wished I had waited on posting a v3 just a few more hours and I would have been able to use all this for v3. I will use all of your comments in

Re: [Intel-gfx] [PATCH v3 0/6] Documentation patch for batchbuffer submission

Hi, >>Call out GEM_EXECBUFFER as deprecated. > Oh not it isn't. _WR has a singular purpose that isn't even the recommend > method any more. I had understood that DRM_I915_GEM_EXECBUFFER was considered deprecated. I will fix this mistake on next spin. I had thought that DRM_i915_GEM_EXECBUF

Re: [Intel-gfx] [PATCH 1/1 RFC] drivers/gpu/drm/i915:Documentation for batchbuffer submission

Hi, > These documentation improvements are much welcome, here are a few comments > from me. Thankyou! >Quoting kevin.rogo...@intel.com (2018-02-16 16:04:22) >> +Intel GPU Basics >> + >> + >> +An Intel GPU has multiple engines. There are several engine types. >> + >> +- RCS engin

Re: [Intel-gfx] [PATCH 3/3] i965: check scratch page in a locked fashion on each ioctl

Thanks, I will make a v2 and post it shortly to correct for my terribly embarrassing omission caused by even more terribly embarrassing ignorance. -Kevin -Original Message- From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] Sent: Tuesday, December 5, 2017 12:39 PM To: Rogovin, Kevin

Re: [Intel-gfx] [PATCH 3/3] i965: check scratch page in a locked fashion on each ioctl

Hi, > Per context, then you can remove the locking. It's fitting since the scratch > page is per-context anyway. The scratch page is per context? This I did not know, I thought it was per PPGTT. If that is the case, then my proposed interface to get/set the scratch page contents is wrong beca

Re: [Intel-gfx] [PATCH 2/3] i965: define stuff for scratch page checking in intel_screen

-bounds-write-detect which has the initialization of the scratch page with noise. -Kevin -Original Message- From: Rogovin, Kevin Sent: Tuesday, December 5, 2017 9:48 AM To: intel-gfx@lists.freedesktop.org Cc: Rogovin, Kevin Subject: [PATCH 2/3] i965: define stuff for scratch page checking

Re: [Intel-gfx] [PATCH 1/3] drm-uapi: define interface to kernel for scratch page read

-bounds-write-detect which has the initialization of the scratch page with noise. -Kevin -Original Message- From: Rogovin, Kevin Sent: Tuesday, December 5, 2017 9:48 AM To: intel-gfx@lists.freedesktop.org Cc: Rogovin, Kevin Subject: [PATCH 1/3] drm-uapi: define interface to kernel for

[Intel-gfx] Nov 2013 MSR: Kevin Rogovin

MSR Nov 2013, Kevin Rogovin Benchmark Suite: Creation of a benchmark suite (found on Teamforge) where each benchmark stresses a particular point of an OpenGL implementation. A number of bugs have been found and reported from running this suite on Mesa: https://bugs.freedesktop.org/show_b

[Intel-gfx] Intel DRM API Reference?

Hi all, I've been digging through Mesa's i965 and am at the point that I likely need to atleast know what is the API for the intel_drm calls. Chasing the code in DRM sources for each of the calls leaves me with essentially a function pointer chase which then lands me with an ioctl call. The i