Re: [Intel-gfx] build error with GCC5.1.1

2015-05-18 Thread Olivier Fourdan
Hey, > gcc5.1.1 generates an error at build time. > > sna_accel.c: In function 'sna_poly_zero_line_blt': > sna_accel.c:9207:10: warning: variable 'intersects' set but not used > [-Wunused-but-set-variable] >bool intersects; >^ > sna_accel.c:9107:6: warning: variable 'degenerat

[Intel-gfx] [PATCH] backlight: Do not hang forever if helper pid is -1

2015-04-29 Thread Olivier Fourdan
Backlight helper PID is set to -1 by default, if for some reason it's not set, we may end up with waitpid(-1, ...) which will hang forever. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90230 Signed-off-by: Olivier Fourdan --- src/backlight.c | 2 +- 1 file changed, 1 insertion(

Re: [Intel-gfx] [RFC PATCH] sna: Fix build with gcc 5.0

2015-04-24 Thread Olivier Fourdan
On 24/04/15 10:43, Olivier Fourdan wrote: [...] Yet, *not* setting _FORTIFY_SOURCE seems to work around the issue. I find it weird the error is with the inlining of memcpy() ... I'll double check on the gcc side and report back once I know more :) Quick follow-up, I checked with Jakub a

Re: [Intel-gfx] [RFC PATCH] sna: Fix build with gcc 5.0

2015-04-24 Thread Olivier Fourdan
Hi Chris, On 24/04/15 10:11, Chris Wilson wrote: On Fri, Apr 24, 2015 at 09:43:37AM +0200, Olivier Fourdan wrote: gcc generates an error at build time because it fails to inline some functions: blt.c: In function 'affine_blt': blt.c:980:1: error: inlining failed

[Intel-gfx] [RFC PATCH] sna: Fix build with gcc 5.0

2015-04-24 Thread Olivier Fourdan
ear_interpolation(tl, tr, bl, br, fx, fy); ^ Do not force inlining of these functions and let the compiler decide to avoid the compilation failure. Signed-off-by: Olivier Fourdan --- Note: It could be a gcc bug, I am not sure, I don't know enough of gcc internals to tell, that'

[Intel-gfx] [PATCH v2] uxa: Do not register hotplug without RandR

2015-04-08 Thread Olivier Fourdan
. Signed-off-by: Olivier Fourdan --- v2: Do not register udev monitor without RandR as done in sna. src/uxa/intel_driver.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/uxa/intel_driver.c b/src/uxa/intel_driver.c index 6e64b8c..7cd770f 100644 --- a/src/uxa/intel_driver.c +++ b/src

[Intel-gfx] [PATCH] uxa: Do not use RandR in hotplug if not available

2015-04-02 Thread Olivier Fourdan
When using Xinerama, RandR is automatically disabled, and calling RR routines will trigger an assert() because the RR keys/resources are not set, leading to an Xserver abort. Hotplug makes little sense without RandR, so it's safer to just return if RandR is not available. Signed-off-by: Ol