Re: [Intel-gfx] [PATCH v6 3/7] drm/i915/guc: add enable_guc_loading parameter

2016-05-23 Thread Nick Hoath
Ursulin Reviewed-by: Tvrtko Ursulin (v5) Signed-off-by: Tvrtko Ursulin Reviewed-by: Nick Hoath (v6) --- drivers/gpu/drm/i915/i915_gem.c| 5 +- drivers/gpu/drm/i915/i915_guc_submission.c | 4 +- drivers/gpu/drm/i915/i915_params.c | 14 +++- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v3] drm/i915: resize the GuC WOPCM for rc6

2016-05-16 Thread Nick Hoath
On 06/05/2016 13:18, Gordon, David S wrote: On 06/05/16 10:37, Nick Hoath wrote: On 05/05/2016 16:04, Dave Gordon wrote: On 05/05/2016 15:02, Antoine, Peter wrote: The attached version still does not explain that the WOPCM_TOP is to tell the GuC not to use that space. That's NOT

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/guc: GuC firmware loading updates

2016-05-12 Thread Nick Hoath
On 09/05/2016 08:53, Patchwork wrote: == Series Details == Series: drm/i915/guc: GuC firmware loading updates URL : https://patchwork.freedesktop.org/series/6818/ State : warning == Summary == Series 6818v1 drm/i915/guc: GuC firmware loading updates http://patchwork.freedesktop.org/api/1.0/s

[Intel-gfx] [PATCH 2/2] drm/i915/guc: Add Broxton GuC firmware loading support

2016-05-06 Thread Nick Hoath
Issue: VIZ-7772 Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/intel_guc_loader.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_guc_loader.c b/drivers/gpu/drm/i915/intel_guc_loader.c index 46b01d7..d122e74 100644 --- a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 0/2] drm/i915/guc: GuC firmware loading updates

2016-05-06 Thread Nick Hoath
Updates to Skylake firmware filename & support for loading Broxton firmware. Nick Hoath (1): drm/i915/guc: Add Broxton GuC firmware loading support Tom O'Rourke (1): drm/i915/guc: Use major_minor version for filename drivers/gpu/drm/i915/intel_guc_loader.c | 9 - 1 file c

[Intel-gfx] [PATCH 1/2] drm/i915/guc: Use major_minor version for filename

2016-05-06 Thread Nick Hoath
be used by default without some testing. Issue: VIZ-7713 Signed-off-by: Tom O'Rourke Signed-off-by: Nick Hoath Acked-by: Jani Nikula --- drivers/gpu/drm/i915/intel_guc_loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_guc_loader.c b/drive

Re: [Intel-gfx] [PATCH v3] drm/i915: resize the GuC WOPCM for rc6

2016-05-06 Thread Nick Hoath
On 05/05/2016 16:04, Dave Gordon wrote: On 05/05/2016 15:02, Antoine, Peter wrote: The attached version still does not explain that the WOPCM_TOP is to tell the GuC not to use that space. That's NOT what WOPCM_TOP means. The GuC is allowed to use the space up to the value stored in the GUC_WO

Re: [Intel-gfx] [PATCH v3] drm/i915: resize the GuC WOPCM for rc6

2016-05-06 Thread Nick Hoath
omment was required. And this patch has been held up two weeks just for a better comment. Peter. .Dave. And what if the next reserved space is not for RC6? But, I have not actual objection to the patch. Peter. Tested-by: Nick Hoath Reviewed-by: Nick Hoath -- Peter Antoin

Re: [Intel-gfx] [PATCH v12] drm/i915: Extend LRC pinning to cover GPU context writeback

2016-01-26 Thread Nick Hoath
On 25/01/2016 18:19, Daniel Vetter wrote: On Fri, Jan 22, 2016 at 02:25:27PM +, Nick Hoath wrote: Use the first retired request on a new context to unpin the old context. This ensures that the hw context remains bound until it has been written back to by the GPU. Now that the context is

[Intel-gfx] [PATCH v12] drm/i915: Extend LRC pinning to cover GPU context writeback

2016-01-22 Thread Nick Hoath
ev. v11: Kick BAT rerun v12: Rebase Signed-off-by: Nick Hoath Issue: VIZ-4277 --- drivers/gpu/drm/i915/intel_lrc.c | 37 +++-- 1 file changed, 15 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c index

Re: [Intel-gfx] [PATCH v2 4/8] drm/i915/bxt: Add GEN9_CS_DEBUG_MODE1 to HW whitelist

2016-01-21 Thread Nick Hoath
the same GT these are extended for A1 as well. These are also required for SKL until B0 but not adding them because they are pre-production steppings. v2: use lower case in register defines (Nick) Signed-off-by: Arun Siluvery Reviewed-by: Nick Hoath --- drivers/gpu/drm/i915/i915_reg.h

Re: [Intel-gfx] [PATCH v2 8/8] drm/i915/gen9: Add WaOCLCoherentLineFlush

2016-01-21 Thread Nick Hoath
On 21/01/2016 14:00, Arun Siluvery wrote: This is mainly required for preemption. Cc: Dave Gordon Signed-off-by: Arun Siluvery Reviewed-by: Nick Hoath --- drivers/gpu/drm/i915/intel_ringbuffer.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v2 7/8] drm/i915/skl: Enable Per context Preemption granularity control

2016-01-21 Thread Nick Hoath
On 21/01/2016 14:00, Arun Siluvery wrote: Per context preemption granularity control is only available from SKL:E0+ Cc: Dave Gordon Signed-off-by: Arun Siluvery Reviewed-by: Nick Hoath --- drivers/gpu/drm/i915/i915_reg.h | 3 +++ drivers/gpu/drm/i915/intel_ringbuffer.c | 10

Re: [Intel-gfx] [PATCH 7/8] drm/i915/skl: Enable Per context Preemption granularity control

2016-01-21 Thread Nick Hoath
On 13/01/2016 10:06, Arun Siluvery wrote: Per context preemption granularity control is only available from SKL:E0+ Cc: Dave Gordon Signed-off-by: Arun Siluvery --- drivers/gpu/drm/i915/i915_reg.h | 3 +++ drivers/gpu/drm/i915/intel_ringbuffer.c | 10 ++ 2 files changed, 1

Re: [Intel-gfx] [PATCH 6/8] drm/i915/skl: Add GEN8_L3SQCREG4 to HW whitelist

2016-01-21 Thread Nick Hoath
On 13/01/2016 10:06, Arun Siluvery wrote: Required for WaDisableLSQCROPERFforOCL:skl Signed-off-by: Arun Siluvery Reviewed-by: Nick Hoath --- drivers/gpu/drm/i915/intel_ringbuffer.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b

Re: [Intel-gfx] [PATCH 5/8] drm/i915/bxt: Add GEN8_L3SQCREG4 to HW whitelist

2016-01-21 Thread Nick Hoath
On 13/01/2016 10:06, Arun Siluvery wrote: Required for WaDisableLSQCROPERFforOCL:bxt According to WA database these are only applicable for BXT:A0 but since A0 and A1 shares the same GT these are extended for A1 as well. Signed-off-by: Arun Siluvery Reviewed-by: Nick Hoath --- drivers

Re: [Intel-gfx] [PATCH 4/8] drm/i915/bxt: Add GEN9_CS_DEBUG_MODE1 to HW whitelist

2016-01-21 Thread Nick Hoath
On 13/01/2016 10:06, Arun Siluvery wrote: Required for, WaDisableObjectLevelPreemptionForTrifanOrPolygon:bxt WaDisableObjectLevelPreemptionForInstancedDraw:bxt WaDisableObjectLevelPreemtionForInstanceId:bxt According to WA database these are only applicable for BXT:A0 but since A0 and A1 shares

Re: [Intel-gfx] [PATCH 3/8] drm/i915/gen9: Add HDC_CHICKEN1 to HW whitelist

2016-01-21 Thread Nick Hoath
On 13/01/2016 10:06, Arun Siluvery wrote: Required for WaAllowUMDToModifyHDCChicken1:skl,bxt Signed-off-by: Arun Siluvery Reviewed-by: Nick Hoath --- drivers/gpu/drm/i915/i915_reg.h | 2 ++ drivers/gpu/drm/i915/intel_ringbuffer.c | 5 + 2 files changed, 7 insertions

Re: [Intel-gfx] [PATCH 2/8] drm/i915/gen9: Add GEN8_CS_CHICKEN1 to HW whitelist

2016-01-21 Thread Nick Hoath
On 13/01/2016 10:06, Arun Siluvery wrote: Required for WaEnablePreemptionGranularityControlByUMD:skl,bxt Signed-off-by: Arun Siluvery Reviewed-by: Nick Hoath --- drivers/gpu/drm/i915/i915_reg.h | 2 ++ drivers/gpu/drm/i915/intel_ringbuffer.c | 6 ++ 2 files changed, 8

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Fix premature LRC unpin in GuC mode

2016-01-20 Thread Nick Hoath
depends on i915_gem_cleanup_ringbuffer running before itself. Signed-off-by: Tvrtko Ursulin Issue: VIZ-4277 Cc: Chris Wilson Cc: Nick Hoath --- I cannot test this with GuC but it passes BAT with execlists and some real world smoke tests. --- drivers/gpu/drm/i915/i915_gem_context.c | 4

[Intel-gfx] [PATCH v11] drm/i915: Extend LRC pinning to cover GPU context writeback

2016-01-19 Thread Nick Hoath
ev. v11: Kick BAT rerun Signed-off-by: Nick Hoath Issue: VIZ-4277 Cc: Daniel Vetter Cc: David Gordon Cc: Chris Wilson Cc: Alex Dai Cc: Mika Kuoppala --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_gem.c | 3 + drivers/gpu/drm/i915/i

Re: [Intel-gfx] [PATCH v3 3/3] drm/i915: tidy up a few leftovers

2016-01-18 Thread Nick Hoath
Reviewed-by: Nick Hoath --- drivers/gpu/drm/i915/i915_debugfs.c | 15 +-- drivers/gpu/drm/i915/i915_gem.c | 6 ++ drivers/gpu/drm/i915/intel_lrc.c| 38 + 3 files changed, 24 insertions(+), 35 deletions(-) diff --git a/drivers/gpu

Re: [Intel-gfx] [PATCH v3 2/3] drm/i915: abolish separate per-ring default_context pointers

2016-01-18 Thread Nick Hoath
each of the engine[] elements. This make refcounting more sensible too, as we now have a refcount of one for the one pointer, rather than a refcount of one but multiple pointers. From an idea by Chris Wilson. Signed-off-by: Dave Gordon Reviewed-by: Nick Hoath --- drivers/gpu/

Re: [Intel-gfx] [PATCH v3 1/3] drm/i915: simplify allocation of driver-internal requests

2016-01-18 Thread Nick Hoath
ing->default_context, &req); if (err) ... NEW: req = i915_gem_request_alloc(ring, NULL); if (IS_ERR(req)) ... Signed-off-by: Dave Gordon Reviewed-by: Nick Hoath --- drivers/gpu/drm/i915/i915_drv.h| 6 ++-- d

Re: [Intel-gfx] [PATCH v10] drm/i915: Extend LRC pinning to cover GPU context writeback

2016-01-15 Thread Nick Hoath
On 14/01/2016 12:37, Nick Hoath wrote: On 14/01/2016 12:31, Chris Wilson wrote: On Thu, Jan 14, 2016 at 11:56:07AM +, Nick Hoath wrote: On 14/01/2016 11:36, Chris Wilson wrote: On Wed, Jan 13, 2016 at 04:19:45PM +, Nick Hoath wrote: + if (ctx->engine[ring->id]

Re: [Intel-gfx] [PATCH v10] drm/i915: Extend LRC pinning to cover GPU context writeback

2016-01-14 Thread Nick Hoath
On 14/01/2016 12:31, Chris Wilson wrote: On Thu, Jan 14, 2016 at 11:56:07AM +, Nick Hoath wrote: On 14/01/2016 11:36, Chris Wilson wrote: On Wed, Jan 13, 2016 at 04:19:45PM +, Nick Hoath wrote: + if (ctx->engine[ring->id].dirty) { + struct drm_i915_gem_reques

Re: [Intel-gfx] [PATCH v10] drm/i915: Extend LRC pinning to cover GPU context writeback

2016-01-14 Thread Nick Hoath
On 14/01/2016 11:36, Chris Wilson wrote: On Wed, Jan 13, 2016 at 04:19:45PM +, Nick Hoath wrote: + if (ctx->engine[ring->id].dirty) { + struct drm_i915_gem_request *req = NULL; + + /** +* If there is already a request pend

Re: [Intel-gfx] ✗ failure: Fi.CI.BAT

2016-01-14 Thread Nick Hoath
On 14/01/2016 07:20, Patchwork wrote: == Summary == Built on 058740f8fced6851aeda34f366f5330322cd585f drm-intel-nightly: 2016y-01m-13d-17h-07m-44s UTC integration manifest Test gem_ctx_basic: pass -> FAIL (bdw-ultra) Test failed to load - not patch related Test

[Intel-gfx] [PATCH v10] drm/i915: Extend LRC pinning to cover GPU context writeback

2016-01-13 Thread Nick Hoath
on dev. Signed-off-by: Nick Hoath Issue: VIZ-4277 Cc: Daniel Vetter Cc: David Gordon Cc: Chris Wilson Cc: Alex Dai Cc: Mika Kuoppala --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_gem.c | 3 + drivers/gpu/drm/i915/i

[Intel-gfx] [PATCH v9] drm/i915: Extend LRC pinning to cover GPU context writeback

2015-12-18 Thread Nick Hoath
cases where the codepaths leaked (Mika Kuoppala) NULL'd last_context in reset case - there was a pointer leak if someone did reset->close context. v9: Rebase over "Fix context/engine cleanup order" Signed-off-by: Nick Hoath Issue: VIZ-4277 Cc: Daniel Vetter Cc: David G

[Intel-gfx] [PATCH v4] drm/i915: Fix context/engine cleanup order

2015-12-18 Thread Nick Hoath
e fact that the HWSP and the default context are the different offsets within the same object. v2: Also make the fix in i915_load_modeset_init, not just in i915_driver_unload (Chris Wilson) v3: Folded in Dave Gordon's fix for HWSP kunmap issues. v4: Rebase over Dave Gordon's various cl

Re: [Intel-gfx] [PATCH 4/4] drm/i915: tidy up initialisation failure paths (GEM & LRC)

2015-12-17 Thread Nick Hoath
mably copypasted from legacy ringbuffer version at creation. Reviewed-by: Nick Hoath Signed-off-by: Dave Gordon --- drivers/gpu/drm/i915/i915_gem.c | 5 - drivers/gpu/drm/i915/intel_lrc.c | 10 ++ 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm

Re: [Intel-gfx] [PATCH 3/4] drm/i915: tidy up initialisation failure paths (legacy)

2015-12-17 Thread Nick Hoath
() no longer needs 'dev_priv'. Reviewed-by: Nick Hoath Signed-off-by: Dave Gordon --- drivers/gpu/drm/i915/intel_ringbuffer.c | 47 +++-- 1 file changed, 22 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drive

Re: [Intel-gfx] [PATCH 2/4] drm/i915: mark the global default (intel_)context as such

2015-12-17 Thread Nick Hoath
llary that only one context doesn't belong to any file. Using pointers like this to provide 'magic' secondary state information just adds to the fragility of the driver. So: Reviewed-by: Nick Hoath to the original patch. -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 1/4] drm/i915: teardown default context in reverse, update comments

2015-12-17 Thread Nick Hoath
Reviewed-by: Nick Hoath On 16/12/2015 18:36, Gordon, David S wrote: We set up engines in forwards order, so some things (notably the default context) are "owned" by engine 0 (the render engine, aka "RCS"). For symmetry and to make sure such shared objects don't disap

[Intel-gfx] [PATCH] drm/i915: Fix context/engine cleanup order

2015-12-14 Thread Nick Hoath
e fact that the HWSP and the default context are the different offsets within the same object. v2: Also make the fix in i915_load_modeset_init, not just in i915_driver_unload (Chris Wilson) v3: Folded in Dave Gordon's fix for HWSP kunmap issues. Signed-off-by: Nick Hoath Reviewed-by: Chr

[Intel-gfx] [PATCH v2] drm/i915: Fix context/engine cleanup order

2015-12-11 Thread Nick Hoath
er_unload (Chris Wilson) Signed-off-by: Nick Hoath Reviewed-by: Chris Wilson Cc: Mika Kuoppala Cc: Daniel Vetter Cc: David Gordon Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_dma.c | 4 ++-- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_gem.c | 23 -

[Intel-gfx] [PATCH] drm/i915: Fix context/engine cleanup order

2015-12-11 Thread Nick Hoath
lized() must be simple and inline' patch now using ring->dev as an initialised flag. Rename the cleanup function to reflect what it actually does. Also clean up some very annoying whitespace issues at the same time. Signed-off-by: Nick Hoath Cc: Mika Kuoppala Cc: Daniel Vetter Cc: David G

[Intel-gfx] [PATCH v8] drm/i915: Extend LRC pinning to cover GPU context writeback

2015-12-07 Thread Nick Hoath
cases where the codepaths leaked (Mika Kuoppala) NULL'd last_context in reset case - there was a pointer leak if someone did reset->close context. Signed-off-by: Nick Hoath Issue: VIZ-4277 Cc: Daniel Vetter Cc: David Gordon Cc: Chris Wilson Cc: Alex Dai Cc: Mika Kuoppala --- dr

[Intel-gfx] [PATCH] drm/i915: Extend LRC pinning to cover GPU context writeback

2015-12-01 Thread Nick Hoath
ppala) Added explanation of the GuC hang that this fixes (Daniel Vetter) v7: Removed extra per request pinning from ring reset code (Alex Dai) Added forced ring unpin/clean in error case in context free (Alex Dai) Signed-off-by: Nick Hoath Issue: VIZ-4277 Cc: Daniel Vetter Cc: David Gordon Cc:

[Intel-gfx] [PATCH v6] drm/i915: Change context lifecycle

2015-11-26 Thread Nick Hoath
ppala) Added explanation of the GuC hang that this fixes (Daniel Vetter) Signed-off-by: Nick Hoath Issue: VIZ-4277 Cc: Daniel Vetter Cc: David Gordon Cc: Chris Wilson Cc: Alex Dai Cc: Mika Kuoppala --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_gem.c | 3 + drivers/gp

Re: [Intel-gfx] [PATCH] drm/i915: Change context lifecycle

2015-11-26 Thread Nick Hoath
On 26/11/2015 08:48, Daniel Vetter wrote: On Wed, Nov 25, 2015 at 05:02:44PM +0200, Mika Kuoppala wrote: Nick Hoath writes: Use the first retired request on a new context to unpin the old context. This ensures that the hw context remains bound until it has been written back to by the GPU

Re: [Intel-gfx] [PATCH v2] drm/i915/guc: Clean up locks in GuC

2015-11-26 Thread Nick Hoath
On 25/11/2015 19:29, Dai, Yu wrote: From: Alex Dai When GuC Work Queue is full, driver will wait GuC for avaliable available space by delaying 1ms. The wait needs to be out of spinlockirq / unlock. Otherwise, lockup happens because jiffi

[Intel-gfx] [PATCH] drm/i915: Change context lifecycle

2015-11-25 Thread Nick Hoath
ngine cleanup from context_free as it was getting unwieldy Corrected locking (Dave Gordon) Signed-off-by: Nick Hoath Issue: VIZ-4277 Cc: Daniel Vetter Cc: David Gordon Cc: Chris Wilson Cc: Alex Dai --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_gem.c

Re: [Intel-gfx] [PATCH] drm/i915: Change context lifecycle

2015-11-25 Thread Nick Hoath
On 25/11/2015 01:11, Dai, Yu wrote: On 11/24/2015 08:23 AM, Nick Hoath wrote: Use the first retired request on a new context to unpin the old context. This ensures that the hw context remains bound until it has been saved. Now that the context is pinned until later in the request/context

[Intel-gfx] [PATCH] drm/i915: Change context lifecycle

2015-11-24 Thread Nick Hoath
the hw was actually still using it v4: Unwrapped context unpin to allow calling without a request Signed-off-by: Nick Hoath Issue: VIZ-4277 Cc: Daniel Vetter Cc: David Gordon Cc: Chris Wilson Cc: Alex Dai --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_gem.c | 9

[Intel-gfx] [PATCH] drm/i915: Change context lifecycle

2015-11-09 Thread Nick Hoath
refcount on the context also has to be extended to cover this new longer period. Signed-off-by: Nick Hoath Issue: VIZ-4277 Cc: Daniel Vetter Cc: David Gordon Cc: Chris Wilson Cc: Alex Dai --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_gem.c | 7 + drivers/gpu/drm

[Intel-gfx] [PATCH 4/6] drm/i915: Improve dynamic management/eviction of lrc backing objects

2015-10-20 Thread Nick Hoath
Shovel all context related objects through the active queue and obj management. - Added callback in vma_(un)bind to add CPU (un)mapping at same time if desired - Inserted LRC hw context & ringbuf to vma active list Issue: VIZ-4277 Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/i915_d

[Intel-gfx] [PATCH 1/6] drm/i195: Rename gt_irq_handler variable

2015-10-20 Thread Nick Hoath
Renamed tmp variable to the more descriptive iir. (Daniel Vetter/ Thomas Daniel) Issue: VIZ-4277 Signed-off-by: Nick Hoath Cc: Daniel Vetter Cc: David Gordon Cc: Thomas Daniel --- drivers/gpu/drm/i915/i915_irq.c | 46 - 1 file changed, 23 insertions

[Intel-gfx] [PATCH 2/6] drm/i915: Break out common code from gen8_gt_irq_handler

2015-10-20 Thread Nick Hoath
Break out common code from gen8_gt_irq_handler and put it in to an always inlined function. gcc optimises out the shift at compile time. (Thomas Daniel/Daniel Vetter/Chris Wilson) Issue: VIZ-4277 Signed-off-by: Nick Hoath Cc: Thomas Daniel Cc: Daniel Vetter Cc: Chris Wilson --- drivers/gpu

[Intel-gfx] [PATCH 6/6] drm/i915: Only update ringbuf address when necessary

2015-10-20 Thread Nick Hoath
We now only need to update the address of the ringbuf object in the hw context when it is pinned, and the hw context is first CPU mapped Issue: VIZ-4277 Signed-off-by: Nick Hoath Cc: David Gordon --- drivers/gpu/drm/i915/intel_lrc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion

[Intel-gfx] [PATCH 5/6] drm/i915: Add the CPU mapping of the hw context to the pinned items.

2015-10-20 Thread Nick Hoath
Pin the hw ctx mapping so that it is not mapped/unmapped per bb when doing GuC submission. v2: Removed interim development extra mapping. (Daniel Vetter) Issue: VIZ-4277 Signed-off-by: Nick Hoath Cc: David Gordon Cc: Daniel Vetter --- drivers/gpu/drm/i915/i915_debugfs.c | 14

[Intel-gfx] [PATCH 0/6] lrc lifecycle cleanups

2015-10-20 Thread Nick Hoath
x27;t released/made continuously as this is an expensive process. V2: Removed unecessary changes in the lrc retiring code path Removed unecessary map/unmap Nick Hoath (6): drm/i195: Rename gt_irq_handler variable drm/i915: Break out common code from gen8_gt_irq_handler drm/i915: Unify execlis

[Intel-gfx] [PATCH 3/6] drm/i915: Unify execlist and legacy request life-cycles

2015-10-20 Thread Nick Hoath
uest pin of context. (Chris Wilson/Daniel Vetter) Issue: VIZ-4277 Signed-off-by: Thomas Daniel Signed-off-by: Nick Hoath Cc: Daniel Vetter Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_gem.c | 23 - drivers/gpu

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Improve dynamic management/eviction of lrc backing objects

2015-10-19 Thread Nick Hoath
On 19/10/2015 10:48, Daniel Vetter wrote: On Fri, Oct 16, 2015 at 03:42:53PM +0100, Nick Hoath wrote: On 08/10/2015 14:35, Chris Wilson wrote: On Wed, Oct 07, 2015 at 06:05:46PM +0200, Daniel Vetter wrote: On Tue, Oct 06, 2015 at 03:52:02PM +0100, Nick Hoath wrote: Shovel all context related

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Improve dynamic management/eviction of lrc backing objects

2015-10-16 Thread Nick Hoath
On 08/10/2015 14:35, Chris Wilson wrote: On Wed, Oct 07, 2015 at 06:05:46PM +0200, Daniel Vetter wrote: On Tue, Oct 06, 2015 at 03:52:02PM +0100, Nick Hoath wrote: Shovel all context related objects through the active queue and obj management. - Added callback in vma_(un)bind to add CPU (un

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Unify execlist and legacy request life-cycles

2015-10-14 Thread Nick Hoath
On 14/10/2015 15:42, Dave Gordon wrote: On 13/10/15 12:36, Chris Wilson wrote: On Tue, Oct 13, 2015 at 01:29:56PM +0200, Daniel Vetter wrote: On Fri, Oct 09, 2015 at 06:23:50PM +0100, Chris Wilson wrote: On Fri, Oct 09, 2015 at 07:18:21PM +0200, Daniel Vetter wrote: On Fri, Oct 09, 2015 at 10

[Intel-gfx] [PATCH 1/4] drm/i915: Unify execlist and legacy request life-cycles

2015-10-06 Thread Nick Hoath
pin leaks Issue: VIZ-4277 Signed-off-by: Thomas Daniel Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/i915_drv.h | 6 +++ drivers/gpu/drm/i915/i915_gem.c | 67 +-- drivers/gpu/drm/i915/i915_irq.c | 81 + drivers

[Intel-gfx] [PATCH 3/4] drm/i915: Add the CPU mapping of the hw context to the pinned items.

2015-10-06 Thread Nick Hoath
Pin the hw ctx mapping so that it is not mapped/unmapped per bb when doing GuC submission. Issue: VIZ-4277 Cc: David Gordon Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/i915_debugfs.c | 14 -- drivers/gpu/drm/i915/i915_drv.h | 4 ++- drivers/gpu/drm/i915/intel_lrc.c| 56

[Intel-gfx] [PATCH 4/4] drm/i915: Only update ringbuf address when necessary

2015-10-06 Thread Nick Hoath
We now only need to update the address of the ringbuf object in the hw context when it is pinned, and the hw context is first CPU mapped Issue: VIZ-4277 Cc: David Gordon Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/intel_lrc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion

[Intel-gfx] [PATCH 2/4] drm/i915: Improve dynamic management/eviction of lrc backing objects

2015-10-06 Thread Nick Hoath
Shovel all context related objects through the active queue and obj management. - Added callback in vma_(un)bind to add CPU (un)mapping at same time if desired - Inserted LRC hw context & ringbuf to vma active list Issue: VIZ-4277 Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/i915_d

[Intel-gfx] [PATCH 0/4] lrc lifecycle cleanups

2015-10-06 Thread Nick Hoath
eased/made continuously as this is an expensive process. Nick Hoath (4): drm/i915: Unify execlist and legacy request life-cycles drm/i915: Improve dynamic management/eviction of lrc backing objects drm/i915: Add the CPU mapping of the hw context to the pinned items. drm/i915: Only update ri

[Intel-gfx] [PATCH] drm/i915: Remove extraneous request cancel.

2015-09-21 Thread Nick Hoath
Remove extraneous request cancel in request allocation failure path in intel_lr_context_deferred_alloc (Tvrtko Ursulin) Signed-off-by: Nick Hoath Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_lrc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_lrc.c b

[Intel-gfx] [PATCH] drm/i915: Split alloc from init for lrc

2015-09-11 Thread Nick Hoath
ebase breakage. Put context pinning in separate function. Removed code churn. (Thomas Daniel) v6: Cleanup up issues introduced in v2 & v5 (Thomas Daniel) Issue: VIZ-4798 Signed-off-by: Nick Hoath Cc: Daniel Vetter Cc: Chris Wilson Cc: John Harrison Cc: David Gordon Cc: Thomas Danie

[Intel-gfx] [PATCH] drm/i915: Split alloc from init for lrc

2015-09-10 Thread Nick Hoath
ebase breakage. Put context pinning in separate function. Removed code churn. (Thomas Daniel) Issue: VIZ-4798 Signed-off-by: Nick Hoath Cc: Daniel Vetter Cc: Chris Wilson Cc: John Harrison Cc: David Gordon Cc: Thomas Daniel --- drivers/gpu/drm/i915/i915_drv.h| 1 - d

Re: [Intel-gfx] [PATCH 4/4] drm/i915/bxt: Clean up bxt_init_clock_gating

2015-09-07 Thread Nick Hoath
On 29/06/2015 15:29, Mika Kuoppala wrote: Nick Hoath writes: Add stepping check for A0 workarounds, and remove the associated FIXME tags. Split out unrelated WAs for later condition checking. v2: Fixed format (PeterL) v3: Corrected stepping check for WaDisableSDEUnitClockGating

[Intel-gfx] [PATCH] drm/i915: Split alloc from init for lrc

2015-09-04 Thread Nick Hoath
river load time. This prevents the seqno being reset on reinit (Chris Wilson) v4: Set seqno back to ~0 - 0x1000 at start-of-day, and increment by 0x100 on reset. This makes it obvious which bbs are which after a reset. (David Gordon & John Harrison) Rebase. Issue: VIZ-4798

Re: [Intel-gfx] [PATCH] drm/i915: Split alloc from init for lrc

2015-08-19 Thread Nick Hoath
On 19/08/2015 13:37, Chris Wilson wrote: On Wed, Aug 19, 2015 at 01:24:28PM +0100, Nick Hoath wrote: Extend init/init_hw split to context init. - Move context initialisation in to i915_gem_init_hw - Move one off initialisation for render ring to i915_gem_validate_context

[Intel-gfx] [PATCH] drm/i915: Split alloc from init for lrc

2015-08-19 Thread Nick Hoath
river load time. This prevents the seqno being reset on reinit (Chris Wilson) Issue: VIZ-4798 Signed-off-by: Nick Hoath Cc: Daniel Vetter Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.h| 1 - drivers/gpu/drm/i915/i915_gem.c| 18 ++-- drivers/gpu/drm/i915/i915_g

Re: [Intel-gfx] [PATCH] drm/i915: Split alloc from init for lrc

2015-08-18 Thread Nick Hoath
On 18/08/2015 15:31, Chris Wilson wrote: On Tue, Aug 18, 2015 at 03:23:32PM +0100, Nick Hoath wrote: Extend init/init_hw split to context init. - Move context initialisation in to i915_gem_init_hw - Move one off initialisation for render ring to i915_gem_validate_context

[Intel-gfx] [PATCH] drm/i915: Split alloc from init for lrc

2015-08-18 Thread Nick Hoath
Left ->init_context int intel_lr_context_deferred_alloc (Daniel Vetter) Remove unnecessary init flag & ring type test. (Daniel Vetter) Improve commit message (Daniel Vetter) Issue: VIZ-4798 Signed-off-by: Nick Hoath Cc: Daniel Vetter --- drivers/gpu/drm/i915/i915_drv.h|

Re: [Intel-gfx] [PATCH] drm/i915: Clean up lrc context init

2015-08-10 Thread Nick Hoath
On 07/08/2015 11:13, Chris Wilson wrote: On Fri, Aug 07, 2015 at 11:05:24AM +0100, Nick Hoath wrote: Clean up lrc context init by: - Move context initialisation in to i915_gem_init_hw - Move one off initialisation for render ring to i915_gem_validate_context - Move default

[Intel-gfx] [PATCH] drm/i915: Clean up lrc context init

2015-08-07 Thread Nick Hoath
intel_lr_context_deferred_alloc, to reflect reduced functionality. Issue: VIZ-4798 Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/i915_drv.h| 1 - drivers/gpu/drm/i915/i915_gem.c| 23 ++--- drivers/gpu/drm/i915/i915_gem_context.c| 21 - drivers/gpu/drm/i915

Re: [Intel-gfx] [RFC 3/5] drm/i915: Simplify runtime_pm reference for execlists

2015-07-29 Thread Nick Hoath
On 09/07/2015 12:14, Chris Wilson wrote: On Thu, Jul 09, 2015 at 11:57:42AM +0100, Nick Hoath wrote: No longer take a runtime_pm reference for each execlist request. Only take a single reference when the execlist queue becomes nonempty and release it when it becomes empty. Nak. We already

Re: [Intel-gfx] [RFC 2/5] drm/i915: Unify execlist and legacy request life-cycles

2015-07-29 Thread Nick Hoath
On 09/07/2015 12:12, Chris Wilson wrote: On Thu, Jul 09, 2015 at 11:57:41AM +0100, Nick Hoath wrote: There is a desire to simplify the i915 driver by reducing the number of different code paths introduced by the LRC / execlists support. As the execlists request is now part of the gem request

[Intel-gfx] [PATCH] drm/i915/gen9: Implement WaDisableKillLogic for gen 9

2015-07-14 Thread Nick Hoath
v2: Patch leakage fixed Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 4 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 059de0f..afa8972 100644

[Intel-gfx] [PATCH] drm/i915/gen9: Implement WaDisableKillLogic for gen 9

2015-07-14 Thread Nick Hoath
Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 4 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 709b3c7

[Intel-gfx] [RFC 4/5] drm/i915: Reorder make_rpcs for later patch

2015-07-09 Thread Nick Hoath
Issue: VIZ-4798 Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/intel_lrc.c | 86 1 file changed, 43 insertions(+), 43 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c index adc4942..770a6f6 100644 --- a

[Intel-gfx] [RFC 3/5] drm/i915: Simplify runtime_pm reference for execlists

2015-07-09 Thread Nick Hoath
No longer take a runtime_pm reference for each execlist request. Only take a single reference when the execlist queue becomes nonempty and release it when it becomes empty. Signed-off-by: Thomas Daniel Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/i915_gem.c | 10 +++--- drivers/gpu

[Intel-gfx] [RFC 1/5] drm/i915: Clean up gen8 irq handler

2015-07-09 Thread Nick Hoath
Moved common code handling command streamer interrupts into a function. Renamed tmp variable to the more descriptive iir. Signed-off-by: Thomas Daniel Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/i915_irq.c | 68 + 1 file changed, 35 insertions

[Intel-gfx] [RFC 5/5] drm/i915: Clean up lrc context init

2015-07-09 Thread Nick Hoath
intel_lr_context_deferred_alloc, to reflect reduced functionality. Issue: VIZ-4798 Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/i915_drv.h| 1 - drivers/gpu/drm/i915/i915_gem.c| 41 drivers/gpu/drm/i915/i915_gem_context.c| 21 -- drivers/gpu/drm/i915

[Intel-gfx] [RFC 2/5] drm/i915: Unify execlist and legacy request life-cycles

2015-07-09 Thread Nick Hoath
() is called when contexts complete as well as when a user interrupt occurs so that notification happens when a request is complete and context save has finished. v2: Rebase over the read-read optimisation changes Signed-off-by: Thomas Daniel Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915

[Intel-gfx] [RFC 0/5] drm/i915: Execlist cleanup

2015-07-09 Thread Nick Hoath
This set of patches cleans up a number of issues that were pushed out in the initial execlist submission. Nick Hoath (5): drm/i915: Clean up gen8 irq handler drm/i915: Unify execlist and legacy request life-cycles drm/i915: Simplify runtime_pm reference for execlists drm/i915: Reorder

Re: [Intel-gfx] [PATCH 1/4] drm/i915/bxt: Enable WaVSRefCountFullforceMissDisable

2015-06-29 Thread Nick Hoath
On 29/06/2015 15:08, Mika Kuoppala wrote: Hi, Nick Hoath writes: From: Rafael Barbalho Signed-off-by: Rafael Barbalho Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/intel_pm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu

[Intel-gfx] [PATCH 0/4] drm/i915: Extra GEN 9 workaround patches

2015-06-29 Thread Nick Hoath
Nick Hoath (2): drm/i915/bxt: Enable WaOCLCoherentLineFlush drm/i915/bxt: Clean up bxt_init_clock_gating Rafael Barbalho (2): drm/i915/bxt: Enable WaVSRefCountFullforceMissDisable drm/i915/bxt: Enable WaDSRefCountFullforceMissDisable drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu

[Intel-gfx] [PATCH 4/4] drm/i915/bxt: Clean up bxt_init_clock_gating

2015-06-29 Thread Nick Hoath
description for TILECTL setting (JonB) Cc: Peter Lawthers Cc: Chris Harris Cc: Jon Bloomfield Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/intel_pm.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 3/4] drm/i915/bxt: Enable WaOCLCoherentLineFlush

2015-06-29 Thread Nick Hoath
Signed-off-by: Nick Hoath Cc: Rafael Barbalho --- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 4 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index b9f6b8c..115911a 100644 --- a/drivers/gpu/drm

[Intel-gfx] [PATCH 2/4] drm/i915/bxt: Enable WaDSRefCountFullforceMissDisable

2015-06-29 Thread Nick Hoath
From: Rafael Barbalho Signed-off-by: Rafael Barbalho Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/intel_pm.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index d635d0a..f29e575 100644 --- a

[Intel-gfx] [PATCH 1/4] drm/i915/bxt: Enable WaVSRefCountFullforceMissDisable

2015-06-29 Thread Nick Hoath
From: Rafael Barbalho Signed-off-by: Rafael Barbalho Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/intel_pm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index 32ff034..d635d0a 100644 --- a/drivers/gpu/drm

Re: [Intel-gfx] [PATCH] drm/i915/skl: Implement WaBarrierPerformanceFixDisable (again)

2015-06-03 Thread Nick Hoath
Implement WaBarrierPerformanceFixDisable The workaround ended up in the chv workarounds. Not sure what the reason or history of that is, but it /seems/ wrong. Don't know if this fixes anything patch doesn't always get it right... Reviewed-by: Nick Hoath since I have many other problems with my platform. Cc

[Intel-gfx] [PATCH 8/9] drm/i915/bxt: Mark WaDisablePartialResolveInVc as for Broxton also.

2015-05-07 Thread Nick Hoath
Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/intel_ringbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index cf36c6b..e5c9f9a 100644 --- a/drivers/gpu/drm/i915/intel_ringbuffer.c

[Intel-gfx] [PATCH 5/9] drm/i915/bxt: Enable WaEnableYV12BugFixInHalfSliceChicken7 for Broxton

2015-05-07 Thread Nick Hoath
Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/intel_ringbuffer.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index ac1ad44..076d3e5 100644 --- a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 7/9] drm/i915/bxt: Mark Wa4x4STCOptimizationDisable as for Broxton also.

2015-05-07 Thread Nick Hoath
Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/intel_ringbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index dec0e74..cf36c6b 100644 --- a/drivers/gpu/drm/i915/intel_ringbuffer.c

[Intel-gfx] [PATCH 6/9] drm/i915/bxt: Move WaForceEnableNonCoherent to Skylake only

2015-05-07 Thread Nick Hoath
Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/intel_ringbuffer.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index 076d3e5..dec0e74 100644 --- a/drivers/gpu

[Intel-gfx] [PATCH 9/9] drm/i915/bxt: Mark WaCcsTlbPrefetchDisable as for Broxton also.

2015-05-07 Thread Nick Hoath
Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/intel_ringbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index e5c9f9a..001343f 100644 --- a/drivers/gpu/drm/i915/intel_ringbuffer.c

[Intel-gfx] [PATCH 1/9] drm/i915/bxt: Mark WaDisablePartialInstShootdown as for Broxton also.

2015-05-07 Thread Nick Hoath
Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/intel_ringbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index 7ef9a29..49e4610 100644 --- a/drivers/gpu/drm/i915/intel_ringbuffer.c

[Intel-gfx] [PATCH 0/9] drm/i915/bxt Enable existing workarounds for Broxton

2015-05-07 Thread Nick Hoath
. (Imre) Cleaned up revision ID usage (Imre) Nick Hoath (9): drm/i915/bxt: Mark WaDisablePartialInstShootdown as for Broxton also. drm/i915/bxt: Mark workaround as for Skylake & Broxton drm/i915/bxt: Enable WaDisableDgMirrorFixInHalfSliceChicken5 for Broxton drm/i915/bxt: En

[Intel-gfx] [PATCH 2/9] drm/i915/bxt: Mark workaround as for Skylake & Broxton

2015-05-07 Thread Nick Hoath
Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/intel_ringbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index 49e4610..cdbdf49 100644 --- a/drivers/gpu/drm/i915/intel_ringbuffer.c

[Intel-gfx] [PATCH 4/9] drm/i915/bxt: Enable WaSetDisablePixMaskCammingAndRhwoInCommonSliceChicken for Broxton

2015-05-07 Thread Nick Hoath
Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/intel_ringbuffer.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index 3f1a784..ac1ad44 100644 --- a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 3/9] drm/i915/bxt: Enable WaDisableDgMirrorFixInHalfSliceChicken5 for Broxton

2015-05-07 Thread Nick Hoath
Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/intel_ringbuffer.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index cdbdf49..3f1a784 100644 --- a/drivers/gpu/drm/i915

  1   2   3   >