a very long time. They're
> >>> > redundant in our local subdir-ccflags-y and can be dropped.
> >>> >
> >>> > Cc: Arnd Bergmann
> >>> > Cc: Nick Desaulniers
> >>> > Cc: Nathan Chancellor
> >>> > Cc: Masahiro Yamad
in our local subdir-ccflags-y and can be dropped.
>
> Cc: Arnd Bergmann
> Cc: Nick Desaulniers
> Cc: Nathan Chancellor
> Cc: Masahiro Yamada
> Signed-off-by: Jani Nikula
I didn't carefully cross reference these specific flags so I provide
and ack rather than RB, but
t; drivers/gpu/drm/v3d/v3d_drv.h:343:24: note: remove constant to silence this
> warning
> 1 warning generated.
>
> Turn this into an explicit comparison against zero to make the
> expression a boolean to make it clear this should be a logical check,
> not a bitwise one.
>
>
On Thu, May 25, 2023 at 1:30 PM Matthieu Baerts
wrote:
>
> Hi Nick,
>
> On 24/05/2023 20:56, Nick Desaulniers wrote:
> > On Wed, May 24, 2023 at 11:41 AM Nathan Chancellor
> > wrote:
> >>
> >> On Wed, May 24, 2023 at 11:32:32AM -0700, Nick Desaulni
On Wed, May 24, 2023 at 11:41 AM Nathan Chancellor wrote:
>
> On Wed, May 24, 2023 at 11:32:32AM -0700, Nick Desaulniers wrote:
> > On Wed, May 24, 2023 at 8:38 AM Nathan Chancellor wrote:
> > >
> > > Clang warns:
> > >
> > > drivers/gp
MOD_X_TILED:
> case I915_FORMAT_MOD_Y_TILED:
>
> ---
> base-commit: 9a2cb1b31c040e2f1b313e2f7921f0f5e6b66d82
> change-id:
> 20230524-intel_async_flip_check_hw-implicit-fallthrough-c4c40b03802f
>
> Best regards,
> --
> Nathan Chancellor
>
--
Thanks,
~Nick Desaulniers
On Thu, Oct 27, 2022 at 9:53 AM Dixit, Ashutosh
wrote:
>
> On Thu, 27 Oct 2022 09:35:24 -0700, Nick Desaulniers wrote:
> >
>
> Hi Nick,
>
> > On Tue, Oct 25, 2022 at 5:18 PM Andi Shyti
> > wrote:
> > >
> > > Hi Ashutosh,
> > &
?
Warnings are treated as errors, so I don't want this breaking our CI.
--
Thanks,
~Nick Desaulniers
ds like Jani has
another suggestion to try instead.
https://lore.kernel.org/intel-gfx/87eduwdllr@intel.com/
Please re-cc us and our list if that doesn't work out.
>
> If we want to stick to gcc only, then I still think the patch is
> correct for two reasons:
>
> 1. it's cleaner
> 2. we would get on with the job and if one day we will decide
> to suppport builtin functions in gcc as well, we will sleep
> peacefully :)
>
> > Copying l...@lists.linux.dev too.
>
> maybe llvm folks have a better opinion.
>
> Thanks,
> Andi
>
> > Thanks.
> > --
> > Ashutosh
> >
> >
> > > }
> > >
> > > /*
> > > @@ -406,7 +401,6 @@ hwm_power_write(struct hwm_drvdata *ddat, u32 attr,
> > > int chan, long val)
> > > case hwmon_power_max:
> > > hwm_field_scale_and_write(ddat,
> > > hwmon->rg.pkg_rapl_limit,
> > > - PKG_PWR_LIM_1,
> > > hwmon->scl_shift_power,
> > > SF_POWER, val);
> > > return 0;
> > > --
> > > 2.37.1
> > >
>
--
Thanks,
~Nick Desaulniers
do {\
> + typeof(t1) __t1h = type_max(t1);\
> + typeof(t1) __t1l = type_min(t1);\
> + typeof(t2) __t2h = type_max(t2);\
> + typeof(t2) __t2l = type_min(t2); \
Can we use __auto_type here rather than typeof(macro expansion)?
--
Thanks,
~Nick Desaulniers
2]: https://lore.kernel.org/r/20210824022640.2170859-1-nat...@kernel.org/
>
> Signed-off-by: Nathan Chancellor
Thanks for the patch! Do you need to re-ping, rebase, or resend that
other series?
Reviewed-by: Nick Desaulniers
> ---
>
> NOTE: This is based on my series to enable
ase, it's not
immune to bugs. And its maturity has yet to slow its rapid pace of
development.
--
Thanks,
~Nick Desaulniers
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> __llvm_gcov_writeout()+0x1: call without frame pointer save/setup
> >> drivers/dma-buf/dma-fence-proxy.o: warning: objtool:
> >> __llvm_gcov_flush()+0x0: call without frame pointer save/setup
> >> drivers/dma-buf/dma-fence-proxy.o: warning: objtool:
> >>
_ptr(entry->relocs_ptr);
remain = entry->relocation_count;
+#ifndef CONFIG_64BIT
if (unlikely(remain > N_RELOC(ULONG_MAX)))
return -EINVAL;
+#endif
/*
* We must check that the entire relocation array is safe
```
We now have 4 proposed solutions:
1. https://lore.kernel.org/lkml/20191123195321.41305-1-natechancel...@gmail.com/
2. https://lore.kernel.org/lkml/20200211050808.29463-1-natechancel...@gmail.com/
3. https://lore.kernel.org/lkml/20200214054706.33870-1-natechancel...@gmail.com/
4. my diff above
Let's please come to a resolution on this.
--
Thanks,
~Nick Desaulniers
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
one of the lower 16 bits). As such, these workarounds should
> be applied via wa_write_or() rather than wa_masked_en()
>
> Reported-by: Nick Desaulniers
> Fixes: 50148a25f841 ("drm/i915/tgl: Move and restrict Wa_1408615072")
> Fixes: 3551ff928744 ("drm/i915/gen11: Movin
ould silence the warning.
> >
> > I do like this one better than the former.
>
> FWIW, one downside of this one compared to all alternatives (presumably)
> is that it might end up generating actual code even on 64-bit, which
> always ends up skipping the return.
The warning is pointing out that the conditional is always false,
which is correct on 64b. The check is only active for 32b.
https://godbolt.org/z/oQrgT_
The cast silences the warning for 64b. (Note that GCC and Clang also
generate precisely the same instruction sequences in my example, just
GCC doesn't warn on such tautologies).
--
Thanks,
~Nick Desaulniers
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Tue, Dec 3, 2019 at 5:42 AM Chris Wilson wrote:
>
> Quoting Nick Desaulniers (2019-12-02 19:18:20)
> > On Sat, Nov 23, 2019 at 12:05 PM Chris Wilson
> > wrote:
> > >
> > > Quoting Nathan Chancellor (2019-11-23 19:53:22)
> > > > -Wtautolog
as a purpose for conveying information to the reader.
Well leaving a warning unaddressed is also not a solution. Either
replace it with a comment or turn off the warning for your subdir.
The warning here looks valid to me; you have a guard for something
that's impossible.
--
Thanks,
~Nick Desaulni
On Thu, Aug 8, 2019 at 1:22 PM Thomas Gleixner wrote:
> > tglx just picked up 2 other patches of mine, bumping just in case he's
> > not picking up patches while on vacation. ;)
>
> I'm only half on vacation :)
>
> So I can pick it up.
Thanks, will send h
to squash the build warnings, feel free.
> > > > >
> > > > > It would be nice to get it into 5.3. I can route it linuxwards if you
> > > > > give
> > > > > an Acked-by, but I'm happy to hand it to you :)
> > > >
> > > > Acked-by: Chris Wilson
> > >
> > > Thomas did you take this through tip tree after Chris' ACK?
> > >
> >
> > Hi,
> >
> > Gentle ping...
> > Thomas and Chris: Will someone of you pick this up?
> > As "objtool: Improve UACCESS coverage" [1] went trough tip tree I
> > highly appreciate to do so with this one.
>
> I think Thomas has gone on holiday, so hopefully Chris can pick it up
> after all.
tglx just picked up 2 other patches of mine, bumping just in case he's
not picking up patches while on vacation. ;)
--
Thanks,
~Nick Desaulniers
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
t this_cpu;
+ unsigned long local_clock = local_clock_us(&this_cpu);
- if (time_after(local_clock_us(&this_cpu), timeout))
+ if (time_after(local_clock, timeout))
return true;
return this_cpu != cpu;
--
Thanks,
~Nick Desaulniers
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Fri, Jan 25, 2019 at 11:34 PM Nick Desaulniers
wrote:
>
> On Fri, Jan 25, 2019 at 11:13 PM Nathan Chancellor
> wrote:
> >
> > This warning is disabled by default in scripts/Makefile.extrawarn when
> > W= is not provided but this Makefile adds -Wall after this wa
like commit 46e2068081e9 ("drm/i915:
> Disable some extra clang warnings").
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/220
> Signed-off-by: Nathan Chancellor
Reviewed-by: Nick Desaulniers
probably could give Chris Wilson the suggested by tag.
https://lore.ke
nfig and allyesconfig
> without any warnings with tip-of-tree Clang.
Also, please let us know about any other bugs found via testing with
Clang: https://github.com/ClangBuiltLinux/linux/issues
We're happy to take a look!
--
Thanks,
~Nick Desaulniers
_
a/drivers/gpu/drm/i915/Makefile
> +++ b/drivers/gpu/drm/i915/Makefile
> @@ -26,6 +26,7 @@ subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror
>
> # Fine grained warnings disable
> CFLAGS_i915_pci.o = $(call cc-disable-warning, override-init)
> +CFLAGS_intel_breadcrumbs.o = $(ca
On Mon, Oct 22, 2018 at 2:10 PM Nick Desaulniers
wrote:
>
> On Wed, Oct 17, 2018 at 12:25 AM Jani Nikula wrote:
> >
> > On Tue, 16 Oct 2018, Nick Desaulniers wrote:
> > > On Tue, Oct 16, 2018 at 8:35 AM Stephen Boyd wrote:
> > >>
> > >> Quoti
On Wed, Oct 17, 2018 at 12:25 AM Jani Nikula wrote:
>
> On Tue, 16 Oct 2018, Nick Desaulniers wrote:
> > On Tue, Oct 16, 2018 at 8:35 AM Stephen Boyd wrote:
> >>
> >> Quoting Jani Nikula (2018-10-16 05:29:38)
> >> > Clang build with UBSAN enabled leads
optimized away unless there's a type that's not
> > handled by _print_param().
> >
> > References: https://github.com/ClangBuiltLinux/linux/issues/191
> > References:
> > 20181009171401.14980-1-natechancellor@gmail.com">http://mid.mail-archive.com/20181009
M_BUG_ON() instead of BUILD_BUG_ON().
> >
> > v2: Use is_power_of_2() from log2.h (Chris)
> >
> > References:
> > 20181015203410.155997-1-swboyd@chromium.org">http://mid.mail-archive.com/20181015203410.155997-1-swboyd@chromium.org
> > Reported-by: Stephen Boy
On Wed, Oct 10, 2018 at 11:21 PM Jani Nikula
wrote:
>
> On Wed, 10 Oct 2018, Nick Desaulniers wrote:
> > On Wed, Oct 10, 2018 at 1:30 PM Michal Wajdeczko
> > wrote:
> >>
> >> On Wed, 10 Oct 2018 14:01:40 +0200, Jani Nikula
> >> wrote:
> >&g
On Wed, Oct 10, 2018 at 1:30 PM Michal Wajdeczko
wrote:
>
> On Wed, 10 Oct 2018 14:01:40 +0200, Jani Nikula
> wrote:
>
> > On Tue, 09 Oct 2018, Nick Desaulniers wrote:
> >> On Tue, Oct 9, 2018 at 10:14 AM Nathan Chancellor
> >> wrote:
> >>>
e the compiler starts
doing semantic analysis. I suspect this code is not valid for GCC
unless optimizations are enabled (the kernel only does compile with
optimizations turned on). This change allows us to build this
translation unit with Clang.
Acked-by: Nick Desaulniers
(Note: this is the
On Mon, Nov 27, 2017 at 2:26 AM, Joonas Lahtinen
wrote:
> On Sun, 2017-11-26 at 20:40 -0800, Nick Desaulniers wrote:
>> In
>> general, how do people find what tree they should be basing their
>> patch off of?
>
> "T:" line from the MAINTAINERS ent
Do I need to be basing my patches on a different tree than Linus'? In
general, how do people find what tree they should be basing their
patch off of?
On Sun, Nov 26, 2017 at 7:52 PM, Patchwork
wrote:
> == Series Details ==
>
> Series: drm/i915: Avoid enum conversion warning (rev2)
> URL : http
pll_id pll_id = port;
~~ ^~~~
Suggested-by: Daniel Vetter
Signed-off-by: Nick Desaulniers
---
drivers/gpu/drm/i915/intel_ddi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index 933c18fd4258..3c346
pll_id pll_id = port;
~~ ^~~~
Signed-off-by: Nick Desaulniers
---
drivers/gpu/drm/i915/intel_ddi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index 933c18fd4258..f9de45316901 100644
--- a/drivers/gpu/
Signed-off-by: Nick Desaulniers
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
ping for review
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Your patch also fixes the original warning reported in:
https://lkml.org/lkml/2017/5/21/1
Signed-off-by: Nick Desaulniers
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
.
Signed-off-by: Nick Desaulniers
---
I verified that -Wall was redundant by compiling with V=1:
make V=1 -j4 drivers/gpu/drm/i915/i915_gem_request.o
drivers/gpu/drm/i915/gvt/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gvt/Makefile
b/drivers/gpu/drm
eclaration]
static int wait_for_engine(struct intel_engine_cs *engine, int
timeout_ms)
^
Signed-off-by: Nick Desaulniers
---
Additionally, it only has one call site. Should I mark it inline, too, while
I'm at it?
drivers/gpu/drm/i915/i915_gem.c | 3 ++-
1 file changed, 2 i
41 matches
Mail list logo
